)]}'
{"stack.sh":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d5475242612f10166bccefd50166e1370c1bb4dc","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    # Per the point above, it\u0027s a bunch of repos so starts getting a"},{"line_number":332,"context_line":"    # little messy..."},{"line_number":333,"context_line":"    if ! is_package_installed rdo-release ; then"},{"line_number":334,"context_line":"        if [[ \"$TARGET_BRANCH\" \u003d\u003d \"master\" ]]; then"},{"line_number":335,"context_line":"            yum_install https://rdoproject.org/repos/rdo-release.rpm"},{"line_number":336,"context_line":"        else"},{"line_number":337,"context_line":"            # Get latest rdo-release-$rdo_release RPM package version"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_ba1e6609","line":334,"range":{"start_line":334,"start_character":16,"end_line":334,"end_character":29},"updated":"2019-06-29 00:07:49.000000000","message":"This variable can be empty.. Please take a look here: http://logs.openstack.org/21/667721/2/check/manila-tempest-minimal-dsvm-lvm-centos-7/c9e1620/logs/devstack-early.txt.gz\n\nThis log is from a dsvm job on CentOS for stable/queens in the manila project. Review URL: https://review.opendev.org/#/c/667721/\n\n\nCan we use $REQUIREMENTS_BRANCH instead, as used onL769 of this file?","commit_id":"eb375ad9fa7d769e538de1c1c4f263572e57f07f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7275be08bab759c785c5023ceadf5e770c7fcb35","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    # Per the point above, it\u0027s a bunch of repos so starts getting a"},{"line_number":332,"context_line":"    # little messy..."},{"line_number":333,"context_line":"    if ! is_package_installed rdo-release ; then"},{"line_number":334,"context_line":"        if [[ \"$TARGET_BRANCH\" \u003d\u003d \"master\" ]]; then"},{"line_number":335,"context_line":"            yum_install https://rdoproject.org/repos/rdo-release.rpm"},{"line_number":336,"context_line":"        else"},{"line_number":337,"context_line":"            # Get latest rdo-release-$rdo_release RPM package version"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_db3b1799","line":334,"range":{"start_line":334,"start_character":16,"end_line":334,"end_character":29},"in_reply_to":"9fb8cfa7_ba1e6609","updated":"2019-06-29 19:23:08.000000000","message":"Ignore this ^. I copied this over to the stable/queens branch, and this works!","commit_id":"eb375ad9fa7d769e538de1c1c4f263572e57f07f"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"2161025c50dadc874ac9ff10e121735180877eb4","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            # Get latest rdo-release-$rdo_release RPM package version"},{"line_number":338,"context_line":"            rdo_release\u003d$(echo $TARGET_BRANCH | sed \"s|stable/||g\")"},{"line_number":339,"context_line":"            rdo_package\u003d$(curl -s https://repos.fedorapeople.org/repos/openstack/openstack-$rdo_release/ | grep -o \u0027rdo-release-.[^\u003e]*.noarch.rpm\u0027 | sort | tail -1)"},{"line_number":340,"context_line":"            yum_install https://rdoproject.org/repos/openstack-$rdo_release/$rdo_package"},{"line_number":341,"context_line":"        fi"},{"line_number":342,"context_line":"    fi"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_e4ed17f0","line":340,"range":{"start_line":340,"start_character":24,"end_line":340,"end_character":88},"updated":"2019-07-01 09:57:24.000000000","message":"No need to parse output of directory list. You can use https://rdoproject.org/repos/openstack-$rdo_release/rdo-release-$rdo_release.rpm . That should always point to the good one.","commit_id":"eb375ad9fa7d769e538de1c1c4f263572e57f07f"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3739be7e1ed6a182690321f3a5ddc43f2030672e","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            # Get latest rdo-release-$rdo_release RPM package version"},{"line_number":338,"context_line":"            rdo_release\u003d$(echo $TARGET_BRANCH | sed \"s|stable/||g\")"},{"line_number":339,"context_line":"            rdo_package\u003d$(curl -s https://repos.fedorapeople.org/repos/openstack/openstack-$rdo_release/ | grep -o \u0027rdo-release-.[^\u003e]*.noarch.rpm\u0027 | sort | tail -1)"},{"line_number":340,"context_line":"            yum_install https://rdoproject.org/repos/openstack-$rdo_release/$rdo_package"},{"line_number":341,"context_line":"        fi"},{"line_number":342,"context_line":"    fi"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_e7c2f933","line":340,"range":{"start_line":340,"start_character":24,"end_line":340,"end_character":88},"in_reply_to":"9fb8cfa7_c41ed36e","updated":"2019-07-01 11:05:33.000000000","message":"Ah. rdoproject.org redirected to repos.fedorapeople.org and I had not noticed it. That one works, thank you!","commit_id":"eb375ad9fa7d769e538de1c1c4f263572e57f07f"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d21c5c22888cb81016ddb4f5b2d67f185cae5a10","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            # Get latest rdo-release-$rdo_release RPM package version"},{"line_number":338,"context_line":"            rdo_release\u003d$(echo $TARGET_BRANCH | sed \"s|stable/||g\")"},{"line_number":339,"context_line":"            rdo_package\u003d$(curl -s https://repos.fedorapeople.org/repos/openstack/openstack-$rdo_release/ | grep -o \u0027rdo-release-.[^\u003e]*.noarch.rpm\u0027 | sort | tail -1)"},{"line_number":340,"context_line":"            yum_install https://rdoproject.org/repos/openstack-$rdo_release/$rdo_package"},{"line_number":341,"context_line":"        fi"},{"line_number":342,"context_line":"    fi"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_c41ed36e","line":340,"range":{"start_line":340,"start_character":24,"end_line":340,"end_character":88},"in_reply_to":"9fb8cfa7_c493334e","updated":"2019-07-01 10:33:37.000000000","message":"You should not luse fedorapeople.org url but rdoproject.org one:\n\nhttps://rdoproject.org/repos/openstack-queens/rdo-release-queens.rpm","commit_id":"eb375ad9fa7d769e538de1c1c4f263572e57f07f"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"4c5f0eefc6c071fe974382f73e65cf6eb878af7b","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            # Get latest rdo-release-$rdo_release RPM package version"},{"line_number":338,"context_line":"            rdo_release\u003d$(echo $TARGET_BRANCH | sed \"s|stable/||g\")"},{"line_number":339,"context_line":"            rdo_package\u003d$(curl -s https://repos.fedorapeople.org/repos/openstack/openstack-$rdo_release/ | grep -o \u0027rdo-release-.[^\u003e]*.noarch.rpm\u0027 | sort | tail -1)"},{"line_number":340,"context_line":"            yum_install https://rdoproject.org/repos/openstack-$rdo_release/$rdo_package"},{"line_number":341,"context_line":"        fi"},{"line_number":342,"context_line":"    fi"},{"line_number":343,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_c493334e","line":340,"range":{"start_line":340,"start_character":24,"end_line":340,"end_character":88},"in_reply_to":"9fb8cfa7_e4ed17f0","updated":"2019-07-01 10:01:49.000000000","message":"It returns 404. For example, https://repos.fedorapeople.org/repos/openstack/openstack-queens/rdo-release-queens.noarch.rpm\n\nPresently, for Queens, there are two rdo-release-queens RPMs:\n- rdo-release-queens-0.noarch.rpm\n- rdo-release-queens-1.noarch.rpm\n\nThere is no redirect from rdo-release-queens.noarch.rpm to rdo-release-queens-1.noarch.rpm. L339 fetches the latest RPM, rdo-release-queens-1 in this case.","commit_id":"eb375ad9fa7d769e538de1c1c4f263572e57f07f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"403a891ca522c94eaa6b40e0f3854530d06aa9bb","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            rdo_package\u003d$(curl -s https://repos.fedorapeople.org/repos/openstack/openstack-$rdo_release/ | grep -o \u0027rdo-release-.[^\u003e]*.noarch.rpm\u0027 | sort | tail -1)"},{"line_number":340,"context_line":"            yum_install https://rdoproject.org/repos/openstack-$rdo_release/$rdo_package"},{"line_number":341,"context_line":"        fi"},{"line_number":342,"context_line":"    fi"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    # Also enable optional for RHEL7 proper.  Note this is a silent"},{"line_number":345,"context_line":"    # no-op on other platforms."}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_19a7cebf","line":342,"updated":"2019-06-25 06:51:13.000000000","message":"I guess the other option is just checking into the stable/ branches the hardlinked rpm; i\u0027m not sure if it\u0027s a bug or a feature that it sticks to a certain \"-X\" release then, unless explicitly updated in the devstack tree?  I feel like that\u0027s what we\u0027ve done before but surely have forgotten.  I\u0027m open to arguments either way :)","commit_id":"eb375ad9fa7d769e538de1c1c4f263572e57f07f"}]}