)]}'
{"lib/cinder_backends/ceph_iscsi":[{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"be4d0d12c9785205b03053a3e7648bbfad31ca67","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# Defaults"},{"line_number":26,"context_line":"# --------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CEPH_ISCSI_API_URL\u003d${CEPH_ISCSI_API_URL:-http://$CEPH_ISCSI_API_HOST:$CEPH_ISCSI_API_PORT}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Entry Points"},{"line_number":31,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_4ec1b380","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":18},"updated":"2020-07-02 02:41:40.000000000","message":"Move CEPH_ISCSI_API_URL into configure_cinder_backend_ceph_iscsi? Define CEPH_ISCSI_API_URL early here won\u0027t get any values from CEPH_ISCSI_API_HOST and CEPH_ISCSI_API_PORT, they are empty at this time point.","commit_id":"a1ff315a680b5033ed293f7c0950bbc723552ed9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7d02f2436936565b02225b131cb9ec229d7a5025","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# Defaults"},{"line_number":26,"context_line":"# --------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CEPH_ISCSI_API_URL\u003d${CEPH_ISCSI_API_URL:-http://$CEPH_ISCSI_API_HOST:$CEPH_ISCSI_API_PORT}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Entry Points"},{"line_number":31,"context_line":"# ------------"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_29ce8b2c","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":18},"in_reply_to":"bf51134e_4ec1b380","updated":"2020-07-09 16:00:28.000000000","message":"Done","commit_id":"a1ff315a680b5033ed293f7c0950bbc723552ed9"},{"author":{"_account_id":22997,"name":"xinliang","email":"xinliang.liu@linaro.org","username":"xinliang.liu"},"change_message_id":"faebca5801cb0297968a542bbe2def067ee69819","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    iniset $CINDER_CONF $be_name rbd_max_clone_depth 5"},{"line_number":49,"context_line":"    iniset $CINDER_CONF DEFAULT glance_api_version 2"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    sudo pip install rbd-iscsi-client"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_851ea5b8","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":21},"updated":"2020-07-09 06:53:21.000000000","message":"Use pip_install? Which will avoid using python2 pip to install packages.","commit_id":"a1ff315a680b5033ed293f7c0950bbc723552ed9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e70bbf9e6edaf796e06ea78ce4eb5d91bced0c9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    iniset $CINDER_CONF $be_name rbd_max_clone_depth 5"},{"line_number":49,"context_line":"    iniset $CINDER_CONF DEFAULT glance_api_version 2"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    sudo pip install rbd-iscsi-client"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_1aadcb9a","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":21},"in_reply_to":"bf51134e_1ab82be3","updated":"2020-07-09 12:11:05.000000000","message":"Ignore my last comment. Xinliang is right, pip_install should be used here:\n\nhttps://opendev.org/openstack/devstack/src/branch/master/inc/python#L127","commit_id":"a1ff315a680b5033ed293f7c0950bbc723552ed9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ffad9ec8abf5de930463ee891dfbef9351965c9b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    iniset $CINDER_CONF $be_name rbd_max_clone_depth 5"},{"line_number":49,"context_line":"    iniset $CINDER_CONF DEFAULT glance_api_version 2"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    sudo pip install rbd-iscsi-client"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_1ab82be3","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":21},"in_reply_to":"bf51134e_851ea5b8","updated":"2020-07-09 12:09:02.000000000","message":"\"python -m pip\" is probably better since it should pick up whatever python is being used in the venv.","commit_id":"a1ff315a680b5033ed293f7c0950bbc723552ed9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7d02f2436936565b02225b131cb9ec229d7a5025","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    iniset $CINDER_CONF $be_name rbd_max_clone_depth 5"},{"line_number":49,"context_line":"    iniset $CINDER_CONF DEFAULT glance_api_version 2"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    sudo pip install rbd-iscsi-client"},{"line_number":52,"context_line":"}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"# Restore xtrace"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_09862714","line":51,"range":{"start_line":51,"start_character":9,"end_line":51,"end_character":21},"in_reply_to":"bf51134e_851ea5b8","updated":"2020-07-09 16:00:28.000000000","message":"Done","commit_id":"a1ff315a680b5033ed293f7c0950bbc723552ed9"}]}