)]}'
{"id":"openstack%2Fdevstack~671937","triplet_id":"openstack%2Fdevstack~stable%2Fpike~Ifcf3ad008cf42d3d4762cfb3b6c31c93cfeb40db","project":"openstack/devstack","branch":"stable/pike","topic":"stablepike-zuulfixes","hashtags":[],"change_id":"Ifcf3ad008cf42d3d4762cfb3b6c31c93cfeb40db","subject":"Automatically set LIBS_FROM_GIT based on required projects","status":"MERGED","created":"2019-07-21 15:06:40.000000000","updated":"2019-07-30 06:17:40.000000000","submitted":"2019-07-30 06:17:40.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"671937-1564467460576-d14e3b94","meta_rev_id":"bab863a0151bcfaef535212e701a6145ac5395b0","_number":671937,"virtual_id_number":671937,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-30 06:17:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-26 10:04:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-30 03:40:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-21 15:06:40.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2019-07-30 03:40:57.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-07-30 06:17:40.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"01bfd62d62d5c6a93ae998c0c38456bdf95aed7d","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-07-21 15:06:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"995c4e8e2074ee65ebedfb1cc45f45dec2f3d17a","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-07-21 15:54:05.000000000","message":"Patch Set 1:\n\nDespite stable/pike being in extended maintenance, this chain of backports is still useful because the CI is still active and having those changes may help with reducing the delta while cherry-picking fixes and jobs (especially when ported to Zuul v3), thus reducing the maintenance effort of the teams which still keep pike alive.","accounts_in_message":[],"_revision_number":1},{"id":"94e85396d2452a78013055f5f1e44bc6f7992cb5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-21 17:03:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/37/671937/1/check/tempest-full/5cbd0c2/ : SUCCESS in 1h 49m 17s\n- neutron-grenade http://logs.openstack.org/37/671937/1/check/neutron-grenade/a671f53/ : SUCCESS in 50m 06s\n- build-openstack-sphinx-docs http://logs.openstack.org/37/671937/1/check/build-openstack-sphinx-docs/5ddc408/html/ : SUCCESS in 3m 52s\n- devstack http://logs.openstack.org/37/671937/1/check/devstack/e8b89b1/ : SUCCESS in 23m 19s\n- devstack-multinode http://logs.openstack.org/37/671937/1/check/devstack-multinode/f2c97d4/ : SUCCESS in 40m 06s\n- openstack-tox-bashate http://logs.openstack.org/37/671937/1/check/openstack-tox-bashate/099509d/ : SUCCESS in 3m 28s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/37/671937/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/987c6e2/ : SUCCESS in 45m 43s (non-voting)\n- swift-dsvm-functional http://logs.openstack.org/37/671937/1/check/swift-dsvm-functional/6e9d106/ : SUCCESS in 24m 39s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/37/671937/1/check/neutron-grenade-multinode/18c1118/ : SUCCESS in 1h 05m 40s\n- neutron-tempest-linuxbridge http://logs.openstack.org/37/671937/1/check/neutron-tempest-linuxbridge/b2413c7/ : SUCCESS in 1h 28m 40s\n- tempest-multinode-full http://logs.openstack.org/37/671937/1/check/tempest-multinode-full/d3f37d2/ : SUCCESS in 1h 46m 07s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4fc0ef8c5b5dd1ce84aa9a1460ad1faf1f6a3a78","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-07-26 06:39:00.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nquick merge as a backport passing ci","accounts_in_message":[],"_revision_number":1},{"id":"f1120f32efd5d428318c100f19757b676e2cc213","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 06:39:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"83682f37851249981d290ca3b3319e4637a42c68","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 08:20:33.000000000","message":"Patch Set 1: Verified-2\n\nThis change depends on a change that failed to merge.","accounts_in_message":[],"_revision_number":1},{"id":"8ade92c8778e872a2ef6c4ed7033ca97d32d0bec","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-07-26 10:04:28.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"496fb728a7cad09ddfe06c5254df447c198a53eb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-26 12:01:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/37/671937/2/check/tempest-full/78f527d/ : SUCCESS in 1h 40m 30s\n- neutron-grenade http://logs.openstack.org/37/671937/2/check/neutron-grenade/c0353f2/ : SUCCESS in 54m 54s\n- build-openstack-sphinx-docs http://logs.openstack.org/37/671937/2/check/build-openstack-sphinx-docs/c8a2007/html/ : SUCCESS in 5m 15s\n- devstack http://logs.openstack.org/37/671937/2/check/devstack/4424473/ : SUCCESS in 28m 17s\n- devstack-multinode http://logs.openstack.org/37/671937/2/check/devstack-multinode/a5be57d/ : SUCCESS in 39m 19s\n- openstack-tox-bashate http://logs.openstack.org/37/671937/2/check/openstack-tox-bashate/9e9508c/ : SUCCESS in 2m 23s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/37/671937/2/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/dfab26e/ : SUCCESS in 45m 13s (non-voting)\n- swift-dsvm-functional http://logs.openstack.org/37/671937/2/check/swift-dsvm-functional/825700f/ : SUCCESS in 26m 06s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/37/671937/2/check/neutron-grenade-multinode/9ff1f31/ : SUCCESS in 1h 10m 31s\n- neutron-tempest-linuxbridge http://logs.openstack.org/37/671937/2/check/neutron-tempest-linuxbridge/cee7725/ : SUCCESS in 1h 22m 18s\n- tempest-multinode-full http://logs.openstack.org/37/671937/2/check/tempest-multinode-full/936d3c3/ : SUCCESS in 1h 45m 27s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"9180cf665892ed38ee1e406210b649b565a6ed25","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-07-30 03:40:57.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"6d3f849907e71475f5853ca49adead52825ae0da","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 03:41:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1fb16cd765f8427d5cb90879abeedbd3f43106f2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 06:17:40.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/37/671937/2/gate/tempest-full/fd23173/ : SUCCESS in 1h 34m 18s\n- neutron-grenade http://logs.openstack.org/37/671937/2/gate/neutron-grenade/56668e1/ : SUCCESS in 1h 00m 00s\n- build-openstack-sphinx-docs http://logs.openstack.org/37/671937/2/gate/build-openstack-sphinx-docs/80fc005/html/ : SUCCESS in 3m 48s\n- devstack http://logs.openstack.org/37/671937/2/gate/devstack/208c524/ : SUCCESS in 32m 18s\n- openstack-tox-bashate http://logs.openstack.org/37/671937/2/gate/openstack-tox-bashate/6b46aa2/ : SUCCESS in 2m 05s\n- neutron-grenade-multinode http://logs.openstack.org/37/671937/2/gate/neutron-grenade-multinode/5be9723/ : SUCCESS in 1h 06m 20s\n- neutron-tempest-linuxbridge http://logs.openstack.org/37/671937/2/gate/neutron-tempest-linuxbridge/aed83e1/ : SUCCESS in 1h 24m 49s","accounts_in_message":[],"_revision_number":2},{"id":"500ed3966b3efdf210e339e16e693bf9a9250a17","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 06:17:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1b674f9a8cc2e086227c458336496019632789b0","revisions":{"9090afe0bd9bb00b3272e01480beeca1c5665d31":{"kind":"REWORK","_number":1,"created":"2019-07-21 15:06:40.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/37/671937/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/37/671937/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/37/671937/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/37/671937/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/37/671937/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/37/671937/1"}}},"commit":{"parents":[{"commit":"cd6b35695f95359e3f7768fda7ecda889ed6edf1","subject":"Zuul: support plugin dependencies","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/cd6b35695f95359e3f7768fda7ecda889ed6edf1"}]}],"author":{"name":"James E. Blair","email":"jeblair@redhat.com","date":"2018-03-02 15:05:14.000000000","tz":0},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2019-07-21 15:06:11.000000000","tz":120},"subject":"Automatically set LIBS_FROM_GIT based on required projects","message":"Automatically set LIBS_FROM_GIT based on required projects\n\nIf a project shows up in zuul\u0027s required-projects list, add it\nto LIBS_FROM_GIT automatically.  This way, when a user specifies\nthat a job requires a zuul-project, it gets used in testing, but\notherwise, it doesn\u0027t (pypi is used instead).\n\nAlso add information about what happens behind the scenes for both\nLIBS_FROM_GIT and plugin dependencies.\n\nThis moves the check performed in check_libs_from_git to\na helper function which is installed for most kinds of\ninstallations.  This means that if someone sets LIBS_FROM_GIT to\n\"foobar\", devstack won\u0027t error anymore, as nothing is going to\ntry to install foobar, therefore the check won\u0027t run on that.\nHowever, as we move to automated generation of the local config,\nthat error is not likely to happen.  This check was originally\nadded due to an error in the upper-constraints file (where a\nconstraint name did not match a package name).  This location of\nthe check would still catch that type of error.\n\nChange-Id: Ifcf3ad008cf42d3d4762cfb3b6c31c93cfeb40db\n(cherry picked from commit e1edde38edb697f56e111f55e5992e7bf22f6284)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9090afe0bd9bb00b3272e01480beeca1c5665d31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/9090afe0bd9bb00b3272e01480beeca1c5665d31"}]},"branch":"refs/heads/stable/pike"},"1b674f9a8cc2e086227c458336496019632789b0":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-07-26 10:04:28.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/37/671937/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/37/671937/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/37/671937/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/37/671937/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/37/671937/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/37/671937/2"}}},"commit":{"parents":[{"commit":"0b4351efdb2bc10fc3321879a613929597d69d90","subject":"Zuul: support plugin dependencies","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0b4351efdb2bc10fc3321879a613929597d69d90"}]}],"author":{"name":"James E. Blair","email":"jeblair@redhat.com","date":"2018-03-02 15:05:14.000000000","tz":0},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2019-07-26 10:04:10.000000000","tz":120},"subject":"Automatically set LIBS_FROM_GIT based on required projects","message":"Automatically set LIBS_FROM_GIT based on required projects\n\nIf a project shows up in zuul\u0027s required-projects list, add it\nto LIBS_FROM_GIT automatically.  This way, when a user specifies\nthat a job requires a zuul-project, it gets used in testing, but\notherwise, it doesn\u0027t (pypi is used instead).\n\nAlso add information about what happens behind the scenes for both\nLIBS_FROM_GIT and plugin dependencies.\n\nThis moves the check performed in check_libs_from_git to\na helper function which is installed for most kinds of\ninstallations.  This means that if someone sets LIBS_FROM_GIT to\n\"foobar\", devstack won\u0027t error anymore, as nothing is going to\ntry to install foobar, therefore the check won\u0027t run on that.\nHowever, as we move to automated generation of the local config,\nthat error is not likely to happen.  This check was originally\nadded due to an error in the upper-constraints file (where a\nconstraint name did not match a package name).  This location of\nthe check would still catch that type of error.\n\nChange-Id: Ifcf3ad008cf42d3d4762cfb3b6c31c93cfeb40db\n(cherry picked from commit e1edde38edb697f56e111f55e5992e7bf22f6284)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1b674f9a8cc2e086227c458336496019632789b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1b674f9a8cc2e086227c458336496019632789b0"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}