)]}'
{"lib/nova":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ab337032cce837ee063b7ca28768d0d4ef0881c4","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    local compute_cell_conf\u003d$NOVA_CONF"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    merge_config_file $compute_cell_conf post-config $NOVA_CPU_CONF"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"    if [[ \"${CELLSV2_SETUP}\" \u003d\u003d \"singleconductor\" ]]; then"},{"line_number":845,"context_line":"        # NOTE(danms): Grenade doesn\u0027t setup multi-cell rabbit, so"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_c9944aeb","line":842,"range":{"start_line":842,"start_character":22,"end_line":842,"end_character":67},"updated":"2019-07-25 18:22:35.000000000","message":"Not clear whether the order of these should be reversed. I assume we would want to give precedence to $NOVA_CPU_CONF in case of conflicts.","commit_id":"7b69084d57f0bb729ff870d112790ff4b41ada32"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"b1919fa4d8cd02977a3386a0c530a82e33ef91b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Dependencies:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# - ``functions`` file"},{"line_number":9,"context_line":"# - ``inc/meta-config`` file"},{"line_number":10,"context_line":"# - ``DEST``, ``DATA_DIR``, ``STACK_USER`` must be defined"},{"line_number":11,"context_line":"# - ``FILES``"},{"line_number":12,"context_line":"# - ``SERVICE_{TENANT_NAME|PASSWORD}`` must be defined"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_fafc663f","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":21},"updated":"2019-07-25 21:38:36.000000000","message":"Okay, this isn\u0027t being sourced in all cases, e.g. [1], so let\u0027s just do it explicitly from here.\n\n[1] http://logs.openstack.org/05/672805/2/check/grenade-py3/6e3db67/logs/grenade.sh.txt.gz#_2019-07-25_20_49_12_567","commit_id":"812df46f74905a4435481cd1d2ee592fc6eca09d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b957f567c741c5203b38fa0a593d1de9bd5aeade","unresolved":false,"context_lines":[{"line_number":839,"context_line":"    local compute_cell_conf\u003d$NOVA_CONF"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    # Lazy-import meta-config for merge_config_file"},{"line_number":842,"context_line":"    type -t merge_config_file || source $TOP_DIR/inc/meta-config"},{"line_number":843,"context_line":"    # Bug #1802143: $NOVA_CPU_CONF is constructed by first copying $NOVA_CONF..."},{"line_number":844,"context_line":"    cp $compute_cell_conf $NOVA_CPU_CONF"},{"line_number":845,"context_line":"    # ...and then adding/overriding anything explicitly set in $NOVA_CPU_CONF"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_056ebe95","line":842,"updated":"2019-07-26 06:56:58.000000000","message":"so this is a ... unique solution :)\n\nin stack.sh we do\n\n # Import common functions\n source $TOP_DIR/functions\n # Import config functions\n source $TOP_DIR/inc/meta-config\n\nI have no idea why meta-config isn\u0027t just sourced from functions, like ini-config is etc (which grenade is using just above before it fails in the log linked)\n\ncould we try just moving the meta-config source from stack.sh into functions?  then i think this \"just works\" ... stack.sh shouldn\u0027t care if the line above imports it, or it does it directly ...?","commit_id":"70bbe5572343d50dd5cf4c911a92f5a3a4958655"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"54688f3355aec422e2453eee0d46ddd6ff490f1c","unresolved":false,"context_lines":[{"line_number":839,"context_line":"    local compute_cell_conf\u003d$NOVA_CONF"},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"    # Lazy-import meta-config for merge_config_file"},{"line_number":842,"context_line":"    type -t merge_config_file || source $TOP_DIR/inc/meta-config"},{"line_number":843,"context_line":"    # Bug #1802143: $NOVA_CPU_CONF is constructed by first copying $NOVA_CONF..."},{"line_number":844,"context_line":"    cp $compute_cell_conf $NOVA_CPU_CONF"},{"line_number":845,"context_line":"    # ...and then adding/overriding anything explicitly set in $NOVA_CPU_CONF"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_f18ec430","line":842,"in_reply_to":"7faddb67_056ebe95","updated":"2019-07-26 12:05:05.000000000","message":"Thanks Ian, I wasn\u0027t sure what would be an acceptable (and unintrusive) way of getting at that import from here. What you say makes lots of sense to me. Done.","commit_id":"70bbe5572343d50dd5cf4c911a92f5a3a4958655"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"dcf88b5275e40894cd8d8d5a6ba11491ddaeae36","unresolved":false,"context_lines":[{"line_number":843,"context_line":"    # Bug #1802143: $NOVA_CPU_CONF is constructed by first copying $NOVA_CONF..."},{"line_number":844,"context_line":"    cp $compute_cell_conf $NOVA_CPU_CONF"},{"line_number":845,"context_line":"    # ...and then adding/overriding anything explicitly set in $NOVA_CPU_CONF"},{"line_number":846,"context_line":"    merge_config_file $TOP_DIR/local.conf post-config $NOVA_CPU_CONF"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    if [[ \"${CELLSV2_SETUP}\" \u003d\u003d \"singleconductor\" ]]; then"},{"line_number":849,"context_line":"        # NOTE(danms): Grenade doesn\u0027t setup multi-cell rabbit, so"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7faddb67_518eb827","line":846,"range":{"start_line":846,"start_character":54,"end_line":846,"end_character":68},"updated":"2019-07-26 12:07:45.000000000","message":"This is being expanded [1], which is wrong. Quote it.\n\n[1] http://logs.openstack.org/00/672800/2/check/nova-next/dfd7f56/job-output.txt.gz#_2019-07-25_22_13_42_825946","commit_id":"70bbe5572343d50dd5cf4c911a92f5a3a4958655"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b1c47baa4b12170301a56d9ebf81715762b62f64","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Dependencies:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# - ``functions`` file"},{"line_number":9,"context_line":"# - ``inc/meta-config`` file"},{"line_number":10,"context_line":"# - ``DEST``, ``DATA_DIR``, ``STACK_USER`` must be defined"},{"line_number":11,"context_line":"# - ``FILES``"},{"line_number":12,"context_line":"# - ``SERVICE_{TENANT_NAME|PASSWORD}`` must be defined"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7faddb67_0c7d0de6","line":9,"updated":"2019-08-20 09:43:51.000000000","message":"I don\u0027t think you need to list this here as it is an implicit requirement when sourcing \"functions\", the other deps like \"inc/ini-config\" aren\u0027t listed either.","commit_id":"0c31d005fdada8f93580fd0611f6a7e26aa6bf00"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"27c5da1f79210babf1c2e599256f548011bad3f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Dependencies:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# - ``functions`` file"},{"line_number":9,"context_line":"# - ``inc/meta-config`` file"},{"line_number":10,"context_line":"# - ``DEST``, ``DATA_DIR``, ``STACK_USER`` must be defined"},{"line_number":11,"context_line":"# - ``FILES``"},{"line_number":12,"context_line":"# - ``SERVICE_{TENANT_NAME|PASSWORD}`` must be defined"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7faddb67_c1a49609","line":9,"in_reply_to":"7faddb67_0c7d0de6","updated":"2019-08-20 15:20:45.000000000","message":"Better explicit than implicit? Perhaps the other transitive deps *should* be mentioned?","commit_id":"0c31d005fdada8f93580fd0611f6a7e26aa6bf00"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"12f855c8ac61d8daf12bcbc64c79f11e1692f6a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Dependencies:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# - ``functions`` file"},{"line_number":9,"context_line":"# - ``inc/meta-config`` file"},{"line_number":10,"context_line":"# - ``DEST``, ``DATA_DIR``, ``STACK_USER`` must be defined"},{"line_number":11,"context_line":"# - ``FILES``"},{"line_number":12,"context_line":"# - ``SERVICE_{TENANT_NAME|PASSWORD}`` must be defined"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7faddb67_d5c74646","line":9,"in_reply_to":"7faddb67_4997459e","updated":"2019-08-22 13:34:52.000000000","message":"Ack, done","commit_id":"0c31d005fdada8f93580fd0611f6a7e26aa6bf00"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"83693a803ef93c7fa1bae01ce75b0ef2cdc4546f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Dependencies:"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# - ``functions`` file"},{"line_number":9,"context_line":"# - ``inc/meta-config`` file"},{"line_number":10,"context_line":"# - ``DEST``, ``DATA_DIR``, ``STACK_USER`` must be defined"},{"line_number":11,"context_line":"# - ``FILES``"},{"line_number":12,"context_line":"# - ``SERVICE_{TENANT_NAME|PASSWORD}`` must be defined"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7faddb67_4997459e","line":9,"in_reply_to":"7faddb67_c1a49609","updated":"2019-08-22 10:04:50.000000000","message":"I\u0027d rather apply \"less is more\" here, as these references tend to get outdated pretty soon anyway.","commit_id":"0c31d005fdada8f93580fd0611f6a7e26aa6bf00"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"83693a803ef93c7fa1bae01ce75b0ef2cdc4546f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# - ``SERVICE_{TENANT_NAME|PASSWORD}`` must be defined"},{"line_number":13,"context_line":"# - ``LIBVIRT_TYPE`` must be defined"},{"line_number":14,"context_line":"# - ``INSTANCE_NAME_PREFIX``, ``VOLUME_NAME_PREFIX`` must be defined"},{"line_number":15,"context_line":"# - ``KEYSTONE_TOKEN_FORMAT`` must be defined"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# ``stack.sh`` calls the entry points in this order:"},{"line_number":18,"context_line":"#"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7faddb67_c99335a4","line":15,"updated":"2019-08-22 10:04:50.000000000","message":"Like this one, which doesn\u0027t seems to be used anymore except in lib/keystone, but it still claimed to be required not only here, but in a couple of other libs, too.","commit_id":"0c31d005fdada8f93580fd0611f6a7e26aa6bf00"}]}