)]}'
{"lib/neutron":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"ab37692e7e549c69bb938dd846d7254066149fad","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":506,"context_line":"    fi"},{"line_number":507,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":508,"context_line":"        pid\u003d$(ps aux | awk \u0027/[n]eutron-ns-metadata-proxy/ { print $2 }\u0027)"},{"line_number":509,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":510,"context_line":"    fi"},{"line_number":511,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2FJng%3D","line":508,"updated":"2014-01-16 23:26:31.000000000","message":"why not just \n\npkill -9 -f neutron-ns-metadata-proxy ?","commit_id":"1784ed2b5dbd67862606fdba5a61082022731b87"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e6f833c9a327ef9bd2cb9e4bb5e1ff6bd724506c","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":506,"context_line":"    fi"},{"line_number":507,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":508,"context_line":"        pid\u003d$(ps aux | awk \u0027/[n]eutron-ns-metadata-proxy/ { print $2 }\u0027)"},{"line_number":509,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":510,"context_line":"    fi"},{"line_number":511,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2FIfk%3D","line":508,"in_reply_to":"AAAAUH%2F%2FJlk%3D","updated":"2014-01-17 05:17:47.000000000","message":"Done","commit_id":"1784ed2b5dbd67862606fdba5a61082022731b87"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"b45ecced00f78c5f74811845bc25079c1d247b16","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":506,"context_line":"    fi"},{"line_number":507,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":508,"context_line":"        pid\u003d$(ps aux | awk \u0027/[n]eutron-ns-metadata-proxy/ { print $2 }\u0027)"},{"line_number":509,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":510,"context_line":"    fi"},{"line_number":511,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2FJlk%3D","line":508,"in_reply_to":"AAAAUH%2F%2FJmw%3D","updated":"2014-01-16 23:43:34.000000000","message":"IMO the pkill -9 is actually a better fix than a pid|awk with a regexp","commit_id":"1784ed2b5dbd67862606fdba5a61082022731b87"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e058b3ed35ce3473b560f9ea7aeb38d81e18cd85","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":506,"context_line":"    fi"},{"line_number":507,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":508,"context_line":"        pid\u003d$(ps aux | awk \u0027/[n]eutron-ns-metadata-proxy/ { print $2 }\u0027)"},{"line_number":509,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":510,"context_line":"    fi"},{"line_number":511,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2FJmw%3D","line":508,"in_reply_to":"AAAAUH%2F%2FJng%3D","updated":"2014-01-16 23:30:36.000000000","message":"Thank you Chmouel for your review. The goal of my patch is not to change the command, but to fix the regex and fix a bug.\nPlease consider that in your review :-)","commit_id":"1784ed2b5dbd67862606fdba5a61082022731b87"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"808c3d3aa8e2f5b518ab34da16e5f751abe08fff","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":506,"context_line":"    fi"},{"line_number":507,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":508,"context_line":"        pkill -9 -f neutron-ns-metadata-proxy"},{"line_number":509,"context_line":"    fi"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    if is_service_enabled q-lbaas; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUH%2F%2FHZ4%3D","line":508,"updated":"2014-01-17 09:42:03.000000000","message":"Is -f option necessary? Isn\u0027t the process name exactly neutron-ns-metadata-proxy?","commit_id":"04f6dc24a7845ee139977fa5b0c5e53aad8e99bd"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"ed6207443c254a5d2b723f2e22a9e5c28d691e0c","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        [ ! -z \"$pid\" ] \u0026\u0026 sudo kill -9 $pid"},{"line_number":506,"context_line":"    fi"},{"line_number":507,"context_line":"    if is_service_enabled q-meta; then"},{"line_number":508,"context_line":"        pkill -9 -f neutron-ns-metadata-proxy"},{"line_number":509,"context_line":"    fi"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    if is_service_enabled q-lbaas; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAUH%2F%2FHJc%3D","line":508,"in_reply_to":"AAAAUH%2F%2FHZ4%3D","updated":"2014-01-17 10:36:50.000000000","message":"i don\u0027t think that matter, we would be very unlucky to have a service called: neutron-ns-metadata-proxy-2 and we don\u0027t want to kill it at that time :)","commit_id":"04f6dc24a7845ee139977fa5b0c5e53aad8e99bd"}]}