)]}'
{"id":"openstack%2Fdevstack~673420","triplet_id":"openstack%2Fdevstack~stable%2Frocky~I125870b13d2581cdec0dede11157b19b702565cd","project":"openstack/devstack","branch":"stable/rocky","hashtags":[],"change_id":"I125870b13d2581cdec0dede11157b19b702565cd","subject":"Fix testing for the write-devstack-local-conf role","status":"MERGED","created":"2019-07-30 07:40:47.000000000","updated":"2019-07-31 03:23:48.000000000","submitted":"2019-07-31 03:23:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673420-1564543428717-66f2565c","meta_rev_id":"acc1345115ef375f614afc2ec369532cdd71ae85","_number":673420,"virtual_id_number":673420,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-31 03:23:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-31 00:32:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-31 00:32:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"date":"2019-07-30 07:40:47.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-30 07:40:47.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-07-31 00:32:09.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-07-31 03:23:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e955b5af939a65eb527644855ee1e2dece2efe4a","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-07-30 07:40:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6281144ca8a4299c0cdf3026c061a5c664f37536","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 11:19:38.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/20/673420/1/check/tempest-full/02eea40/ : SUCCESS in 1h 36m 39s\n- neutron-grenade http://logs.openstack.org/20/673420/1/check/neutron-grenade/6383b9a/ : SUCCESS in 51m 57s\n- tempest-full-py3 http://logs.openstack.org/20/673420/1/check/tempest-full-py3/7c7dc14/ : SUCCESS in 1h 19m 22s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/673420/1/check/build-openstack-sphinx-docs/a974de6/html/ : SUCCESS in 6m 12s\n- devstack http://logs.openstack.org/20/673420/1/check/devstack/92bc2d5/ : SUCCESS in 29m 09s\n- devstack-platform-centos-7 http://logs.openstack.org/20/673420/1/check/devstack-platform-centos-7/4c9f136/ : FAILURE in 1h 25m 15s (non-voting)\n- devstack-platform-opensuse-423 http://logs.openstack.org/20/673420/1/check/devstack-platform-opensuse-423/c524760/ : FAILURE in 1h 29m 39s (non-voting)\n- devstack-platform-opensuse-tumbleweed http://logs.openstack.org/20/673420/1/check/devstack-platform-opensuse-tumbleweed/1f2cd05/ : FAILURE in 18m 20s (non-voting)\n- devstack-platform-fedora-latest http://logs.openstack.org/20/673420/1/check/devstack-platform-fedora-latest/b8b4cbf/ : FAILURE in 30m 29s (non-voting)\n- devstack-multinode http://logs.openstack.org/20/673420/1/check/devstack-multinode/2b31880/ : SUCCESS in 38m 47s\n- devstack-unit-tests http://logs.openstack.org/20/673420/1/check/devstack-unit-tests/853218d/ : SUCCESS in 4m 08s\n- openstack-tox-bashate http://logs.openstack.org/20/673420/1/check/openstack-tox-bashate/0631661/ : SUCCESS in 3m 42s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/20/673420/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/decd61e/ : SUCCESS in 47m 01s (non-voting)\n- swift-dsvm-functional http://logs.openstack.org/20/673420/1/check/swift-dsvm-functional/b163f76/ : SUCCESS in 30m 43s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/20/673420/1/check/neutron-grenade-multinode/23beb2f/ : SUCCESS in 1h 04m 16s\n- neutron-tempest-linuxbridge http://logs.openstack.org/20/673420/1/check/neutron-tempest-linuxbridge/3b66268/ : SUCCESS in 1h 32m 53s\n- tempest-multinode-full http://logs.openstack.org/20/673420/1/check/tempest-multinode-full/833d33e/ : SUCCESS in 1h 40m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9e11ffe73ab7f12dc9cd3a3929e6f6c5ed85502d","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-07-31 00:32:09.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\npassing backport cherry-pick of job-related functions, let\u0027s just merge (platform tests not related)","accounts_in_message":[],"_revision_number":1},{"id":"4d53a2bc9311aa9d44fa62ff995c3db19e697151","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 00:33:56.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"21e231a6c48b90bc8cdbe35254b8783b1ad5f80d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 03:23:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/20/673420/1/gate/tempest-full/da3d4c9/ : SUCCESS in 1h 27m 48s\n- neutron-grenade http://logs.openstack.org/20/673420/1/gate/neutron-grenade/2d81534/ : SUCCESS in 1h 06m 37s\n- tempest-full-py3 http://logs.openstack.org/20/673420/1/gate/tempest-full-py3/046a0ea/ : SUCCESS in 1h 18m 16s\n- build-openstack-sphinx-docs http://logs.openstack.org/20/673420/1/gate/build-openstack-sphinx-docs/fa62948/html/ : SUCCESS in 3m 53s\n- devstack http://logs.openstack.org/20/673420/1/gate/devstack/afc056e/ : SUCCESS in 28m 55s\n- devstack-unit-tests http://logs.openstack.org/20/673420/1/gate/devstack-unit-tests/14ead11/ : SUCCESS in 3m 42s\n- openstack-tox-bashate http://logs.openstack.org/20/673420/1/gate/openstack-tox-bashate/eefee94/ : SUCCESS in 3m 28s\n- neutron-grenade-multinode http://logs.openstack.org/20/673420/1/gate/neutron-grenade-multinode/1600575/ : SUCCESS in 1h 03m 10s\n- neutron-tempest-linuxbridge http://logs.openstack.org/20/673420/1/gate/neutron-tempest-linuxbridge/d628454/ : SUCCESS in 1h 24m 37s","accounts_in_message":[],"_revision_number":1},{"id":"acc1345115ef375f614afc2ec369532cdd71ae85","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 03:23:48.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"d86f3dbc89d8594c32cb4d20f527a8ffb2ed0cd6","revisions":{"d86f3dbc89d8594c32cb4d20f527a8ffb2ed0cd6":{"kind":"REWORK","_number":1,"created":"2019-07-30 07:40:47.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/20/673420/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/20/673420/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/673420/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/673420/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/20/673420/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/20/673420/1"}}},"commit":{"parents":[{"commit":"ed120e335fadc901f9547e347e3c3a51b278bc73","subject":"Fix rdo-release install","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ed120e335fadc901f9547e347e3c3a51b278bc73"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2018-12-19 11:53:16.000000000","tz":0},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2019-07-21 19:43:57.000000000","tz":120},"subject":"Fix testing for the write-devstack-local-conf role","message":"Fix testing for the write-devstack-local-conf role\n\nThe test_plugin_deps function in the test code for the\nwrite-devstack-local-conf role was missing the import part of actually\nexecuting the code under test and asserting the expected result.\n\nChange-Id: I125870b13d2581cdec0dede11157b19b702565cd\n(cherry picked from commit 6d103a7ff845076da984afbd317cd8cf4504fb7a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d86f3dbc89d8594c32cb4d20f527a8ffb2ed0cd6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/d86f3dbc89d8594c32cb4d20f527a8ffb2ed0cd6"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}