)]}'
{"id":"openstack%2Fdevstack~673425","triplet_id":"openstack%2Fdevstack~stable%2Fqueens~I125870b13d2581cdec0dede11157b19b702565cd","project":"openstack/devstack","branch":"stable/queens","hashtags":[],"change_id":"I125870b13d2581cdec0dede11157b19b702565cd","subject":"Fix testing for the write-devstack-local-conf role","status":"MERGED","created":"2019-07-30 07:41:42.000000000","updated":"2019-07-31 04:14:37.000000000","submitted":"2019-07-31 04:14:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673425-1564546477491-a91269ad","meta_rev_id":"b2d4a0755f81972f1e7b97bce5e670dfd8c6cbf8","_number":673425,"virtual_id_number":673425,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2019-07-31 04:14:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-31 00:32:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"date":"2019-07-30 07:41:42.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-31 00:32:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-30 07:41:42.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-07-31 00:32:22.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-07-31 04:14:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f15a1574e0a5cfd595632d371fad9d96a9499388","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-07-30 07:41:42.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87e3484af483de790c690c82c9e038a18ee0970f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 11:14:12.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/25/673425/1/check/tempest-full/ed25943/ : SUCCESS in 1h 23m 46s\n- neutron-grenade http://logs.openstack.org/25/673425/1/check/neutron-grenade/c5d3c6e/ : SUCCESS in 55m 04s\n- tempest-full-py3 http://logs.openstack.org/25/673425/1/check/tempest-full-py3/a63d791/ : SUCCESS in 1h 24m 52s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/673425/1/check/build-openstack-sphinx-docs/5883ab1/html/ : SUCCESS in 3m 50s\n- devstack http://logs.openstack.org/25/673425/1/check/devstack/e43d117/ : SUCCESS in 30m 50s\n- devstack-multinode http://logs.openstack.org/25/673425/1/check/devstack-multinode/09a375c/ : SUCCESS in 41m 09s\n- openstack-tox-bashate http://logs.openstack.org/25/673425/1/check/openstack-tox-bashate/7d2f8de/ : SUCCESS in 3m 42s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/25/673425/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/9351af3/ : SUCCESS in 49m 23s (non-voting)\n- swift-dsvm-functional http://logs.openstack.org/25/673425/1/check/swift-dsvm-functional/82dfe6d/ : SUCCESS in 27m 12s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/25/673425/1/check/neutron-grenade-multinode/3b76399/ : SUCCESS in 1h 05m 11s\n- neutron-tempest-linuxbridge http://logs.openstack.org/25/673425/1/check/neutron-tempest-linuxbridge/ceb1f19/ : SUCCESS in 1h 17m 52s\n- tempest-multinode-full http://logs.openstack.org/25/673425/1/check/tempest-multinode-full/df842cf/ : SUCCESS in 1h 34m 52s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e3fcf76f9368171052a8bd86c24678c221fd7534","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-07-31 00:32:22.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\npassing backport cherry-pick of job-related functions, let\u0027s just merge","accounts_in_message":[],"_revision_number":1},{"id":"5a08e72687b132bd64f62359131501feeb6c15de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 00:33:58.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a3230f1491d8585e56ad91f270201005c0559728","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 04:14:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/25/673425/1/gate/tempest-full/fdbde8d/ : SUCCESS in 1h 27m 06s\n- neutron-grenade http://logs.openstack.org/25/673425/1/gate/neutron-grenade/7b8abdd/ : SUCCESS in 59m 16s\n- tempest-full-py3 http://logs.openstack.org/25/673425/1/gate/tempest-full-py3/bbd5d26/ : SUCCESS in 1h 12m 21s\n- build-openstack-sphinx-docs http://logs.openstack.org/25/673425/1/gate/build-openstack-sphinx-docs/a2da501/html/ : SUCCESS in 3m 16s\n- devstack http://logs.openstack.org/25/673425/1/gate/devstack/c6bd40a/ : SUCCESS in 29m 19s\n- openstack-tox-bashate http://logs.openstack.org/25/673425/1/gate/openstack-tox-bashate/c95c0fa/ : SUCCESS in 2m 39s\n- neutron-grenade-multinode http://logs.openstack.org/25/673425/1/gate/neutron-grenade-multinode/fa91fda/ : SUCCESS in 1h 00m 54s\n- neutron-tempest-linuxbridge http://logs.openstack.org/25/673425/1/gate/neutron-tempest-linuxbridge/231de6b/ : SUCCESS in 1h 18m 54s","accounts_in_message":[],"_revision_number":1},{"id":"b2d4a0755f81972f1e7b97bce5e670dfd8c6cbf8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 04:14:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7b001f5d6c4eb95a27c73aa7eb45970167ce5c1a","revisions":{"7b001f5d6c4eb95a27c73aa7eb45970167ce5c1a":{"kind":"REWORK","_number":1,"created":"2019-07-30 07:41:42.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/25/673425/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/25/673425/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/673425/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/673425/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/25/673425/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/25/673425/1"}}},"commit":{"parents":[{"commit":"2281642c889b5c962cbf64c06bc895ebaaa37fef","subject":"Merge \"Fix rdo-release install\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/2281642c889b5c962cbf64c06bc895ebaaa37fef"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2018-12-19 11:53:16.000000000","tz":0},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2019-07-26 10:04:38.000000000","tz":120},"subject":"Fix testing for the write-devstack-local-conf role","message":"Fix testing for the write-devstack-local-conf role\n\nThe test_plugin_deps function in the test code for the\nwrite-devstack-local-conf role was missing the import part of actually\nexecuting the code under test and asserting the expected result.\n\nChange-Id: I125870b13d2581cdec0dede11157b19b702565cd\n(cherry picked from commit 6d103a7ff845076da984afbd317cd8cf4504fb7a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7b001f5d6c4eb95a27c73aa7eb45970167ce5c1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7b001f5d6c4eb95a27c73aa7eb45970167ce5c1a"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}