)]}'
{"id":"openstack%2Fdevstack~673430","triplet_id":"openstack%2Fdevstack~stable%2Fpike~I125870b13d2581cdec0dede11157b19b702565cd","project":"openstack/devstack","branch":"stable/pike","hashtags":[],"change_id":"I125870b13d2581cdec0dede11157b19b702565cd","subject":"Fix testing for the write-devstack-local-conf role","status":"MERGED","created":"2019-07-30 07:45:44.000000000","updated":"2019-07-31 02:09:44.000000000","submitted":"2019-07-31 02:09:44.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"673430-1564538984662-4b3fabf7","meta_rev_id":"63f4361a95478138d3df5198369fc4c6728977c9","_number":673430,"virtual_id_number":673430,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-07-31 02:09:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-07-31 00:30:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-07-31 00:30:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"date":"2019-07-30 07:45:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-07-30 07:45:44.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-07-31 00:30:29.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-07-31 02:09:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fa595ae3650ffc7e0800eedf2d7666891e780642","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-07-30 07:45:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9840d71978224b6a9a0648a8f39e04b37ea4d354","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-30 11:33:20.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/30/673430/1/check/tempest-full/45b20c7/ : SUCCESS in 1h 34m 04s\n- neutron-grenade http://logs.openstack.org/30/673430/1/check/neutron-grenade/06d3efc/ : SUCCESS in 50m 28s\n- build-openstack-sphinx-docs http://logs.openstack.org/30/673430/1/check/build-openstack-sphinx-docs/a805408/html/ : SUCCESS in 3m 17s\n- devstack http://logs.openstack.org/30/673430/1/check/devstack/604cf0b/ : SUCCESS in 30m 31s\n- devstack-multinode http://logs.openstack.org/30/673430/1/check/devstack-multinode/f451400/ : SUCCESS in 41m 14s\n- openstack-tox-bashate http://logs.openstack.org/30/673430/1/check/openstack-tox-bashate/b4fdc44/ : SUCCESS in 3m 00s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa http://logs.openstack.org/30/673430/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/6808e33/ : SUCCESS in 45m 54s (non-voting)\n- swift-dsvm-functional http://logs.openstack.org/30/673430/1/check/swift-dsvm-functional/1b3cf11/ : SUCCESS in 24m 21s (non-voting)\n- neutron-grenade-multinode http://logs.openstack.org/30/673430/1/check/neutron-grenade-multinode/0769303/ : SUCCESS in 1h 11m 13s\n- neutron-tempest-linuxbridge http://logs.openstack.org/30/673430/1/check/neutron-tempest-linuxbridge/527db37/ : SUCCESS in 1h 27m 14s\n- tempest-multinode-full http://logs.openstack.org/30/673430/1/check/tempest-multinode-full/9870d6f/ : SUCCESS in 1h 48m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bb529efb6c7d9d763a66b457b842ee9fb3d2bdb1","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-07-31 00:30:29.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\npassing backport cherry-pick of job-related functions, let\u0027s just merge","accounts_in_message":[],"_revision_number":1},{"id":"c1e20c3042f3d9827e7719f0798601af81d758d4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 00:30:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4201e773c11e29cd6e1cd198ea6b3c51cd95eb9f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 02:09:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full http://logs.openstack.org/30/673430/1/gate/tempest-full/66cfe55/ : SUCCESS in 1h 31m 44s\n- neutron-grenade http://logs.openstack.org/30/673430/1/gate/neutron-grenade/50ad769/ : SUCCESS in 51m 44s\n- build-openstack-sphinx-docs http://logs.openstack.org/30/673430/1/gate/build-openstack-sphinx-docs/3a3875f/html/ : SUCCESS in 3m 56s\n- devstack http://logs.openstack.org/30/673430/1/gate/devstack/5139f2d/ : SUCCESS in 23m 08s\n- openstack-tox-bashate http://logs.openstack.org/30/673430/1/gate/openstack-tox-bashate/3ef13a4/ : SUCCESS in 4m 27s\n- neutron-grenade-multinode http://logs.openstack.org/30/673430/1/gate/neutron-grenade-multinode/9aa73c2/ : SUCCESS in 56m 07s\n- neutron-tempest-linuxbridge http://logs.openstack.org/30/673430/1/gate/neutron-tempest-linuxbridge/9e6f5cd/ : SUCCESS in 1h 36m 13s","accounts_in_message":[],"_revision_number":1},{"id":"63f4361a95478138d3df5198369fc4c6728977c9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-07-31 02:09:44.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a069e496023528e4ee0de62bbcde10f9691cdcef","revisions":{"a069e496023528e4ee0de62bbcde10f9691cdcef":{"kind":"REWORK","_number":1,"created":"2019-07-30 07:45:44.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/30/673430/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/30/673430/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/30/673430/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/30/673430/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/30/673430/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/30/673430/1"}}},"commit":{"parents":[{"commit":"1a99135f00d629538f5dfb26f7c9f313a641d6e0","subject":"Add the project under test to LIBS_FROM_GIT","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1a99135f00d629538f5dfb26f7c9f313a641d6e0"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2018-12-19 11:53:16.000000000","tz":0},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2019-07-30 07:42:34.000000000","tz":120},"subject":"Fix testing for the write-devstack-local-conf role","message":"Fix testing for the write-devstack-local-conf role\n\nThe test_plugin_deps function in the test code for the\nwrite-devstack-local-conf role was missing the import part of actually\nexecuting the code under test and asserting the expected result.\n\nChange-Id: I125870b13d2581cdec0dede11157b19b702565cd\n(cherry picked from commit 6d103a7ff845076da984afbd317cd8cf4504fb7a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a069e496023528e4ee0de62bbcde10f9691cdcef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a069e496023528e4ee0de62bbcde10f9691cdcef"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}