)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"75bfcebe473dc3cafcbf27eb209d0093afd129b1","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    # only setup database connections if there are services that"},{"line_number":421,"context_line":"    # require them running on the host. The ensures that n-cpu doesn\u0027t"},{"line_number":422,"context_line":"    # leak a need to use the db in a multinode scenario."},{"line_number":423,"context_line":"    if is_service_enabled n-api n-cond n-sched; then"},{"line_number":424,"context_line":"        # If we\u0027re in multi-tier cells mode, we want our control services pointing"},{"line_number":425,"context_line":"        # at cell0 instead of cell1 to ensure isolation. If not, we point everything"},{"line_number":426,"context_line":"        # at the main database like normal."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_a6f9974e","line":423,"updated":"2019-08-01 14:37:03.000000000","message":"This is a nit but frickler brought up a decent point in IRC that nova-compute will be using a cache local to the host on the subnode and arguably should be pointing at the cache on the controller. I don\u0027t really know how much nova-compute actually leverages a cache if enabled though, and nova-compute for the most part should avoid hitting things (resources) managed by the controller.\n\nSo I don\u0027t think it hurts to enable the cache on subnodes, but it\u0027s likely also not necessary.\n\nWhat you could do though is move the cache enablement logic for nova to this conditional and then we don\u0027t configure the cache on subnodes. The nova-compute service on the controller would still have the cache enabled, but like I said I\u0027m not sure it really matters.\n\nIf we want to be strict about not using the cache in nova-compute, we have to make sure to remove the cache config from NOVA_CPU_CONF which is a bit more clunky IMO.","commit_id":"a480aabd63dbbc3a0b81bd68edfe218b172c7b61"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d76070ba57ab66b8bd21d756d9147563ad7032de","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    # only setup database connections if there are services that"},{"line_number":421,"context_line":"    # require them running on the host. The ensures that n-cpu doesn\u0027t"},{"line_number":422,"context_line":"    # leak a need to use the db in a multinode scenario."},{"line_number":423,"context_line":"    if is_service_enabled n-api n-cond n-sched; then"},{"line_number":424,"context_line":"        # If we\u0027re in multi-tier cells mode, we want our control services pointing"},{"line_number":425,"context_line":"        # at cell0 instead of cell1 to ensure isolation. If not, we point everything"},{"line_number":426,"context_line":"        # at the main database like normal."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_a8a6450e","line":423,"in_reply_to":"7faddb67_a6f9974e","updated":"2019-08-01 14:54:13.000000000","message":"Done","commit_id":"a480aabd63dbbc3a0b81bd68edfe218b172c7b61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3111261c6d75cc07e0ebd0c309636945842c222e","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        iniset $NOVA_CONF DEFAULT bindir \"/usr/bin\""},{"line_number":418,"context_line":"    fi"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    # only setup database connections if there are services that"},{"line_number":421,"context_line":"    # require them running on the host. The ensures that n-cpu doesn\u0027t"},{"line_number":422,"context_line":"    # leak a need to use the db in a multinode scenario."},{"line_number":423,"context_line":"    if is_service_enabled n-api n-cond n-sched; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_48dd516e","line":420,"updated":"2019-08-01 14:58:13.000000000","message":"This comment could have been updated a bit but it\u0027s OK.","commit_id":"64b41f3ab268ec75bcfbf46e8a13495aa3151985"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b45406e4256a3a27343149bb3abd01fe6ea3f8d7","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        iniset $NOVA_CONF DEFAULT bindir \"/usr/bin\""},{"line_number":418,"context_line":"    fi"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    # only setup database connections if there are services that"},{"line_number":421,"context_line":"    # require them running on the host. The ensures that n-cpu doesn\u0027t"},{"line_number":422,"context_line":"    # leak a need to use the db in a multinode scenario."},{"line_number":423,"context_line":"    if is_service_enabled n-api n-cond n-sched; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_d19b2cc6","line":420,"in_reply_to":"7faddb67_48dd516e","updated":"2019-08-01 17:14:02.000000000","message":"Done","commit_id":"64b41f3ab268ec75bcfbf46e8a13495aa3151985"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3111261c6d75cc07e0ebd0c309636945842c222e","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        iniset $NOVA_CONF database connection `database_connection_url $db`"},{"line_number":437,"context_line":"        iniset $NOVA_CONF api_database connection `database_connection_url nova_api`"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        # Cache related settings"},{"line_number":440,"context_line":"        iniset $NOVA_CONF cache enabled $NOVA_ENABLE_CACHE"},{"line_number":441,"context_line":"        iniset $NOVA_CONF cache backend $CACHE_BACKEND"},{"line_number":442,"context_line":"        iniset $NOVA_CONF cache memcache_servers $MEMCACHE_SERVERS"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_08e3d935","line":439,"updated":"2019-08-01 14:58:13.000000000","message":"nit: could mention why this is done here rather than in general, i.e. since we will re-use the cache on the controller and not configure it for subnode n-cpu which doesn\u0027t probably need it anyway.","commit_id":"64b41f3ab268ec75bcfbf46e8a13495aa3151985"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b45406e4256a3a27343149bb3abd01fe6ea3f8d7","unresolved":false,"context_lines":[{"line_number":436,"context_line":"        iniset $NOVA_CONF database connection `database_connection_url $db`"},{"line_number":437,"context_line":"        iniset $NOVA_CONF api_database connection `database_connection_url nova_api`"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"        # Cache related settings"},{"line_number":440,"context_line":"        iniset $NOVA_CONF cache enabled $NOVA_ENABLE_CACHE"},{"line_number":441,"context_line":"        iniset $NOVA_CONF cache backend $CACHE_BACKEND"},{"line_number":442,"context_line":"        iniset $NOVA_CONF cache memcache_servers $MEMCACHE_SERVERS"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_71959886","line":439,"in_reply_to":"7faddb67_08e3d935","updated":"2019-08-01 17:14:02.000000000","message":"Done","commit_id":"64b41f3ab268ec75bcfbf46e8a13495aa3151985"}]}