)]}'
{"id":"openstack%2Fdevstack~674590","triplet_id":"openstack%2Fdevstack~stable%2Frocky~Ia703af54a7131843fc2b0ae34efcfe0f5507acbf","project":"openstack/devstack","branch":"stable/rocky","hashtags":[],"change_id":"Ia703af54a7131843fc2b0ae34efcfe0f5507acbf","subject":"Fix quoting for devstack_localrc arguments","status":"MERGED","created":"2019-08-05 12:29:41.000000000","updated":"2019-08-08 13:19:31.000000000","submitted":"2019-08-08 13:19:31.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674590-1565270371755-ca213fc5","meta_rev_id":"2846702c505b8f47bbed070995871c1342032927","_number":674590,"virtual_id_number":674590,"owner":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-08 13:19:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"date":"2019-08-08 07:25:02.000000000","_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-08 03:35:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2019-08-07 15:56:21.000000000","_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-08 03:35:51.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-07 15:56:21.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2019-08-08 03:35:51.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-08-08 13:19:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b8b2ef5605226b1d82fb87050fd85800cfc0d43c","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-08-05 12:29:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"284fcdb8348a9990d210d99cdd78c7752c9d9fff","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-05 14:17:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://logs.opendev.org/90/674590/1/check/tempest-full/ba8ad76/ : SUCCESS in 1h 42m 06s\n- neutron-grenade https://logs.opendev.org/90/674590/1/check/neutron-grenade/a57f51c/ : SUCCESS in 56m 07s\n- tempest-full-py3 https://logs.opendev.org/90/674590/1/check/tempest-full-py3/1ab3272/ : SUCCESS in 1h 32m 03s\n- build-openstack-sphinx-docs https://logs.opendev.org/90/674590/1/check/build-openstack-sphinx-docs/9b99428/html/ : SUCCESS in 3m 43s\n- devstack https://logs.opendev.org/90/674590/1/check/devstack/42d0a49/ : SUCCESS in 29m 01s\n- devstack-platform-centos-7 https://logs.opendev.org/90/674590/1/check/devstack-platform-centos-7/4b31c47/ : FAILURE in 1h 40m 52s (non-voting)\n- devstack-platform-opensuse-423 https://logs.opendev.org/90/674590/1/check/devstack-platform-opensuse-423/9e1cba9/ : FAILURE in 1h 15m 14s (non-voting)\n- devstack-platform-opensuse-tumbleweed https://logs.opendev.org/90/674590/1/check/devstack-platform-opensuse-tumbleweed/665f98e/ : FAILURE in 18m 34s (non-voting)\n- devstack-platform-fedora-latest https://logs.opendev.org/90/674590/1/check/devstack-platform-fedora-latest/c98325b/ : FAILURE in 37m 29s (non-voting)\n- devstack-multinode https://logs.opendev.org/90/674590/1/check/devstack-multinode/03a472e/ : SUCCESS in 39m 26s\n- devstack-unit-tests https://logs.opendev.org/90/674590/1/check/devstack-unit-tests/37177f6/ : SUCCESS in 2m 52s\n- openstack-tox-bashate https://logs.opendev.org/90/674590/1/check/openstack-tox-bashate/2cf0bde/ : SUCCESS in 3m 06s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://logs.opendev.org/90/674590/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/989defc/ : FAILURE in 38m 08s (non-voting)\n- swift-dsvm-functional https://logs.opendev.org/90/674590/1/check/swift-dsvm-functional/88d2b0c/ : SUCCESS in 28m 11s (non-voting)\n- neutron-grenade-multinode https://logs.opendev.org/90/674590/1/check/neutron-grenade-multinode/7f3cb3d/ : SUCCESS in 1h 35m 15s\n- neutron-tempest-linuxbridge https://logs.opendev.org/90/674590/1/check/neutron-tempest-linuxbridge/0da4924/ : SUCCESS in 1h 29m 13s\n- tempest-multinode-full https://logs.opendev.org/90/674590/1/check/tempest-multinode-full/dbe0197/ : SUCCESS in 1h 34m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c87cb7c8feec0bbc7e11f72c8b4cde27029e2945","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2019-08-07 15:56:21.000000000","message":"Patch Set 1: Code-Review+2\n\nI am not big fan of this kind of `double style/ guessing game` interfaces, but it is better to make it consistent with the other versions..","accounts_in_message":[],"_revision_number":1},{"id":"63ea00277acd28f35d2a3d3af20d34ce1d97e0f4","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-08 03:35:51.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"efa9faf00dea1f2786a60f38c022bb62423ce114","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 03:36:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"dc00f862b0ab565b06037cb66296a88361d215d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 05:25:31.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://logs.opendev.org/90/674590/1/gate/tempest-full/acb50bd/ : SUCCESS in 1h 35m 21s\n- neutron-grenade https://logs.opendev.org/90/674590/1/gate/neutron-grenade/340d7af/ : SUCCESS in 53m 39s\n- tempest-full-py3 https://logs.opendev.org/90/674590/1/gate/tempest-full-py3/8a35c64/ : SUCCESS in 1h 28m 47s\n- build-openstack-sphinx-docs https://logs.opendev.org/90/674590/1/gate/build-openstack-sphinx-docs/86c8a61/html/ : SUCCESS in 4m 50s\n- devstack https://logs.opendev.org/90/674590/1/gate/devstack/4595a4a/ : SUCCESS in 23m 23s\n- devstack-unit-tests https://logs.opendev.org/90/674590/1/gate/devstack-unit-tests/3e36f72/ : SUCCESS in 3m 32s\n- openstack-tox-bashate https://logs.opendev.org/90/674590/1/gate/openstack-tox-bashate/82e8782/ : SUCCESS in 2m 47s\n- neutron-grenade-multinode https://logs.opendev.org/90/674590/1/gate/neutron-grenade-multinode/aa5409f/ : FAILURE in 48m 53s\n- neutron-tempest-linuxbridge https://logs.opendev.org/90/674590/1/gate/neutron-tempest-linuxbridge/301e9e2/ : SUCCESS in 1h 38m 25s","accounts_in_message":[],"_revision_number":1},{"id":"7f285c0c02b36b3d18ac7f7352212f8bf716f221","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-08-08 07:25:02.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0dab7b5713ac4381f1538d106bf8909793790a4b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 10:32:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://logs.opendev.org/90/674590/1/check/tempest-full/1a9d51c/ : SUCCESS in 1h 25m 11s\n- neutron-grenade https://logs.opendev.org/90/674590/1/check/neutron-grenade/fa32d11/ : SUCCESS in 1h 08m 07s\n- tempest-full-py3 https://logs.opendev.org/90/674590/1/check/tempest-full-py3/568faf4/ : SUCCESS in 1h 24m 53s\n- build-openstack-sphinx-docs https://logs.opendev.org/90/674590/1/check/build-openstack-sphinx-docs/f7713b9/html/ : SUCCESS in 4m 09s\n- devstack https://logs.opendev.org/90/674590/1/check/devstack/fcfa0a0/ : SUCCESS in 31m 40s\n- devstack-platform-centos-7 https://logs.opendev.org/90/674590/1/check/devstack-platform-centos-7/15e4847/ : SUCCESS in 1h 44m 56s (non-voting)\n- devstack-platform-opensuse-423 https://logs.opendev.org/90/674590/1/check/devstack-platform-opensuse-423/9530f67/ : TIMED_OUT in 2h 10m 36s (non-voting)\n- devstack-platform-opensuse-tumbleweed https://logs.opendev.org/90/674590/1/check/devstack-platform-opensuse-tumbleweed/f71a872/ : FAILURE in 22m 18s (non-voting)\n- devstack-platform-fedora-latest https://logs.opendev.org/90/674590/1/check/devstack-platform-fedora-latest/2916b27/ : FAILURE in 36m 17s (non-voting)\n- devstack-multinode https://logs.opendev.org/90/674590/1/check/devstack-multinode/a3a9eaf/ : SUCCESS in 47m 24s\n- devstack-unit-tests https://logs.opendev.org/90/674590/1/check/devstack-unit-tests/fafa04e/ : SUCCESS in 3m 34s\n- openstack-tox-bashate https://logs.opendev.org/90/674590/1/check/openstack-tox-bashate/0810c1f/ : SUCCESS in 4m 17s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://logs.opendev.org/90/674590/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/87222bc/ : FAILURE in 29m 06s (non-voting)\n- swift-dsvm-functional https://logs.opendev.org/90/674590/1/check/swift-dsvm-functional/e040b82/ : SUCCESS in 30m 05s (non-voting)\n- neutron-grenade-multinode https://logs.opendev.org/90/674590/1/check/neutron-grenade-multinode/28d8c12/ : SUCCESS in 1h 00m 00s\n- neutron-tempest-linuxbridge https://logs.opendev.org/90/674590/1/check/neutron-tempest-linuxbridge/6398d0b/ : SUCCESS in 1h 20m 33s\n- tempest-multinode-full https://logs.opendev.org/90/674590/1/check/tempest-multinode-full/3ec4bd1/ : SUCCESS in 1h 53m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"74b7bb1f60256ca30e6d7dfdafc171f7d7d4a7ad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 10:32:30.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"30c9baeb6ea814d9234ee7d002043bc8162c8dc7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 13:19:31.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://logs.opendev.org/90/674590/1/gate/tempest-full/d8ed2e4/ : SUCCESS in 1h 38m 26s\n- neutron-grenade https://logs.opendev.org/90/674590/1/gate/neutron-grenade/ee9ccf1/ : SUCCESS in 58m 07s\n- tempest-full-py3 https://logs.opendev.org/90/674590/1/gate/tempest-full-py3/4612e7e/ : SUCCESS in 1h 24m 09s\n- build-openstack-sphinx-docs https://logs.opendev.org/90/674590/1/gate/build-openstack-sphinx-docs/69ddacd/html/ : SUCCESS in 4m 57s\n- devstack https://logs.opendev.org/90/674590/1/gate/devstack/61ea5a1/ : SUCCESS in 30m 29s\n- devstack-unit-tests https://logs.opendev.org/90/674590/1/gate/devstack-unit-tests/ce6014e/ : SUCCESS in 3m 22s\n- openstack-tox-bashate https://logs.opendev.org/90/674590/1/gate/openstack-tox-bashate/9e0d5a1/ : SUCCESS in 3m 11s\n- neutron-grenade-multinode https://logs.opendev.org/90/674590/1/gate/neutron-grenade-multinode/2bd1b33/ : SUCCESS in 1h 41m 46s\n- neutron-tempest-linuxbridge https://logs.opendev.org/90/674590/1/gate/neutron-tempest-linuxbridge/1e28c52/ : SUCCESS in 1h 59m 19s","accounts_in_message":[],"_revision_number":1},{"id":"2846702c505b8f47bbed070995871c1342032927","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 13:19:31.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"11c5aa83281dffa035b367da637346df3548bcbf","revisions":{"11c5aa83281dffa035b367da637346df3548bcbf":{"kind":"REWORK","_number":1,"created":"2019-08-05 12:29:41.000000000","uploader":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"ref":"refs/changes/90/674590/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/90/674590/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/90/674590/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/90/674590/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/90/674590/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/90/674590/1"}}},"commit":{"parents":[{"commit":"f0d1896d0acdf0aa9198442f0642e8a7fd3ff422","subject":"zuul: new variable to easily populate TEMPEST_PLUGINS","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f0d1896d0acdf0aa9198442f0642e8a7fd3ff422"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-08-01 08:22:44.000000000","tz":120},"committer":{"name":"Luigi Toscano","email":"ltoscano@redhat.com","date":"2019-08-05 09:14:17.000000000","tz":120},"subject":"Fix quoting for devstack_localrc arguments","message":"Fix quoting for devstack_localrc arguments\n\nThis is a combination of the following commits:\n- \"Quote devstack_localrc arguments\"\n  https://review.opendev.org/636078\n  Ia63a53d745dfea7262bcdb5d46425f431c3ccfe5\n- \"Fix double quoting issue when writing localconf\"\n  https://review.opendev.org/648951\n  I92146e04731efc6dcc632ae6c3a7c374e783cdba\n\nThey have been merged together because the first commit introduces\na bug, and it looks a bit pointless to deliberately introduce\na potentially breaking change on the process of backporting a fix.\n\nCo-Authored-By: Ian Wienand \u003ciwienand@redhat.com\u003e\nCo-Authored-By: Jens Harbott \u003cj.harbott@x-ion.de\u003e\n\nChange-Id: Ia703af54a7131843fc2b0ae34efcfe0f5507acbf\n(cherry picked from commit 2e1393621a4d4321e5437b63d6ac97011f089c45)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/11c5aa83281dffa035b367da637346df3548bcbf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/11c5aa83281dffa035b367da637346df3548bcbf"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}