)]}'
{"tools/fixup_stuff.sh":[{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"3a0fcc0d43ec40cec898a1b32b76776d64d99b97","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    # Disable apparmor profiles in openSUSE and SLE distros"},{"line_number":234,"context_line":"    # to avoid issues with haproxy and dnsmasq"},{"line_number":235,"context_line":"    if sudo systemctl is-active -q apparmor; then"},{"line_number":236,"context_line":"        sudo systemctl stop apparmor"},{"line_number":237,"context_line":"    fi"},{"line_number":238,"context_line":"    if sudo systemctl is-enabled -q apparmor; then"},{"line_number":239,"context_line":"        sudo systemctl disable apparmor"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_017b5929","line":236,"updated":"2019-08-07 16:56:27.000000000","message":"I have this comment in my systemd apparmor using Leap 15.0 \n# systemd maps \u0027restart\u0027 to \u0027stop; start\u0027 which means removing AppArmor confinement\n# from running processes (and not being able to re-apply it later).\n# Upstream systemd developers refused to implement an option that allows overriding\n# this behaviour, therefore we have to make ExecStop a no-op to error out on the\n# safe side.","commit_id":"327f4a77445662ae9749a8454dcf2ec21e121929"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"29ca057f28188c129b0a949ffd169dacc60e7a08","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    # Disable apparmor profiles in openSUSE and SLE distros"},{"line_number":234,"context_line":"    # to avoid issues with haproxy and dnsmasq"},{"line_number":235,"context_line":"    if sudo systemctl is-active -q apparmor; then"},{"line_number":236,"context_line":"        sudo systemctl stop apparmor"},{"line_number":237,"context_line":"    fi"},{"line_number":238,"context_line":"    if sudo systemctl is-enabled -q apparmor; then"},{"line_number":239,"context_line":"        sudo systemctl disable apparmor"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_01afd92b","line":236,"in_reply_to":"7faddb67_017b5929","updated":"2019-08-07 17:14:53.000000000","message":"Interesting, where do you see that comment?\n\nWhat do you propose as a solution for systems which don\u0027t have aa-teardown?","commit_id":"327f4a77445662ae9749a8454dcf2ec21e121929"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"a50156683aa9fc5b652d2d82eab06be9d7e64ae0","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    # Disable apparmor profiles in openSUSE and SLE distros"},{"line_number":234,"context_line":"    # to avoid issues with haproxy and dnsmasq"},{"line_number":235,"context_line":"    if sudo systemctl is-active -q apparmor; then"},{"line_number":236,"context_line":"        sudo systemctl stop apparmor"},{"line_number":237,"context_line":"    fi"},{"line_number":238,"context_line":"    if sudo systemctl is-enabled -q apparmor; then"},{"line_number":239,"context_line":"        sudo systemctl disable apparmor"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_1e8c0c7e","line":236,"in_reply_to":"7faddb67_01afd92b","updated":"2019-08-08 09:16:31.000000000","message":"You can see the comment here\nhttps://build.opensuse.org/package/view_file/openSUSE:Leap:15.2/apparmor/apparmor.service?expand\u003d1\n\nThis was the patch that introduced the stop behaviour https://gitlab.com/apparmor/apparmor/merge_requests/81\n\nAnd the release notes explain the rationale https://www.suse.com/releasenotes/x86_64/SUSE-SLES/15/#fate-325343\n\nMy understanding is that you can safely add the `systemctl stop apparmor`, it will disable apparmor in previous SLES versions and will be a no-op in newer ones.\n\nI will keep the previous if and add this additional check","commit_id":"327f4a77445662ae9749a8454dcf2ec21e121929"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"426cd7ad4856a51062e6fef97866babf5651f9fc","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    # Disable apparmor profiles in openSUSE and SLE distros"},{"line_number":234,"context_line":"    # to avoid issues with haproxy and dnsmasq"},{"line_number":235,"context_line":"    if sudo systemctl is-active -q apparmor; then"},{"line_number":236,"context_line":"        sudo systemctl stop apparmor"},{"line_number":237,"context_line":"    fi"},{"line_number":238,"context_line":"    if sudo systemctl is-enabled -q apparmor; then"},{"line_number":239,"context_line":"        sudo systemctl disable apparmor"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_d44e5395","line":236,"in_reply_to":"7faddb67_1e8c0c7e","updated":"2019-08-08 11:42:23.000000000","message":"Thanks for the info.  A no-op is no good otherwise haproxy/dnsmasq will still break.  I\u0027ll make it use aa-teardown if and only if it\u0027s available, and call stop in all cases.","commit_id":"327f4a77445662ae9749a8454dcf2ec21e121929"}]}