)]}'
{"lib/nova":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d4f54cb3f06f6189cd11054e4911eda8663c68ce","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        iniset $NOVA_CONF scheduler workers \"$API_WORKERS\""},{"line_number":399,"context_line":"    fi"},{"line_number":400,"context_line":"    iniset $NOVA_CONF neutron default_floating_pool \"$PUBLIC_NETWORK_NAME\""},{"line_number":401,"context_line":"    if [[ $SERVICE_IP_VERSION \u003d\u003d 6 ]]; then"},{"line_number":402,"context_line":"        iniset $NOVA_CONF DEFAULT my_ip \"$HOST_IPV6\""},{"line_number":403,"context_line":"        iniset $NOVA_CONF DEFAULT use_ipv6 \"True\""},{"line_number":404,"context_line":"    else"},{"line_number":405,"context_line":"        iniset $NOVA_CONF DEFAULT my_ip \"$HOST_IP\""},{"line_number":406,"context_line":"    fi"},{"line_number":407,"context_line":"    iniset $NOVA_CONF DEFAULT instance_name_template \"${INSTANCE_NAME_PREFIX}%08x\""},{"line_number":408,"context_line":"    iniset $NOVA_CONF DEFAULT osapi_compute_listen \"$NOVA_SERVICE_LISTEN_ADDRESS\""},{"line_number":409,"context_line":"    iniset $NOVA_CONF DEFAULT metadata_listen \"$NOVA_SERVICE_LISTEN_ADDRESS\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_7f295e99","line":406,"range":{"start_line":401,"start_character":4,"end_line":406,"end_character":6},"updated":"2019-08-09 16:02:01.000000000","message":"This is where default_proxyclient_addr gets the default value. I could just avoid using iniget and use the same HOST_IPV6 and HOST_IP variables below if that\u0027s cleaner.","commit_id":"d28d380063ab12d9d682bcd80a2ee0ab7a25828c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0c4dda3aa662e4155ed06cd5ae2298abddc37b48","unresolved":false,"context_lines":[{"line_number":597,"context_line":"    local offset"},{"line_number":598,"context_line":"    offset\u003d$(((NOVA_CPU_CELL - 1) * 4))"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    local default_proxyclient_addr\u003d$(iniget $NOVA_CPU_CONF DEFAULT my_ip)"},{"line_number":601,"context_line":"    local default_server_listen"},{"line_number":602,"context_line":"    if [[ $SERVICE_IP_VERSION \u003d\u003d 6 ]]; then"},{"line_number":603,"context_line":"        default_server_listen\u003d\"::\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_42e03af9","line":600,"updated":"2019-08-10 19:58:01.000000000","message":"Note: I ended up needing this in my patch when previously I thought I wouldn\u0027t. Turns out NOVA_SERVICE_HOST only ever represents the controller node and not the compute/subnode. So I added you as co-author on that patch. (And I would have just modified this patch instead of doing a new patch if I had known about NOVA_SERVICE_HOST from the outset).","commit_id":"d28d380063ab12d9d682bcd80a2ee0ab7a25828c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9d8b3598f265e090e2d916f74bef46c51a57504f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        # Address on which instance vncservers will listen on compute hosts."},{"line_number":630,"context_line":"        # For multi-host, this should be the management ip of the compute host."},{"line_number":631,"context_line":"        VNCSERVER_LISTEN\u003d${VNCSERVER_LISTEN:-$default_server_listen}"},{"line_number":632,"context_line":"        VNCSERVER_PROXYCLIENT_ADDRESS\u003d${VNCSERVER_PROXYCLIENT_ADDRESS:-$default_proxyclient_addr}"},{"line_number":633,"context_line":"        iniset $NOVA_CPU_CONF vnc server_listen \"$VNCSERVER_LISTEN\""},{"line_number":634,"context_line":"        iniset $NOVA_CPU_CONF vnc server_proxyclient_address \"$VNCSERVER_PROXYCLIENT_ADDRESS\""},{"line_number":635,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_22fd0908","line":632,"updated":"2019-08-09 16:05:31.000000000","message":"Is there some reason why we can\u0027t just set these to use the existing variables?\n\n +        VNCSERVER_LISTEN\u003d${VNCSERVER_LISTEN\u003d$NOVA_SERVICE_LISTEN_ADDRESS}\n +        VNCSERVER_PROXYCLIENT_ADDRESS\u003d${VNCSERVER_PROXYCLIENT_ADDRESS\u003d$NOVA_SERVICE_HOST}","commit_id":"d28d380063ab12d9d682bcd80a2ee0ab7a25828c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d05acae03d0354f726c391af374c5c2086f2d3f","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        # Address on which instance vncservers will listen on compute hosts."},{"line_number":630,"context_line":"        # For multi-host, this should be the management ip of the compute host."},{"line_number":631,"context_line":"        VNCSERVER_LISTEN\u003d${VNCSERVER_LISTEN:-$default_server_listen}"},{"line_number":632,"context_line":"        VNCSERVER_PROXYCLIENT_ADDRESS\u003d${VNCSERVER_PROXYCLIENT_ADDRESS:-$default_proxyclient_addr}"},{"line_number":633,"context_line":"        iniset $NOVA_CPU_CONF vnc server_listen \"$VNCSERVER_LISTEN\""},{"line_number":634,"context_line":"        iniset $NOVA_CPU_CONF vnc server_proxyclient_address \"$VNCSERVER_PROXYCLIENT_ADDRESS\""},{"line_number":635,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_048d7529","line":632,"in_reply_to":"7faddb67_22fd0908","updated":"2019-08-10 00:11:33.000000000","message":"Hmm, I wasn\u0027t aware of NOVA_SERVICE_LISTEN_ADDRESS.","commit_id":"d28d380063ab12d9d682bcd80a2ee0ab7a25828c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9d8b3598f265e090e2d916f74bef46c51a57504f","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        # Address on which instance spiceservers will listen on compute hosts."},{"line_number":641,"context_line":"        # For multi-host, this should be the management ip of the compute host."},{"line_number":642,"context_line":"        SPICESERVER_PROXYCLIENT_ADDRESS\u003d${SPICESERVER_PROXYCLIENT_ADDRESS\u003d$NOVA_SERVICE_LOCAL_HOST}"},{"line_number":643,"context_line":"        SPICESERVER_LISTEN\u003d${SPICESERVER_LISTEN\u003d$NOVA_SERVICE_LOCAL_HOST}"},{"line_number":644,"context_line":"        iniset $NOVA_CPU_CONF spice enabled true"},{"line_number":645,"context_line":"        iniset $NOVA_CPU_CONF spice server_listen \"$SPICESERVER_LISTEN\""},{"line_number":646,"context_line":"        iniset $NOVA_CPU_CONF spice server_proxyclient_address \"$SPICESERVER_PROXYCLIENT_ADDRESS\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7faddb67_621a2170","line":643,"updated":"2019-08-09 16:05:31.000000000","message":"Same here.","commit_id":"d28d380063ab12d9d682bcd80a2ee0ab7a25828c"}]}