)]}'
{"lib/databases/mysql":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a284864b26e75e739d3a93640408ea4b8b76255d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"register_database mysql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"MYSQL_SERVICE_NAME\u003d${MYSQL_SERVICE_NAME:-\"\"}"},{"line_number":19,"context_line":"if [[ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"\" ]]; then"},{"line_number":20,"context_line":"    MYSQL_SERVICE_NAME\u003dmysql"},{"line_number":21,"context_line":"    if is_fedora \u0026\u0026 ! is_oraclelinux; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_9e18141e","line":18,"updated":"2019-10-17 11:57:02.000000000","message":"This line doesn\u0027t seem to be necessary to me. If the variable isn\u0027t set beforehand, it will get it\u0027s value below.","commit_id":"9ae47800df4130390cac9cdfec67c35bae58af54"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"02528c206bac8066e527bad84e614109e9d85d10","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"register_database mysql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"MYSQL_SERVICE_NAME\u003d${MYSQL_SERVICE_NAME:-\"\"}"},{"line_number":19,"context_line":"if [[ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"\" ]]; then"},{"line_number":20,"context_line":"    MYSQL_SERVICE_NAME\u003dmysql"},{"line_number":21,"context_line":"    if is_fedora \u0026\u0026 ! is_oraclelinux; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_2b43da6e","line":18,"in_reply_to":"3fa7e38b_9e18141e","updated":"2019-10-17 20:36:23.000000000","message":"Done","commit_id":"9ae47800df4130390cac9cdfec67c35bae58af54"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a284864b26e75e739d3a93640408ea4b8b76255d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"register_database mysql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"MYSQL_SERVICE_NAME\u003d${MYSQL_SERVICE_NAME:-\"\"}"},{"line_number":19,"context_line":"if [[ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"\" ]]; then"},{"line_number":20,"context_line":"    MYSQL_SERVICE_NAME\u003dmysql"},{"line_number":21,"context_line":"    if is_fedora \u0026\u0026 ! is_oraclelinux; then"},{"line_number":22,"context_line":"        MYSQL_SERVICE_NAME\u003dmariadb"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_be139000","line":19,"updated":"2019-10-17 11:57:02.000000000","message":"This is simpler:\n\nif [[ -z \"$MYSQL_SERVICE_NAME\" ]]; then","commit_id":"9ae47800df4130390cac9cdfec67c35bae58af54"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"02528c206bac8066e527bad84e614109e9d85d10","unresolved":false,"context_lines":[{"line_number":16,"context_line":"register_database mysql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"MYSQL_SERVICE_NAME\u003d${MYSQL_SERVICE_NAME:-\"\"}"},{"line_number":19,"context_line":"if [[ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"\" ]]; then"},{"line_number":20,"context_line":"    MYSQL_SERVICE_NAME\u003dmysql"},{"line_number":21,"context_line":"    if is_fedora \u0026\u0026 ! is_oraclelinux; then"},{"line_number":22,"context_line":"        MYSQL_SERVICE_NAME\u003dmariadb"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_cb532639","line":19,"in_reply_to":"3fa7e38b_be139000","updated":"2019-10-17 20:36:23.000000000","message":"Done","commit_id":"9ae47800df4130390cac9cdfec67c35bae58af54"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fce1363773bce3535af8f565e8f1d1924d3b2467","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"register_database mysql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"MYSQL_SERVICE_NAME\u003dmysql"},{"line_number":19,"context_line":"if is_fedora \u0026\u0026 ! is_oraclelinux; then"},{"line_number":20,"context_line":"    MYSQL_SERVICE_NAME\u003dmariadb"},{"line_number":21,"context_line":"elif is_suse \u0026\u0026 systemctl list-unit-files | grep -q \u0027mariadb\\.service\u0027; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_edd219fd","side":"PARENT","line":18,"updated":"2019-10-29 12:01:43.000000000","message":"I\u0027m not 100% convinced that we should overload this variable. Currently it just tells us which systemd service name we should enable or restart. Maybe this is always identical with the intended use here, but would it still make sense to use a different name like maybe MYSQL_SERVER(_TYPE)?","commit_id":"650769a3115704aa8af8b346a57838d46b87ba6a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"34ea16fb25eecafaaaf711da1f43de776b70d805","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"register_database mysql"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"MYSQL_SERVICE_NAME\u003dmysql"},{"line_number":19,"context_line":"if is_fedora \u0026\u0026 ! is_oraclelinux; then"},{"line_number":20,"context_line":"    MYSQL_SERVICE_NAME\u003dmariadb"},{"line_number":21,"context_line":"elif is_suse \u0026\u0026 systemctl list-unit-files | grep -q \u0027mariadb\\.service\u0027; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_d3ae2c2e","side":"PARENT","line":18,"in_reply_to":"3fa7e38b_edd219fd","updated":"2019-11-13 12:27:44.000000000","message":"Personally I don\u0027t think it is problem and that we should add another variable and another \"if\" blocks to set it properly. But if You really want, I can change it.","commit_id":"650769a3115704aa8af8b346a57838d46b87ba6a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fce1363773bce3535af8f565e8f1d1924d3b2467","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # In case of Mariadb, giving hostname in arguments causes permission"},{"line_number":98,"context_line":"    # problems as it expects connection through socket"},{"line_number":99,"context_line":"    cmd_args\u003d\"-uroot -p$DATABASE_PASSWORD \""},{"line_number":100,"context_line":"    if ! is_ubuntu || [ \"$MYSQL_SERVICE_NAME\" !\u003d \"mariadb\" ]; then"},{"line_number":101,"context_line":"        cmd_args\u003d\"$cmd_args -h127.0.0.1 \""},{"line_number":102,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_edfa19b8","line":99,"updated":"2019-10-29 12:01:43.000000000","message":"Better make this a local variable to avoid side effects.","commit_id":"27bd2cd2663bb8efbecc26f6f154045bef88a5be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"34ea16fb25eecafaaaf711da1f43de776b70d805","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    # In case of Mariadb, giving hostname in arguments causes permission"},{"line_number":98,"context_line":"    # problems as it expects connection through socket"},{"line_number":99,"context_line":"    cmd_args\u003d\"-uroot -p$DATABASE_PASSWORD \""},{"line_number":100,"context_line":"    if ! is_ubuntu || [ \"$MYSQL_SERVICE_NAME\" !\u003d \"mariadb\" ]; then"},{"line_number":101,"context_line":"        cmd_args\u003d\"$cmd_args -h127.0.0.1 \""},{"line_number":102,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_73f09867","line":99,"in_reply_to":"3fa7e38b_edfa19b8","updated":"2019-11-13 12:27:44.000000000","message":"Done","commit_id":"27bd2cd2663bb8efbecc26f6f154045bef88a5be"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fce1363773bce3535af8f565e8f1d1924d3b2467","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    # In case of Mariadb, giving hostname in arguments causes permission"},{"line_number":98,"context_line":"    # problems as it expects connection through socket"},{"line_number":99,"context_line":"    cmd_args\u003d\"-uroot -p$DATABASE_PASSWORD \""},{"line_number":100,"context_line":"    if ! is_ubuntu || [ \"$MYSQL_SERVICE_NAME\" !\u003d \"mariadb\" ]; then"},{"line_number":101,"context_line":"        cmd_args\u003d\"$cmd_args -h127.0.0.1 \""},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_3fca296e","line":100,"updated":"2019-10-29 12:01:43.000000000","message":"This condition looks horribly complicated to me. IIUC it is the inverse of the condition on L107, so maybe you can move this into an \"else\" branch below?","commit_id":"27bd2cd2663bb8efbecc26f6f154045bef88a5be"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"34ea16fb25eecafaaaf711da1f43de776b70d805","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    # In case of Mariadb, giving hostname in arguments causes permission"},{"line_number":98,"context_line":"    # problems as it expects connection through socket"},{"line_number":99,"context_line":"    cmd_args\u003d\"-uroot -p$DATABASE_PASSWORD \""},{"line_number":100,"context_line":"    if ! is_ubuntu || [ \"$MYSQL_SERVICE_NAME\" !\u003d \"mariadb\" ]; then"},{"line_number":101,"context_line":"        cmd_args\u003d\"$cmd_args -h127.0.0.1 \""},{"line_number":102,"context_line":"    fi"},{"line_number":103,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_d385ccaf","line":100,"in_reply_to":"3fa7e38b_3fca296e","updated":"2019-11-13 12:27:44.000000000","message":"but cmd_args is needed already in L108 so I can\u0027t put it in \"else\" below L108.\nI changed it to make it easier to read. Hope it\u0027s better for You now.","commit_id":"27bd2cd2663bb8efbecc26f6f154045bef88a5be"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9cdc1dd860ff5ef6f2b6be45543df7305eed551b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        local cmd_args\u003d\"-uroot -p$DATABASE_PASSWORD -h127.0.0.1 \""},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # In mariadb on Ubuntu socket plugin is used for authentication as root so"},{"line_number":106,"context_line":"    # it works only as sudo. To restore old \"mysql like\" behaviour, we need to"},{"line_number":107,"context_line":"    # change auth plugin for root user"},{"line_number":108,"context_line":"    if is_ubuntu \u0026\u0026 [ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"mariadb\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_b1b26c05","line":105,"updated":"2019-12-04 17:22:10.000000000","message":"This is actually enabled by default on mariadb 10.4.3 and later, https://mariadb.com/kb/en/library/authentication-plugin-unix-socket/.\n\nMaybe we should run this UPDATE against all mariadb installs?","commit_id":"13d035ec2f0f64cbff1cbf48a16c547dbd6ed16c"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c26b36d0eca202c478b73eb3c963c9289a4b2d57","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        local cmd_args\u003d\"-uroot -p$DATABASE_PASSWORD -h127.0.0.1 \""},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # In mariadb on Ubuntu socket plugin is used for authentication as root so"},{"line_number":106,"context_line":"    # it works only as sudo. To restore old \"mysql like\" behaviour, we need to"},{"line_number":107,"context_line":"    # change auth plugin for root user"},{"line_number":108,"context_line":"    if is_ubuntu \u0026\u0026 [ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"mariadb\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_939dbfbc","line":105,"in_reply_to":"3fa7e38b_77ae2430","updated":"2019-12-09 11:36:45.000000000","message":"in that case, i guess it should check the version of mariadb instead.\nand maybe the condition in L99 should be consistent with this?","commit_id":"13d035ec2f0f64cbff1cbf48a16c547dbd6ed16c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b91661f59c8f27a0a5feca5ef35164d90e92a8ec","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        local cmd_args\u003d\"-uroot -p$DATABASE_PASSWORD -h127.0.0.1 \""},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # In mariadb on Ubuntu socket plugin is used for authentication as root so"},{"line_number":106,"context_line":"    # it works only as sudo. To restore old \"mysql like\" behaviour, we need to"},{"line_number":107,"context_line":"    # change auth plugin for root user"},{"line_number":108,"context_line":"    if is_ubuntu \u0026\u0026 [ \"$MYSQL_SERVICE_NAME\" \u003d\u003d \"mariadb\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_77ae2430","line":105,"in_reply_to":"3fa7e38b_b1b26c05","updated":"2019-12-04 19:59:24.000000000","message":"Done","commit_id":"13d035ec2f0f64cbff1cbf48a16c547dbd6ed16c"}]}