)]}'
{"id":"openstack%2Fdevstack~683247","triplet_id":"openstack%2Fdevstack~master~Ica4a690a4f2894a03ceb8557a947ed2ea4a60e53","project":"openstack/devstack","branch":"master","topic":"iscsi-fedora-only","hashtags":[],"change_id":"Ica4a690a4f2894a03ceb8557a947ed2ea4a60e53","subject":"Restrict iscsi package hack to Fedora","status":"MERGED","created":"2019-09-19 22:12:46.000000000","updated":"2019-09-20 11:36:14.000000000","submitted":"2019-09-20 11:34:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"683247-1568979264885-8c653045","meta_rev_id":"d70b8c3861fc9e5c9f6b6ada0bb9e946ba64aef8","_number":683247,"virtual_id_number":683247,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"value":0,"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},{"value":2,"date":"2019-09-20 11:34:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":2,"date":"2019-09-19 22:21:40.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":2,"date":"2019-09-20 09:25:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2019-09-19 22:13:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"value":1,"date":"2019-09-20 09:16:36.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"value":0,"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-20 05:35:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"value":0,"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-19 22:13:35.000000000","updated_by":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"reviewer":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"state":"REVIEWER"},{"updated":"2019-09-19 22:21:40.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2019-09-20 09:16:36.000000000","updated_by":{"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},"reviewer":{"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},"state":"REVIEWER"},{"updated":"2019-09-20 09:25:46.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-09-20 11:34:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"96012745fc940060da0167e9e6b7c67bdb722e76","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-19 22:12:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b1cbc48701ec5883f84fbdde79cc84e7ff8a8dd5","author":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"date":"2019-09-19 22:13:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"225bdb8050be033c20640831155a08d0ed7c1e2e","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-09-19 22:21:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5fb3445b82828d7d8d806e47fbe8b9f375325535","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-20 05:35:16.000000000","message":"Patch Set 1: Workflow+1\n\nthis hasn\u0027t yet got nodes ... but it is holding up other people\u0027s gates.  going for a +w pre-emptively","accounts_in_message":[],"_revision_number":1},{"id":"184e2cbd4b5931c1feb4b7348888332a49bdffea","author":{"_account_id":29035,"name":"Kamil Mańkowski","email":"kamil.mankowski+one@codilime.com","username":"kamil.mankowski"},"date":"2019-09-20 09:16:36.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"cce0c1f4b23ebbe53fa0dd76d20cb0bae20e375b","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-20 09:25:46.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"c8e1effb6a3c1863102433846d6f1c3154a9cc12","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 09:38:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-devstack-dsvm-updown https://zuul.opendev.org/t/openstack/build/3a79b8ce3a914a19a3e073f0f54487cf : SUCCESS in 36m 27s\n- tempest-full https://zuul.opendev.org/t/openstack/build/c7231b7cda834cc4b36e135b631d7fe7 : SUCCESS in 2h 05m 04s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/f8cd060ed97d431b9031cfa067537dd1 : SUCCESS in 1h 03m 02s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/33259ca52dc94c7999126386a8340776 : SUCCESS in 51m 24s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a7a99c99f0fe45198060c28bc02de40c : SUCCESS in 1h 27m 05s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fc8b1b22a7d240b8a404617ef5b310ef : SUCCESS in 4m 47s\n- devstack https://zuul.opendev.org/t/openstack/build/c75caf70a78649718ceb4b3a88307d6b : SUCCESS in 34m 17s\n- devstack-xenial https://zuul.opendev.org/t/openstack/build/6c1de3e12fda4adcac3be00250b637c0 : SUCCESS in 38m 40s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/4521d9a53d7e478cbe3f94dfe7fd759f : SUCCESS in 30m 01s\n- devstack-platform-centos-7 https://zuul.opendev.org/t/openstack/build/6fbd26d994a144cebed324c5c0f72110 : FAILURE in 1h 50m 02s (non-voting)\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/ab366c1fd99e4f51a36cef0fb8dbd6c0 : FAILURE in 1h 32m 35s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/035877db18364d76a42585cf79369ed5 : SUCCESS in 1h 53m 46s (non-voting)\n- devstack-platform-xenial https://zuul.opendev.org/t/openstack/build/a7c33b79fd81478fa8ded27b99a15a59 : SUCCESS in 1h 41m 04s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/b416ada95d8142938c4cb30632bbf81c : SUCCESS in 42m 22s\n- devstack-multinode-xenial https://zuul.opendev.org/t/openstack/build/9c42748027b844e59bd761ad7fc12458 : SUCCESS in 43m 21s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/5c61d45774e24fc9b662f87739d1cd83 : SUCCESS in 4m 44s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/e2d2e9e3ff944285996730aaec5a6f6e : SUCCESS in 4m 16s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2ece38dc00ff469dacb7b6f12a325a5b : SUCCESS in 53m 13s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/95f03442d1bd4184b6760a0ccfa95f9f : SUCCESS in 31m 24s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/34bfd611e3b6464bb9ee7d4f83337a95 : SUCCESS in 1h 14m 59s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/1ea0a6f2be8743009dbfaeda6f1553c9 : SUCCESS in 1h 24m 31s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/0407a5a9089c4f908735d0f0c8de4448 : FAILURE in 1h 26m 26s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/946f3608b5f841eab10066ef45c83041 : SUCCESS in 59m 34s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c32b47c1616c4cd3806b68cbda35e418 : SUCCESS in 1h 11m 30s","accounts_in_message":[],"_revision_number":1},{"id":"88b443a1ca94b6040dadb22102964f67b439ef9c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 09:39:15.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"805e3bb0d657498c169cb7dc03f0b443d978d898","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 11:34:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/1fe0289f5a9f428cb1ced41adb13913d : SUCCESS in 1h 52m 36s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/9852a73711654153b5ebc9bd0c6c880e : SUCCESS in 1h 06m 19s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/227711e32761418ab1311b29801eb25d : SUCCESS in 1h 00m 02s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/479bc07bd0a14918bfed47994f9edb45 : SUCCESS in 1h 26m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/10821798ac284f5181ea69811ab556a8 : SUCCESS in 2m 54s\n- devstack https://zuul.opendev.org/t/openstack/build/6314d4555d2f4ba6a438f4250dbdbf91 : SUCCESS in 29m 20s\n- devstack-xenial https://zuul.opendev.org/t/openstack/build/fb6fc084405f40cfab2d4555f6d615e6 : SUCCESS in 33m 04s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/33b6b09f4a6f4ad19ed8aa6b59c4944c : SUCCESS in 31m 12s\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/1ed29d133d244d20ace2a2d5ba7695be : SUCCESS in 50m 44s\n- devstack-multinode-xenial https://zuul.opendev.org/t/openstack/build/6e0362bfc1214a6083f905a9115ce182 : SUCCESS in 42m 09s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/18a8a3f15fda48fba3ba7599beb9439d : SUCCESS in 4m 14s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/83ceb8d636fd4ceeb6df2b496763018a : SUCCESS in 2m 27s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/7de1663742ab4a6eb9449ed1d68dbe73 : SUCCESS in 1h 15m 32s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/c0c67fec9c4e48678525f1e9b50e81b0 : SUCCESS in 1h 27m 32s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/6c6a655406f344a394bffe6e5848baed : SUCCESS in 1h 02m 49s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f9b3f0cbf2344b55b4f66644ec3c59c9 : SUCCESS in 1h 06m 02s","accounts_in_message":[],"_revision_number":1},{"id":"7718b28540e20ef1be20c92d3f25707710321060","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 11:34:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"84340116ccaed24369248343035577784d7742d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 11:36:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dde5f2219a8344489c7beeb656875df9 : SUCCESS in 1m 20s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1a46c898db9c16173013d95e2bc954992121077c","revisions":{"1a46c898db9c16173013d95e2bc954992121077c":{"kind":"REWORK","_number":1,"created":"2019-09-19 22:12:46.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/47/683247/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/47/683247/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/683247/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/683247/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/47/683247/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/47/683247/1"}}},"commit":{"parents":[{"commit":"ba50347526ea76b501dacf774ea6f0997361358c","subject":"Update for f29","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ba50347526ea76b501dacf774ea6f0997361358c"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-19 22:11:08.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-19 22:11:08.000000000","tz":600},"subject":"Restrict iscsi package hack to Fedora","message":"Restrict iscsi package hack to Fedora\n\nI forgot in I2f16658c5a3e22cac70912a0f3ad65cdd7071a1e that \"is_fedora\"\nmatches rhel/centos for historical reasons.  Restrict the install to\njust the Fedora platforms by checking DISTRO matches\n\nChange-Id: Ica4a690a4f2894a03ceb8557a947ed2ea4a60e53\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1a46c898db9c16173013d95e2bc954992121077c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1a46c898db9c16173013d95e2bc954992121077c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}