)]}'
{"id":"openstack%2Fdevstack~684184","triplet_id":"openstack%2Fdevstack~master~Ic54b050ce9e21cfdbedcecaab7d7b89f78226441","project":"openstack/devstack","branch":"master","topic":"oscwrap-stderr","hashtags":[],"change_id":"Ic54b050ce9e21cfdbedcecaab7d7b89f78226441","subject":"OSC helpers: do not rely only on non-blank output","status":"NEW","created":"2019-09-24 03:45:02.000000000","updated":"2020-09-27 10:44:42.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"72d911ccf63a68d59030b9fb8740de834697e9ed","_number":684184,"virtual_id_number":684184,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-09-25 01:23:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-09-17 05:16:18.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2020-09-27 10:44:42.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-25 01:23:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-27 10:44:42.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"}],"messages":[{"id":"6ab398d3fefe24919d2c6cf3f417e92504193db8","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-24 03:45:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6496709cd82f6afac7cdd7d0095055856a1f87a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 04:11:06.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- legacy-devstack-dsvm-updown https://zuul.opendev.org/t/openstack/build/48f3275943ea42879d9c5464973c343b : FAILURE in 18m 36s\n- devstack https://zuul.opendev.org/t/openstack/build/61f74e516c2e49f9b579364ad278157b : FAILURE in 18m 06s","accounts_in_message":[],"_revision_number":1},{"id":"f72c86a7f0389996893092a9fd97cda7f56c2dd4","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-24 05:24:06.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"408de42e0190086e6ce68554f415bf168dd82f38","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 06:12:22.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-devstack-dsvm-updown https://zuul.opendev.org/t/openstack/build/ae43d870ecca4fa49d86840636fe775a : SUCCESS in 38m 12s\n- devstack https://zuul.opendev.org/t/openstack/build/d49d08a789884882bdf5741c846eec65 : SUCCESS in 27m 17s","accounts_in_message":[],"_revision_number":2},{"id":"ecdc8d3c86f2d0588293fb6c57780d638fe0b4ea","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-24 06:22:07.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"37b13c13e4e7d325bc9c611ba55a10c4464bfed6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-24 11:21:19.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- legacy-devstack-dsvm-updown https://zuul.opendev.org/t/openstack/build/cab5741d012b49bfbaa5cb19afc532ab : SUCCESS in 41m 26s\n- tempest-full https://zuul.opendev.org/t/openstack/build/f08300ff998842aa8159e716d4602c1b : SUCCESS in 1h 42m 27s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/89852f45327e4948b235963e527b2d76 : FAILURE in 40m 56s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/7559dccabd6c423a912703711948515a : SUCCESS in 1h 22m 26s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/16d8233f73f4484394957b07350dddb8 : SUCCESS in 1h 44m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/15810a8cacb0418b888b364717b6938b : SUCCESS in 3m 40s\n- devstack https://zuul.opendev.org/t/openstack/build/7690450d4d97438dbe3561b19f899952 : SUCCESS in 37m 30s\n- devstack-xenial https://zuul.opendev.org/t/openstack/build/e55050cde51d4e0d82287af33ec4333e : SUCCESS in 31m 47s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/c9358616ea744de7a291b73b15ff96d4 : SUCCESS in 28m 01s\n- devstack-platform-centos-7 https://zuul.opendev.org/t/openstack/build/c4bb1b553d6042c7ba79c8cae6d27b5e : SUCCESS in 1h 45m 28s (non-voting)\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/dc845861dae54b258cfc4e0f969571bb : SUCCESS in 1h 26m 03s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/00e7a54f1e7d429aae1a144e03e8f6a0 : SUCCESS in 1h 45m 07s (non-voting)\n- devstack-platform-xenial https://zuul.opendev.org/t/openstack/build/08c90d876ae2492fa70e95c3a10fb0ac : SUCCESS in 1h 48m 30s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/79b4727d4a8f4a268ad6b7a86e113ee4 : SUCCESS in 56m 15s\n- devstack-multinode-xenial https://zuul.opendev.org/t/openstack/build/1c66b0d099bf45aa9ac1643ab763caed : SUCCESS in 38m 11s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/d350e55f4f9d47239397115d67b85fad : SUCCESS in 4m 46s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/f06d646e66704564a5cd5297d91da813 : SUCCESS in 2m 45s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/36ddec97fe1045f7ab8ca5ecb46c7ccb : SUCCESS in 1h 06m 23s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/2c342f4b6fb84303b8c14a7a633acc94 : SUCCESS in 29m 59s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/bb6a15d767054f99a1151db3f9a855ee : SUCCESS in 1h 14m 17s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/7ddf30377ed64002b470fd51ad1688de : SUCCESS in 1h 25m 07s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/d6f52d128db5476e8168e2b5b6a68763 : SUCCESS in 2h 09m 53s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/731e25668e9940ea9bdda2f21ae464c9 : SUCCESS in 1h 04m 09s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/de592e0b087d49ecb6f55d59987a9ca2 : SUCCESS in 1h 25m 09s","accounts_in_message":[],"_revision_number":3},{"id":"40d88d2c5967958b7bc564988d0fa9b4a22ba047","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-09-24 21:04:21.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"c656ec4e4faf44a9516597593c00e3e3fff1ab54","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-25 01:23:15.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-devstack-dsvm-updown https://zuul.opendev.org/t/openstack/build/5252c4a0f8ab4a24bdd618988dd102b9 : SUCCESS in 30m 34s\n- tempest-full https://zuul.opendev.org/t/openstack/build/918cf7a7c9b3432280ad2e3372eccacc : SUCCESS in 1h 37m 54s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/918e1655a3b14c56ae47ffa9713c9a4d : SUCCESS in 58m 30s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/189e5c6804814da1a63a1fc8e8a5f426 : SUCCESS in 1h 08m 01s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/94272d88f56c4848a05fc7632c06332e : SUCCESS in 1h 28m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/289b1e47c45f42e2a823db8e1c018f2b : SUCCESS in 4m 07s\n- devstack https://zuul.opendev.org/t/openstack/build/69bf58d699f540759b858855cff8722d : SUCCESS in 27m 57s\n- devstack-xenial https://zuul.opendev.org/t/openstack/build/9b9b280fc3124278ac69b6377961257c : SUCCESS in 30m 05s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/9cb7044244cf4b4fa0970b3141c1878e : SUCCESS in 27m 47s\n- devstack-platform-centos-7 https://zuul.opendev.org/t/openstack/build/db51131986eb4c3d8ae986b5fc7c9580 : SUCCESS in 2h 00m 29s (non-voting)\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/18d4559537384f348e95e9c5d8e8864d : FAILURE in 1h 40m 33s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/ddd179ad2cbd432e98912714eb0476aa : SUCCESS in 1h 50m 37s (non-voting)\n- devstack-platform-xenial https://zuul.opendev.org/t/openstack/build/95e671df70494e0d8c305bb6bb1ff2ed : SUCCESS in 1h 40m 54s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/01181bbfd72c421e8a596ee2763558f3 : SUCCESS in 45m 06s\n- devstack-multinode-xenial https://zuul.opendev.org/t/openstack/build/5dd9429d490e44eea17ed9cf2a5a9f44 : SUCCESS in 36m 49s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/fa814a3994f3471390b21db1ad5a20a8 : SUCCESS in 5m 40s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/c747d10abadb4da6bfe372340c13adcf : SUCCESS in 3m 11s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/32abf837d1494f4586747b7849cb9dbc : SUCCESS in 52m 31s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/33aa66948b8046b9b02b7dd7b387c9a1 : SUCCESS in 31m 36s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/d7628d6e09854ad992dbf063e591f538 : SUCCESS in 1h 08m 22s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/9260e25f5a7d4706935be95c755753cf : SUCCESS in 1h 27m 27s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/cbbece48a5154906b5ffa270a3224fab : SUCCESS in 1h 48m 13s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/55f05f74c7bd42dc8015abde8e1a07ec : SUCCESS in 57m 18s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a883b4cbb93c4a10966401c10f80b898 : SUCCESS in 1h 04m 02s","accounts_in_message":[],"_revision_number":3},{"id":"ac7a68ebbafaae168df551e15d580d1aac1a8323","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-09-17 05:16:18.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"a24a14bda02bdf9c87757ecb61934bc5c9110dd0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-17 07:03:42.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- grenade https://zuul.opendev.org/t/openstack/build/5635827c29614750ac49b4f474a5a332 : SUCCESS in 1h 04m 05s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d496b783e8d44af6b23a81ba2f7a59e0 : SUCCESS in 1h 22m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cbfeb5e47489406caa89df868d35ede4 : SUCCESS in 13m 31s\n- devstack https://zuul.opendev.org/t/openstack/build/5ecd4becdff64d7eb86be8b637da2956 : SUCCESS in 28m 45s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/df44058c8dbc4776ba7102f3e70f5849 : SUCCESS in 30m 47s\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/1013d6a83c2343c78862b04d0e46c608 : SUCCESS in 1h 35m 28s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/783113feb2304253a1575a78618426e3 : RETRY_LIMIT in 1m 06s (non-voting)\n- devstack-platform-centos-8 https://zuul.opendev.org/t/openstack/build/e7ac32d40c3b4edfa3ebd0d1164cf293 : SUCCESS in 1h 40m 12s (non-voting)\n- devstack-platform-focal https://zuul.opendev.org/t/openstack/build/1c0527c593274a31b684cf2a8afc19de : SUCCESS in 1h 26m 12s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/2b86036e9164461eada6098493f3ed5b : SUCCESS in 36m 32s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/a169499ed36c4059af38f172438930b0 : SUCCESS in 3m 25s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/1c5d8f63379c4fa18a882d3736eadcdf : SUCCESS in 2m 39s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/73476b03c5394eb08aad3f6ea0112c00 : SUCCESS in 1h 15m 45s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/090533be0af74096973207dfbdbf6412 : SUCCESS in 39m 06s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/da5f508d0cff4cb1912ecf639e6bfabc : SUCCESS in 1h 11m 26s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/da48a82de9564f7cb888e1bb9b77a87e : SUCCESS in 1h 14m 52s\n- neutron-ovn-tempest-ovs-release https://zuul.opendev.org/t/openstack/build/8016b919001341239823ba64f0da298e : SUCCESS in 1h 12m 42s (non-voting)\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/34c6af27c46f4d31a1ddf0590fc3db95 : SUCCESS in 1h 36m 20s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c6f4333677564cdcb203d1dd256c2d8e : SUCCESS in 1h 03m 47s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/168455eda7244637bca23d56d725c08f : SUCCESS in 56m 53s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/4a3efdadb5f84d6aa02344b5b2e016b2 : SUCCESS in 56m 10s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"3731e42b7fe7afd04fa70aef61d92c185f613340","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-09-27 10:44:42.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"bf75e71443c54b786a543957a58558c86184ff1b","revisions":{"e2fe2e7c970ae03cd237f9d721201c15f457b5f4":{"kind":"REWORK","_number":1,"created":"2019-09-24 03:45:02.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/84/684184/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/84/684184/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/84/684184/1"}}},"commit":{"parents":[{"commit":"201d05fdc1fc89eb9d1766d8ba2c13568857f62f","subject":"Simplify role addtion helper functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/201d05fdc1fc89eb9d1766d8ba2c13568857f62f"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-24 03:05:35.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-24 03:44:19.000000000","tz":600},"subject":"OSC helpers: do not rely only on non-blank output","message":"OSC helpers: do not rely only on non-blank output\n\nEnsure that we handle error cases by checking the return code.  See\nfollow-on Iba1f1a90559d4bf5ec1481d22d66e54aa4f3274d where a non-blank\noutput from oscwrap does not always imply success (it might be an\nerror message).\n\nChange-Id: Ic54b050ce9e21cfdbedcecaab7d7b89f78226441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e2fe2e7c970ae03cd237f9d721201c15f457b5f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/e2fe2e7c970ae03cd237f9d721201c15f457b5f4"}]},"branch":"refs/heads/master"},"333c17b6d388708f30b47a6ed52791a3fc12b61b":{"kind":"REWORK","_number":2,"created":"2019-09-24 05:24:06.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/84/684184/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/84/684184/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/84/684184/2"}}},"commit":{"parents":[{"commit":"201d05fdc1fc89eb9d1766d8ba2c13568857f62f","subject":"Simplify role addtion helper functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/201d05fdc1fc89eb9d1766d8ba2c13568857f62f"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-24 03:05:35.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-24 05:23:30.000000000","tz":600},"subject":"OSC helpers: do not rely only on non-blank output","message":"OSC helpers: do not rely only on non-blank output\n\nEnsure that we handle error cases by checking the return code.  See\nfollow-on Iba1f1a90559d4bf5ec1481d22d66e54aa4f3274d where a non-blank\noutput from oscwrap does not always imply success (it might be an\nerror message).\n\nChange-Id: Ic54b050ce9e21cfdbedcecaab7d7b89f78226441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/333c17b6d388708f30b47a6ed52791a3fc12b61b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/333c17b6d388708f30b47a6ed52791a3fc12b61b"}]},"branch":"refs/heads/master"},"bf75e71443c54b786a543957a58558c86184ff1b":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2019-09-24 06:22:07.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/84/684184/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/84/684184/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/84/684184/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/84/684184/3"}}},"commit":{"parents":[{"commit":"21c2e68902113b578c4ce1fb8658c4c1d98396e7","subject":"Simplify role addtion helper functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/21c2e68902113b578c4ce1fb8658c4c1d98396e7"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-24 03:05:35.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-09-24 06:21:28.000000000","tz":600},"subject":"OSC helpers: do not rely only on non-blank output","message":"OSC helpers: do not rely only on non-blank output\n\nEnsure that we handle error cases by checking the return code.  See\nfollow-on Iba1f1a90559d4bf5ec1481d22d66e54aa4f3274d where a non-blank\noutput from oscwrap does not always imply success (it might be an\nerror message).\n\nChange-Id: Ic54b050ce9e21cfdbedcecaab7d7b89f78226441\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bf75e71443c54b786a543957a58558c86184ff1b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/bf75e71443c54b786a543957a58558c86184ff1b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}