)]}'
{"functions":[{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"fb9e8c58cf69195a1338c02b8ce028329a496d06","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"                fi"},{"line_number":1531,"context_line":"            fi"},{"line_number":1532,"context_line":"            #TODO(alegendre): handle streamOptimized once supported by the VMware driver."},{"line_number":1533,"context_line":"            vmdk_adapter_type\u003d\"ide\""},{"line_number":1534,"context_line":"            vmdk_disktype\u003d\"preallocated\""},{"line_number":1535,"context_line":"        else"},{"line_number":1536,"context_line":"            #TODO(alegendre): handle streamOptimized once supported by the VMware driver."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2BnXQ%3D","line":1533,"updated":"2014-01-23 21:17:45.000000000","message":"ide as the default adapter type is probably not a good idea. \nWe should just not guess at the adapter type if there are no available clues, in which case nova will use the default which is lsiLogic.","commit_id":"1ba9c6b02fe9bf19531ec95a6c844460f6d6473d"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"fb9e8c58cf69195a1338c02b8ce028329a496d06","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"        # NOTE: For backwards compatibility reasons, colons may be used in place"},{"line_number":1542,"context_line":"        # of semi-colons for property delimiters but they are not permitted"},{"line_number":1543,"context_line":"        # characters in NTFS filesystems."},{"line_number":1544,"context_line":"        property_string\u003d`echo \"$IMAGE_NAME\" | grep -oP \u0027(?\u003c\u003d-)(?!.*-).+[:;].+[:;].+$\u0027`"},{"line_number":1545,"context_line":"        IFS\u003d\u0027:;\u0027 read -a props \u003c\u003c\u003c \"$property_string\""},{"line_number":1546,"context_line":"        vmdk_disktype\u003d\"${props[0]:-$vmdk_disktype}\""},{"line_number":1547,"context_line":"        vmdk_adapter_type\u003d\"${props[1]:-$vmdk_adapter_type}\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2BnW0%3D","line":1544,"updated":"2014-01-23 21:17:45.000000000","message":"For the ide image in question, we can rename the image, and allow this script to infer the adapter type from the naming convention.","commit_id":"1ba9c6b02fe9bf19531ec95a6c844460f6d6473d"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"unresolved":false,"context_lines":[{"line_number":1547,"context_line":"        vmdk_adapter_type\u003d\"${props[1]:-$vmdk_adapter_type}\""},{"line_number":1548,"context_line":"        vmdk_net_adapter\u003d\"${props[2]:-$vmdk_net_adapter}\""},{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"        glance --os-auth-token $token --os-image-url http://$GLANCE_HOSTPORT image-create --name \"$IMAGE_NAME\" --is-public\u003dTrue --container-format bare --disk-format vmdk --property vmware_disktype\u003d\"$vmdk_disktype\" --property vmware_adaptertype\u003d\"$vmdk_adapter_type\" --property hw_vif_model\u003d\"$vmdk_net_adapter\" \u003c \"${IMAGE}\""},{"line_number":1551,"context_line":"        return"},{"line_number":1552,"context_line":"    fi"},{"line_number":1553,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F%2BnV8%3D","line":1550,"updated":"2014-01-23 21:20:15.000000000","message":"Also, a suggestion would be to not supply the vmware_adaptertype property if none can be inferred, since there is already a default that will kick in.","commit_id":"1ba9c6b02fe9bf19531ec95a6c844460f6d6473d"}]}