)]}'
{"id":"openstack%2Fdevstack~68538","triplet_id":"openstack%2Fdevstack~master~Ie3c23a4bb212f30fd078cec6b2b1d604738b595d","project":"openstack/devstack","branch":"master","topic":"bug/1271793","hashtags":[],"change_id":"Ie3c23a4bb212f30fd078cec6b2b1d604738b595d","subject":"Set default adapter type for monolithic flat disks","status":"ABANDONED","created":"2014-01-23 02:09:05.000000000","updated":"2014-01-23 21:20:15.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f00199f94a5f5f87de55fec59fc5b0b5ee05d803","_number":68538,"virtual_id_number":68538,"owner":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-01-23 06:54:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"disliked":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-01-23 07:09:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2014-01-23 05:48:04.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"value":-1,"date":"2014-01-23 21:17:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-01-23 02:11:25.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2014-01-23 02:10:27.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"date":"2014-01-23 02:11:29.000000000","_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-23 02:11:25.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2014-01-23 02:11:29.000000000","updated_by":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"reviewer":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"state":"REVIEWER"},{"updated":"2014-01-23 06:54:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ed77e7ca0a48b4d4f0999e1673d97da160a03e13","author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"date":"2014-01-23 02:10:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"703cde6cf0f634ae3f7480eb1fe74d9a4e1cab69","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-23 03:52:20.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-devstack-bash8 http://logs.openstack.org/38/68538/2/check/gate-devstack-bash8/35c9455 : SUCCESS in 8s\n- check-tempest-dsvm-full http://logs.openstack.org/38/68538/2/check/check-tempest-dsvm-full/10522e1 : SUCCESS in 1h 03m 50s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/38/68538/2/check/check-tempest-dsvm-postgres-full/78d3295 : SUCCESS in 1h 04m 48s\n- check-tempest-dsvm-neutron http://logs.openstack.org/38/68538/2/check/check-tempest-dsvm-neutron/9dc8e69 : SUCCESS in 35m 10s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/38/68538/2/check/gate-tempest-dsvm-large-ops/8d57419 : SUCCESS in 12m 54s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/38/68538/2/check/gate-tempest-dsvm-neutron-large-ops/7fa47aa : SUCCESS in 14m 25s\n- check-grenade-dsvm http://logs.openstack.org/38/68538/2/check/check-grenade-dsvm/773fb78 : FAILURE in 21m 32s\n- check-swift-dsvm-functional http://logs.openstack.org/38/68538/2/check/check-swift-dsvm-functional/5c8e3dc : SUCCESS in 17m 23s\n- check-devstack-dsvm-neutron http://logs.openstack.org/38/68538/2/check/check-devstack-dsvm-neutron/e3c5533 : FAILURE in 14m 43s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"ed3cee1955504a0a62eb188a9d49ea36785f49b6","author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"date":"2014-01-23 05:48:04.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"2e52eb758d22a9353fa3f4d33cecd50f48e35be1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-23 06:54:31.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/38/68538/2/check/gate-devstack-bash8/70fad61 : SUCCESS in 16s\n- check-tempest-dsvm-full http://logs.openstack.org/38/68538/2/check/check-tempest-dsvm-full/d31aa3f : SUCCESS in 1h 03m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/38/68538/2/check/check-tempest-dsvm-postgres-full/fd644fd : SUCCESS in 1h 04m 56s\n- check-tempest-dsvm-neutron http://logs.openstack.org/38/68538/2/check/check-tempest-dsvm-neutron/c897b72 : SUCCESS in 31m 37s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/38/68538/2/check/gate-tempest-dsvm-large-ops/88ec3d2 : SUCCESS in 12m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/38/68538/2/check/gate-tempest-dsvm-neutron-large-ops/31dc3e6 : SUCCESS in 12m 38s\n- check-grenade-dsvm http://logs.openstack.org/38/68538/2/check/check-grenade-dsvm/bc59ce2 : SUCCESS in 37m 36s\n- check-swift-dsvm-functional http://logs.openstack.org/38/68538/2/check/check-swift-dsvm-functional/a56108d : SUCCESS in 15m 14s\n- check-devstack-dsvm-neutron http://logs.openstack.org/38/68538/2/check/check-devstack-dsvm-neutron/29635ae : FAILURE in 14m 30s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"c05f39957543db4bef6bec4bf8fa013ff8b5ac67","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2014-01-23 07:09:21.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fb9e8c58cf69195a1338c02b8ce028329a496d06","author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"date":"2014-01-23 21:17:45.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"aec7dcb3b6508977ae8e4d6482feebdd6ab20f94","author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"date":"2014-01-23 21:20:08.000000000","message":"Patch Set 2: Abandoned\n\nNova already pick lsiLogic as a default value.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1ba9c6b02fe9bf19531ec95a6c844460f6d6473d","revisions":{"8bd4720a94bc7beda197227218a974f65c41fc46":{"kind":"REWORK","_number":1,"created":"2014-01-23 02:09:05.000000000","uploader":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"ref":"refs/changes/38/68538/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/38/68538/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/68538/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/68538/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/68538/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/38/68538/1"}}},"commit":{"parents":[{"commit":"6d323f43b499482765438a964ac11874d4af3aec","subject":"Merge \"updated sar options to collect more data\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6d323f43b499482765438a964ac11874d4af3aec"}]}],"author":{"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","date":"2014-01-23 01:55:57.000000000","tz":-480},"committer":{"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","date":"2014-01-23 02:08:50.000000000","tz":-480},"subject":"Set default adapter type for monolithic flat disks","message":"Set default adapter type for monolithic flat disks\n\nupload_image.sh tries to find corresponding metadata in the\ndescriptor file for a monolithicFlat *-flat.vmdk\nIf this descriptor is not found, the script sets the disk_type\nto preallocated but doesn\u0027t set the adapter_type.\nMost of the VMs will fail booting without an adapter type.\nThis patch sets the adapter type to a default value: this value might\nnot the correct/most optimized but at least it a value is set.\n\nBooting the example VMDK provided\nhttps://wiki.openstack.org/wiki/NovaVMware/DeveloperGuide will work.\n\nCloses-Bug: #1271793\n\nChange-Id: Ie3c23a4bb212f30fd078cec6b2b1d604738b595d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8bd4720a94bc7beda197227218a974f65c41fc46"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8bd4720a94bc7beda197227218a974f65c41fc46"}]},"branch":"refs/heads/master"},"1ba9c6b02fe9bf19531ec95a6c844460f6d6473d":{"kind":"REWORK","_number":2,"created":"2014-01-23 02:10:27.000000000","uploader":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"ref":"refs/changes/38/68538/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/38/68538/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/68538/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/68538/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/38/68538/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/38/68538/2"}}},"commit":{"parents":[{"commit":"6d323f43b499482765438a964ac11874d4af3aec","subject":"Merge \"updated sar options to collect more data\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6d323f43b499482765438a964ac11874d4af3aec"}]}],"author":{"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","date":"2014-01-23 01:55:57.000000000","tz":-480},"committer":{"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","date":"2014-01-23 02:10:12.000000000","tz":-480},"subject":"Set default adapter type for monolithic flat disks","message":"Set default adapter type for monolithic flat disks\n\nupload_image.sh tries to find corresponding metadata in the\ndescriptor file for a monolithicFlat *-flat.vmdk\nIf this descriptor is not found, the script sets the disk_type\nto preallocated but doesn\u0027t set the adapter_type.\nMost of the VMs will fail booting without an adapter type.\nThis patch sets the adapter type to a default value: this value might\nnot the correct/most optimized but at least it a value is set.\n\nBooting the example VMDK provided\nhttps://wiki.openstack.org/wiki/NovaVMware/DeveloperGuide will work.\n\nCloses-Bug: #1271793\n\nChange-Id: Ie3c23a4bb212f30fd078cec6b2b1d604738b595d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1ba9c6b02fe9bf19531ec95a6c844460f6d6473d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/1ba9c6b02fe9bf19531ec95a6c844460f6d6473d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}