)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9ca771d6f2069e4e68d1d4b3b41bd9a60bc74afe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Terry Wilson \u003ctwilson@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-18 15:03:09 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle uninstalled python3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Distros such as Centos 7 do not install python3 with the minimal"},{"line_number":10,"context_line":"install. This ensures that python3 gets installed if it isn\u0027t."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_42343efb","line":7,"updated":"2019-11-21 09:27:40.000000000","message":"How about we make this \"Always install python3\"\n\nSince we run with USE_PYTHON3\u003dTrue by default now, that would be a logical followup and not specifically targeted to any distro.\n\nJust needs to be combined with https://review.opendev.org/693137","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"8c830b81a7f112b9021fa9327cd87b6b871993c6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Distros such as Centos 7 do not install python3 with the minimal"},{"line_number":10,"context_line":"install. This ensures that python3 gets installed if it isn\u0027t."},{"line_number":11,"context_line":"Also, python3 package is now python36 when installing from EPEL."},{"line_number":12,"context_line":"I don\u0027t believe anything still uses python3.5 by default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":15,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_60f31da1","line":12,"updated":"2019-11-07 06:09:30.000000000","message":"I\u0027ve pushed back on this before; I don\u0027t see the point of testing devstack on centos7 with python3 ... it\u0027s not used in any actual situations.\n\nAt this point, it probably means dropping the job if we have no interest in python2 for U","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"fc299ce5ba2cb563cb4fafe68e736fc9215c0428","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Distros such as Centos 7 do not install python3 with the minimal"},{"line_number":10,"context_line":"install. This ensures that python3 gets installed if it isn\u0027t."},{"line_number":11,"context_line":"Also, python3 package is now python36 when installing from EPEL."},{"line_number":12,"context_line":"I don\u0027t believe anything still uses python3.5 by default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":15,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_8b77553c","line":12,"in_reply_to":"3fa7e38b_60f31da1","updated":"2019-11-07 17:00:58.000000000","message":"I\u0027m not sure what \"not used in any actual situations\" means. Centos w/ EPEL is pretty common. I know of at least one major company that uses Openstack w/ Centos 7. Not sure if they use python3 or not, but they definitely use EPEL--and if we are dropping python2 support...I don\u0027t see why we wouldn\u0027t test it.","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0a3f1b22f2e88b147165d87cb0a3fcffbd4f0a06","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Distros such as Centos 7 do not install python3 with the minimal"},{"line_number":10,"context_line":"install. This ensures that python3 gets installed if it isn\u0027t."},{"line_number":11,"context_line":"Also, python3 package is now python36 when installing from EPEL."},{"line_number":12,"context_line":"I don\u0027t believe anything still uses python3.5 by default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":15,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_d7de4a3d","line":12,"in_reply_to":"3fa7e38b_8b77553c","updated":"2019-11-07 21:56:30.000000000","message":"If you\u0027re using openstack on centos, surely you\u0027re using RDO and that doesn\u0027t support the epel python3.  I just don\u0027t think there\u0027s any realistic deployment method of openstack with centos7+python3 so I don\u0027t see it\u0027s not worth person-hours to work on it.","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"20f66c749b924e8d87f8d059441f28d3d7c70783","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Distros such as Centos 7 do not install python3 with the minimal"},{"line_number":10,"context_line":"install. This ensures that python3 gets installed if it isn\u0027t."},{"line_number":11,"context_line":"Also, python3 package is now python36 when installing from EPEL."},{"line_number":12,"context_line":"I don\u0027t believe anything still uses python3.5 by default."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":15,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a570f841","line":12,"in_reply_to":"3fa7e38b_d7de4a3d","updated":"2019-11-14 06:15:02.000000000","message":"Ian you are making too much assumptions here. DevStack must provide what OpenStack developers wants from it. It doesn\u0027t matter the reason why we want Python3 on CentOS 7. The point is the decision is on DevStack users and not on us. It has been a very desired feature and RDO cannot provide the same experience as DevStack just because it is not DevStack. As Python developer I want to stop using Python 2 because it is wasting my time supporting both language dialects, but in the same time I want to test my code on CentOS because it carries different binary code (kernel, OVS, compiler, ssl, etc.) than Ubuntu. I want to test my code on both distros because it is a good thing to do and it is convenient to me. What do you know about what is convenient to me and other DevStack users need?","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e82497ed3fd2667ae95a899a65618241a1c14862","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Always install python3 and its dev package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some distros do not install python3/python3-devel with the minimal"},{"line_number":10,"context_line":"install. F29 doesn\u0027t install -devel, and neither Centos 7 or 8"},{"line_number":11,"context_line":"install either. This patch ensures that these packages get installed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_55716faa","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":69},"updated":"2020-01-23 09:01:48.000000000","message":"but only for fedora?","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c8cd80a2a3524d057711ccf9d84f5f8c7146dc91","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Always install python3 and its dev package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some distros do not install python3/python3-devel with the minimal"},{"line_number":10,"context_line":"install. F29 doesn\u0027t install -devel, and neither Centos 7 or 8"},{"line_number":11,"context_line":"install either. This patch ensures that these packages get installed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_cece3057","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":69},"in_reply_to":"3fa7e38b_2ead84a3","updated":"2020-01-23 13:16:33.000000000","message":"Ah, just like is_ubuntu matches debian. -2 for naming ;p","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0763603e2343bcfcd21a3880f37eed64652a3030","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Always install python3 and its dev package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some distros do not install python3/python3-devel with the minimal"},{"line_number":10,"context_line":"install. F29 doesn\u0027t install -devel, and neither Centos 7 or 8"},{"line_number":11,"context_line":"install either. This patch ensures that these packages get installed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_9314dfa0","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":69},"in_reply_to":"3fa7e38b_55716faa","updated":"2020-01-23 12:05:46.000000000","message":"They did get installed earlier already for the other distros, so I\u0027d say this wording is fine.","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e3e738df7a7ac305872c8c76ccf98c4f24fa4562","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Always install python3 and its dev package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some distros do not install python3/python3-devel with the minimal"},{"line_number":10,"context_line":"install. F29 doesn\u0027t install -devel, and neither Centos 7 or 8"},{"line_number":11,"context_line":"install either. This patch ensures that these packages get installed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_2ead84a3","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":69},"in_reply_to":"3fa7e38b_735e0352","updated":"2020-01-23 12:55:02.000000000","message":"is_fedora covers all rpm-based distros, including centos.","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a96a114d9364ee968a04f763dd356299ebdb3da7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Always install python3 and its dev package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some distros do not install python3/python3-devel with the minimal"},{"line_number":10,"context_line":"install. F29 doesn\u0027t install -devel, and neither Centos 7 or 8"},{"line_number":11,"context_line":"install either. This patch ensures that these packages get installed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_735e0352","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":69},"in_reply_to":"3fa7e38b_9314dfa0","updated":"2020-01-23 12:13:43.000000000","message":"For CentOS? Where? :D","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e82497ed3fd2667ae95a899a65618241a1c14862","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."},{"line_number":15,"context_line":"This sets it to 3.6 as nothing uses 3.5 anymore."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7bdfc408b7c18273639ec26eade475856ac43593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_156777ee","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":48},"updated":"2020-01-23 09:01:48.000000000","message":"this looks like a separate issue to me","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"1ffa663d64b6e112de2f0d32867389c100e5fa62","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."},{"line_number":15,"context_line":"This sets it to 3.6 as nothing uses 3.5 anymore."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7bdfc408b7c18273639ec26eade475856ac43593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_60e78447","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":48},"in_reply_to":"3fa7e38b_156777ee","updated":"2020-02-03 15:10:05.000000000","message":"Things will fail w/o this change. So even if it was a separate change, this change would be dependent on it (and nothing else would). So it seemed best to keep the changes together. Just changing one thing wouldn\u0027t actually make anything that was broken start working.","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f6c981a8ebfa0e4444ff156d4c5b5a68ffbc8a10","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Ideally, PYTHON3_VERSION would be set *after* ensuring that python3"},{"line_number":14,"context_line":"was installed, but it gets a little tricky with all of the includes."},{"line_number":15,"context_line":"This sets it to 3.6 as nothing uses 3.5 anymore."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7bdfc408b7c18273639ec26eade475856ac43593"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_e19db3ba","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":48},"in_reply_to":"3fa7e38b_60e78447","updated":"2020-02-03 20:13:21.000000000","message":"I understand your logic but it has even been proposed earlier independently: https://review.opendev.org/687588\n\nAtm the change is a bit convoluted as it:\n\n- does what subject says\n- changes logic regarding py3/py2 installation\n- changes default py3 version\n\nquite a bit for the original subject...\nPlease let\u0027s keep it more organized in the future.\n\nIt has one +2, passed CI, its direction is the right one for devstack master and it is no candidate for backport so should be fine in general. I am a little worried about the other issue I\u0027ve just commented on.","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"}],"inc/python":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"39dc331787c6d493e95668a689069c2703546a42","unresolved":false,"context_lines":[{"line_number":553,"context_line":"    elif is_suse; then"},{"line_number":554,"context_line":"        install_package python3-devel python3-dbm"},{"line_number":555,"context_line":"    elif is_fedora; then"},{"line_number":556,"context_line":"        install_package python3 python3-devel"},{"line_number":557,"context_line":"    fi"},{"line_number":558,"context_line":"}"},{"line_number":559,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_b293d24e","line":556,"range":{"start_line":556,"start_character":24,"end_line":556,"end_character":45},"updated":"2019-10-16 15:08:07.000000000","message":"Why don\u0027t these show up in the package list?\n\nhttps://zuul.opendev.org/t/openstack/build/8f4f5dd05ad4475281723caf40ae3f7c/log/controller/logs/rpm-qa.txt.gz\n\nThe is_fedora function handles CentOS as well.","commit_id":"5f4acc7c54a135b4108cf75b6bed303d38c4d6d6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4b63ee47d4696ab301daae4561b2a040da1e02f","unresolved":false,"context_lines":[{"line_number":553,"context_line":"    elif is_suse; then"},{"line_number":554,"context_line":"        install_package python3-devel python3-dbm"},{"line_number":555,"context_line":"    elif is_fedora; then"},{"line_number":556,"context_line":"        install_package python3 python3-devel"},{"line_number":557,"context_line":"    fi"},{"line_number":558,"context_line":"}"},{"line_number":559,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_92ded60e","line":556,"range":{"start_line":556,"start_character":24,"end_line":556,"end_character":45},"in_reply_to":"3fa7e38b_b293d24e","updated":"2019-10-16 15:10:19.000000000","message":"I guess maybe because the job isn\u0027t using python3.","commit_id":"5f4acc7c54a135b4108cf75b6bed303d38c4d6d6"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9ca771d6f2069e4e68d1d4b3b41bd9a60bc74afe","unresolved":false,"context_lines":[{"line_number":553,"context_line":"    elif is_suse; then"},{"line_number":554,"context_line":"        install_package python3-devel python3-dbm"},{"line_number":555,"context_line":"    elif is_fedora; then"},{"line_number":556,"context_line":"        install_package python3 python3-devel"},{"line_number":557,"context_line":"    fi"},{"line_number":558,"context_line":"}"},{"line_number":559,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_822556c1","line":556,"updated":"2019-11-21 09:27:40.000000000","message":"Can we do this for any fedora-type distro or will this break on older or newer ones?","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ae3e76d41c06f851f890ae9a45c54f9a567b66d4","unresolved":false,"context_lines":[{"line_number":553,"context_line":"    elif is_suse; then"},{"line_number":554,"context_line":"        install_package python3-devel python3-dbm"},{"line_number":555,"context_line":"    elif is_fedora; then"},{"line_number":556,"context_line":"        install_package python3 python3-devel"},{"line_number":557,"context_line":"    fi"},{"line_number":558,"context_line":"}"},{"line_number":559,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"3fa7e38b_41a9bc75","line":556,"in_reply_to":"3fa7e38b_822556c1","updated":"2020-01-23 00:39:29.000000000","message":"It should work for any. I\u0027ve tested on f29 and centos7 so far. But the centos8 package python36-devel provides python3-devl as well, so yum/dnf install python3 will install python36 etc.","commit_id":"6f05154544634b405445764744c8d413e8108da7"}],"stack.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9ca771d6f2069e4e68d1d4b3b41bd9a60bc74afe","unresolved":false,"context_lines":[{"line_number":419,"context_line":"is_package_installed python || install_package python"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"if python3_enabled; then"},{"line_number":422,"context_line":"    is_package_installed python3 || install_python3"},{"line_number":423,"context_line":"fi"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# Configure Logging"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_c50d9835","line":422,"updated":"2019-11-21 09:27:40.000000000","message":"Since the pkg we install isn\u0027t always called \"python3\", I\u0027d say drop the is_installed check. Installation is idempotent so that shouldn\u0027t hurt. We\u0027ll also need to install python3 for our scripts if python3_enabled is false.\n\nInstead we can move the \"install_package python\" line from above into an \"if ! python3_enabled\" block.","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ae3e76d41c06f851f890ae9a45c54f9a567b66d4","unresolved":false,"context_lines":[{"line_number":419,"context_line":"is_package_installed python || install_package python"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"if python3_enabled; then"},{"line_number":422,"context_line":"    is_package_installed python3 || install_python3"},{"line_number":423,"context_line":"fi"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# Configure Logging"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_41f77c8f","line":422,"in_reply_to":"3fa7e38b_5ce31635","updated":"2020-01-23 00:39:29.000000000","message":"Maybe, but that isn\u0027t how it works for any other distro and I\u0027d prefer not to make unnecessary unrelated style changes if possible since getting this through at all is less than ideally simple.","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"c54eb29e2e87303fac18f2ebc4a34d1ee756d8aa","unresolved":false,"context_lines":[{"line_number":419,"context_line":"is_package_installed python || install_package python"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"if python3_enabled; then"},{"line_number":422,"context_line":"    is_package_installed python3 || install_python3"},{"line_number":423,"context_line":"fi"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# Configure Logging"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_5ce31635","line":422,"in_reply_to":"3fa7e38b_c50d9835","updated":"2019-12-10 09:15:13.000000000","message":"I think logic would be simpler if install_python3 function would check if python3 is installed and just call it here as it is.","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ae3e76d41c06f851f890ae9a45c54f9a567b66d4","unresolved":false,"context_lines":[{"line_number":419,"context_line":"is_package_installed python || install_package python"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"if python3_enabled; then"},{"line_number":422,"context_line":"    is_package_installed python3 || install_python3"},{"line_number":423,"context_line":"fi"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# Configure Logging"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_925e204f","line":422,"in_reply_to":"3fa7e38b_c50d9835","updated":"2020-01-23 00:39:29.000000000","message":"Sounds good. rpm -q is a pretty terrible way to see if a package is installed since it doesn\u0027t take into account \"Provides\" etc.","commit_id":"6f05154544634b405445764744c8d413e8108da7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e82497ed3fd2667ae95a899a65618241a1c14862","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"# Ensure python is installed"},{"line_number":417,"context_line":"# --------------------------"},{"line_number":418,"context_line":"install_python3"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"if ! python3_enabled; then"},{"line_number":421,"context_line":"    is_package_installed python || install_package python"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_f5389bcb","line":418,"range":{"start_line":418,"start_character":0,"end_line":418,"end_character":15},"updated":"2020-01-23 09:01:48.000000000","message":"previously only python3_enabled triggered this, now both paths do (see install_prereqs)","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0763603e2343bcfcd21a3880f37eed64652a3030","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"# Ensure python is installed"},{"line_number":417,"context_line":"# --------------------------"},{"line_number":418,"context_line":"install_python3"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"if ! python3_enabled; then"},{"line_number":421,"context_line":"    is_package_installed python || install_package python"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_134eafc1","line":418,"range":{"start_line":418,"start_character":0,"end_line":418,"end_character":15},"in_reply_to":"3fa7e38b_f5389bcb","updated":"2020-01-23 12:05:46.000000000","message":"Hmm, yes, one should clean up the duplicate call in tools/install_prereqs.sh which happens after this, but I\u0027d be fine with doing that in a followup.","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f6c981a8ebfa0e4444ff156d4c5b5a68ffbc8a10","unresolved":false,"context_lines":[{"line_number":417,"context_line":"# --------------------------"},{"line_number":418,"context_line":"install_python3"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"if ! python3_enabled; then"},{"line_number":421,"context_line":"    is_package_installed python || install_package python"},{"line_number":422,"context_line":"fi"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"# Configure Logging"},{"line_number":425,"context_line":"# -----------------"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_61df8367","line":422,"range":{"start_line":420,"start_character":0,"end_line":422,"end_character":2},"updated":"2020-02-03 20:13:21.000000000","message":"This makes py2 not install. I wonder if it does not break something in devstack that we have not ported yet. CI images obviosly include python so it\u0027s a noop.","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"4ce31d53094de4e27bc4343f5afba5a8968d426f","unresolved":false,"context_lines":[{"line_number":417,"context_line":"# --------------------------"},{"line_number":418,"context_line":"install_python3"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"if ! python3_enabled; then"},{"line_number":421,"context_line":"    is_package_installed python || install_package python"},{"line_number":422,"context_line":"fi"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"# Configure Logging"},{"line_number":425,"context_line":"# -----------------"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3fa7e38b_849ea952","line":422,"range":{"start_line":420,"start_character":0,"end_line":422,"end_character":2},"in_reply_to":"3fa7e38b_61df8367","updated":"2020-02-13 16:20:20.000000000","message":"This was changed as per aprevious review. Originally it just added the install_python3 -- https://review.opendev.org/#/c/688799/4..5/stack.sh. If Jens is ok w/ changing this back, I\u0027m happy to do it. Just don\u0027t want to get in a situation where different reviewers want different things. :) I\u0027m also more than happy for someone else to take this over and make whatever changes they\u0027d like to see.","commit_id":"78cf6f642aea91385dfbe6e1fa594e9f5373e69c"}]}