)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ab492ad94063fc5e9cb795d9b19f350dbde13b81","unresolved":false,"context_lines":[{"line_number":11,"context_line":"multiple file stores for glance. In order to configure multiple file stores"},{"line_number":12,"context_line":"user need to set below options in local.conf"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"GLANCE_ENABLE_MULTIPLE_STORES\u003dTrue/False"},{"line_number":15,"context_line":"To enable multiple stores of glance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"GLANCE_MULTIPLE_FILE_STORES\u003dveryfast,fast,cheap,verycheap,slow,veryslow"},{"line_number":18,"context_line":"Comma separated list of store identifiers."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"GLANCE_DEFAULT_BACKEND\u003dfast"},{"line_number":21,"context_line":"Default glance store in which image should be stored if store identifier not"},{"line_number":22,"context_line":"specified explicilty. Should be one of the store identifier from"},{"line_number":23,"context_line":"GLANCE_MULTIPLE_FILE_STORES config option."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"NOTE: This support is added so that we can start adding tempest/CI tests for"},{"line_number":26,"context_line":"glance multiple stores."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_83519f10","line":23,"range":{"start_line":14,"start_character":0,"end_line":23,"end_character":42},"updated":"2019-10-17 10:06:25.000000000","message":"I think it would make sense to add some documentation about this somewhere. The minimalist version would be to add this as comments to the variable definitions.","commit_id":"d8dc5ebc3b0907aa8e651a6452b57a41aa435e4b"}],"lib/glance":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f028dcb3913fb2437df4e905c60934bd283ce832","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Glance multi-store configuration"},{"line_number":45,"context_line":"# Boolean flag to enable multiple store configuration for glance"},{"line_number":46,"context_line":"GLANCE_ENABLE_MULTIPLE_STORES\u003d${GLANCE_ENABLE_MULTIPLE_STORES:-False}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Comma separated list for configuring multiple file stores of glance,"},{"line_number":49,"context_line":"# for example; GLANCE_MULTIPLE_FILE_STORES \u003d fast,cheap,slow"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_113900a2","line":46,"updated":"2019-10-24 21:03:18.000000000","message":"can you use trueorfalse here please (see other examples)","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"48dbcd80cbecfb75f3367a2061f85fe88f5397fa","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Glance multi-store configuration"},{"line_number":45,"context_line":"# Boolean flag to enable multiple store configuration for glance"},{"line_number":46,"context_line":"GLANCE_ENABLE_MULTIPLE_STORES\u003d${GLANCE_ENABLE_MULTIPLE_STORES:-False}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Comma separated list for configuring multiple file stores of glance,"},{"line_number":49,"context_line":"# for example; GLANCE_MULTIPLE_FILE_STORES \u003d fast,cheap,slow"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_d706071d","line":46,"in_reply_to":"3fa7e38b_113900a2","updated":"2019-11-14 07:21:59.000000000","message":"Same thing is done at line #77, I have taken reference from there only.","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2fdbd758048c9db51230784af4acb8ef7d9ff4ca","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Glance multi-store configuration"},{"line_number":45,"context_line":"# Boolean flag to enable multiple store configuration for glance"},{"line_number":46,"context_line":"GLANCE_ENABLE_MULTIPLE_STORES\u003d${GLANCE_ENABLE_MULTIPLE_STORES:-False}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Comma separated list for configuring multiple file stores of glance,"},{"line_number":49,"context_line":"# for example; GLANCE_MULTIPLE_FILE_STORES \u003d fast,cheap,slow"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1fa4df85_1e740a35","line":46,"in_reply_to":"3fa7e38b_d706071d","updated":"2020-02-25 01:40:07.000000000","message":"with trueorfalse you cna normalize the boolean values, for example, ``0 no  No  NO  false False FALSE`` can be taken as False. and same for True.\n\nGLANCE_ENABLE_MULTIPLE_STORES\u003d$(trueorfalse False GLANCE_ENABLE_MULTIPLE_STORES)","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f028dcb3913fb2437df4e905c60934bd283ce832","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        done"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Cleanup reserved stores directories"},{"line_number":128,"context_line":"        staging_file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_staging_store/\""},{"line_number":129,"context_line":"        tasks_file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_tasks_store/\""},{"line_number":130,"context_line":"        sudo rm -rf $staging_file_dir $tasks_file_dir"},{"line_number":131,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_d142880f","line":128,"updated":"2019-10-24 21:03:18.000000000","message":"be nice to make these locals","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"48dbcd80cbecfb75f3367a2061f85fe88f5397fa","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        done"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Cleanup reserved stores directories"},{"line_number":128,"context_line":"        staging_file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_staging_store/\""},{"line_number":129,"context_line":"        tasks_file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_tasks_store/\""},{"line_number":130,"context_line":"        sudo rm -rf $staging_file_dir $tasks_file_dir"},{"line_number":131,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_b734abe0","line":128,"in_reply_to":"3fa7e38b_0418a073","updated":"2019-11-14 07:21:59.000000000","message":"Done","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"914e03f5a9e3d4cbc06853872b9a8128718d3b10","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        done"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        # Cleanup reserved stores directories"},{"line_number":128,"context_line":"        staging_file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_staging_store/\""},{"line_number":129,"context_line":"        tasks_file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_tasks_store/\""},{"line_number":130,"context_line":"        sudo rm -rf $staging_file_dir $tasks_file_dir"},{"line_number":131,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_0418a073","line":128,"in_reply_to":"3fa7e38b_d142880f","updated":"2019-10-30 05:05:30.000000000","message":"Could you please explain little more?","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f028dcb3913fb2437df4e905c60934bd283ce832","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    fi"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # Glance multiple store Store specific configs"},{"line_number":186,"context_line":"    if [ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]; then"},{"line_number":187,"context_line":"        iniset $GLANCE_API_CONF glance_store default_backend $GLANCE_DEFAULT_BACKEND"},{"line_number":188,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":189,"context_line":"            iniset $GLANCE_API_CONF $store filesystem_store_datadir \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/${store}/\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_3153dce4","line":186,"updated":"2019-10-24 21:03:18.000000000","message":"\u003d\u003d should really use [[ ]]","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"48dbcd80cbecfb75f3367a2061f85fe88f5397fa","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    fi"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    # Glance multiple store Store specific configs"},{"line_number":186,"context_line":"    if [ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]; then"},{"line_number":187,"context_line":"        iniset $GLANCE_API_CONF glance_store default_backend $GLANCE_DEFAULT_BACKEND"},{"line_number":188,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":189,"context_line":"            iniset $GLANCE_API_CONF $store filesystem_store_datadir \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/${store}/\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_973e4fb7","line":186,"in_reply_to":"3fa7e38b_3153dce4","updated":"2019-11-14 07:21:59.000000000","message":"Done","commit_id":"2f524cba9740a0ebeafbc4f40196e7d58ab4570b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d09d4e4d306108dec2de2b9f0d7fa75319ab11c3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # Cleanup multiple stores directories"},{"line_number":123,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]]; then"},{"line_number":124,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":125,"context_line":"            file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/${store}/\""},{"line_number":126,"context_line":"            sudo rm -rf $file_dir"},{"line_number":127,"context_line":"        done"},{"line_number":128,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_f889a024","line":125,"updated":"2019-12-05 04:49:07.000000000","message":"this looks like a syntax error to me; which makes me think it hasn\u0027t run?","commit_id":"80c1df23df2342332cad7585efe54829827c575d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5ef0b7ecc539bef0d75b150986fc28e3a0490d2c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    # Cleanup multiple stores directories"},{"line_number":123,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]]; then"},{"line_number":124,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":125,"context_line":"            file_dir \u003d \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/${store}/\""},{"line_number":126,"context_line":"            sudo rm -rf $file_dir"},{"line_number":127,"context_line":"        done"},{"line_number":128,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_53cd355c","line":125,"in_reply_to":"3fa7e38b_f889a024","updated":"2019-12-05 07:03:15.000000000","message":"Hi Ian,\n\nYou are right, I didn\u0027t catch this because when I run cleanup.sh it actually deletes the /opt/stack/data directory as well. Corrected the same.","commit_id":"80c1df23df2342332cad7585efe54829827c575d"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba25b5126f32d9dfaace60fef6d3a0aa79d36704","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    # Cleanup multiple stores directories"},{"line_number":123,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]]; then"},{"line_number":124,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":125,"context_line":"            file_dir\u003d\"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/${store}/\""},{"line_number":126,"context_line":"            sudo rm -rf $file_dir"},{"line_number":127,"context_line":"        done"},{"line_number":128,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_433ba798","line":125,"range":{"start_line":124,"start_character":8,"end_line":125,"end_character":68},"updated":"2020-02-17 05:46:51.000000000","message":"Looking at this once more, both \"store\" and \"file_dir\" should be declared local (once, outside the loop).","commit_id":"ddb8740249a1f4be7833985f3a192e2fb8aa491a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5b28c79ace49c720ab8b18c3317abe5c81e3ee93","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    # Cleanup multiple stores directories"},{"line_number":123,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]]; then"},{"line_number":124,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":125,"context_line":"            file_dir\u003d\"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/${store}/\""},{"line_number":126,"context_line":"            sudo rm -rf $file_dir"},{"line_number":127,"context_line":"        done"},{"line_number":128,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_a3129bfc","line":125,"range":{"start_line":124,"start_character":8,"end_line":125,"end_character":68},"in_reply_to":"3fa7e38b_433ba798","updated":"2020-02-17 06:30:21.000000000","message":"Done","commit_id":"ddb8740249a1f4be7833985f3a192e2fb8aa491a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"58dc2c57d6f3b5a054921896c174e97f47b72b5f","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    # Cleanup multiple stores directories"},{"line_number":123,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"True\" ]]; then"},{"line_number":124,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":125,"context_line":"            file_dir\u003d\"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/${store}/\""},{"line_number":126,"context_line":"            sudo rm -rf $file_dir"},{"line_number":127,"context_line":"        done"},{"line_number":128,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_c346b71f","line":125,"range":{"start_line":124,"start_character":8,"end_line":125,"end_character":68},"in_reply_to":"3fa7e38b_433ba798","updated":"2020-02-17 05:53:33.000000000","message":"Jens,\n\nI am not familiar with bash concepts/syntax, could you please suggest how can I change this?","commit_id":"ddb8740249a1f4be7833985f3a192e2fb8aa491a"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a1a1f4bfd6d3781a58e45245a3df861eaefcc6ab","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    fi"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # Store specific configs"},{"line_number":198,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"False\" ]]; then"},{"line_number":199,"context_line":"        iniset $GLANCE_API_CONF glance_store filesystem_store_datadir $GLANCE_IMAGE_DIR/"},{"line_number":200,"context_line":"    fi"},{"line_number":201,"context_line":"    iniset $GLANCE_API_CONF DEFAULT registry_host $(ipv6_unquote $GLANCE_SERVICE_HOST)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_2e15abe6","line":198,"updated":"2019-12-05 16:14:05.000000000","message":"Minor nit: you could add this as \"else\" branch to the new block above, to make it clearer that it is either one or the other. But that can happen as followup.","commit_id":"ddb8740249a1f4be7833985f3a192e2fb8aa491a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"58dc2c57d6f3b5a054921896c174e97f47b72b5f","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    fi"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # Store specific configs"},{"line_number":198,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"False\" ]]; then"},{"line_number":199,"context_line":"        iniset $GLANCE_API_CONF glance_store filesystem_store_datadir $GLANCE_IMAGE_DIR/"},{"line_number":200,"context_line":"    fi"},{"line_number":201,"context_line":"    iniset $GLANCE_API_CONF DEFAULT registry_host $(ipv6_unquote $GLANCE_SERVICE_HOST)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_635b43f8","line":198,"in_reply_to":"3fa7e38b_2e15abe6","updated":"2020-02-17 05:53:33.000000000","message":"ditto","commit_id":"ddb8740249a1f4be7833985f3a192e2fb8aa491a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"5b28c79ace49c720ab8b18c3317abe5c81e3ee93","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    fi"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # Store specific configs"},{"line_number":198,"context_line":"    if [[ \"$GLANCE_ENABLE_MULTIPLE_STORES\" \u003d\u003d \"False\" ]]; then"},{"line_number":199,"context_line":"        iniset $GLANCE_API_CONF glance_store filesystem_store_datadir $GLANCE_IMAGE_DIR/"},{"line_number":200,"context_line":"    fi"},{"line_number":201,"context_line":"    iniset $GLANCE_API_CONF DEFAULT registry_host $(ipv6_unquote $GLANCE_SERVICE_HOST)"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_63cee38f","line":198,"in_reply_to":"3fa7e38b_635b43f8","updated":"2020-02-17 06:30:21.000000000","message":"Done","commit_id":"ddb8740249a1f4be7833985f3a192e2fb8aa491a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72e1bb4b9f2a1537dfcb5d26ee9cc759304e927f","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Comma separated list for configuring multiple file stores of glance,"},{"line_number":49,"context_line":"# for example; GLANCE_MULTIPLE_FILE_STORES \u003d fast,cheap,slow"},{"line_number":50,"context_line":"GLANCE_MULTIPLE_FILE_STORES\u003d${GLANCE_MULTIPLE_FILE_STORES:-Fast}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Default store/backend for glance, must be one of the store specified"},{"line_number":53,"context_line":"# in GLANCE_MULTIPLE_FILE_STORES option."}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_3cf301a1","line":50,"range":{"start_line":50,"start_character":59,"end_line":50,"end_character":63},"updated":"2020-02-25 17:57:28.000000000","message":"any reason of keeping F as cap? I think all can be in small.","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b4dd8304d3509f871c13a3feb8f88bb1391c3c15","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# Comma separated list for configuring multiple file stores of glance,"},{"line_number":49,"context_line":"# for example; GLANCE_MULTIPLE_FILE_STORES \u003d fast,cheap,slow"},{"line_number":50,"context_line":"GLANCE_MULTIPLE_FILE_STORES\u003d${GLANCE_MULTIPLE_FILE_STORES:-Fast}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Default store/backend for glance, must be one of the store specified"},{"line_number":53,"context_line":"# in GLANCE_MULTIPLE_FILE_STORES option."}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_f0934d4e","line":50,"range":{"start_line":50,"start_character":59,"end_line":50,"end_character":63},"in_reply_to":"1fa4df85_3cf301a1","updated":"2020-02-25 18:48:58.000000000","message":"No reason","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72e1bb4b9f2a1537dfcb5d26ee9cc759304e927f","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Default store/backend for glance, must be one of the store specified"},{"line_number":53,"context_line":"# in GLANCE_MULTIPLE_FILE_STORES option."},{"line_number":54,"context_line":"GLANCE_DEFAULT_BACKEND\u003d${GLANCE_DEFAULT_BACKEND:-Fast}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"GLANCE_CACHE_DIR\u003d${GLANCE_CACHE_DIR:\u003d$DATA_DIR/glance/cache}"},{"line_number":57,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_fc2a49e5","line":54,"range":{"start_line":54,"start_character":49,"end_line":54,"end_character":53},"updated":"2020-02-25 17:57:28.000000000","message":"ditto","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72e1bb4b9f2a1537dfcb5d26ee9cc759304e927f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        local store enabled_backends"},{"line_number":155,"context_line":"        enabled_backends\u003d\"\""},{"line_number":156,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":157,"context_line":"            enabled_backends+\u003d\"${store}:file,\""},{"line_number":158,"context_line":"        done"},{"line_number":159,"context_line":"        iniset $GLANCE_API_CONF DEFAULT enabled_backends ${enabled_backends::-1}"},{"line_number":160,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_7c273914","line":157,"range":{"start_line":157,"start_character":40,"end_line":157,"end_character":44},"updated":"2020-02-25 17:57:28.000000000","message":"you are hard coding the value to \u0027file\u0027 should not we take the key-value pair itself in GLANCE_MULTIPLE_FILE_STORES ? so that we can allow users to set rdb, swift, cinder and any other backends. Or multi-store is only implemented in \u0027file\u0027 ?","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"53739da05af70076348a8faa59005850eeca60fc","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        local store enabled_backends"},{"line_number":155,"context_line":"        enabled_backends\u003d\"\""},{"line_number":156,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":157,"context_line":"            enabled_backends+\u003d\"${store}:file,\""},{"line_number":158,"context_line":"        done"},{"line_number":159,"context_line":"        iniset $GLANCE_API_CONF DEFAULT enabled_backends ${enabled_backends::-1}"},{"line_number":160,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_042b06eb","line":157,"range":{"start_line":157,"start_character":40,"end_line":157,"end_character":44},"in_reply_to":"1fa4df85_30c24535","updated":"2020-03-18 15:00:23.000000000","message":"i see, thanks.","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b4dd8304d3509f871c13a3feb8f88bb1391c3c15","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        local store enabled_backends"},{"line_number":155,"context_line":"        enabled_backends\u003d\"\""},{"line_number":156,"context_line":"        for store in $(echo $GLANCE_MULTIPLE_FILE_STORES | tr \",\" \"\\n\"); do"},{"line_number":157,"context_line":"            enabled_backends+\u003d\"${store}:file,\""},{"line_number":158,"context_line":"        done"},{"line_number":159,"context_line":"        iniset $GLANCE_API_CONF DEFAULT enabled_backends ${enabled_backends::-1}"},{"line_number":160,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_30c24535","line":157,"range":{"start_line":157,"start_character":40,"end_line":157,"end_character":44},"in_reply_to":"1fa4df85_7c273914","updated":"2020-02-25 18:48:58.000000000","message":"This patch is specially for enabling the multiple file system stores.\nThough multiple stores are supported for all kind of stores, changes for swift and rbd will be done in later stage. The main reason is we need multiple vms as we can not install two swift or ceph in one VM.\n\nThis will be implemented in devstack around next cycle.","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"84edb789d58838cf9c6864ce1da57d48a55e6911","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    # NOTE(flaper87): To uncomment as soon as all services consuming Glance are"},{"line_number":181,"context_line":"    # able to consume V2 entirely."},{"line_number":182,"context_line":"    if [ \"$GLANCE_V1_ENABLED\" !\u003d \"True\" ]; then"},{"line_number":183,"context_line":"        iniset $GLANCE_API_CONF DEFAULT enable_v1_api False"},{"line_number":184,"context_line":"    fi"},{"line_number":185,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_725bef86","line":182,"updated":"2020-02-25 09:13:22.000000000","message":"sidenote: should not we drop this now?","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"72e1bb4b9f2a1537dfcb5d26ee9cc759304e927f","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    # NOTE(flaper87): To uncomment as soon as all services consuming Glance are"},{"line_number":181,"context_line":"    # able to consume V2 entirely."},{"line_number":182,"context_line":"    if [ \"$GLANCE_V1_ENABLED\" !\u003d \"True\" ]; then"},{"line_number":183,"context_line":"        iniset $GLANCE_API_CONF DEFAULT enable_v1_api False"},{"line_number":184,"context_line":"    fi"},{"line_number":185,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"1fa4df85_3c76a108","line":182,"in_reply_to":"1fa4df85_725bef86","updated":"2020-02-25 17:57:28.000000000","message":"yeah, we can do that now, hoping all moved to glance v2. but this is separate change.","commit_id":"e7bf6d35eda1c1cce893612869504c6649ddc3af"}]}