)]}'
{"lib/tempest":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"834a2fbd71812183a3881944c66aa7ae05f842f5","unresolved":false,"context_lines":[{"line_number":607,"context_line":"    fi"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    # The requirements might be on a different branch, while tempest needs master requirements."},{"line_number":610,"context_line":"    tmp_u_c_m\u003d$(mktemp -d -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":611,"context_line":"    (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e tmp_u_c_m"},{"line_number":612,"context_line":"    tox -evenv-tempest -- pip install -c tmp_u_c_m -r requirements.txt"},{"line_number":613,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_389a5162","line":610,"updated":"2019-11-05 19:27:08.000000000","message":"Please make this a local var.\n\n\"mktemp -d\" creates a directory, not a file, which seems wrong here.","commit_id":"104f25dccd689c797b6a8b0d12678e47bfd6e541"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"39079df541310064ee40d9fb2a334cad3a843381","unresolved":false,"context_lines":[{"line_number":607,"context_line":"    fi"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    # The requirements might be on a different branch, while tempest needs master requirements."},{"line_number":610,"context_line":"    tmp_u_c_m\u003d$(mktemp -d -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":611,"context_line":"    (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e tmp_u_c_m"},{"line_number":612,"context_line":"    tox -evenv-tempest -- pip install -c tmp_u_c_m -r requirements.txt"},{"line_number":613,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_79b761f7","line":610,"in_reply_to":"3fa7e38b_389a5162","updated":"2019-11-06 15:59:14.000000000","message":"I mixed up commands, sorry.","commit_id":"104f25dccd689c797b6a8b0d12678e47bfd6e541"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"834a2fbd71812183a3881944c66aa7ae05f842f5","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    # The requirements might be on a different branch, while tempest needs master requirements."},{"line_number":610,"context_line":"    tmp_u_c_m\u003d$(mktemp -d -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":611,"context_line":"    (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e tmp_u_c_m"},{"line_number":612,"context_line":"    tox -evenv-tempest -- pip install -c tmp_u_c_m -r requirements.txt"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    # Auth:"},{"line_number":615,"context_line":"    iniset $TEMPEST_CONFIG auth tempest_roles \"member\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_18ae7581","line":612,"range":{"start_line":611,"start_character":4,"end_line":612,"end_character":70},"updated":"2019-11-05 19:27:08.000000000","message":"Need to add \"$\" in front of the variable references here. Currently you are creating a file \"tmp_u_c_m\" instead of \"u-c-m.txt\".\n\nFor a complete solution, maybe also clean up the tmpfile?","commit_id":"104f25dccd689c797b6a8b0d12678e47bfd6e541"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"39079df541310064ee40d9fb2a334cad3a843381","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"    # The requirements might be on a different branch, while tempest needs master requirements."},{"line_number":610,"context_line":"    tmp_u_c_m\u003d$(mktemp -d -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":611,"context_line":"    (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e tmp_u_c_m"},{"line_number":612,"context_line":"    tox -evenv-tempest -- pip install -c tmp_u_c_m -r requirements.txt"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"    # Auth:"},{"line_number":615,"context_line":"    iniset $TEMPEST_CONFIG auth tempest_roles \"member\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_39c9e978","line":612,"range":{"start_line":611,"start_character":4,"end_line":612,"end_character":70},"in_reply_to":"3fa7e38b_18ae7581","updated":"2019-11-06 15:59:14.000000000","message":"I don\u0027t know what I submitted, sorry","commit_id":"104f25dccd689c797b6a8b0d12678e47bfd6e541"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2728f235e8bf8bbf27419327beefd085ef379166","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    # The requirements might be on a different branch, while tempest needs master requirements."},{"line_number":610,"context_line":"    local tmp_u_c_m"},{"line_number":611,"context_line":"    tmp_u_c_m\u003d$(mktemp -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":612,"context_line":"    (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e tmp_u_c_m"},{"line_number":613,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":614,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":615,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_5c537317","line":612,"range":{"start_line":612,"start_character":77,"end_line":612,"end_character":86},"updated":"2019-11-06 16:34:44.000000000","message":"As noted in the previous revision, this should be changed as well to reference the variable: \n\n\u003e$tmp_u_c_m","commit_id":"6be4de681cb281f9cd4d686a2bdb220391254302"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6ba42060c3663ecccdac827440055229a232f905","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    # The requirements might be on a different branch, while tempest needs master requirements."},{"line_number":610,"context_line":"    local tmp_u_c_m"},{"line_number":611,"context_line":"    tmp_u_c_m\u003d$(mktemp -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":612,"context_line":"    (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e tmp_u_c_m"},{"line_number":613,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":614,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":615,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_9f5c7df1","line":612,"range":{"start_line":612,"start_character":77,"end_line":612,"end_character":86},"in_reply_to":"3fa7e38b_5c537317","updated":"2019-11-06 18:00:53.000000000","message":"Sorry again, my bad.","commit_id":"6be4de681cb281f9cd4d686a2bdb220391254302"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2728f235e8bf8bbf27419327beefd085ef379166","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        # The requirements might be on a different branch, while tempest \u0026 tempest plugins needs master requirements."},{"line_number":703,"context_line":"        local tmp_u_c_m"},{"line_number":704,"context_line":"        tmp_u_c_m\u003d$(mktemp -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":705,"context_line":"        (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e tmp_u_c_m"},{"line_number":706,"context_line":"        tox -evenv-tempest -- pip install -c $tmp_u_c_m $TEMPEST_PLUGINS"},{"line_number":707,"context_line":"        rm -f $tmp_u_c_m"},{"line_number":708,"context_line":"        echo \"Checking installed Tempest plugins:\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa7e38b_1c3dfbbb","line":705,"updated":"2019-11-06 16:34:44.000000000","message":"see above","commit_id":"6be4de681cb281f9cd4d686a2bdb220391254302"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"984383da55b23b3bd389f71d0b60c4989cfed026","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    tmp_u_c_m\u003d$(mktemp -t tempest_u_c_m.XXXXXXXXXX)"},{"line_number":612,"context_line":"    (cd $REQUIREMENTS_DIR \u0026\u0026 git show origin/master:upper-constraints.txt) \u003e $tmp_u_c_m"},{"line_number":613,"context_line":"    tox -evenv-tempest -- pip install -c $tmp_u_c_m -r requirements.txt"},{"line_number":614,"context_line":"    rm -f $tmp_u_c_m"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    # Auth:"},{"line_number":617,"context_line":"    iniset $TEMPEST_CONFIG auth tempest_roles \"member\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_f8bbe0e0","line":614,"updated":"2019-12-05 04:44:01.000000000","message":"I feel like you could get rid of all of this by putting hte git show in a \u003c( ) call ...","commit_id":"8579f583077e5df3358605e4cdfe418b1d46f53b"}]}