)]}'
{"inc/python":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"df93122356bc3fcfe54a8726258314687735a881","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    cmd_pip\u003d\"$cmd_pip install\""},{"line_number":258,"context_line":"    # Always apply constraints"},{"line_number":259,"context_line":"    if [ -n \"$UPPER_CONSTRAINTS_FILE\" ]; then"},{"line_number":260,"context_line":"        cmd_pip\u003d\"$cmd_pip -c $UPPER_CONSTRAINTS_FILE\""},{"line_number":261,"context_line":"    else"},{"line_number":262,"context_line":"        cmd_pip\u003d\"$cmd_pip -c $REQUIREMENTS_DIR/upper-constraints.txt\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_5872adb2","line":259,"range":{"start_line":259,"start_character":4,"end_line":259,"end_character":40},"updated":"2019-11-05 18:51:10.000000000","message":"Also can be useful to check if file exist with something like:\n\n```\nif [ -n \"${UPPER_CONSTRAINTS_FILE}\" ] \u0026\u0026 [ -f $1  ${UPPER_CONSTRAINTS_FILE} ]; then \n```\n\nAlso it can be more secure to protect your variables by surrounding them with \"{}\"","commit_id":"55dfda3651efb22bd7ab6b8934e3296b7db1bd1f"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"f84b2c3a4d46096b1bc166e5334900a5581148b3","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    cmd_pip\u003d\"$cmd_pip install\""},{"line_number":258,"context_line":"    # Always apply constraints"},{"line_number":259,"context_line":"    if [ -n \"$UPPER_CONSTRAINTS_FILE\" ]; then"},{"line_number":260,"context_line":"        cmd_pip\u003d\"$cmd_pip -c $UPPER_CONSTRAINTS_FILE\""},{"line_number":261,"context_line":"    else"},{"line_number":262,"context_line":"        cmd_pip\u003d\"$cmd_pip -c $REQUIREMENTS_DIR/upper-constraints.txt\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_9e556d21","line":259,"range":{"start_line":259,"start_character":4,"end_line":259,"end_character":40},"in_reply_to":"3fa7e38b_5872adb2","updated":"2019-11-05 21:43:19.000000000","message":"ack on the {}; I will push a new patchset with that.\n\n\nhm.... I\u0027m afraid that would not account for cases when that is actually a url instead of an actual file. You see, the -c param in pip can actually be something like: \n\nhttps://opendev.org/openstack/.../upper-constraints.txt\n\nex:\n\nhttps://github.com/openstack/networking-ovn/blob/eb32c7ee992417242b608e48a64bb218b76b68cc/tox.ini#L13","commit_id":"55dfda3651efb22bd7ab6b8934e3296b7db1bd1f"}]}