)]}'
{"inc/python":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"c8506e4ed562304987cd0d0d6100f4c5ed3ef19e","unresolved":false,"context_lines":[{"line_number":527,"context_line":"    fi"},{"line_number":528,"context_line":"}"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"PYTHON_VERSION\u003d${PYTHON_VERSION:-3}"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"# Define python to detect python3 in the current environment"},{"line_number":533,"context_line":"function python {"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3fa7e38b_bcbd6a04","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":14},"updated":"2019-12-04 12:36:00.000000000","message":"Because of this line PYTHON_VERSION cannot be empty.","commit_id":"50e56609d23ddae9bc73edd23fee000cda91a0f9"},{"author":{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},"change_message_id":"ca607f44aef5b68e332d82b9d9888d3d7af96cac","unresolved":false,"context_lines":[{"line_number":527,"context_line":"    fi"},{"line_number":528,"context_line":"}"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"PYTHON_VERSION\u003d${PYTHON_VERSION:-3}"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"# Define python to detect python3 in the current environment"},{"line_number":533,"context_line":"function python {"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3fa7e38b_e65330dd","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":14},"in_reply_to":"3fa7e38b_bcbd6a04","updated":"2019-12-06 03:27:04.000000000","message":"You are right! not a good way to fix this issue, I will replace all the executing python as python3","commit_id":"50e56609d23ddae9bc73edd23fee000cda91a0f9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"6afe8e59f797bc422f4c66ba02b82682740e21b9","unresolved":false,"context_lines":[{"line_number":530,"context_line":"PYTHON_VERSION\u003d${PYTHON_VERSION:-3}"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"# Define python to detect python3 in the current environment"},{"line_number":533,"context_line":"function python {"},{"line_number":534,"context_line":"    # call get_python_exe only the first time it is required"},{"line_number":535,"context_line":"    export PYTHON_EXECUTABLE\u003d$(which python${PYTHON3_VERSION} 2\u003e/dev/null || which python3 2\u003e/dev/null)"},{"line_number":536,"context_line":"    \"${PYTHON_EXECUTABLE}\" \"$@\""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3fa7e38b_b334a94a","line":533,"updated":"2019-12-05 07:08:50.000000000","message":"I don\u0027t like having this as a function.\n\nCan\u0027t we just make sure we always install python3 and replace the calls to \"python\" with \"python3\"? We dropped support for centos7 in the meantime, so there shouldn\u0027t be any blocker.","commit_id":"50e56609d23ddae9bc73edd23fee000cda91a0f9"},{"author":{"_account_id":27738,"name":"mashuting","email":"shutingm@vmware.com","username":"mashuting"},"change_message_id":"ca607f44aef5b68e332d82b9d9888d3d7af96cac","unresolved":false,"context_lines":[{"line_number":530,"context_line":"PYTHON_VERSION\u003d${PYTHON_VERSION:-3}"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"# Define python to detect python3 in the current environment"},{"line_number":533,"context_line":"function python {"},{"line_number":534,"context_line":"    # call get_python_exe only the first time it is required"},{"line_number":535,"context_line":"    export PYTHON_EXECUTABLE\u003d$(which python${PYTHON3_VERSION} 2\u003e/dev/null || which python3 2\u003e/dev/null)"},{"line_number":536,"context_line":"    \"${PYTHON_EXECUTABLE}\" \"$@\""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3fa7e38b_668bc068","line":533,"in_reply_to":"3fa7e38b_b334a94a","updated":"2019-12-06 03:27:04.000000000","message":"That should be an easier way and same as patchset 1....\nI will update as you said and then look forward to the result of CI","commit_id":"50e56609d23ddae9bc73edd23fee000cda91a0f9"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"c8506e4ed562304987cd0d0d6100f4c5ed3ef19e","unresolved":false,"context_lines":[{"line_number":532,"context_line":"# Define python to detect python3 in the current environment"},{"line_number":533,"context_line":"function python {"},{"line_number":534,"context_line":"    # call get_python_exe only the first time it is required"},{"line_number":535,"context_line":"    export PYTHON_EXECUTABLE\u003d$(which python${PYTHON3_VERSION} 2\u003e/dev/null || which python3 2\u003e/dev/null)"},{"line_number":536,"context_line":"    \"${PYTHON_EXECUTABLE}\" \"$@\""},{"line_number":537,"context_line":"}"},{"line_number":538,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"3fa7e38b_bc19ea23","line":535,"range":{"start_line":535,"start_character":11,"end_line":535,"end_character":28},"updated":"2019-12-04 12:36:00.000000000","message":"As PYTHON_VERSION cannot be empty (as stated above) and python2 command is not available on some architectures then this implicitely remove support for python2!\n\nTo workaround this situation please allow to specify PYTHON_EXECUTABLE by hand:\n\n export PYTHON_EXECUTABLE\u003d{PYTHON_EXECUTABLE:-$(find_python_executable \"${PYTHON_VERSION}\")}\n\nThen implement find_python_executable more smartly to introduce support for well known python versions. For example:\n\n function find_python_executable {\n   local version\u003d${1:-3}\n   if  [[ \"${version}\" \u003d~ ^2.* ]]; then\n       local names\u003d( \"python${version}\" python2 python )\n   elif  [[ \"${version}\" \u003d~ ^3.* ]]; then\n       local names\u003d( \"python${version}\" python3 python )\n   else\n       die ...  # Invalid Python version: \"${version}\"\n   fi\n\n   for name in \"${names[@]}\"; then\n       local executable\u003d$(which \"${name}\" || true)\n       if [ -x \"${executable}\" ]; then\n           if \"${executable}\" --version 2\u003e\u00261 | grep \"^Python ${version}\"; then\n               echo \"${executable}\"\n               return 0\n            fi\n       fi\n   done\n\n   die ... # No such executable for required Python version: \"${version}\"\n }","commit_id":"50e56609d23ddae9bc73edd23fee000cda91a0f9"}]}