)]}'
{"lib/neutron_plugins/ovn":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"89ea6a2524dceb8cc1ee3591cb1fd461327c86cd","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        die $LINENO \"OVN needs to be enabled in \\$Q_ML2_PLUGIN_MECHANISM_DRIVERS\""},{"line_number":356,"context_line":"    elif [[ ! $Q_ML2_PLUGIN_TYPE_DRIVERS \u003d~ \"geneve\" ]]; then"},{"line_number":357,"context_line":"        die $LINENO \"Geneve needs to be enabled in \\$Q_ML2_PLUGIN_TYPE_DRIVERS to be used with OVN\""},{"line_number":358,"context_line":"    fi"},{"line_number":359,"context_line":"}"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# install_ovn() - Collect source and prepare"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_e2b2a6e5","line":358,"updated":"2019-11-28 10:08:39.000000000","message":"just a question here: shouldn\u0027t we maybe simply force those options and force disable services here?","commit_id":"9113e051544ebed98175d9c4807b4736e9967ec0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0d0a247084941b598a1fc53720fc1d68510a236e","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        die $LINENO \"OVN needs to be enabled in \\$Q_ML2_PLUGIN_MECHANISM_DRIVERS\""},{"line_number":356,"context_line":"    elif [[ ! $Q_ML2_PLUGIN_TYPE_DRIVERS \u003d~ \"geneve\" ]]; then"},{"line_number":357,"context_line":"        die $LINENO \"Geneve needs to be enabled in \\$Q_ML2_PLUGIN_TYPE_DRIVERS to be used with OVN\""},{"line_number":358,"context_line":"    fi"},{"line_number":359,"context_line":"}"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# install_ovn() - Collect source and prepare"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_45c70148","line":358,"in_reply_to":"3fa7e38b_e2b2a6e5","updated":"2019-11-28 13:57:19.000000000","message":"Hmm perhaps, tho, it may look strange if someone explicit enable these services and then they try it with OVN and at the end the service is not running and the person has to investigate why.\n\nI thought failing like this would be better.\n\nWhat u think ?","commit_id":"9113e051544ebed98175d9c4807b4736e9967ec0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"89ea6a2524dceb8cc1ee3591cb1fd461327c86cd","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    fi"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    # NOTE(rtheis): OVN currently lacks support for metadata so enabling"},{"line_number":462,"context_line":"    # config drive is required to provide metadata to instances."},{"line_number":463,"context_line":"    if is_service_enabled n-api-meta ; then"},{"line_number":464,"context_line":"        if is_service_enabled networking-ovn-metadata-agent ; then"},{"line_number":465,"context_line":"            iniset $NOVA_CONF neutron service_metadata_proxy True"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_42c13a2f","line":462,"updated":"2019-11-28 10:08:39.000000000","message":"is that still true?","commit_id":"9113e051544ebed98175d9c4807b4736e9967ec0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0d0a247084941b598a1fc53720fc1d68510a236e","unresolved":false,"context_lines":[{"line_number":459,"context_line":"    fi"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    # NOTE(rtheis): OVN currently lacks support for metadata so enabling"},{"line_number":462,"context_line":"    # config drive is required to provide metadata to instances."},{"line_number":463,"context_line":"    if is_service_enabled n-api-meta ; then"},{"line_number":464,"context_line":"        if is_service_enabled networking-ovn-metadata-agent ; then"},{"line_number":465,"context_line":"            iniset $NOVA_CONF neutron service_metadata_proxy True"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_85e2d9d3","line":462,"in_reply_to":"3fa7e38b_42c13a2f","updated":"2019-11-28 13:57:19.000000000","message":"ops not anymore, will remove!","commit_id":"9113e051544ebed98175d9c4807b4736e9967ec0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"89ea6a2524dceb8cc1ee3591cb1fd461327c86cd","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:system-id\u003d\"$OVN_UUID\""},{"line_number":550,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-remote\u003d\"$OVN_SB_REMOTE\""},{"line_number":551,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-bridge\u003d\"br-int\""},{"line_number":552,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-type\u003d\"geneve,vxlan\""},{"line_number":553,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-ip\u003d\"$HOST_IP\""},{"line_number":554,"context_line":"        # Select this chassis to host gateway routers"},{"line_number":555,"context_line":"        if [[ \"$ENABLE_CHASSIS_AS_GW\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_a2c90e52","line":552,"range":{"start_line":552,"start_character":83,"end_line":552,"end_character":88},"updated":"2019-11-28 10:08:39.000000000","message":"why do we need vxlan here?","commit_id":"9113e051544ebed98175d9c4807b4736e9967ec0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0d0a247084941b598a1fc53720fc1d68510a236e","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:system-id\u003d\"$OVN_UUID\""},{"line_number":550,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-remote\u003d\"$OVN_SB_REMOTE\""},{"line_number":551,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-bridge\u003d\"br-int\""},{"line_number":552,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-type\u003d\"geneve,vxlan\""},{"line_number":553,"context_line":"        ovs-vsctl --no-wait set open_vswitch . external-ids:ovn-encap-ip\u003d\"$HOST_IP\""},{"line_number":554,"context_line":"        # Select this chassis to host gateway routers"},{"line_number":555,"context_line":"        if [[ \"$ENABLE_CHASSIS_AS_GW\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3fa7e38b_453aa135","line":552,"range":{"start_line":552,"start_character":83,"end_line":552,"end_character":88},"in_reply_to":"3fa7e38b_a2c90e52","updated":"2019-11-28 13:57:19.000000000","message":"I need to look at the history of this, but yeah, it shouldn\u0027t have vxlan there AFAICT!\n\nI will investigate and remove it if appropriated","commit_id":"9113e051544ebed98175d9c4807b4736e9967ec0"}]}