)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc83ebc34a9ae990fd6fdaf823d0dc3cc9605abd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable libvirt virtio rng device"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027ve seen jobs where tests fail due to what appears to be rng"},{"line_number":10,"context_line":"starvation. Enable virtio rng device to try and alleviate this."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I70d800cdc45b6008f775110f22c0000736421529"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_a56558b1","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":63},"updated":"2019-12-04 00:44:43.000000000","message":"this should help with the l2 guest but i was also suggestign we should enable the random number generator in the vm we get form the providers too.\n\nthat said this is a good first start\n\nif the host vm runs out of entropy it will cause issues for the guest vms we need good entropy all the way down ideally.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f8d6d074becb7f5359b3b654740a606fc4ab549d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable libvirt virtio rng device"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027ve seen jobs where tests fail due to what appears to be rng"},{"line_number":10,"context_line":"starvation. Enable virtio rng device to try and alleviate this."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I70d800cdc45b6008f775110f22c0000736421529"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_2b14cf9e","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":63},"in_reply_to":"3fa7e38b_a56558b1","updated":"2019-12-04 16:06:38.000000000","message":"We can suggest that providers do that for us but have no control over it ultimately. This is something we can do and do have control over (and I believe slaweq was saying the issue is in entropy in the inner guest anyways which this addresses though haveged on the test node and virtio device in the inner guest).\n\nNote we should already address entropy availability on all of our test nodes via our use of haveged. It is possible that having our test node providers enable the virt io device would help, but my understanding is that haveged is supposed to be a proper stand in.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"}],"functions":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc83ebc34a9ae990fd6fdaf823d0dc3cc9605abd","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    local disk_format\u003d\"\""},{"line_number":293,"context_line":"    local container_format\u003d\"\""},{"line_number":294,"context_line":"    local unpack\u003d\"\""},{"line_number":295,"context_line":"    local img_property\u003d\"--property hw_rng_model\u003dvirtio\""},{"line_number":296,"context_line":"    case \"$image_fname\" in"},{"line_number":297,"context_line":"        *.tar.gz|*.tgz)"},{"line_number":298,"context_line":"            # Extract ami and aki files"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_255ac8f1","line":295,"range":{"start_line":295,"start_character":3,"end_line":295,"end_character":55},"updated":"2019-12-04 00:44:43.000000000","message":"yep that should also work.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc83ebc34a9ae990fd6fdaf823d0dc3cc9605abd","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        *) echo \"Do not know what to do with $image_fname\"; false;;"},{"line_number":364,"context_line":"    esac"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    if is_arch \"ppc64le\" || is_arch \"ppc64\" || is_arch \"ppc\"; then"},{"line_number":367,"context_line":"        img_property\u003d\"$img_property --property hw_cdrom_bus\u003dscsi --property os_command_line\u003dconsole\u003dhvc0\""},{"line_number":368,"context_line":"    fi"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    if is_arch \"aarch64\"; then"},{"line_number":371,"context_line":"        img_property\u003d\"$img_property --property hw_machine_type\u003dvirt --property hw_cdrom_bus\u003dscsi --property hw_scsi_model\u003dvirtio-scsi --property os_command_line\u003d\u0027console\u003dttyAMA0\u0027\""},{"line_number":372,"context_line":"    fi"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    if [ \"$container_format\" \u003d \"bare\" ]; then"},{"line_number":375,"context_line":"        if [ \"$unpack\" \u003d \"zcat\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_250f28e1","line":372,"range":{"start_line":366,"start_character":3,"end_line":372,"end_character":6},"updated":"2019-12-04 00:44:43.000000000","message":"you dont seem to be enabling this for x86\nalso devstack should only enable this if you are deploying libvirt as the virt driver.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"50e587ac23a29e455e537f6dc74af24e50524b0f","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        *) echo \"Do not know what to do with $image_fname\"; false;;"},{"line_number":364,"context_line":"    esac"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    if is_arch \"ppc64le\" || is_arch \"ppc64\" || is_arch \"ppc\"; then"},{"line_number":367,"context_line":"        img_property\u003d\"$img_property --property hw_cdrom_bus\u003dscsi --property os_command_line\u003dconsole\u003dhvc0\""},{"line_number":368,"context_line":"    fi"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    if is_arch \"aarch64\"; then"},{"line_number":371,"context_line":"        img_property\u003d\"$img_property --property hw_machine_type\u003dvirt --property hw_cdrom_bus\u003dscsi --property hw_scsi_model\u003dvirtio-scsi --property os_command_line\u003d\u0027console\u003dttyAMA0\u0027\""},{"line_number":372,"context_line":"    fi"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    if [ \"$container_format\" \u003d \"bare\" ]; then"},{"line_number":375,"context_line":"        if [ \"$unpack\" \u003d \"zcat\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_b1058c12","line":372,"range":{"start_line":366,"start_character":3,"end_line":372,"end_character":6},"in_reply_to":"3fa7e38b_06f30f0b","updated":"2019-12-05 16:20:21.000000000","message":"oh sorry yes this is appending to it because of $img_property \n\nya this is correct","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"365e2f098fdc7298ee77ec9e634b9e238640b9a8","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        *) echo \"Do not know what to do with $image_fname\"; false;;"},{"line_number":364,"context_line":"    esac"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    if is_arch \"ppc64le\" || is_arch \"ppc64\" || is_arch \"ppc\"; then"},{"line_number":367,"context_line":"        img_property\u003d\"$img_property --property hw_cdrom_bus\u003dscsi --property os_command_line\u003dconsole\u003dhvc0\""},{"line_number":368,"context_line":"    fi"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    if is_arch \"aarch64\"; then"},{"line_number":371,"context_line":"        img_property\u003d\"$img_property --property hw_machine_type\u003dvirt --property hw_cdrom_bus\u003dscsi --property hw_scsi_model\u003dvirtio-scsi --property os_command_line\u003d\u0027console\u003dttyAMA0\u0027\""},{"line_number":372,"context_line":"    fi"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    if [ \"$container_format\" \u003d \"bare\" ]; then"},{"line_number":375,"context_line":"        if [ \"$unpack\" \u003d \"zcat\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_06f30f0b","line":372,"range":{"start_line":366,"start_character":3,"end_line":372,"end_character":6},"in_reply_to":"3fa7e38b_250f28e1","updated":"2019-12-04 10:16:04.000000000","message":"I\u0027m reading this as passing \u0027--property hw_rng_model\u003dvirtio\u0027 for all architectures and then passing these *additional* options for some specific architectures. Good point on these being libvirt-only, though I don\u0027t think that matters much since they\u0027ll simply be ignored for other virt drivers","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f8d6d074becb7f5359b3b654740a606fc4ab549d","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        elif [ \"$unpack\" \u003d \"bunzip2\" ]; then"},{"line_number":378,"context_line":"            openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" $img_property --public --container-format\u003d$container_format --disk-format $disk_format \u003c \u003c(bunzip2 -cdk \"${image}\")"},{"line_number":379,"context_line":"        else"},{"line_number":380,"context_line":"            openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" $img_property --public --container-format\u003d$container_format --disk-format $disk_format \u003c \"${image}\""},{"line_number":381,"context_line":"        fi"},{"line_number":382,"context_line":"    else"},{"line_number":383,"context_line":"        # Use glance client to add the kernel the root filesystem."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_cb9bbb14","line":380,"range":{"start_line":380,"start_character":94,"end_line":380,"end_character":105},"updated":"2019-12-04 16:06:38.000000000","message":"Yes, this is where we set the image properties for all images. And I agree I think we should be able to set them as an image property then let nova decide if it can provide that functionality or not at boot time.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"}],"lib/nova":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc83ebc34a9ae990fd6fdaf823d0dc3cc9605abd","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"    if is_service_enabled n-api; then"},{"line_number":1108,"context_line":"        if ! openstack --os-region-name\u003d\"$REGION_NAME\" flavor list | grep -q ds512M; then"},{"line_number":1109,"context_line":"            # Note that danms hates these flavors and apologizes for sdague"},{"line_number":1110,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id c1 --ram 256 --disk 1 --vcpus 1 --property hw_rng:allowed\u003dTrue cirros256"},{"line_number":1111,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d1 --ram 512 --disk 5 --vcpus 1 --property hw_rng:allowed\u003dTrue ds512M"},{"line_number":1112,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d2 --ram 1024 --disk 10 --vcpus 1 --property hw_rng:allowed\u003dTrue ds1G"},{"line_number":1113,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d3 --ram 2048 --disk 10 --vcpus 2 --property hw_rng:allowed\u003dTrue ds2G"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_05578ccc","line":1110,"range":{"start_line":1110,"start_character":105,"end_line":1110,"end_character":135},"updated":"2019-12-04 00:44:43.000000000","message":"yep this is correct","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"365e2f098fdc7298ee77ec9e634b9e238640b9a8","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"    if is_service_enabled n-api; then"},{"line_number":1108,"context_line":"        if ! openstack --os-region-name\u003d\"$REGION_NAME\" flavor list | grep -q ds512M; then"},{"line_number":1109,"context_line":"            # Note that danms hates these flavors and apologizes for sdague"},{"line_number":1110,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id c1 --ram 256 --disk 1 --vcpus 1 --property hw_rng:allowed\u003dTrue cirros256"},{"line_number":1111,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d1 --ram 512 --disk 5 --vcpus 1 --property hw_rng:allowed\u003dTrue ds512M"},{"line_number":1112,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d2 --ram 1024 --disk 10 --vcpus 1 --property hw_rng:allowed\u003dTrue ds1G"},{"line_number":1113,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d3 --ram 2048 --disk 10 --vcpus 2 --property hw_rng:allowed\u003dTrue ds2G"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_0641cf0a","line":1110,"range":{"start_line":1110,"start_character":105,"end_line":1110,"end_character":135},"in_reply_to":"3fa7e38b_05578ccc","updated":"2019-12-04 10:16:04.000000000","message":"Why are we configuring *both* the flavor extra spec and image metadata property though? Surely one or the other would do?","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f8d6d074becb7f5359b3b654740a606fc4ab549d","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"    if is_service_enabled n-api; then"},{"line_number":1108,"context_line":"        if ! openstack --os-region-name\u003d\"$REGION_NAME\" flavor list | grep -q ds512M; then"},{"line_number":1109,"context_line":"            # Note that danms hates these flavors and apologizes for sdague"},{"line_number":1110,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id c1 --ram 256 --disk 1 --vcpus 1 --property hw_rng:allowed\u003dTrue cirros256"},{"line_number":1111,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d1 --ram 512 --disk 5 --vcpus 1 --property hw_rng:allowed\u003dTrue ds512M"},{"line_number":1112,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d2 --ram 1024 --disk 10 --vcpus 1 --property hw_rng:allowed\u003dTrue ds1G"},{"line_number":1113,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d3 --ram 2048 --disk 10 --vcpus 2 --property hw_rng:allowed\u003dTrue ds2G"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_ab643f4e","line":1110,"range":{"start_line":1110,"start_character":105,"end_line":1110,"end_character":135},"in_reply_to":"3fa7e38b_0641cf0a","updated":"2019-12-04 16:06:38.000000000","message":"All of the documentation I could find (mostly blog posts because this is really poorly documented) indicate both the flavor and image property are necessary to enable the functionality in the running guest.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b123c3b2089d7d5a59f4d1d659a1ab3186747b9","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"    if is_service_enabled n-api; then"},{"line_number":1108,"context_line":"        if ! openstack --os-region-name\u003d\"$REGION_NAME\" flavor list | grep -q ds512M; then"},{"line_number":1109,"context_line":"            # Note that danms hates these flavors and apologizes for sdague"},{"line_number":1110,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id c1 --ram 256 --disk 1 --vcpus 1 --property hw_rng:allowed\u003dTrue cirros256"},{"line_number":1111,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d1 --ram 512 --disk 5 --vcpus 1 --property hw_rng:allowed\u003dTrue ds512M"},{"line_number":1112,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d2 --ram 1024 --disk 10 --vcpus 1 --property hw_rng:allowed\u003dTrue ds1G"},{"line_number":1113,"context_line":"            openstack --os-region-name\u003d\"$REGION_NAME\" flavor create --id d3 --ram 2048 --disk 10 --vcpus 2 --property hw_rng:allowed\u003dTrue ds2G"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_b6534216","line":1110,"range":{"start_line":1110,"start_character":105,"end_line":1110,"end_character":135},"in_reply_to":"3fa7e38b_ab643f4e","updated":"2019-12-04 16:18:24.000000000","message":"TIL /o\\ Turns out it is required. I\u0027ll go fix the docs for that.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"}],"lib/nova_plugins/hypervisor-libvirt":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cc83ebc34a9ae990fd6fdaf823d0dc3cc9605abd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    iniset $NOVA_CONF DEFAULT compute_driver \"libvirt.LibvirtDriver\""},{"line_number":48,"context_line":"    LIBVIRT_FIREWALL_DRIVER\u003d${LIBVIRT_FIREWALL_DRIVER:-\"nova.virt.libvirt.firewall.IptablesFirewallDriver\"}"},{"line_number":49,"context_line":"    iniset $NOVA_CONF DEFAULT firewall_driver \"$LIBVIRT_FIREWALL_DRIVER\""},{"line_number":50,"context_line":"    # Use hardware rng"},{"line_number":51,"context_line":"    iniset $NOVA_CONF DEFAULT rng_dev_path \"/dev/random\""},{"line_number":52,"context_line":"    # Power architecture currently does not support graphical consoles."},{"line_number":53,"context_line":"    if is_arch \"ppc64\"; then"},{"line_number":54,"context_line":"        iniset $NOVA_CONF vnc enabled \"false\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_455d84ea","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":56},"updated":"2019-12-04 00:44:43.000000000","message":"you should not do this.\n\nwe should be useing /dev/urandom whcih is what nova already defaults too.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"628c82975ac25b66cdcf61ae25a10071b84e9c92","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    iniset $NOVA_CONF DEFAULT compute_driver \"libvirt.LibvirtDriver\""},{"line_number":48,"context_line":"    LIBVIRT_FIREWALL_DRIVER\u003d${LIBVIRT_FIREWALL_DRIVER:-\"nova.virt.libvirt.firewall.IptablesFirewallDriver\"}"},{"line_number":49,"context_line":"    iniset $NOVA_CONF DEFAULT firewall_driver \"$LIBVIRT_FIREWALL_DRIVER\""},{"line_number":50,"context_line":"    # Use hardware rng"},{"line_number":51,"context_line":"    iniset $NOVA_CONF DEFAULT rng_dev_path \"/dev/random\""},{"line_number":52,"context_line":"    # Power architecture currently does not support graphical consoles."},{"line_number":53,"context_line":"    if is_arch \"ppc64\"; then"},{"line_number":54,"context_line":"        iniset $NOVA_CONF vnc enabled \"false\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_a5e8f8de","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":56},"in_reply_to":"3fa7e38b_455d84ea","updated":"2019-12-04 00:48:26.000000000","message":"note we change teh default path to /dev/urandom in\n\nhttps://github.com/openstack/nova/commit/814bfd937238cbd211ea30805c36ae682cfd7b48\n\nso this would effectively regress that default change","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b123c3b2089d7d5a59f4d1d659a1ab3186747b9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    iniset $NOVA_CONF DEFAULT compute_driver \"libvirt.LibvirtDriver\""},{"line_number":48,"context_line":"    LIBVIRT_FIREWALL_DRIVER\u003d${LIBVIRT_FIREWALL_DRIVER:-\"nova.virt.libvirt.firewall.IptablesFirewallDriver\"}"},{"line_number":49,"context_line":"    iniset $NOVA_CONF DEFAULT firewall_driver \"$LIBVIRT_FIREWALL_DRIVER\""},{"line_number":50,"context_line":"    # Use hardware rng"},{"line_number":51,"context_line":"    iniset $NOVA_CONF DEFAULT rng_dev_path \"/dev/random\""},{"line_number":52,"context_line":"    # Power architecture currently does not support graphical consoles."},{"line_number":53,"context_line":"    if is_arch \"ppc64\"; then"},{"line_number":54,"context_line":"        iniset $NOVA_CONF vnc enabled \"false\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_56b0ce40","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":56},"in_reply_to":"3fa7e38b_6b4727a5","updated":"2019-12-04 16:18:24.000000000","message":"\u003e Possible I was just looking at older branch docs.\n\nI\u0027d say so. The latest docs state that this is the default.\n\n[1] https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.rng_dev_path","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"365e2f098fdc7298ee77ec9e634b9e238640b9a8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    iniset $NOVA_CONF DEFAULT compute_driver \"libvirt.LibvirtDriver\""},{"line_number":48,"context_line":"    LIBVIRT_FIREWALL_DRIVER\u003d${LIBVIRT_FIREWALL_DRIVER:-\"nova.virt.libvirt.firewall.IptablesFirewallDriver\"}"},{"line_number":49,"context_line":"    iniset $NOVA_CONF DEFAULT firewall_driver \"$LIBVIRT_FIREWALL_DRIVER\""},{"line_number":50,"context_line":"    # Use hardware rng"},{"line_number":51,"context_line":"    iniset $NOVA_CONF DEFAULT rng_dev_path \"/dev/random\""},{"line_number":52,"context_line":"    # Power architecture currently does not support graphical consoles."},{"line_number":53,"context_line":"    if is_arch \"ppc64\"; then"},{"line_number":54,"context_line":"        iniset $NOVA_CONF vnc enabled \"false\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_e6c833a9","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":56},"in_reply_to":"3fa7e38b_a5e8f8de","updated":"2019-12-04 10:16:04.000000000","message":"Correct. This is enabled by default and therefore not necessary here. It might be necessary in backports.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f8d6d074becb7f5359b3b654740a606fc4ab549d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    iniset $NOVA_CONF DEFAULT compute_driver \"libvirt.LibvirtDriver\""},{"line_number":48,"context_line":"    LIBVIRT_FIREWALL_DRIVER\u003d${LIBVIRT_FIREWALL_DRIVER:-\"nova.virt.libvirt.firewall.IptablesFirewallDriver\"}"},{"line_number":49,"context_line":"    iniset $NOVA_CONF DEFAULT firewall_driver \"$LIBVIRT_FIREWALL_DRIVER\""},{"line_number":50,"context_line":"    # Use hardware rng"},{"line_number":51,"context_line":"    iniset $NOVA_CONF DEFAULT rng_dev_path \"/dev/random\""},{"line_number":52,"context_line":"    # Power architecture currently does not support graphical consoles."},{"line_number":53,"context_line":"    if is_arch \"ppc64\"; then"},{"line_number":54,"context_line":"        iniset $NOVA_CONF vnc enabled \"false\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_6b4727a5","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":56},"in_reply_to":"3fa7e38b_e6c833a9","updated":"2019-12-04 16:06:38.000000000","message":"Ok. From documentation I could find there wasn\u0027t any indication that there was a valid preset default. Can you all double check that nova docs are properly updated?\n\nPossible I was just looking at older branch docs.","commit_id":"8115cb1c279630383b60fa7109f6592217a9782f"}]}