)]}'
{"id":"openstack%2Fdevstack~697194","triplet_id":"openstack%2Fdevstack~master~I70d800cdc45b6008f775110f22c0000736421529","project":"openstack/devstack","branch":"master","topic":"virtio-rng","hashtags":[],"change_id":"I70d800cdc45b6008f775110f22c0000736421529","subject":"Enable libvirt virtio rng device","status":"MERGED","created":"2019-12-03 22:35:51.000000000","updated":"2019-12-09 00:39:00.000000000","submitted":"2019-12-09 00:37:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":16,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"697194-1575851873754-a71cd6a1","meta_rev_id":"d203671cd5611887b97edaba75a99413f5bff720","_number":697194,"virtual_id_number":697194,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-12-09 00:37:53.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2019-12-05 18:29:44.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-12-08 23:06:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2019-12-08 14:47:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},{"value":2,"date":"2019-12-06 12:49:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":1,"date":"2019-12-05 18:41:37.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":1,"date":"2019-12-08 14:04:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-12-08 23:06:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-12-05 10:37:03.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-12-05 18:41:37.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2019-12-06 12:49:59.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2019-12-08 14:04:08.000000000","updated_by":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"reviewer":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"state":"REVIEWER"},{"updated":"2019-12-08 14:47:24.000000000","updated_by":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"reviewer":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"state":"REVIEWER"},{"updated":"2019-12-08 23:06:39.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-12-09 00:37:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0f95aefe42f39f68b03f7ad7eb70e984b60cf4e9","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-12-03 22:35:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b3f404ada24017068dceea098aab129515e79ce","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 00:24:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/ff2a3bbf547a45bcbde95d4a2482408e : SUCCESS in 1h 33m 59s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/1b568dfcae6440b68725aaf9cf4d8f54 : SUCCESS in 56m 03s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5d6cb7bb2e6e4e56834592b37df7f9fc : SUCCESS in 1h 27m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/30085c1412cc43d7ad7dd2e9802c07d1 : SUCCESS in 4m 40s\n- devstack https://zuul.opendev.org/t/openstack/build/251e90d666e04adbb2928fdcafab52c1 : SUCCESS in 32m 17s\n- devstack-xenial https://zuul.opendev.org/t/openstack/build/49d00b8c3bba4fc2b7b2496217fcc0fe : SUCCESS in 29m 45s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/0f8b6968f9784291a7f17934dadb3780 : SUCCESS in 27m 30s\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/770493f6f52c40c3909a9b9b3a7aa98d : SUCCESS in 1h 22m 42s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/1daed7cd2aa94ffea5e59f018f6b5bd1 : SUCCESS in 1h 42m 20s (non-voting)\n- devstack-platform-xenial https://zuul.opendev.org/t/openstack/build/b9783c77d71942aebb4e43ee737ca63f : SUCCESS in 1h 18m 49s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/475e0385510e454fa84cb8b1311b4ec1 : SUCCESS in 39m 07s\n- devstack-multinode-xenial https://zuul.opendev.org/t/openstack/build/cccfc0a0bf0248ae892b0dea671977bb : SUCCESS in 39m 37s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/a044722474aa4d5fb25aaaf94676abf2 : SUCCESS in 3m 10s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/c5f66040f9604d32b5e76ff7856c1c7b : SUCCESS in 2m 19s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/4144d8f0ff584acb943e113632e22e57 : SUCCESS in 51m 39s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/d092fbd5af3740f4ad7ad2a2dc27c488 : SUCCESS in 31m 34s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/7034324353c14314aa9978b4154aeabe : SUCCESS in 1h 09m 59s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/41e90f1f2a9e46698d15ce81302ac16b : SUCCESS in 1h 13m 33s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/21ee2c9f214e44da8012e2105fcf6b88 : SUCCESS in 1h 40m 40s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/86dddd49644e47d8a4e2762414f210e7 : SUCCESS in 56m 53s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2eef0b340f74493c96b499c4f053c4de : SUCCESS in 1h 01m 12s","accounts_in_message":[],"_revision_number":1},{"id":"cc83ebc34a9ae990fd6fdaf823d0dc3cc9605abd","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-12-04 00:44:43.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)\n\n-1 is for the nova conf change to change the default randome number source to /dev/random from /dev/urandom and the fact i dont think you are setting the image property for x86? just arm and power right or did i miss it?","accounts_in_message":[],"_revision_number":1},{"id":"628c82975ac25b66cdcf61ae25a10071b84e9c92","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-12-04 00:48:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"365e2f098fdc7298ee77ec9e634b9e238640b9a8","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-04 10:16:04.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"f8d6d074becb7f5359b3b654740a606fc4ab549d","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-12-04 16:06:38.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4a3c30affbeef96b97e84ae142f9ef62e92adaa8","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-12-04 16:06:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7b123c3b2089d7d5a59f4d1d659a1ab3186747b9","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-04 16:18:24.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9105b2e722a1423f324606cb3a4e98c4d2fe37d9","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-04 16:18:43.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"aa4af6ca9cad64c3b379cf5ac01c2ed58eb7388d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-04 19:51:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/92b7918280e04fb9a92b8748adeab711 : SUCCESS in 1h 38m 12s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/a10c4fe480c94ba2a862d6fc69f5a0a4 : SUCCESS in 1h 09m 09s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a14055c947754bd8ba29dad75578df5a : SUCCESS in 1h 27m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4cdde9ad5f27470e8c4507de52f34432 : SUCCESS in 6m 33s\n- devstack https://zuul.opendev.org/t/openstack/build/3a3c42a27224446f96aee66d89395173 : SUCCESS in 33m 04s\n- devstack-xenial https://zuul.opendev.org/t/openstack/build/ec6edfb1351044db9a55e94d5c45cb75 : SUCCESS in 28m 53s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/be76b98bee73473cac6805c7a4a95d39 : SUCCESS in 33m 38s\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/cf8b85edd83e4d6a91e0cc90ce359482 : TIMED_OUT in 2h 09m 26s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/67d9bfa82354419e9600a80860506585 : SUCCESS in 1h 42m 59s (non-voting)\n- devstack-platform-xenial https://zuul.opendev.org/t/openstack/build/5bdde776046c4bc7aa8cfec19d14c658 : SUCCESS in 1h 31m 44s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/fc0b719ee63b4306ab9c18a48e8e2578 : SUCCESS in 37m 02s\n- devstack-multinode-xenial https://zuul.opendev.org/t/openstack/build/e0669faa8d5848a9b50aebbbef5f6b03 : SUCCESS in 41m 34s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/0c4c8aa6a20342d1835f86bb53bfd013 : SUCCESS in 5m 12s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/942fd66724b944e4aa60b7cb55d91fd0 : SUCCESS in 4m 30s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ca647f540faf42078ac19863851282e2 : SUCCESS in 56m 30s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/ddc2f1225eda44b8af796b64ffc56e08 : SUCCESS in 40m 40s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/a81640134e72476aafd0202218125c45 : SUCCESS in 1h 22m 02s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/b5c9e55976ce46c1be5a9c3fe79840a8 : SUCCESS in 1h 24m 19s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/0907e25d17ab43dfaf036a6d0e3368d9 : SUCCESS in 1h 46m 28s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/2a9b0d4294104766853976c8bcf33394 : SUCCESS in 1h 06m 33s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6fb61e40b477432caf040fbc55f9846a : SUCCESS in 1h 06m 03s","accounts_in_message":[],"_revision_number":2},{"id":"36730312f5d4b07f7df4e48f6b0f25d570aab8f8","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-12-05 04:40:59.000000000","message":"Patch Set 2: Code-Review+2\n\nI don\u0027t really feel that qualified to vote on the nova details here, but the basic implementation looks ok to me","accounts_in_message":[],"_revision_number":2},{"id":"78224d5bfaa7280d0d29b53c207ffd0c0a0dab89","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-12-05 06:52:53.000000000","message":"Patch Set 2: Code-Review-1\n\nIs there a way to verify that this actually does what it claims?\n\nI\u0027m also worried that it may affect gate stability negatively, is anyone actually using this kind of setup in production? And if this makes for a better default experience, wouldn\u0027t it be better to make it the default in nova?","accounts_in_message":[],"_revision_number":2},{"id":"bf0a0632f715cb50310f40867fc16f11ab71877f","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-05 10:37:03.000000000","message":"Patch Set 2: -Code-Review\n\n\u003e Is there a way to verify that this actually does what it claims?\n \u003e \n \u003e I\u0027m also worried that it may affect gate stability negatively, is\n \u003e anyone actually using this kind of setup in production? And if this\n \u003e makes for a better default experience, wouldn\u0027t it be better to\n \u003e make it the default in nova?\n\nHmm, that\u0027s a good point. Which tests are failing? I went looking at the nova-compute logs for the Tempest job and couldn\u0027t see the RNG device in the XML for the various instances, however, this seems to be because we don\u0027t use the flavors created in \u0027lib/nova\u0027 but rather those created in \u0027lib/tempest\u0027 (m1.nano, by default). Do we need to modify that file too?","accounts_in_message":[],"_revision_number":2},{"id":"496d7000bd465baa6cb5c2fa8ecdcdb86d8b5b4f","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-12-05 15:58:32.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"03e36d8764c542c4e3b68fb3281c489e4f0b2350","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-12-05 16:00:43.000000000","message":"Patch Set 3:\n\n\u003e \u003e Is there a way to verify that this actually does what it claims?\n \u003e \u003e\n \u003e \u003e I\u0027m also worried that it may affect gate stability negatively, is\n \u003e \u003e anyone actually using this kind of setup in production? And if\n \u003e this\n \u003e \u003e makes for a better default experience, wouldn\u0027t it be better to\n \u003e \u003e make it the default in nova?\n \u003e \n \u003e Hmm, that\u0027s a good point. Which tests are failing? I went looking\n \u003e at the nova-compute logs for the Tempest job and couldn\u0027t see the\n \u003e RNG device in the XML for the various instances, however, this\n \u003e seems to be because we don\u0027t use the flavors created in \u0027lib/nova\u0027\n \u003e but rather those created in \u0027lib/tempest\u0027 (m1.nano, by default). Do\n \u003e we need to modify that file too?\n\nI\u0027ve updated the change to include updates for the tempest flavors.\n\nTestability was my concern too. I am definitely not the expert here was simply trying to get the ball rolling. I think questions of testing may be best deferred to nova?\n\nAs for checking if this improves gate stability I think this may be a case of merge and mark point in time against related e-r bugs. Then check again in a week and see if trends have changed. If they change for the better great. If there is no change or change for the worse we should consider reverting.","accounts_in_message":[],"_revision_number":3},{"id":"50e587ac23a29e455e537f6dc74af24e50524b0f","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-12-05 16:20:21.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nso looking at https://zuul.opendev.org/t/openstack/build/92b7918280e04fb9a92b8748adeab711/log/controller/logs/screen-n-cpu.txt.gz#5698-5776\n\ni dont think this is working","accounts_in_message":[],"_revision_number":3},{"id":"ffae229af8c28413f84cac799806f3b1d6381a40","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-05 18:11:35.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/3b84e78a44664c288b8e18f9ab3544cb : SUCCESS in 1h 30m 52s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d7335c6842984d47b7dd20ae52ff0f6f : SUCCESS in 1h 04m 57s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/bcf95d776e1c40ed80b0c9051a65d757 : SUCCESS in 1h 34m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/576019251462417d85c97cb51fd88877 : SUCCESS in 5m 46s\n- devstack https://zuul.opendev.org/t/openstack/build/01e1fc53ad854dddbafc2f3b8c6ccb40 : SUCCESS in 35m 16s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/3499dce9b73748c4833afa7f83d169d6 : SUCCESS in 32m 00s\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/19826f1783934417a2f1697a53c77383 : FAILURE in 1h 37m 57s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/0597ce5e18d04043a6981dd8d41e212d : SUCCESS in 1h 31m 03s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/bae090f8078240e5b08e3eed367e8e2a : SUCCESS in 43m 33s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/36885fcdf4564afe86352a29e48a7475 : SUCCESS in 4m 39s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/0499613a307a46169fcf916b2ff2df1f : SUCCESS in 3m 35s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/49077001d58b446383a26ba0ae1adf95 : SUCCESS in 55m 24s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1d7e32c6865d447da675b7d8fff4e383 : SUCCESS in 30m 35s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/b4bb5e5936ca4e4f9fb94d394f7b0eda : SUCCESS in 1h 10m 29s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/cf37e6bdc6604fd39fd7d7a69e3ee2e0 : SUCCESS in 1h 17m 00s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/8384620104e443f2b0086c5792b180b5 : SUCCESS in 1h 53m 40s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/dba42125e3d74e52954d3a702c649a18 : SUCCESS in 57m 58s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/958960a104c04f9cb1f29b885d0e9f16 : SUCCESS in 1h 14m 29s","accounts_in_message":[],"_revision_number":3},{"id":"e1a75f2bb3928b736e7620fc50dd94854271c855","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-12-05 18:29:44.000000000","message":"Patch Set 3:\n\n\u003e (1 comment)\n \u003e \n \u003e so looking at https://zuul.opendev.org/t/openstack/build/92b7918280e04fb9a92b8748adeab711/log/controller/logs/screen-n-cpu.txt.gz#5698-5776\n \u003e \n \u003e i dont think this is working\n\nThat job ran against patchset 2 which stephenfin pointed out didn\u0027t update the tempest flavors. Patchset 3 fixes this and it appears to work now:\n\nhttps://zuul.opendev.org/t/openstack/build/bcf95d776e1c40ed80b0c9051a65d757/log/controller/logs/screen-n-cpu.txt.gz#2003-2005","accounts_in_message":[],"_revision_number":3},{"id":"2defe024bd553ecda0092830043c70c7eda05b14","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2019-12-05 18:41:37.000000000","message":"Patch Set 3: Code-Review+1\n\nyep that is exactly what i was hoping to see\nthis looks good to me.\n\nit would be interestign is we notice any reduction in the time it takes test to run. we might not but if we had slow start up of service or intermittent failure it might. we also have considered enable the RNG by default so if we see an overall imporvemtne in stablity of execution time that might be a useful factor to condier for nova in the future.","accounts_in_message":[],"_revision_number":3},{"id":"f7f1b358aaef894e58f8d0b369a237d8b96320dd","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-12-06 12:49:59.000000000","message":"Patch Set 3: Code-Review+2\n\nO.k., so let\u0027s do some live testing with this.","accounts_in_message":[],"_revision_number":3},{"id":"dd82cd5e9c50ce052b599b88eb7e2f7359a94532","author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"date":"2019-12-08 14:04:08.000000000","message":"Patch Set 3: Code-Review+1\n\nSimilar to this change, see https://review.opendev.org/#/c/697183/","accounts_in_message":[],"_revision_number":3},{"id":"55448d5d4fa8f447dc1931e8a4ee0232472ee301","author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"date":"2019-12-08 14:47:24.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"4b753a674370e812cb4a616bcbf89b4f99849b1a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-12-08 23:06:39.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"d05a2fda7528848f4d1e057ec89e3bff73ad5734","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-08 23:06:52.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"b80d211d577cbab9777f3a256a335c2b435789cf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 00:37:53.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/e63a9ba8f1034fac91eec1b176ef1e0e : SUCCESS in 1h 19m 50s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/60dcf0a30ee042bfafe4f00a02255262 : SUCCESS in 50m 30s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/fc719f29ff90462a973d60004af5a6ad : SUCCESS in 1h 30m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d481f6065be042f8ab551ddd702a4d4e : SUCCESS in 4m 33s\n- devstack https://zuul.opendev.org/t/openstack/build/294fdb9f59b9465e9f8db791c7577ea0 : SUCCESS in 24m 51s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/586cc05ece6f4c6787aa2fce1d61a60d : SUCCESS in 27m 15s\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/dc7d038750b946b79a6f323e07d9b467 : SUCCESS in 34m 28s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/432e2c553872461a8314e54dc4988e26 : SUCCESS in 3m 59s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/b995f1b1b88540abb1ca91087721e48e : SUCCESS in 2m 30s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/d6699a56f99341fdab69941e4b84925f : SUCCESS in 1h 21m 34s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/5c12cbda214b4521af9bfc96a433e291 : SUCCESS in 1h 13m 02s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/b470bbb0ec9f4ff984ca94591572941c : SUCCESS in 53m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/d7d70750ee4f45cdb92833510fc73fdf : SUCCESS in 56m 53s","accounts_in_message":[],"_revision_number":3},{"id":"937eef26f227a5ebd44c08217a661c5404fb21ad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 00:37:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"8a3ff551088b7e5354c052fb8a46f802fdbeef3b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-09 00:39:00.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cffbd69c969c48cf89c859e683d649ad : SUCCESS in 48s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"7ddbece508413592cbb7540408b3edbf04ca8d04","revisions":{"8115cb1c279630383b60fa7109f6592217a9782f":{"kind":"REWORK","_number":1,"created":"2019-12-03 22:35:51.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/94/697194/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/697194/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/697194/1"}}},"commit":{"parents":[{"commit":"595759c764eebbaffeb120f178dcd9069fbba070","subject":"Merge \"Drop centos7 platform job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/595759c764eebbaffeb120f178dcd9069fbba070"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-12-03 22:35:03.000000000","tz":-480},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-12-03 22:35:03.000000000","tz":-480},"subject":"Enable libvirt virtio rng device","message":"Enable libvirt virtio rng device\n\nWe\u0027ve seen jobs where tests fail due to what appears to be rng\nstarvation. Enable virtio rng device to try and alleviate this.\n\nChange-Id: I70d800cdc45b6008f775110f22c0000736421529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8115cb1c279630383b60fa7109f6592217a9782f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8115cb1c279630383b60fa7109f6592217a9782f"}]},"branch":"refs/heads/master"},"3ff5ea3aa9ce7d7e049c04d8ac61000710c010e7":{"kind":"REWORK","_number":2,"created":"2019-12-04 16:06:53.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/94/697194/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/697194/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/697194/2"}}},"commit":{"parents":[{"commit":"595759c764eebbaffeb120f178dcd9069fbba070","subject":"Merge \"Drop centos7 platform job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/595759c764eebbaffeb120f178dcd9069fbba070"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-12-03 22:35:03.000000000","tz":-480},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-12-04 16:06:44.000000000","tz":-480},"subject":"Enable libvirt virtio rng device","message":"Enable libvirt virtio rng device\n\nWe\u0027ve seen jobs where tests fail due to what appears to be rng\nstarvation. Enable virtio rng device to try and alleviate this.\n\nChange-Id: I70d800cdc45b6008f775110f22c0000736421529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3ff5ea3aa9ce7d7e049c04d8ac61000710c010e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/3ff5ea3aa9ce7d7e049c04d8ac61000710c010e7"}]},"branch":"refs/heads/master"},"7ddbece508413592cbb7540408b3edbf04ca8d04":{"kind":"REWORK","_number":3,"created":"2019-12-05 15:58:32.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/94/697194/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/94/697194/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/94/697194/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/94/697194/3"}}},"commit":{"parents":[{"commit":"595759c764eebbaffeb120f178dcd9069fbba070","subject":"Merge \"Drop centos7 platform job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/595759c764eebbaffeb120f178dcd9069fbba070"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-12-03 22:35:03.000000000","tz":-480},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-12-05 15:58:23.000000000","tz":-480},"subject":"Enable libvirt virtio rng device","message":"Enable libvirt virtio rng device\n\nWe\u0027ve seen jobs where tests fail due to what appears to be rng\nstarvation. Enable virtio rng device to try and alleviate this.\n\nChange-Id: I70d800cdc45b6008f775110f22c0000736421529\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7ddbece508413592cbb7540408b3edbf04ca8d04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7ddbece508413592cbb7540408b3edbf04ca8d04"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}