)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9fb32bf85cf7eed032ec38f8369776d357a4643a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"for now.  Need to determine what config options"},{"line_number":12,"context_line":"etc. should be used to control this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Set GLANCE_STORE\u003dcinder and add glance_store"},{"line_number":15,"context_line":"to LIBS_FROM_GIT to enable."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Moves the first cirros image upload to Glance"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_5273d8b1","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":23},"updated":"2020-05-28 10:21:39.000000000","message":"we also need to mention, GLANCE_STORE needs to be set swift to enable swift store now","commit_id":"fd0bbf9cdfddf416bfde068f3651ab3bc90481d2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2b19c3c82ba2712d48d263b9e2b2b1a7bbcbb4c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"for glance when cinder backend is nfs."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Finally, if we want to enable swift as glance store"},{"line_number":22,"context_line":"we need to set $GLANCE_STORE\u003dswift."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: If979a76ec4e7a2649b2c1a003cb9cef236559db4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ff570b3c_5f7a9fb9","line":22,"range":{"start_line":22,"start_character":15,"end_line":22,"end_character":16},"updated":"2020-05-30 14:16:55.000000000","message":"w/o this obviously","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"}],"lib/glance":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5648bb25831b6f1f76579a19ecb1796b6da84522","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    fi"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    # Store the images in swift if enabled."},{"line_number":156,"context_line":"    if is_service_enabled s-proxy; then"},{"line_number":157,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store swift"},{"line_number":158,"context_line":"        iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"},{"line_number":159,"context_line":"        if python3_enabled; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff570b3c_c72a888e","line":156,"range":{"start_line":156,"start_character":4,"end_line":156,"end_character":39},"updated":"2020-05-14 08:07:05.000000000","message":"if we want to enable swift for c-bak, this will automatically configure swift as glance store which isn\u0027t right.\nwe should have $GLANCE_STORE\u003dswift set for this case","commit_id":"cb6d4fa2c3a955ad9f1f11901622cdc3783902f2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2c6b7739d938adb18c595dbc44899030f8cbf9e8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        # Cheat a bit here to write rootwrap config from glance_store files."},{"line_number":190,"context_line":"        # This assumes that glance_store is in LIBS_FROM_GIT"},{"line_number":191,"context_line":"        # (used by os-brick when connecting to volumes)"},{"line_number":192,"context_line":"        mkdir -p /opt/stack/glance/etc/glance/rootwrap.d"},{"line_number":193,"context_line":"        cp /opt/stack/glance_store/etc/glance/rootwrap.conf /opt/stack/glance/etc/glance/"},{"line_number":194,"context_line":"        cp /opt/stack/glance_store/etc/glance/rootwrap.d/* /opt/stack/glance/etc/glance/rootwrap.d/"},{"line_number":195,"context_line":"        configure_rootwrap glance"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff570b3c_a7031442","line":192,"range":{"start_line":192,"start_character":17,"end_line":192,"end_character":27},"updated":"2020-05-28 10:17:58.000000000","message":"also makes sense to use $DEST instead of /opt/stack hardcoded here","commit_id":"fd0bbf9cdfddf416bfde068f3651ab3bc90481d2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2c6b7739d938adb18c595dbc44899030f8cbf9e8","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        # Cheat a bit here to write rootwrap config from glance_store files."},{"line_number":190,"context_line":"        # This assumes that glance_store is in LIBS_FROM_GIT"},{"line_number":191,"context_line":"        # (used by os-brick when connecting to volumes)"},{"line_number":192,"context_line":"        mkdir -p /opt/stack/glance/etc/glance/rootwrap.d"},{"line_number":193,"context_line":"        cp /opt/stack/glance_store/etc/glance/rootwrap.conf /opt/stack/glance/etc/glance/"},{"line_number":194,"context_line":"        cp /opt/stack/glance_store/etc/glance/rootwrap.d/* /opt/stack/glance/etc/glance/rootwrap.d/"},{"line_number":195,"context_line":"        configure_rootwrap glance"},{"line_number":196,"context_line":"    fi"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # We need to tell glance what it\u0027s public endpoint is so that the version"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff570b3c_67ea9c75","line":195,"range":{"start_line":192,"start_character":8,"end_line":195,"end_character":33},"updated":"2020-05-28 10:17:58.000000000","message":"as Eric suggested, it makes sense here to add a check if \u0027glance_store\u0027 is included in LIBS_FROM_GIT else there\u0027s a chance it wont work\nfor now we can fail the installation if that\u0027s not the case but if you have a better idea then please go ahead","commit_id":"fd0bbf9cdfddf416bfde068f3651ab3bc90481d2"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"727a31cc024c9501cb67413efa7f63f90594d2b8","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            configure_rootwrap glance"},{"line_number":197,"context_line":"        else"},{"line_number":198,"context_line":"            return 1"},{"line_number":199,"context_line":"        if"},{"line_number":200,"context_line":"    fi"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    # We need to tell glance what it\u0027s public endpoint is so that the version"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ff570b3c_e8d4b849","line":199,"range":{"start_line":199,"start_character":8,"end_line":199,"end_character":10},"updated":"2020-05-28 14:11:59.000000000","message":"This won\u0027t work","commit_id":"3081ba90ea297219afaa9e9c617fee8cde455b45"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2b19c3c82ba2712d48d263b9e2b2b1a7bbcbb4c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        iniset $GLANCE_API_CONF cors allowed_origin \"http://$SERVICE_HOST\""},{"line_number":154,"context_line":"    fi"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    # Store the images in swift if enabled."},{"line_number":157,"context_line":"    if is_service_enabled s-proxy \u0026\u0026 [ \"$GLANCE_STORE\" \u003d \"swift\" ]; then"},{"line_number":158,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store swift"},{"line_number":159,"context_line":"        iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_7f7de3b0","line":156,"range":{"start_line":156,"start_character":4,"end_line":156,"end_character":43},"updated":"2020-05-30 14:16:55.000000000","message":"no longer true, now it requires it to be set as GLANCE_STORE as well","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2b19c3c82ba2712d48d263b9e2b2b1a7bbcbb4c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    fi"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    # Store the images in swift if enabled."},{"line_number":157,"context_line":"    if is_service_enabled s-proxy \u0026\u0026 [ \"$GLANCE_STORE\" \u003d \"swift\" ]; then"},{"line_number":158,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store swift"},{"line_number":159,"context_line":"        iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"},{"line_number":160,"context_line":"        if python3_enabled; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_ff429367","line":157,"range":{"start_line":157,"start_character":41,"end_line":157,"end_character":53},"updated":"2020-05-30 14:16:55.000000000","message":"I don\u0027t see this set anywhere","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4051579bd7e94bf68c8d9c4fc6a8d03a7b2e8849","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    fi"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    # Store the images in swift if enabled."},{"line_number":157,"context_line":"    if is_service_enabled s-proxy \u0026\u0026 [ \"$GLANCE_STORE\" \u003d \"swift\" ]; then"},{"line_number":158,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store swift"},{"line_number":159,"context_line":"        iniset $GLANCE_API_CONF glance_store swift_store_create_container_on_put True"},{"line_number":160,"context_line":"        if python3_enabled; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_0a0c60ea","line":157,"range":{"start_line":157,"start_character":41,"end_line":157,"end_character":53},"in_reply_to":"ff570b3c_ff429367","updated":"2020-05-31 13:55:50.000000000","message":"yeah, i think we need a default for this","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2b19c3c82ba2712d48d263b9e2b2b1a7bbcbb4c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store cinder"},{"line_number":183,"context_line":"        iniset $GLANCE_API_CONF glance_store stores \"file, http, cinder\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_auth_address $KEYSTONE_SERVICE_URI_V3"},{"line_number":186,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_project_name $SERVICE_PROJECT_NAME"},{"line_number":187,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_user_name glance"},{"line_number":188,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_password $SERVICE_PASSWORD"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":191,"context_line":"            local be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_3f77ebd6","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":84},"updated":"2020-05-30 14:16:55.000000000","message":"I am pretty sure these are deprecated nowadays and one is supposed to configure them in their own group (i.e. use \"backends\" in glance).","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4051579bd7e94bf68c8d9c4fc6a8d03a7b2e8849","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store cinder"},{"line_number":183,"context_line":"        iniset $GLANCE_API_CONF glance_store stores \"file, http, cinder\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_auth_address $KEYSTONE_SERVICE_URI_V3"},{"line_number":186,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_project_name $SERVICE_PROJECT_NAME"},{"line_number":187,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_user_name glance"},{"line_number":188,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_password $SERVICE_PASSWORD"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":191,"context_line":"            local be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_ea100c03","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":84},"in_reply_to":"ff570b3c_3f77ebd6","updated":"2020-05-31 13:55:50.000000000","message":"not sure what you mean by deprecated but the values set here will be the project in which cinder will create the image-volume","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f2ce24422b971e48f9898e394f7b4923108b9e39","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store cinder"},{"line_number":183,"context_line":"        iniset $GLANCE_API_CONF glance_store stores \"file, http, cinder\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_auth_address $KEYSTONE_SERVICE_URI_V3"},{"line_number":186,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_project_name $SERVICE_PROJECT_NAME"},{"line_number":187,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_user_name glance"},{"line_number":188,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_password $SERVICE_PASSWORD"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":191,"context_line":"            local be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_75584630","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":84},"in_reply_to":"ff570b3c_9e1b8fc8","updated":"2020-06-02 08:49:50.000000000","message":"There are 2 cases, single store and multiple store.\n1) for single store, these configs are loaded from [glance_store]\n2) for multiple stores, we define a group name against every store used like cinder:fast, file:slow\nthen we have groups like [fast] and [slow]\n\nI\u0027m not sure if we have devstack configuration in place for setting up multiple stores via devstack.\n1) if we have, then all the store configuration (see swift above) uses the default [glance_store] group so everything will require refactoring and not this specifically\n2) if we don\u0027t have then this works completely fine with the default [glance_store] group\n\nEither way, for a gate run i think single store installation would be preferable as we prefer for cinder single backend by default.","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bda992138fca91db4c80762e22f7f3cd93a79f5c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store cinder"},{"line_number":183,"context_line":"        iniset $GLANCE_API_CONF glance_store stores \"file, http, cinder\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_auth_address $KEYSTONE_SERVICE_URI_V3"},{"line_number":186,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_project_name $SERVICE_PROJECT_NAME"},{"line_number":187,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_user_name glance"},{"line_number":188,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_password $SERVICE_PASSWORD"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":191,"context_line":"            local be_name\u003d${be##*:}"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_9e1b8fc8","line":188,"range":{"start_line":185,"start_character":0,"end_line":188,"end_character":84},"in_reply_to":"ff570b3c_ea100c03","updated":"2020-06-01 12:18:23.000000000","message":"Yeah, I know what they do. But the modern glance config wants you to put them in a dedicated group, see https://docs.openstack.org/glance/latest/configuration/glance_api.html#glance-store (especially the parts in red ;-) ).","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2b19c3c82ba2712d48d263b9e2b2b1a7bbcbb4c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_user_name glance"},{"line_number":188,"context_line":"        iniset $GLANCE_API_CONF glance_store cinder_store_password $SERVICE_PASSWORD"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":191,"context_line":"            local be_name\u003d${be##*:}"},{"line_number":192,"context_line":"            if [[ \"$be_name\" \u003d\u003d \"nfs\" ]]; then"},{"line_number":193,"context_line":"                mkdir -p $GLANCE_NFS_MOUNTPOINT"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_1f74a7ce","line":190,"range":{"start_line":190,"start_character":12,"end_line":190,"end_character":14},"updated":"2020-05-30 14:16:55.000000000","message":"can\u0027t we call it backend? or even c_backend","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2b19c3c82ba2712d48d263b9e2b2b1a7bbcbb4c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            fi"},{"line_number":196,"context_line":"        done"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if use_library_from_git \"glance_store\"; then"},{"line_number":199,"context_line":"            # Cheat a bit here to write rootwrap config from glance_store files."},{"line_number":200,"context_line":"            # This assumes that glance_store is in LIBS_FROM_GIT"},{"line_number":201,"context_line":"            # (used by os-brick when connecting to volumes)"},{"line_number":202,"context_line":"            mkdir -p $DEST/glance/etc/glance/rootwrap.d"},{"line_number":203,"context_line":"            cp $DEST/glance_store/etc/glance/rootwrap.conf $DEST/glance/etc/glance/"},{"line_number":204,"context_line":"            cp $DEST/glance_store/etc/glance/rootwrap.d/* $DEST/glance/etc/glance/rootwrap.d/"},{"line_number":205,"context_line":"            configure_rootwrap glance"},{"line_number":206,"context_line":"        else"},{"line_number":207,"context_line":"            echo \"glance_store project is required in LIBS_FROM_GIT\""},{"line_number":208,"context_line":"            exit 1"},{"line_number":209,"context_line":"        fi"},{"line_number":210,"context_line":"    fi"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # We need to tell glance what it\u0027s public endpoint is so that the version"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_9f68b7f5","line":209,"range":{"start_line":198,"start_character":8,"end_line":209,"end_character":10},"updated":"2020-05-30 14:16:55.000000000","message":"can we make it somewhat better and not require this? this is also question to the glance team - maybe it needs better packaging?","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bda992138fca91db4c80762e22f7f3cd93a79f5c","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            fi"},{"line_number":196,"context_line":"        done"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if use_library_from_git \"glance_store\"; then"},{"line_number":199,"context_line":"            # Cheat a bit here to write rootwrap config from glance_store files."},{"line_number":200,"context_line":"            # This assumes that glance_store is in LIBS_FROM_GIT"},{"line_number":201,"context_line":"            # (used by os-brick when connecting to volumes)"},{"line_number":202,"context_line":"            mkdir -p $DEST/glance/etc/glance/rootwrap.d"},{"line_number":203,"context_line":"            cp $DEST/glance_store/etc/glance/rootwrap.conf $DEST/glance/etc/glance/"},{"line_number":204,"context_line":"            cp $DEST/glance_store/etc/glance/rootwrap.d/* $DEST/glance/etc/glance/rootwrap.d/"},{"line_number":205,"context_line":"            configure_rootwrap glance"},{"line_number":206,"context_line":"        else"},{"line_number":207,"context_line":"            echo \"glance_store project is required in LIBS_FROM_GIT\""},{"line_number":208,"context_line":"            exit 1"},{"line_number":209,"context_line":"        fi"},{"line_number":210,"context_line":"    fi"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # We need to tell glance what it\u0027s public endpoint is so that the version"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_de7ea7e2","line":209,"range":{"start_line":198,"start_character":8,"end_line":209,"end_character":10},"in_reply_to":"ff570b3c_4af938c6","updated":"2020-06-01 12:18:23.000000000","message":"Yeah, I wish someone from glance could advise.","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4051579bd7e94bf68c8d9c4fc6a8d03a7b2e8849","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            fi"},{"line_number":196,"context_line":"        done"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        if use_library_from_git \"glance_store\"; then"},{"line_number":199,"context_line":"            # Cheat a bit here to write rootwrap config from glance_store files."},{"line_number":200,"context_line":"            # This assumes that glance_store is in LIBS_FROM_GIT"},{"line_number":201,"context_line":"            # (used by os-brick when connecting to volumes)"},{"line_number":202,"context_line":"            mkdir -p $DEST/glance/etc/glance/rootwrap.d"},{"line_number":203,"context_line":"            cp $DEST/glance_store/etc/glance/rootwrap.conf $DEST/glance/etc/glance/"},{"line_number":204,"context_line":"            cp $DEST/glance_store/etc/glance/rootwrap.d/* $DEST/glance/etc/glance/rootwrap.d/"},{"line_number":205,"context_line":"            configure_rootwrap glance"},{"line_number":206,"context_line":"        else"},{"line_number":207,"context_line":"            echo \"glance_store project is required in LIBS_FROM_GIT\""},{"line_number":208,"context_line":"            exit 1"},{"line_number":209,"context_line":"        fi"},{"line_number":210,"context_line":"    fi"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # We need to tell glance what it\u0027s public endpoint is so that the version"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"ff570b3c_4af938c6","line":209,"range":{"start_line":198,"start_character":8,"end_line":209,"end_character":10},"in_reply_to":"ff570b3c_9f68b7f5","updated":"2020-05-31 13:55:50.000000000","message":"this doesn\u0027t seem the best way but in the current scenario how these rootwrap files exist in glance_store, this seemed to be the only way.","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"}],"stack.sh":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2c6b7739d938adb18c595dbc44899030f8cbf9e8","unresolved":false,"context_lines":[{"line_number":1325,"context_line":"    start_cinder"},{"line_number":1326,"context_line":"    create_volume_types"},{"line_number":1327,"context_line":"fi"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"# Install Images"},{"line_number":1330,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1331,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_27bee464","line":1328,"updated":"2020-05-28 10:17:58.000000000","message":"as mentioned in my previous comment, we need a check here to wait for cinder-volume to be publishing capabilities else image upload will fail\nwe can check like\nif [ \"$GLANCE_STORE\" \u003d \"cinder\" ]; then\n    sleep 30","commit_id":"fd0bbf9cdfddf416bfde068f3651ab3bc90481d2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2b19c3c82ba2712d48d263b9e2b2b1a7bbcbb4c","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"    create_volume_types"},{"line_number":1327,"context_line":"fi"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1330,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1331,"context_line":"if [ \"$GLANCE_STORE\" \u003d \"cinder\" ]; then"},{"line_number":1332,"context_line":"    sleep 30"},{"line_number":1333,"context_line":"fi"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"# Install Images"},{"line_number":1336,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff570b3c_9f51d739","line":1333,"range":{"start_line":1329,"start_character":0,"end_line":1333,"end_character":2},"updated":"2020-05-30 14:16:55.000000000","message":"this is pretty worrying and might have weird impact if we need 31 seconds instead ;-) can\u0027t we check whether cinder is already up?","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f2ce24422b971e48f9898e394f7b4923108b9e39","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"    create_volume_types"},{"line_number":1327,"context_line":"fi"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1330,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1331,"context_line":"if [ \"$GLANCE_STORE\" \u003d \"cinder\" ]; then"},{"line_number":1332,"context_line":"    sleep 30"},{"line_number":1333,"context_line":"fi"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"# Install Images"},{"line_number":1336,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff570b3c_956cfad0","line":1333,"range":{"start_line":1329,"start_character":0,"end_line":1333,"end_character":2},"in_reply_to":"ff570b3c_3e59a38d","updated":"2020-06-02 08:49:50.000000000","message":"i don\u0027t think there is any API in cinder which tells if the backend is publishing capabilities on the scheduler or not.\ni think we can sleep for 1 minute (which is the time for a backend to publish capabilities) and if still it doesn\u0027t then there\u0027s some problem with c-vol and we shouldn\u0027t proceed with the installation anyway.","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bda992138fca91db4c80762e22f7f3cd93a79f5c","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"    create_volume_types"},{"line_number":1327,"context_line":"fi"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1330,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1331,"context_line":"if [ \"$GLANCE_STORE\" \u003d \"cinder\" ]; then"},{"line_number":1332,"context_line":"    sleep 30"},{"line_number":1333,"context_line":"fi"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"# Install Images"},{"line_number":1336,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff570b3c_3e59a38d","line":1333,"range":{"start_line":1329,"start_character":0,"end_line":1333,"end_character":2},"in_reply_to":"ff570b3c_4a22d853","updated":"2020-06-01 12:18:23.000000000","message":"Maybe just poll the cinder API here? It can be a simple loop with sleeps and a set number of repeats (to try only for max e.g. 2 minutes).","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4051579bd7e94bf68c8d9c4fc6a8d03a7b2e8849","unresolved":false,"context_lines":[{"line_number":1326,"context_line":"    create_volume_types"},{"line_number":1327,"context_line":"fi"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1330,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1331,"context_line":"if [ \"$GLANCE_STORE\" \u003d \"cinder\" ]; then"},{"line_number":1332,"context_line":"    sleep 30"},{"line_number":1333,"context_line":"fi"},{"line_number":1334,"context_line":""},{"line_number":1335,"context_line":"# Install Images"},{"line_number":1336,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff570b3c_4a22d853","line":1333,"range":{"start_line":1329,"start_character":0,"end_line":1333,"end_character":2},"in_reply_to":"ff570b3c_9f51d739","updated":"2020-05-31 13:55:50.000000000","message":"From the gate run, i saw the difference as 4 seconds.\nfrom multiple local runs, the results varied but for the slowest run on my slow system, it went as high as 20 seconds.\nthe default backend_stats_polling_interval is 60 seconds which i didn\u0027t find valid waiting for as during the actual run, most of the time of 60 sec is already spend while reaching this step.\nI didn\u0027t find any other way to do it as i found this issue in logs (which also took a lot of time finding as wasn\u0027t obvious).\nkindly suggest if you\u0027ve any better way to do the same.","commit_id":"b1b0fcd8090d4331541be773b950158a77560bd3"}]}