)]}'
{"lib/cinder":[{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"e76a80d98f8351dc4c0d174dca381a999e0b21ea","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        iniset $CINDER_CONF DEFAULT glance_ca_certificates_file $SSL_BUNDLE_FILE"},{"line_number":312,"context_line":"    fi"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    if [ \"$GLANCE_V1_ENABLED\" !\u003d \"True\" ]; then"},{"line_number":315,"context_line":"        iniset $CINDER_CONF DEFAULT glance_api_version 2"},{"line_number":316,"context_line":"    fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    # Set nova credentials (used for os-assisted-snapshots)"},{"line_number":319,"context_line":"    configure_keystone_authtoken_middleware $CINDER_CONF nova nova"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf51134e_f77841f9","side":"PARENT","line":316,"range":{"start_line":314,"start_character":0,"end_line":316,"end_character":6},"updated":"2020-06-17 15:03:37.000000000","message":"Looks like remove these 3 lines changed the logic improperly.\nLine 314 and line 316 can be removed, but line 315 need to be kept.\n\ne.g. GLANCE_V1_ENABLED is normally not \u0027True\u0027, so normally line 315 is executed.","commit_id":"f7a7076facbe8ef7c77863abf977af5cdafdeb6e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f77af3fdb1aed9f0e04c7ca43004a778c60fa756","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        iniset $CINDER_CONF DEFAULT glance_ca_certificates_file $SSL_BUNDLE_FILE"},{"line_number":312,"context_line":"    fi"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    if [ \"$GLANCE_V1_ENABLED\" !\u003d \"True\" ]; then"},{"line_number":315,"context_line":"        iniset $CINDER_CONF DEFAULT glance_api_version 2"},{"line_number":316,"context_line":"    fi"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    # Set nova credentials (used for os-assisted-snapshots)"},{"line_number":319,"context_line":"    configure_keystone_authtoken_middleware $CINDER_CONF nova nova"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf51134e_8da235fb","side":"PARENT","line":316,"range":{"start_line":314,"start_character":0,"end_line":316,"end_character":6},"in_reply_to":"bf51134e_f77841f9","updated":"2020-06-23 11:58:56.000000000","message":"AFAICT from https://docs.openstack.org/cinder/ussuri/configuration/block-storage/samples/cinder.conf.html this option no longer exists, so it should be fine to just drop this.","commit_id":"f7a7076facbe8ef7c77863abf977af5cdafdeb6e"}]}
