)]}'
{"stack.sh":[{"author":{"_account_id":1269,"name":"Shweta P","email":"shpadubi@cisco.com","username":"shweta-ap05"},"change_message_id":"c1fc0825bd1064617587238f7265a9d78f6e5cf2","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"# -------"},{"line_number":1008,"context_line":"if is_service_enabled quantum; then"},{"line_number":1009,"context_line":"    # Put config files in /etc/quantum for everyone to find"},{"line_number":1010,"context_line":"    if [[ ! -d /etc/quantum ]]; then"},{"line_number":1011,"context_line":"        sudo mkdir -p /etc/quantum"},{"line_number":1012,"context_line":"    fi"},{"line_number":1013,"context_line":"    sudo chown `whoami` /etc/quantum"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAHX%2F%2F7dU%3D","line":1010,"updated":"2012-05-15 21:36:00.000000000","message":"Is there a reason why you are not assigning /etc/quantum to a variable?","commit_id":"f13068089155d63fe5e4352195e24cadd5b6c17a"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"58fea75efa753719150acaeced084ec5d5cdf249","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"# -------"},{"line_number":1008,"context_line":"if is_service_enabled quantum; then"},{"line_number":1009,"context_line":"    # Put config files in /etc/quantum for everyone to find"},{"line_number":1010,"context_line":"    if [[ ! -d /etc/quantum ]]; then"},{"line_number":1011,"context_line":"        sudo mkdir -p /etc/quantum"},{"line_number":1012,"context_line":"    fi"},{"line_number":1013,"context_line":"    sudo chown `whoami` /etc/quantum"}],"source_content_type":"text/x-sh","patch_set":2,"id":"AAAAHX%2F%2F7cE%3D","line":1010,"in_reply_to":"AAAAHX%2F%2F7dU%3D","updated":"2012-05-15 21:55:55.000000000","message":"yeah, I originally had a variable for this, but I thought it actually made things less readable (too many variables starting with Q_CONFIG_*\n\nIf the path ever changes (unlikely), it should be easy to do a search and replace, so I opted for clarity.  Its a pretty simple fix if this really irks anyone though :)","commit_id":"f13068089155d63fe5e4352195e24cadd5b6c17a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"22c6d199b827102ba494a62b42e109b756270b51","unresolved":false,"context_lines":[{"line_number":689,"context_line":"if is_service_enabled quantum; then"},{"line_number":690,"context_line":"    git_clone $QUANTUM_CLIENT_REPO $QUANTUM_CLIENT_DIR $QUANTUM_CLIENT_BRANCH"},{"line_number":691,"context_line":"fi"},{"line_number":692,"context_line":"if is_service_enabled quantum; then"},{"line_number":693,"context_line":"    # quantum"},{"line_number":694,"context_line":"    git_clone $QUANTUM_REPO $QUANTUM_DIR $QUANTUM_BRANCH"},{"line_number":695,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAHX%2F%2F3sY%3D","line":692,"updated":"2012-05-25 00:45:51.000000000","message":"As far as I know, quantum is for quantum client, q-svc is for quantum server. So why we change q-svc into quantum here?","commit_id":"0007f3a6151e2cfbe52760c689fde0fb3429ddce"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fbba7a4f27ec08e984bf742a199e91f4109d8351","unresolved":false,"context_lines":[{"line_number":689,"context_line":"if is_service_enabled quantum; then"},{"line_number":690,"context_line":"    git_clone $QUANTUM_CLIENT_REPO $QUANTUM_CLIENT_DIR $QUANTUM_CLIENT_BRANCH"},{"line_number":691,"context_line":"fi"},{"line_number":692,"context_line":"if is_service_enabled quantum; then"},{"line_number":693,"context_line":"    # quantum"},{"line_number":694,"context_line":"    git_clone $QUANTUM_REPO $QUANTUM_DIR $QUANTUM_BRANCH"},{"line_number":695,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAHX%2F%2F3rw%3D","line":692,"in_reply_to":"AAAAHX%2F%2F3sY%3D","updated":"2012-05-25 01:16:25.000000000","message":"Hi gongysh,  actually, they way we have been using \u0027quantum\u0027 in devstack is that it corresponds to installing the quantum python libraries and binaries, while q-svc and q-agt correspond to actually running the quantum-server or agent binaries. Thus, the string \"quantum\" is not just about the quantum client (in fact, the quantum client will be installed on all hosts, since have it installed is pretty harmless).  \n\nI believe this was modeled after some other project at the time when we first added quantum support to devstack, but I\u0027m not sure which.  \n\nHaving some capability to install the libs (particularly the client libs) without running any processes is useful, as there are cases where nova (for example) will need to use quantum libraries even if q-svc or q-agt is not running on the host.  \n\nIf we want to change the way to specify that libraries should be installed independent of running the binaries, I\u0027m open to it, but I\u0027d rather not do the changes here as this patch-set has been delayed enough already :)","commit_id":"0007f3a6151e2cfbe52760c689fde0fb3429ddce"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"22c6d199b827102ba494a62b42e109b756270b51","unresolved":false,"context_lines":[{"line_number":727,"context_line":"if is_service_enabled quantum; then"},{"line_number":728,"context_line":"    cd $QUANTUM_CLIENT_DIR; sudo python setup.py develop"},{"line_number":729,"context_line":"fi"},{"line_number":730,"context_line":"if is_service_enabled quantum; then"},{"line_number":731,"context_line":"    cd $QUANTUM_DIR; sudo python setup.py develop"},{"line_number":732,"context_line":"fi"},{"line_number":733,"context_line":"if is_service_enabled m-svc; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAHX%2F%2F3sU%3D","line":730,"updated":"2012-05-25 00:45:51.000000000","message":"same as my previous comment","commit_id":"0007f3a6151e2cfbe52760c689fde0fb3429ddce"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fbba7a4f27ec08e984bf742a199e91f4109d8351","unresolved":false,"context_lines":[{"line_number":727,"context_line":"if is_service_enabled quantum; then"},{"line_number":728,"context_line":"    cd $QUANTUM_CLIENT_DIR; sudo python setup.py develop"},{"line_number":729,"context_line":"fi"},{"line_number":730,"context_line":"if is_service_enabled quantum; then"},{"line_number":731,"context_line":"    cd $QUANTUM_DIR; sudo python setup.py develop"},{"line_number":732,"context_line":"fi"},{"line_number":733,"context_line":"if is_service_enabled m-svc; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAHX%2F%2F3rs%3D","line":730,"in_reply_to":"AAAAHX%2F%2F3sU%3D","updated":"2012-05-25 01:16:25.000000000","message":"same reply :)","commit_id":"0007f3a6151e2cfbe52760c689fde0fb3429ddce"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"22c6d199b827102ba494a62b42e109b756270b51","unresolved":false,"context_lines":[{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"# Quantum (for controller or agent nodes)"},{"line_number":1031,"context_line":"# -------"},{"line_number":1032,"context_line":"if is_service_enabled quantum; then"},{"line_number":1033,"context_line":"    # Put config files in /etc/quantum for everyone to find"},{"line_number":1034,"context_line":"    if [[ ! -d /etc/quantum ]]; then"},{"line_number":1035,"context_line":"        sudo mkdir -p /etc/quantum"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAHX%2F%2F3r4%3D","line":1032,"updated":"2012-05-25 00:45:51.000000000","message":"According to the for controller or agent nodes comments before and the contents below I think here it should be \"if is_service_enabled q-svc ||  is_service_enabled q-agt\". This way we can keep the \"quantum\" for just quantum client.","commit_id":"0007f3a6151e2cfbe52760c689fde0fb3429ddce"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"fbba7a4f27ec08e984bf742a199e91f4109d8351","unresolved":false,"context_lines":[{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"# Quantum (for controller or agent nodes)"},{"line_number":1031,"context_line":"# -------"},{"line_number":1032,"context_line":"if is_service_enabled quantum; then"},{"line_number":1033,"context_line":"    # Put config files in /etc/quantum for everyone to find"},{"line_number":1034,"context_line":"    if [[ ! -d /etc/quantum ]]; then"},{"line_number":1035,"context_line":"        sudo mkdir -p /etc/quantum"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAHX%2F%2F3rk%3D","line":1032,"in_reply_to":"AAAAHX%2F%2F3r4%3D","updated":"2012-05-25 01:16:25.000000000","message":"same :)","commit_id":"0007f3a6151e2cfbe52760c689fde0fb3429ddce"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"3f4fc82b12ee3344ad7e0ed0533cc66bbfc93c69","unresolved":false,"context_lines":[{"line_number":1273,"context_line":"    \"/dev/rtc\", \"/dev/hpet\",\"/dev/net/tun\","},{"line_number":1274,"context_line":"]"},{"line_number":1275,"context_line":"EOF"},{"line_number":1276,"context_line":"        sudo chmod 644 $QEMU_CONF"},{"line_number":1277,"context_line":"    fi"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    if [[ \"$os_PACKAGE\" \u003d \"deb\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"AAAAHX%2F%2F5%2Fo%3D","line":1276,"updated":"2012-05-19 01:04:42.000000000","message":"This line helps me! Thanks","commit_id":"0007f3a6151e2cfbe52760c689fde0fb3429ddce"}]}