)]}'
{"lib/nova":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"849ada259b878150817f85907a98b693ca86e039","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        # Force IP forwarding on, just on case"},{"line_number":255,"context_line":"        sudo sysctl -w net.ipv4.ip_forward\u003d1"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        if is_fedora \u0026\u0026 [[ $DISTRO \u003d~ f[0-9][0-9] ]] \u0026\u0026 [[\"$NOVA_ENABLE_FEDORA_VIRT_PREVIEW_REPO\" \u003d\u003d \"True\" ]]; then"},{"line_number":258,"context_line":"            # https://copr.fedorainfracloud.org/coprs/g/virtmaint-sig/virt-preview/"},{"line_number":259,"context_line":"            sudo dnf copr enable @virtmaint-sig/virt-preview"},{"line_number":260,"context_line":"            sudo dnf update -y"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_10b8de0f","line":257,"range":{"start_line":257,"start_character":56,"end_line":257,"end_character":59},"updated":"2020-01-06 17:10:10.000000000","message":"2020-01-06 14:49:33.285 | + lib/nova:configure_nova:257              :   \u0027[[True\u0027 \u003d\u003d True \u0027]]\u0027\n2020-01-06 14:49:33.287 | /opt/stack/devstack/lib/nova: line 257: [[True: command not found\n\nhttps://00a1c49e3c0449afb12b-dfb7731ce6789292a31228a6fdf28206.ssl.cf1.rackcdn.com/701231/2/experimental/devstack-platform-fedora-latest-virt-preview/5073597/controller/logs/devstacklog.txt.gz","commit_id":"6bbd48e6ba44b7f68e0eb24cf66dbd524f7b86c8"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7e2e8786f769555529ef953cc0cdfcb0a9a25214","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            sudo dnf update -y"},{"line_number":261,"context_line":"            # Ensure the updated version of libvirtd is being used."},{"line_number":262,"context_line":"            sudo systemctl restart libvirtd"},{"line_number":263,"context_line":"        fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":266,"context_line":"            # Check for kvm (hardware based virtualization).  If unable to initialize"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_c236dc01","line":263,"updated":"2020-01-27 17:20:05.000000000","message":"Should this be moved into the libvirt block just below? Otherwise we\u0027ll get a libvirt running on fedora when not using libvirt (granted the chance of that happening intentionally seems slim).\n\nPerhaps it would be even clearer in lib/nova_plugins/functions-libvirt:install_libvirt?","commit_id":"0d5a36bebd9a37bfbeef6ac985f65a40d295eed2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9f97a6ceab388b10e6dffff695eca218984e2204","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            sudo dnf update -y"},{"line_number":261,"context_line":"            # Ensure the updated version of libvirtd is being used."},{"line_number":262,"context_line":"            sudo systemctl restart libvirtd"},{"line_number":263,"context_line":"        fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":266,"context_line":"            # Check for kvm (hardware based virtualization).  If unable to initialize"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_fd27f9b3","line":263,"in_reply_to":"3fa7e38b_c236dc01","updated":"2020-01-27 17:24:40.000000000","message":"+1","commit_id":"0d5a36bebd9a37bfbeef6ac985f65a40d295eed2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e3391ae2d971023d2e7cee1934b08fb2f848e6ba","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            sudo dnf update -y"},{"line_number":261,"context_line":"            # Ensure the updated version of libvirtd is being used."},{"line_number":262,"context_line":"            sudo systemctl restart libvirtd"},{"line_number":263,"context_line":"        fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":266,"context_line":"            # Check for kvm (hardware based virtualization).  If unable to initialize"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_3d927156","line":263,"in_reply_to":"3fa7e38b_dd331dc3","updated":"2020-01-27 17:43:24.000000000","message":"\u003e Yeah apologies, I totally missed lib/nova_plugins/functions-libvirt,\n \u003e I\u0027ll add it there now.\n\nFear not, guardians of the devstaxy are here to protect the venerable code!","commit_id":"0d5a36bebd9a37bfbeef6ac985f65a40d295eed2"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"44b038bea19729625303ed3942a079102ef4c742","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            sudo dnf update -y"},{"line_number":261,"context_line":"            # Ensure the updated version of libvirtd is being used."},{"line_number":262,"context_line":"            sudo systemctl restart libvirtd"},{"line_number":263,"context_line":"        fi"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if [[ \"$VIRT_DRIVER\" \u003d \u0027libvirt\u0027 ]]; then"},{"line_number":266,"context_line":"            # Check for kvm (hardware based virtualization).  If unable to initialize"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3fa7e38b_dd331dc3","line":263,"in_reply_to":"3fa7e38b_fd27f9b3","updated":"2020-01-27 17:33:09.000000000","message":"Yeah apologies, I totally missed lib/nova_plugins/functions-libvirt, I\u0027ll add it there now.","commit_id":"0d5a36bebd9a37bfbeef6ac985f65a40d295eed2"}],"lib/nova_plugins/functions-libvirt":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"acdcb65d889e573fc86b3719a0e639bad1d9a574","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Optionally enable the virt-preview repo when on Fedora"},{"line_number":69,"context_line":"        if is_fedora \u0026\u0026 [[ $DISTRO \u003d~ f[0-9][0-9] ]] \u0026\u0026 [[ ${ENABLE_FEDORA_VIRT_PREVIEW_REPO} \u003d\u003d \"True\" ]]; then"},{"line_number":70,"context_line":"            # https://copr.fedorainfracloud.org/coprs/g/virtmaint-sig/virt-preview/"},{"line_number":71,"context_line":"            sudo dnf copr enable -y @virtmaint-sig/virt-preview"},{"line_number":72,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_9d2da5fd","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":20},"updated":"2020-01-27 17:52:15.000000000","message":"Well, this is redundant with above plus the part on the right. I would even go with just the boolean so it\u0027s easier to read. It\u0027s already pretty clear it\u0027s for fedora.","commit_id":"cfdd9241eb706becf72122c5da8621de5ccf8b4e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"276329d464fc77625823138a6eac4e73bd6a0ec2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Optionally enable the virt-preview repo when on Fedora"},{"line_number":69,"context_line":"        if is_fedora \u0026\u0026 [[ $DISTRO \u003d~ f[0-9][0-9] ]] \u0026\u0026 [[ ${ENABLE_FEDORA_VIRT_PREVIEW_REPO} \u003d\u003d \"True\" ]]; then"},{"line_number":70,"context_line":"            # https://copr.fedorainfracloud.org/coprs/g/virtmaint-sig/virt-preview/"},{"line_number":71,"context_line":"            sudo dnf copr enable -y @virtmaint-sig/virt-preview"},{"line_number":72,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_bd68a1f2","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":20},"in_reply_to":"3fa7e38b_3d86f1b8","updated":"2020-01-27 18:03:33.000000000","message":"I mean who turns on \"ENABLE_FEDORA_VIRT_PREVIEW_REPO\" to break their RHEL/CentOS or SUSE...","commit_id":"cfdd9241eb706becf72122c5da8621de5ccf8b4e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"70ba03e6482bcbb10a5e95675fdb69b33212cc63","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Optionally enable the virt-preview repo when on Fedora"},{"line_number":69,"context_line":"        if is_fedora \u0026\u0026 [[ $DISTRO \u003d~ f[0-9][0-9] ]] \u0026\u0026 [[ ${ENABLE_FEDORA_VIRT_PREVIEW_REPO} \u003d\u003d \"True\" ]]; then"},{"line_number":70,"context_line":"            # https://copr.fedorainfracloud.org/coprs/g/virtmaint-sig/virt-preview/"},{"line_number":71,"context_line":"            sudo dnf copr enable -y @virtmaint-sig/virt-preview"},{"line_number":72,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_3d86f1b8","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":20},"in_reply_to":"3fa7e38b_9d2da5fd","updated":"2020-01-27 18:02:14.000000000","message":"ACK on dropping is_fedora, the second part is actually required as is_fedora itself matches any EL derivative and this repo only works with Fedora itself:\n\nhttps://github.com/openstack/devstack/blob/761663dbfbddad4bc11d03e71e514c0f43c15668/functions-common#L442-L454","commit_id":"cfdd9241eb706becf72122c5da8621de5ccf8b4e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"00c1f66e2b4167d605cf325ed908a067f4a8f2e4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    elif is_fedora || is_suse; then"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        # Optionally enable the virt-preview repo when on Fedora"},{"line_number":69,"context_line":"        if is_fedora \u0026\u0026 [[ $DISTRO \u003d~ f[0-9][0-9] ]] \u0026\u0026 [[ ${ENABLE_FEDORA_VIRT_PREVIEW_REPO} \u003d\u003d \"True\" ]]; then"},{"line_number":70,"context_line":"            # https://copr.fedorainfracloud.org/coprs/g/virtmaint-sig/virt-preview/"},{"line_number":71,"context_line":"            sudo dnf copr enable -y @virtmaint-sig/virt-preview"},{"line_number":72,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"3fa7e38b_9d3e05e1","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":20},"in_reply_to":"3fa7e38b_bd68a1f2","updated":"2020-01-27 18:05:46.000000000","message":"Being explicit here is nice. One thing you\u0027ll often see is reusing a devstack config from one host to another and not needing to cleanup each distro specific flag simplifies this process for users.","commit_id":"cfdd9241eb706becf72122c5da8621de5ccf8b4e"}]}