)]}'
{"lib/rpc_backend":[{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"36b1944c637f16a813da4330967be5a9ba97a6e4","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            restart_service rabbitmq-server"},{"line_number":145,"context_line":"        fi"},{"line_number":146,"context_line":"        # change the rabbit password since the default is \"guest\""},{"line_number":147,"context_line":"        sudo rabbitmqctl change_password guest $RABBIT_PASSWORD"},{"line_number":148,"context_line":"        if is_service_enabled n-cell; then"},{"line_number":149,"context_line":"            # Add partitioned access for the child cell"},{"line_number":150,"context_line":"            if [ -z `sudo rabbitmqctl list_vhosts | grep child_cell` ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2BDZk%3D","side":"PARENT","line":147,"updated":"2014-01-30 16:44:23.000000000","message":"I\u0027m thinking it might be better to just put the loop around the original password change to keep from duplicating that bit.  Even though we don\u0027t seem to see this on Ubuntu I would prefer the simpler code path.","commit_id":"4b9833bca5252b50b98477c240f4be97ede71f6c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"b0ee5e1ff0e9dd760fe132eaa0ccb9feb3cb2240","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            restart_service rabbitmq-server"},{"line_number":145,"context_line":"        fi"},{"line_number":146,"context_line":"        # change the rabbit password since the default is \"guest\""},{"line_number":147,"context_line":"        sudo rabbitmqctl change_password guest $RABBIT_PASSWORD"},{"line_number":148,"context_line":"        if is_service_enabled n-cell; then"},{"line_number":149,"context_line":"            # Add partitioned access for the child cell"},{"line_number":150,"context_line":"            if [ -z `sudo rabbitmqctl list_vhosts | grep child_cell` ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2BDHo%3D","side":"PARENT","line":147,"in_reply_to":"AAAAUH%2F%2BDOc%3D","updated":"2014-01-30 17:23:17.000000000","message":"Moving the is_fedora inside the loop works for me.","commit_id":"4b9833bca5252b50b98477c240f4be97ede71f6c"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0c6dcb6a32ebfaa97ba7176e5ae4fa777b0aecde","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            restart_service rabbitmq-server"},{"line_number":145,"context_line":"        fi"},{"line_number":146,"context_line":"        # change the rabbit password since the default is \"guest\""},{"line_number":147,"context_line":"        sudo rabbitmqctl change_password guest $RABBIT_PASSWORD"},{"line_number":148,"context_line":"        if is_service_enabled n-cell; then"},{"line_number":149,"context_line":"            # Add partitioned access for the child cell"},{"line_number":150,"context_line":"            if [ -z `sudo rabbitmqctl list_vhosts | grep child_cell` ]; then"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2BDOc%3D","side":"PARENT","line":147,"in_reply_to":"AAAAUH%2F%2BDZk%3D","updated":"2014-01-30 17:14:54.000000000","message":"I tried that, but even minutes after rabbitmq first started the password change was still failing.  I had to actually restart the service to make it work, so that\u0027s why the loop is around restart.\n\nI can probably reduce the duplication by moving the is_fedora || is_suse check inside the loop and then doing the loop for all distros.  I\u0027ll give it a try and see if it cleans things up or just makes them worse. :-)","commit_id":"4b9833bca5252b50b98477c240f4be97ede71f6c"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"36b1944c637f16a813da4330967be5a9ba97a6e4","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            for i in `seq 10`; do"},{"line_number":148,"context_line":"                restart_service rabbitmq-server"},{"line_number":149,"context_line":"                sudo rabbitmqctl change_password guest $RABBIT_PASSWORD \u0026\u0026 break"},{"line_number":150,"context_line":"                sleep 10"},{"line_number":151,"context_line":"            done"},{"line_number":152,"context_line":"        else"},{"line_number":153,"context_line":"            # change the rabbit password since the default is \"guest\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2BDaM%3D","line":150,"updated":"2014-01-30 16:44:23.000000000","message":"Is the sleep necessary?  10 seconds seems like a long time especially for something that happens synchronously.","commit_id":"f612f73accdc2c155274aeb7d44b37c3dd6fed96"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0c6dcb6a32ebfaa97ba7176e5ae4fa777b0aecde","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            for i in `seq 10`; do"},{"line_number":148,"context_line":"                restart_service rabbitmq-server"},{"line_number":149,"context_line":"                sudo rabbitmqctl change_password guest $RABBIT_PASSWORD \u0026\u0026 break"},{"line_number":150,"context_line":"                sleep 10"},{"line_number":151,"context_line":"            done"},{"line_number":152,"context_line":"        else"},{"line_number":153,"context_line":"            # change the rabbit password since the default is \"guest\""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2BDQ4%3D","line":150,"in_reply_to":"AAAAUH%2F%2BDaM%3D","updated":"2014-01-30 17:14:54.000000000","message":"This was mostly because I\u0027m not sure what is causing this, so I figured I\u0027d give rabbit some time to calm down before restarting it again.  I can try without the sleep though.","commit_id":"f612f73accdc2c155274aeb7d44b37c3dd6fed96"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"36b1944c637f16a813da4330967be5a9ba97a6e4","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                restart_service rabbitmq-server"},{"line_number":149,"context_line":"                sudo rabbitmqctl change_password guest $RABBIT_PASSWORD \u0026\u0026 break"},{"line_number":150,"context_line":"                sleep 10"},{"line_number":151,"context_line":"            done"},{"line_number":152,"context_line":"        else"},{"line_number":153,"context_line":"            # change the rabbit password since the default is \"guest\""},{"line_number":154,"context_line":"            sudo rabbitmqctl change_password guest $RABBIT_PASSWORD"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2BDWE%3D","line":151,"updated":"2014-01-30 16:44:23.000000000","message":"Should we give up if the change fails after 10 tries?  Yeah it is unlikely but as long as we\u0027re here...","commit_id":"f612f73accdc2c155274aeb7d44b37c3dd6fed96"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0c6dcb6a32ebfaa97ba7176e5ae4fa777b0aecde","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                restart_service rabbitmq-server"},{"line_number":149,"context_line":"                sudo rabbitmqctl change_password guest $RABBIT_PASSWORD \u0026\u0026 break"},{"line_number":150,"context_line":"                sleep 10"},{"line_number":151,"context_line":"            done"},{"line_number":152,"context_line":"        else"},{"line_number":153,"context_line":"            # change the rabbit password since the default is \"guest\""},{"line_number":154,"context_line":"            sudo rabbitmqctl change_password guest $RABBIT_PASSWORD"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAUH%2F%2BDRs%3D","line":151,"in_reply_to":"AAAAUH%2F%2BDWE%3D","updated":"2014-01-30 17:14:54.000000000","message":"Yeah, good point.  If we didn\u0027t set the password it\u0027s just going to fail later.","commit_id":"f612f73accdc2c155274aeb7d44b37c3dd6fed96"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"6358663eabb89acba353d8aed2fa0144e06a44a2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        # NOTE(bnemec): Retry initial rabbitmq configuration to deal with"},{"line_number":143,"context_line":"        # the fact that sometimes it fails to start properly."},{"line_number":144,"context_line":"        # Reference: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1059028"},{"line_number":145,"context_line":"        for i in `seq 10`; do"},{"line_number":146,"context_line":"            if is_fedora || is_suse; then"},{"line_number":147,"context_line":"                # service is not started by default"},{"line_number":148,"context_line":"                restart_service rabbitmq-server"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAAAUH%2F96iU%3D","line":145,"updated":"2014-02-01 09:56:49.000000000","message":"nit: \n\nfor i in {1..10}; then\n\nlooks better IMO","commit_id":"ec5918f2f6ee54c3384e85866e98b67ef01e1e1e"}]}