)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"11161f8565901c5f247dcbb62faede9e61b7e0ec","unresolved":false,"context_lines":[{"line_number":14,"context_line":"IIRC we cleaned up existing VMs. While I failed to identify which commit"},{"line_number":15,"context_line":"changed this behavior, I believe it is worth recovering it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit changes unstack.sh to call cleanup_nova. cleanup_cinder()"},{"line_number":18,"context_line":"already cleans up LVM volumes and some of them may be used by VMs,"},{"line_number":19,"context_line":"so I believe it is reasonable to clean up VMs in unstack.sh."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9fcbc5105e443037fada1ef6a76a078145964256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_151fde71","line":19,"range":{"start_line":17,"start_character":53,"end_line":19,"end_character":60},"updated":"2020-01-16 04:07:08.000000000","message":"perhaps this is a bug?\n\nI thought that unstack.sh was to more or less shutdown but leave state, and that cleanup.sh actually purges it all ...\n\nBut I never do anything that isn\u0027t in a VM i just remove when I\u0027m done with it anyway, so I\u0027m not a good guide on these because I never use them.","commit_id":"85c5ec11c9526e0429163db5701d3ea8c096a324"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"184820ecf48475f3ba873f59c6c070ca8dcbe2cc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"IIRC we cleaned up existing VMs. While I failed to identify which commit"},{"line_number":15,"context_line":"changed this behavior, I believe it is worth recovering it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit changes unstack.sh to call cleanup_nova. cleanup_cinder()"},{"line_number":18,"context_line":"already cleans up LVM volumes and some of them may be used by VMs,"},{"line_number":19,"context_line":"so I believe it is reasonable to clean up VMs in unstack.sh."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9fcbc5105e443037fada1ef6a76a078145964256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_050d5b35","line":19,"range":{"start_line":17,"start_character":53,"end_line":19,"end_character":60},"in_reply_to":"3fa7e38b_07c00d2b","updated":"2020-01-17 07:59:59.000000000","message":"Totally agree that the role of unstack.sh is unclear.\n\nI have no strong reason to use unstack.sh but I use it from the following two reasons:\n- clean.sh deletes devstack log (/opt/stack/logs). I would like to keep recent devstack logs so I use unstack.sh.\n- Another reason is to skip several package installation like rabbitmq, mysql and so on, However it is not a major factor on how long stack.sh takes now, so it is a matter of taste.\n\nIn a short term, what I expect in unstack.sh is that all services works properly without digging into detail like the issue here when we do stack.sh -\u003e unstack.sh -\u003e stack.sh.\n\nIn a long term, it sounds reasonable to drop the current unstack.sh and use clean.sh for all cases.","commit_id":"85c5ec11c9526e0429163db5701d3ea8c096a324"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4d926482283e1ed4bbee14bd872e6216ff262107","unresolved":false,"context_lines":[{"line_number":14,"context_line":"IIRC we cleaned up existing VMs. While I failed to identify which commit"},{"line_number":15,"context_line":"changed this behavior, I believe it is worth recovering it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit changes unstack.sh to call cleanup_nova. cleanup_cinder()"},{"line_number":18,"context_line":"already cleans up LVM volumes and some of them may be used by VMs,"},{"line_number":19,"context_line":"so I believe it is reasonable to clean up VMs in unstack.sh."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9fcbc5105e443037fada1ef6a76a078145964256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_60e1b2cf","line":19,"range":{"start_line":17,"start_character":53,"end_line":19,"end_character":60},"in_reply_to":"3fa7e38b_151fde71","updated":"2020-01-16 05:47:00.000000000","message":"clean.sh claims to be for cleaning up after grenade runs, so having unstack.sh clean up everything that devstack does seems the right thing to do. one might argue that stack.sh in itself doesn\u0027t create any instances, though.\n\non a more general note, I think we should deprecate unstack.sh completely. we don\u0027t properly test it and if we could agree that ppl should just use throwaway instances for running devstack like we do in gate, things would get much simpler.","commit_id":"85c5ec11c9526e0429163db5701d3ea8c096a324"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"92549ae4463d8ec75708d4a1cd1e98a1f19c764b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"IIRC we cleaned up existing VMs. While I failed to identify which commit"},{"line_number":15,"context_line":"changed this behavior, I believe it is worth recovering it."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit changes unstack.sh to call cleanup_nova. cleanup_cinder()"},{"line_number":18,"context_line":"already cleans up LVM volumes and some of them may be used by VMs,"},{"line_number":19,"context_line":"so I believe it is reasonable to clean up VMs in unstack.sh."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I9fcbc5105e443037fada1ef6a76a078145964256"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_07c00d2b","line":19,"range":{"start_line":17,"start_character":53,"end_line":19,"end_character":60},"in_reply_to":"3fa7e38b_60e1b2cf","updated":"2020-01-16 15:31:05.000000000","message":"I agree. what exactly unstack.sh supposed to do is not very clear. It cleanup few resources and leave few.\n\nAs long term benefits, I agree with Jens to deprecate it and keep the single cleanup script clean.sh only.","commit_id":"85c5ec11c9526e0429163db5701d3ea8c096a324"}]}