)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"09db9ebfb16cb206a0721569fa8954408fc5bf05","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Switch to python3 for memory_peak service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When starting \u0027memory_peak\u0027 service is using python command instead of"},{"line_number":10,"context_line":"python3, while psutil (required package) is most probably being"},{"line_number":11,"context_line":"installed into the python3 environment (as we are dropping python2.7"},{"line_number":12,"context_line":"support)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa7e38b_ddd228fe","line":10,"range":{"start_line":10,"start_character":44,"end_line":10,"end_character":57},"updated":"2020-01-28 19:05:00.000000000","message":"nit: well, we are kind of sure of that ;-)","commit_id":"28909424916a761ad316ddbda7db1bea405ddf57"}],"functions-common":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1fb912ed042199f252db0ef9eb1feb5636f9bae6","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"    iniset -sudo $unitfile \"Service\" \"KillMode\" \"process\""},{"line_number":1478,"context_line":"    iniset -sudo $unitfile \"Service\" \"TimeoutStopSec\" \"300\""},{"line_number":1479,"context_line":"    iniset -sudo $unitfile \"Service\" \"ExecReload\" \"$KILL_PATH -HUP \\$MAINPID\""},{"line_number":1480,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"PYTHON\u003d${PYTHON:-python3}\""},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1483,"context_line":"        iniset -sudo $unitfile \"Service\" \"Group\" \"$group\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3fa7e38b_6a003a00","line":1480,"range":{"start_line":1480,"start_character":60,"end_line":1480,"end_character":77},"updated":"2020-01-24 09:31:14.000000000","message":"just PYTHON should work in here","commit_id":"d96fa76c809fc7f72ff31211d6b3e80e9236e109"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"641f7bd9b7b2b999da4e0020b400657769c0fd14","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"    iniset -sudo $unitfile \"Service\" \"KillMode\" \"process\""},{"line_number":1478,"context_line":"    iniset -sudo $unitfile \"Service\" \"TimeoutStopSec\" \"300\""},{"line_number":1479,"context_line":"    iniset -sudo $unitfile \"Service\" \"ExecReload\" \"$KILL_PATH -HUP \\$MAINPID\""},{"line_number":1480,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"PYTHON\u003d${PYTHON:-python3}\""},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1483,"context_line":"        iniset -sudo $unitfile \"Service\" \"Group\" \"$group\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3fa7e38b_aa0f1289","line":1480,"range":{"start_line":1480,"start_character":60,"end_line":1480,"end_character":77},"in_reply_to":"3fa7e38b_6a003a00","updated":"2020-01-24 10:06:17.000000000","message":"Done","commit_id":"d96fa76c809fc7f72ff31211d6b3e80e9236e109"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1fb912ed042199f252db0ef9eb1feb5636f9bae6","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"    iniset -sudo $unitfile \"Service\" \"Restart\" \"always\""},{"line_number":1507,"context_line":"    iniset -sudo $unitfile \"Service\" \"NotifyAccess\" \"all\""},{"line_number":1508,"context_line":"    iniset -sudo $unitfile \"Service\" \"RestartForceExitStatus\" \"100\""},{"line_number":1509,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"PYTHON\u003d${PYTHON:-python3}\""},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1512,"context_line":"        iniset -sudo $unitfile \"Service\" \"Group\" \"$group\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3fa7e38b_8a057611","line":1509,"updated":"2020-01-24 09:31:14.000000000","message":"ditto","commit_id":"d96fa76c809fc7f72ff31211d6b3e80e9236e109"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"641f7bd9b7b2b999da4e0020b400657769c0fd14","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"    iniset -sudo $unitfile \"Service\" \"Restart\" \"always\""},{"line_number":1507,"context_line":"    iniset -sudo $unitfile \"Service\" \"NotifyAccess\" \"all\""},{"line_number":1508,"context_line":"    iniset -sudo $unitfile \"Service\" \"RestartForceExitStatus\" \"100\""},{"line_number":1509,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"PYTHON\u003d${PYTHON:-python3}\""},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1512,"context_line":"        iniset -sudo $unitfile \"Service\" \"Group\" \"$group\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3fa7e38b_ca14cea1","line":1509,"in_reply_to":"3fa7e38b_8a057611","updated":"2020-01-24 10:06:17.000000000","message":"Done","commit_id":"d96fa76c809fc7f72ff31211d6b3e80e9236e109"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"47ce828eda6544aee9a933404b636e490d06264e","unresolved":false,"context_lines":[{"line_number":1477,"context_line":"    iniset -sudo $unitfile \"Service\" \"KillMode\" \"process\""},{"line_number":1478,"context_line":"    iniset -sudo $unitfile \"Service\" \"TimeoutStopSec\" \"300\""},{"line_number":1479,"context_line":"    iniset -sudo $unitfile \"Service\" \"ExecReload\" \"$KILL_PATH -HUP \\$MAINPID\""},{"line_number":1480,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"PYTHON\u003d${PYTHON}\""},{"line_number":1481,"context_line":""},{"line_number":1482,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1483,"context_line":"        iniset -sudo $unitfile \"Service\" \"Group\" \"$group\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3fa7e38b_0afc260b","line":1480,"updated":"2020-01-24 10:33:47.000000000","message":"nit: could go away without { to keep style used around","commit_id":"8cb65ac8889d9678791afa0e2b5f22ac2a03a752"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"47ce828eda6544aee9a933404b636e490d06264e","unresolved":false,"context_lines":[{"line_number":1506,"context_line":"    iniset -sudo $unitfile \"Service\" \"Restart\" \"always\""},{"line_number":1507,"context_line":"    iniset -sudo $unitfile \"Service\" \"NotifyAccess\" \"all\""},{"line_number":1508,"context_line":"    iniset -sudo $unitfile \"Service\" \"RestartForceExitStatus\" \"100\""},{"line_number":1509,"context_line":"    iniset -sudo $unitfile \"Service\" \"Environment\" \"PYTHON\u003d${PYTHON}\""},{"line_number":1510,"context_line":""},{"line_number":1511,"context_line":"    if [[ -n \"$group\" ]]; then"},{"line_number":1512,"context_line":"        iniset -sudo $unitfile \"Service\" \"Group\" \"$group\""}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3fa7e38b_a5fae30d","line":1509,"updated":"2020-01-24 10:33:47.000000000","message":"nit: ditto","commit_id":"8cb65ac8889d9678791afa0e2b5f22ac2a03a752"}],"tools/memory_tracker.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b2cb8d680c447b4e01f761f790e0751b4e8b9bb6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_2746fb23","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"updated":"2020-01-24 08:37:25.000000000","message":"I do wonder why you would need that since install_prereqs sets the correct PYTHON as the environment variable.","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"641f7bd9b7b2b999da4e0020b400657769c0fd14","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_47d3f7d3","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"in_reply_to":"3fa7e38b_2746fb23","updated":"2020-01-24 10:06:17.000000000","message":"Please have a look to below log:\n\n https://180462068c1ebb89385a-b7d34d92d3c0fa84052da2d7ba8871be.ssl.cf2.rackcdn.com/704006/1/check/tobiko-devstack-faults-centos-7/bb86790/compute1/logs/devstacklog.txt\n\nIt looks like executing below command it doesn\u0027t preserves PYTHON variable:\n\nsudo systemctl status devstack@memory_tracker.service --no-pager","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"fb9c2e2c421a46dc98811bcc81c23960c7e6d603","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_a7266b21","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"in_reply_to":"3fa7e38b_2746fb23","updated":"2020-01-24 09:05:58.000000000","message":"it looks like PYTHON variable is not picked up when starting this script as a service with below command:\n\n sudo systemctl start devstack@memory_tracker.service\n\nPlease have look to this log file:\n https://180462068c1ebb89385a-b7d34d92d3c0fa84052da2d7ba8871be.ssl.cf2.rackcdn.com/704006/1/check/tobiko-devstack-faults-centos-7/bb86790/compute1/logs/devstacklog.txt\n\nI had the same failure with Centos 7 and with Ubuntu Bionic","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b2e776ffcb488ab9cccd732373a2804f243dc357","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_1668cb1f","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"in_reply_to":"3fa7e38b_3bc4d240","updated":"2020-01-24 14:57:20.000000000","message":"Yeah, I did not mean venv per installed project. More like venv for all + venv for devstack misc stuff (if applicable). venv eliminates the distro effects. The situation might get better by itself when we move to focal and C8 where we get cleaner env for py3 and py3 only. :-)","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"47ce828eda6544aee9a933404b636e490d06264e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_65194b74","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"in_reply_to":"3fa7e38b_47d3f7d3","updated":"2020-01-24 10:33:47.000000000","message":"Ah, it looks like it is installing psutil because e.g. cinder wants it. Another case for using venv for different things or else we break each other from time to time.","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"8df624b835e2ac8ca2820c97ae70866eebf5a74a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_3bc4d240","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"in_reply_to":"3fa7e38b_65194b74","updated":"2020-01-24 13:36:35.000000000","message":"Indeed. I agree with you. But situation is not that bad until we install things using upper-requirements.txt file for pinning package versions. Please note all things we are delivering in OpenStack at the end has to coexist on the same Linux distribution with a pinned version (even if from inside a container). Therefore we have to be prepared to make scripts to work with all the same version, even if I would prefer we use a virtualenv as you suggest. I totally agree developers (an DevStack) should always test its code from inside a clean virtual environment to avoid the kind o problems derived by using conflicting versions.","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"78ff8f31edc0a9434b51722d7342770d661e8532","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3fa7e38b_877fafdc","line":17,"range":{"start_line":17,"start_character":17,"end_line":17,"end_character":24},"in_reply_to":"3fa7e38b_a7266b21","updated":"2020-01-24 09:12:57.000000000","message":"Good catch. You are right here. You sure py3 always has psutil? Cause devstack no longer install it per https://review.opendev.org/#/c/703792/\n\nI added that also on the bug report.","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1fb912ed042199f252db0ef9eb1feb5636f9bae6","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3fa7e38b_ea13ca58","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"updated":"2020-01-24 09:31:14.000000000","message":"then we could drop this altogether","commit_id":"d96fa76c809fc7f72ff31211d6b3e80e9236e109"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"641f7bd9b7b2b999da4e0020b400657769c0fd14","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"set -o errexit"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"PYTHON\u003d${PYTHON:-python3}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# time to sleep between checks"},{"line_number":20,"context_line":"SLEEP_TIME\u003d20"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3fa7e38b_8a0a5675","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":25},"in_reply_to":"3fa7e38b_ea13ca58","updated":"2020-01-24 10:06:17.000000000","message":"Done","commit_id":"d96fa76c809fc7f72ff31211d6b3e80e9236e109"}],"tools/mlock_report.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b2cb8d680c447b4e01f761f790e0751b4e8b9bb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# This tool lists processes that lock memory pages from swapping to disk."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_07b41f1c","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"updated":"2020-01-24 08:37:25.000000000","message":"not really relevant","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"faab0570f499c784e96367935483d295d0b3d2f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# This tool lists processes that lock memory pages from swapping to disk."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_672cf3ff","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":22},"in_reply_to":"3fa7e38b_07b41f1c","updated":"2020-01-24 09:07:22.000000000","message":"Done","commit_id":"5b41aa57db5bab984ea9b49f06304579ef7a590b"}]}