)]}'
{"inc/python":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e380057a85bd7830ba938c446465c3c66a499b83","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        cmd_pip\u003d$(get_pip_command $PYTHON2_VERSION)"},{"line_number":166,"context_line":"        local sudo_pip\u003d\"sudo -H\""},{"line_number":167,"context_line":"        if python3_enabled; then"},{"line_number":168,"context_line":"            # Special case some services that have experimental"},{"line_number":169,"context_line":"            # support for python3 in progress, but don\u0027t claim support"},{"line_number":170,"context_line":"            # in their classifier"},{"line_number":171,"context_line":"            echo \"Check python version for : $package_dir\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_05e5f706","side":"PARENT","line":168,"updated":"2020-01-24 10:56:39.000000000","message":"I could not see how it was relevant any longer.","commit_id":"f9a6986b90f896f2c0d122ae2572411f9c13f506"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"12419695d5e6a837ddb8015447dfc1a6f7d1c1fa","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        local cmd_pip"},{"line_number":165,"context_line":"        local sudo_pip\u003d\"sudo -H\""},{"line_number":166,"context_line":"        if python3_enabled; then"},{"line_number":167,"context_line":"            echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":168,"context_line":"            sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":169,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":170,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_45f20f9d","line":167,"updated":"2020-01-24 11:20:48.000000000","message":"Want to remove this too?","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"50757e482814579665136a3bf5838671aca707b3","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        local cmd_pip"},{"line_number":165,"context_line":"        local sudo_pip\u003d\"sudo -H\""},{"line_number":166,"context_line":"        if python3_enabled; then"},{"line_number":167,"context_line":"            echo \"Using $PYTHON3_VERSION version to install $package_dir based on default behavior\""},{"line_number":168,"context_line":"            sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":169,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":170,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_e518dbce","line":167,"in_reply_to":"3fa7e38b_45f20f9d","updated":"2020-01-24 11:31:16.000000000","message":"I guess logging does not hurt (at least it tells the truth, unlike the removed one).","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fed6d0c51e8eabc5c91592583ce48ce4ab920eb7","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":169,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":170,"context_line":"        else"},{"line_number":171,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON2_VERSION)"},{"line_number":172,"context_line":"        fi"},{"line_number":173,"context_line":"    fi"},{"line_number":174,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_05f2d769","line":171,"updated":"2020-01-24 11:41:15.000000000","message":"But Stephen does have a point in that we should also log something here, like\n\n\"Using $PYTHON2_VERSION version to install $package_dir because python3_enabled\u003dFalse\"","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b8c60ca39b7fa3ea847d3807b62d7cb917408487","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":169,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":170,"context_line":"        else"},{"line_number":171,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON2_VERSION)"},{"line_number":172,"context_line":"        fi"},{"line_number":173,"context_line":"    fi"},{"line_number":174,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_653dcbe4","line":171,"in_reply_to":"3fa7e38b_05f2d769","updated":"2020-01-24 11:45:23.000000000","message":"Makes sense.","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"205bc11a9cffa62596a5240dbbc2c9246b94aaea","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            sudo_pip\u003d\"$sudo_pip LC_ALL\u003den_US.UTF-8\""},{"line_number":169,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON3_VERSION)"},{"line_number":170,"context_line":"        else"},{"line_number":171,"context_line":"            cmd_pip\u003d$(get_pip_command $PYTHON2_VERSION)"},{"line_number":172,"context_line":"        fi"},{"line_number":173,"context_line":"    fi"},{"line_number":174,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_a0fad10d","line":171,"in_reply_to":"3fa7e38b_653dcbe4","updated":"2020-01-24 11:55:59.000000000","message":"Done","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7f6df8c734c2614aa3ebbfce9ae8c925fce0fa1d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    # FIXME(dhellmann): Need to force multiple versions of pip for"},{"line_number":180,"context_line":"    # packages like setuptools?"},{"line_number":181,"context_line":"    local pip_version"},{"line_number":182,"context_line":"    pip_version\u003d$(python -c \"import pip; \\"},{"line_number":183,"context_line":"                        print(pip.__version__.split(\u0027.\u0027)[0])\")"},{"line_number":184,"context_line":"    if (( pip_version\u003c6 )); then"},{"line_number":185,"context_line":"        die $LINENO \"Currently installed pip version ${pip_version} does not\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_a5b9837c","line":182,"range":{"start_line":182,"start_character":3,"end_line":182,"end_character":42},"updated":"2020-01-24 11:41:29.000000000","message":"This still runs python 2.7 on my local bionic VM, the import fails, and stack.sh fails.  If I experiment and s/python/python3/ here there is no longer an error and stack.sh works.","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b8c60ca39b7fa3ea847d3807b62d7cb917408487","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    # FIXME(dhellmann): Need to force multiple versions of pip for"},{"line_number":180,"context_line":"    # packages like setuptools?"},{"line_number":181,"context_line":"    local pip_version"},{"line_number":182,"context_line":"    pip_version\u003d$(python -c \"import pip; \\"},{"line_number":183,"context_line":"                        print(pip.__version__.split(\u0027.\u0027)[0])\")"},{"line_number":184,"context_line":"    if (( pip_version\u003c6 )); then"},{"line_number":185,"context_line":"        die $LINENO \"Currently installed pip version ${pip_version} does not\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_e5777bd1","line":182,"range":{"start_line":182,"start_character":3,"end_line":182,"end_character":42},"in_reply_to":"3fa7e38b_a5b9837c","updated":"2020-01-24 11:45:23.000000000","message":"Good catch. We can really remove this part as the check for minimum of 6 is looong irrelevant.","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"205bc11a9cffa62596a5240dbbc2c9246b94aaea","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    # FIXME(dhellmann): Need to force multiple versions of pip for"},{"line_number":180,"context_line":"    # packages like setuptools?"},{"line_number":181,"context_line":"    local pip_version"},{"line_number":182,"context_line":"    pip_version\u003d$(python -c \"import pip; \\"},{"line_number":183,"context_line":"                        print(pip.__version__.split(\u0027.\u0027)[0])\")"},{"line_number":184,"context_line":"    if (( pip_version\u003c6 )); then"},{"line_number":185,"context_line":"        die $LINENO \"Currently installed pip version ${pip_version} does not\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_05fc170b","line":182,"range":{"start_line":182,"start_character":3,"end_line":182,"end_character":42},"in_reply_to":"3fa7e38b_e5777bd1","updated":"2020-01-24 11:55:59.000000000","message":"Done","commit_id":"97ea7a32483883e762f6e6e5dd72a8a93021c0f0"}]}