)]}'
{"tools/fixup_stuff.sh":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9cf4b93355c2dce92f459ac2f1fba2cb1edabe48","unresolved":false,"context_lines":[{"line_number":232,"context_line":"#            install.d/pip-and-virtualenv-source-install/04-install-pip"},{"line_number":233,"context_line":"# [2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1477823"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# TODO(jh): virtualenv 20.0.1 is breaking things in a yet unknown way."},{"line_number":236,"context_line":"# Install previous virtualenv over what infra preinstalls as a hotfix."},{"line_number":237,"context_line":"function fixup_virtualenv {"},{"line_number":238,"context_line":"    if [[ ! -f /etc/ci/mirror_info.sh ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_d089e61d","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":29},"updated":"2020-02-11 14:50:12.000000000","message":"As far as I see the problem is that virtualenv requires six\u003e\u003d1.12 (which has ensure_text function), but we cap six to 1.10 in requirements in rocky)\n\nLink for the (closed) virtualenv issue: https://github.com/pypa/virtualenv/issues/1551","commit_id":"a05fc211ed8b6d265a296b4ce549cf7e685899b1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"f7a797df389e38837a1cd5a3e102caf248031038","unresolved":false,"context_lines":[{"line_number":232,"context_line":"#            install.d/pip-and-virtualenv-source-install/04-install-pip"},{"line_number":233,"context_line":"# [2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1477823"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# TODO(jh): virtualenv 20.0.1 is breaking things in a yet unknown way."},{"line_number":236,"context_line":"# Install previous virtualenv over what infra preinstalls as a hotfix."},{"line_number":237,"context_line":"function fixup_virtualenv {"},{"line_number":238,"context_line":"    if [[ ! -f /etc/ci/mirror_info.sh ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_59a6810f","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":29},"in_reply_to":"3fa7e38b_7e79e3f7","updated":"2020-02-11 16:42:55.000000000","message":"Actually, it\u0027s better (I think) to keep six\u003d\u003d1.10 and cap virtualenv, too. Just noted the cause of the issue :) Thanks again for fixing this!","commit_id":"a05fc211ed8b6d265a296b4ce549cf7e685899b1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f4d833b7feea2639cb69acee249a5e5092df04b","unresolved":false,"context_lines":[{"line_number":232,"context_line":"#            install.d/pip-and-virtualenv-source-install/04-install-pip"},{"line_number":233,"context_line":"# [2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1477823"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# TODO(jh): virtualenv 20.0.1 is breaking things in a yet unknown way."},{"line_number":236,"context_line":"# Install previous virtualenv over what infra preinstalls as a hotfix."},{"line_number":237,"context_line":"function fixup_virtualenv {"},{"line_number":238,"context_line":"    if [[ ! -f /etc/ci/mirror_info.sh ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_7e79e3f7","line":235,"range":{"start_line":235,"start_character":12,"end_line":235,"end_character":29},"in_reply_to":"3fa7e38b_d089e61d","updated":"2020-02-11 16:24:52.000000000","message":"Thanks, that is an interesting pointer. I will check with the requirements team whether we can bump that for queens and rocky, but I\u0027d still go with the current solution as quick fix to unblock gates.","commit_id":"a05fc211ed8b6d265a296b4ce549cf7e685899b1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"9cf4b93355c2dce92f459ac2f1fba2cb1edabe48","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        install_package python-virtualenv"},{"line_number":240,"context_line":"        pip_install -U --force-reinstall \u0027virtualenv\u003c20\u0027"},{"line_number":241,"context_line":"    else"},{"line_number":242,"context_line":"        pip_install -U --force-reinstall \u0027virtualenv\u003c20\u0027"},{"line_number":243,"context_line":"    fi"},{"line_number":244,"context_line":"}"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_706ef2fe","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":56},"updated":"2020-02-11 14:50:12.000000000","message":"This is both in the \u0027then\u0027 and \u0027else\u0027 branch, so simply should be outside the \u0027if\u0027.\n\nMaybe one more question: we have \u0027upper-constraints.txt:virtualenv\u003d\u003d\u003d16.0.0\u0027 in openstack/requirements (stable/rocky), shouldn\u0027t we use that instead?","commit_id":"a05fc211ed8b6d265a296b4ce549cf7e685899b1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7f4d833b7feea2639cb69acee249a5e5092df04b","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        install_package python-virtualenv"},{"line_number":240,"context_line":"        pip_install -U --force-reinstall \u0027virtualenv\u003c20\u0027"},{"line_number":241,"context_line":"    else"},{"line_number":242,"context_line":"        pip_install -U --force-reinstall \u0027virtualenv\u003c20\u0027"},{"line_number":243,"context_line":"    fi"},{"line_number":244,"context_line":"}"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3fa7e38b_7e52436c","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":56},"in_reply_to":"3fa7e38b_706ef2fe","updated":"2020-02-11 16:24:52.000000000","message":"If the six solution comes to fruit, this will get reverted, so I\u0027d rather leave this as is in order to avoid another gate cycle. I we keep this for longer, I can do a followup and amend.","commit_id":"a05fc211ed8b6d265a296b4ce549cf7e685899b1"}]}