)]}'
{"id":"openstack%2Fdevstack~70952","triplet_id":"openstack%2Fdevstack~master~Ifbdb21ac4639d86cf7775634f5b31cfb9739b49f","project":"openstack/devstack","branch":"master","topic":"trove-guest-conf-update","hashtags":[],"change_id":"Ifbdb21ac4639d86cf7775634f5b31cfb9739b49f","subject":"Remove unneeded guest conf values","status":"MERGED","created":"2014-02-04 11:01:59.000000000","updated":"2014-02-05 11:46:48.000000000","submitted":"2014-02-05 11:46:47.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6bbbfd5bf8cdbffe7c1f26fc4957df4b12ab88ce","_number":70952,"virtual_id_number":70952,"owner":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":2,"date":"2014-02-05 11:46:47.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":2,"date":"2014-02-05 08:45:36.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":1,"date":"2014-02-04 17:45:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-02-04 23:52:57.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2014-02-04 12:36:30.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":1,"date":"2014-02-05 08:45:36.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-02-04 23:52:57.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2014-02-04 11:32:42.000000000","_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-04 17:45:40.000000000","updated_by":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"reviewer":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"state":"REVIEWER"},{"updated":"2014-02-04 23:52:57.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-02-05 08:45:36.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2014-02-05 11:46:47.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7d2dbcb7dfcd972fda30b04a9c588b748612e2a6","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-02-04 11:25:18.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"17a3f8e113a3ab6073e1fc9513789351ba19ec53","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-02-04 11:32:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6ec7f71ee4468cabcbc1293f11175ad5547a9405","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2014-02-04 11:32:46.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"e3809bf2628ceac27dcdfea6d81354bd3c38e7ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-04 12:23:55.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-devstack-bash8 http://logs.openstack.org/52/70952/2/check/gate-devstack-bash8/fe8e066 : SUCCESS in 5s\n- check-devstack-dsvm-cells http://logs.openstack.org/52/70952/2/check/check-devstack-dsvm-cells/0faef82 : SUCCESS in 15m 58s\n- check-tempest-dsvm-full http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-full/f517728 : FAILURE in 4m 45s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-postgres-full/86ff880 : SUCCESS in 51m 00s\n- check-tempest-dsvm-neutron http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-neutron/398cc7a : SUCCESS in 35m 36s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/52/70952/2/check/gate-tempest-dsvm-large-ops/7c8a55c : SUCCESS in 12m 04s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/52/70952/2/check/gate-tempest-dsvm-neutron-large-ops/903f017 : SUCCESS in 11m 40s\n- check-grenade-dsvm http://logs.openstack.org/52/70952/2/check/check-grenade-dsvm/f44a915 : SUCCESS in 35m 54s\n- check-swift-dsvm-functional http://logs.openstack.org/52/70952/2/check/check-swift-dsvm-functional/c506bb5 : SUCCESS in 12m 35s\n- check-devstack-dsvm-neutron http://logs.openstack.org/52/70952/2/check/check-devstack-dsvm-neutron/80de3a4 : FAILURE in 16m 36s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-ironic-nv/9eb5028 : FAILURE in 37m 58s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-ironic-postgres-nv/3a4d64f : FAILURE in 25m 13s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"ebc92211ac9771dd950a02788f34e916fccc91e9","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-02-04 12:35:42.000000000","message":"Patch Set 2:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1253896\n- https://bugs.launchpad.net/bugs/1270382\n- https://bugs.launchpad.net/bugs/1275267\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1253896\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1253896","accounts_in_message":[],"_revision_number":2},{"id":"188a1309c7979904f8606d67431cf053d55874c1","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-02-04 12:36:30.000000000","message":"Patch Set 2:\n\nrecheck bug 1253896","accounts_in_message":[],"_revision_number":2},{"id":"99fb37d6ac166f43c4430eed011fc2a164d1e6b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-04 13:26:39.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/52/70952/2/check/gate-devstack-bash8/36e44eb : SUCCESS in 6s\n- check-devstack-dsvm-cells http://logs.openstack.org/52/70952/2/check/check-devstack-dsvm-cells/7ccab88 : SUCCESS in 9m 30s\n- check-tempest-dsvm-full http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-full/77725d8 : SUCCESS in 49m 57s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-postgres-full/82d54c9 : SUCCESS in 49m 01s\n- check-tempest-dsvm-neutron http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-neutron/3367cff : SUCCESS in 29m 17s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/52/70952/2/check/gate-tempest-dsvm-large-ops/7fe6287 : SUCCESS in 13m 35s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/52/70952/2/check/gate-tempest-dsvm-neutron-large-ops/69d18b2 : SUCCESS in 12m 45s\n- check-grenade-dsvm http://logs.openstack.org/52/70952/2/check/check-grenade-dsvm/81cb02b : SUCCESS in 29m 36s\n- check-swift-dsvm-functional http://logs.openstack.org/52/70952/2/check/check-swift-dsvm-functional/16586d1 : SUCCESS in 11m 41s\n- check-devstack-dsvm-neutron http://logs.openstack.org/52/70952/2/check/check-devstack-dsvm-neutron/e009f39 : FAILURE in 13m 39s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-ironic-nv/5e03547 : FAILURE in 26m 42s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/52/70952/2/check/check-tempest-dsvm-ironic-postgres-nv/9cfb189 : FAILURE in 19m 10s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"c13f4b82fe71c23516a9c639a8fb07a9a60b779f","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2014-02-04 17:40:09.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ef24551d53ef46886a858ea3a697daf3e18bac24","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2014-02-04 17:41:09.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\ndevstack setup doesnt use the conf.samples. Did u try running this on a _completely new_ vm and everything worked with that?\n\n - \"exchange_control\" already set in trove-guestagent.conf.sample to \"trove\";","accounts_in_message":[],"_revision_number":2},{"id":"193d28555b2694a3358e84712322253951af17bf","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2014-02-04 17:45:40.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\ndisregard previous comment. That, for some reason, is for every config file _but_ The guest configuration.","accounts_in_message":[],"_revision_number":2},{"id":"909c8182bbf379ef2f3e356dc078e94282495f3b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-02-04 23:52:57.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"e0a6119638d1b5354898b8b3ce3a67ec999b4b47","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-02-05 08:45:36.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nI see it as some cleanup code, if there is a change to do how the samples are used with the guest this may done in a followup review?","accounts_in_message":[],"_revision_number":2},{"id":"2de210663d87c7c2c17e21d37b6ad313d0b5b2de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-05 08:45:37.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"39b3f38123c6972c167eba3518cd38ea2b9079c1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-05 11:46:47.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/52/70952/2/gate/gate-devstack-bash8/241e1b5 : SUCCESS in 6s\n- gate-devstack-dsvm-cells http://logs.openstack.org/52/70952/2/gate/gate-devstack-dsvm-cells/b8111d8 : SUCCESS in 9m 56s\n- gate-tempest-dsvm-full http://logs.openstack.org/52/70952/2/gate/gate-tempest-dsvm-full/087ead3 : SUCCESS in 50m 17s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/52/70952/2/gate/gate-tempest-dsvm-postgres-full/a884356 : SUCCESS in 59m 50s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/52/70952/2/gate/gate-tempest-dsvm-neutron/5a0b4b1 : SUCCESS in 29m 15s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/52/70952/2/gate/gate-tempest-dsvm-large-ops/f2f04a1 : SUCCESS in 14m 01s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/52/70952/2/gate/gate-tempest-dsvm-neutron-large-ops/3d7bb0a : SUCCESS in 17m 00s\n- gate-grenade-dsvm http://logs.openstack.org/52/70952/2/gate/gate-grenade-dsvm/de72210 : SUCCESS in 29m 32s\n- gate-swift-dsvm-functional http://logs.openstack.org/52/70952/2/gate/gate-swift-dsvm-functional/a153722 : SUCCESS in 12m 02s\n","accounts_in_message":[],"_revision_number":2},{"id":"e6f96489bc3e7ffdf8cad7039e6bcd4986e5e76e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-05 11:46:48.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b408dd2072462f47ae294b601039c12136034e5e","revisions":{"6a25886980c1e5228e03da50c890649469c90f28":{"kind":"REWORK","_number":1,"created":"2014-02-04 11:01:59.000000000","uploader":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"ref":"refs/changes/52/70952/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/52/70952/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/70952/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/70952/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/70952/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/52/70952/1"}}},"commit":{"parents":[{"commit":"b7bdb68b6226ae9b5b19afcdbce5795ba2286827","subject":"Merge \"Disable file injection for libvirt driver\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b7bdb68b6226ae9b5b19afcdbce5795ba2286827"}]}],"author":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-02-04 10:58:59.000000000","tz":120},"committer":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-02-04 11:01:56.000000000","tz":120},"subject":"Remove unneeded guest conf values","message":"Remove unneeded guest conf values\n\nReasons:\n - guest service doesn\u0027t relays on sql_connection value any more;\n - exchange_control already set in trove-guestagent.conf.sample to \"trove\";\n\nChange-Id: Ifbdb21ac4639d86cf7775634f5b31cfb9739b49f\nCloses-Bug: #1256046\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6a25886980c1e5228e03da50c890649469c90f28"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6a25886980c1e5228e03da50c890649469c90f28"}]},"branch":"refs/heads/master"},"b408dd2072462f47ae294b601039c12136034e5e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-02-04 11:32:42.000000000","uploader":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"ref":"refs/changes/52/70952/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/52/70952/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/70952/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/70952/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/52/70952/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/52/70952/2"}}},"commit":{"parents":[{"commit":"b7bdb68b6226ae9b5b19afcdbce5795ba2286827","subject":"Merge \"Disable file injection for libvirt driver\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b7bdb68b6226ae9b5b19afcdbce5795ba2286827"}]}],"author":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-02-04 10:58:59.000000000","tz":120},"committer":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-02-04 11:32:00.000000000","tz":120},"subject":"Remove unneeded guest conf values","message":"Remove unneeded guest conf values\n\nReasons:\n - guest service doesn\u0027t depend on \"sql_connection\" value any more;\n - \"exchange_control\" already set in trove-guestagent.conf.sample to \"trove\";\n\nChange-Id: Ifbdb21ac4639d86cf7775634f5b31cfb9739b49f\nCloses-Bug: #1256046\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b408dd2072462f47ae294b601039c12136034e5e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b408dd2072462f47ae294b601039c12136034e5e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}