)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"63d4c014463d3f5eaff32b38deceaef51adf103a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"79a34463_8eed359b","updated":"2022-02-08 22:17:31.000000000","message":"Noodling on this along with a tempest change","commit_id":"56871c9cf7c134b9a0c200255e3943d1a1ce17ec"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"42204d11ffbbd2dc97efeed38e55363d826b8bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"1121734b_e8c96c21","updated":"2022-03-04 19:19:31.000000000","message":"Just rebased to master","commit_id":"197636034e84d9076ebf7b3daaab0288f9985e64"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f728bc4055a7b1a13787c62164f8708968bcc750","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"75058916_390aa88c","updated":"2022-03-29 00:25:50.000000000","message":"recheck","commit_id":"197636034e84d9076ebf7b3daaab0288f9985e64"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"43ade4ef77ced48eeb129bf164b93a6243e959bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"6adbe994_2b21ed81","updated":"2022-03-29 17:09:57.000000000","message":"I\u0027ll send out a new version of this patch soon.\n\nBut I did have one question - if we modify the devstack-ipv6 job definition to also set TUNNEL_IP_VERSION\u003d6, will that impact tempest jobs run in the stable branches? Or maybe\nthey\u0027re using the correct devstack stable/foo branch so I\u0027m just overthinking.","commit_id":"c29aaf978ce66f8683011ddaa4e856629619c3cb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ddb724d06d342393c9f2faf2486809ac2ca0ec73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"2dc30809_493c1afd","updated":"2022-03-29 16:23:25.000000000","message":"as discussed in QA meeting today[1], We have ipv6-only jobs almost in every projects and adding enw job and removing old one later will be more work. Let\u0027s enable it by default in ip6-only job and if any project is broken then they can disable it or fix. Once we enable it in existing ipv6-only job then we can send it on ML also to notify projects if they see the failure in their job.\n\n[1] https://meetings.opendev.org/meetings/qa/2022/qa.2022-03-29-15.00.log.html#l-155","commit_id":"c29aaf978ce66f8683011ddaa4e856629619c3cb"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"48ab6eafa2c0b0681ba5b4e6c9f41a8b50af5d28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"c6bc8e61_070bdc4c","in_reply_to":"6adbe994_2b21ed81","updated":"2022-03-29 17:17:23.000000000","message":"that is a good question. and you are right, they use the corrosponding devstack stable branch to pick the right job definition. As tempest job is inherited from devstack\u0027s devstack-tempest-ipv6 job and with devstack is branched the stable version of tempest job will use the devstack-tempest-ipv6 job definition from stable branch of devstack.","commit_id":"c29aaf978ce66f8683011ddaa4e856629619c3cb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0f28fbab43fea25acc66ce73f328f46318db6fc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e926cea9_486e6a2b","updated":"2022-03-30 17:59:40.000000000","message":"Neutron change testing this seems to work, at least all the single-node tests are fine: https://review.opendev.org/c/openstack/neutron/+/828634","commit_id":"0a1381a579948de6ecf5c4da9d04909065e8e131"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eba3fd6a18727cf5884ca873f197cd7b39057278","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"a6e5c743_d613d524","updated":"2022-03-31 20:09:32.000000000","message":"Had forgotten to add the long-ago bug I filed to commit message.","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d0e2e8ca138dd465539cee9723085f55243e66d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"0a7cf1f6_6fdc6444","updated":"2022-04-01 14:48:13.000000000","message":"recheck","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"117ee21dd2fd84e4292b8917dd65b9ce89ec06b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"4f2dac99_fd61a6e0","updated":"2022-05-18 09:26:31.000000000","message":"Almost +2, just a minor doc suggestion.","commit_id":"04ad8d8a10e6f35b3ef7200daefe8e1e4c321a6f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"88504361982fa475d9acf70d5f319eeecac2b8b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"fead2c3d_d97645bf","updated":"2022-05-05 16:20:55.000000000","message":"recheck\n\nHopefully I addressed all your comments Slawek.","commit_id":"04ad8d8a10e6f35b3ef7200daefe8e1e4c321a6f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e3f4977b773ad46b0e0b80764799ac2e5f12d86a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"b5ba9810_2dd75509","updated":"2022-05-19 23:04:33.000000000","message":"This last PS was just an (unnecessary) rebase to master.","commit_id":"80aed6264eb39a260bdac3d78841333269c845aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4a6b1f4c44a690c772b5888567ee5b4d6e8cdd88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6e70845f_3e09cc2b","updated":"2022-06-04 17:25:21.000000000","message":"looks good to me, let\u0027s move forward with this, this feature has been around for a long while","commit_id":"80aed6264eb39a260bdac3d78841333269c845aa"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"b4921b759542ac076081cffcda84a2b49be07449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"62d9dd07_e9a62893","updated":"2022-06-05 07:39:42.000000000","message":"recheck","commit_id":"80aed6264eb39a260bdac3d78841333269c845aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"619a46467fd4fdb33d0377c507c5280412c61f27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"23a44143_e0ba018f","updated":"2022-06-06 22:28:55.000000000","message":"recheck\n\nERROR: Could not install packages due to an OSError: [Errno 13] Permission denied: \u0027/usr/local/lib/python3.10/dist-packages/future\u0027","commit_id":"80aed6264eb39a260bdac3d78841333269c845aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"59bc2dfbebf7e962d4822e5d8f86772f48227483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"7275f25c_6b758a0d","updated":"2022-06-06 13:20:04.000000000","message":"recheck\n\nfailed configuring tempest","commit_id":"80aed6264eb39a260bdac3d78841333269c845aa"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ccbac07112c365cfb98f977005a44e43c161f185","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"17bed801_b1f250ee","updated":"2022-05-20 06:19:27.000000000","message":"thx","commit_id":"80aed6264eb39a260bdac3d78841333269c845aa"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f74813588fdecc96598819d0e3d3d14e1f4304d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"786dbddd_c730e6bd","updated":"2022-06-07 02:29:16.000000000","message":"Hoping the rebase will fix the jammy tempest issue.","commit_id":"c869d59857c636d21ecd0329023038b24252627d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"73db3c3bf6e7a55139cb1f4656c090775d443ff6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"e57e13ef_724a6c66","updated":"2022-06-07 03:18:19.000000000","message":"Looks like other devstack patches are failing the same way on jammy","commit_id":"c869d59857c636d21ecd0329023038b24252627d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"46a6af11da8d7524113e4af3b3ed7b889bbb8c64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"99745a24_7821858d","updated":"2022-06-08 16:55:40.000000000","message":"recheck\n\nsetuptools fix merged","commit_id":"c869d59857c636d21ecd0329023038b24252627d"}],"doc/source/configuration.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"  HOST_IPV6\u003d${some_local_ipv6_address}"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Tunnel Version"},{"line_number":557,"context_line":"~~~~~~~~~~~~~~"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"DevStack can enable tunnel operation over either IPv4 or IPv6 by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_efe7b5e3","line":556,"range":{"start_line":556,"start_character":0,"end_line":556,"end_character":14},"updated":"2020-02-28 20:38:12.000000000","message":"Tunnel IP Version","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a0cb78ca69ad3958ccad73d293d4217abfb88b9e","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"  HOST_IPV6\u003d${some_local_ipv6_address}"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Tunnel Version"},{"line_number":557,"context_line":"~~~~~~~~~~~~~~"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"DevStack can enable tunnel operation over either IPv4 or IPv6 by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_a9a8d576","line":556,"range":{"start_line":556,"start_character":0,"end_line":556,"end_character":14},"in_reply_to":"1fa4df85_d2937ea2","updated":"2020-02-29 17:46:01.000000000","message":"Thanks.","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a57931421bd7ce71d6f7f40107ad6669df175038","unresolved":false,"context_lines":[{"line_number":553,"context_line":""},{"line_number":554,"context_line":"  HOST_IPV6\u003d${some_local_ipv6_address}"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"Tunnel Version"},{"line_number":557,"context_line":"~~~~~~~~~~~~~~"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"DevStack can enable tunnel operation over either IPv4 or IPv6 by"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1fa4df85_d2937ea2","line":556,"range":{"start_line":556,"start_character":0,"end_line":556,"end_character":14},"in_reply_to":"1fa4df85_efe7b5e3","updated":"2020-02-28 21:31:46.000000000","message":"I\u0027ll fix Service Version above as well","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"14c58b38127723b0d3f8e3524f23e84b9c2962d8","unresolved":true,"context_lines":[{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"},{"line_number":556,"context_line":"for example, ``HOST_IPV6``."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"The default value for this setting is ``4``.  Dual-mode support, for"},{"line_number":559,"context_line":"example ``4+6`` is not currently supported."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Multi-node setup"}],"source_content_type":"text/x-rst","patch_set":23,"id":"235ba272_d8a8b204","line":558,"range":{"start_line":558,"start_character":56,"end_line":558,"end_character":63},"updated":"2022-04-20 10:35:47.000000000","message":"is that needed?","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bf2e3585e5b4175d9e0dd2f322aeb6fc5fda7541","unresolved":true,"context_lines":[{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"},{"line_number":556,"context_line":"for example, ``HOST_IPV6``."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"The default value for this setting is ``4``.  Dual-mode support, for"},{"line_number":559,"context_line":"example ``4+6`` is not currently supported."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Multi-node setup"}],"source_content_type":"text/x-rst","patch_set":23,"id":"5b5a7873_0f263a69","line":558,"range":{"start_line":558,"start_character":56,"end_line":558,"end_character":63},"in_reply_to":"1991f001_548e2e12","updated":"2022-04-25 11:49:45.000000000","message":"I think it is better to be written here","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee1376b8db035153163c77da3392016cce8bc284","unresolved":true,"context_lines":[{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"},{"line_number":556,"context_line":"for example, ``HOST_IPV6``."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"The default value for this setting is ``4``.  Dual-mode support, for"},{"line_number":559,"context_line":"example ``4+6`` is not currently supported."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Multi-node setup"}],"source_content_type":"text/x-rst","patch_set":23,"id":"1991f001_548e2e12","line":558,"range":{"start_line":558,"start_character":56,"end_line":558,"end_character":63},"in_reply_to":"235ba272_d8a8b204","updated":"2022-04-20 16:28:12.000000000","message":"No, it\u0027s not and probably can\u0027t work based on the neutron config since I think it verifies addresses are of the same family. This was a copy/paste from above, but I can remove it if I respin.","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d9101d2226cccf683c8f25aef53f6187e0ebdd33","unresolved":false,"context_lines":[{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"},{"line_number":556,"context_line":"for example, ``HOST_IPV6``."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"The default value for this setting is ``4``.  Dual-mode support, for"},{"line_number":559,"context_line":"example ``4+6`` is not currently supported."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"Multi-node setup"}],"source_content_type":"text/x-rst","patch_set":23,"id":"0c64d37b_c710a41f","line":558,"range":{"start_line":558,"start_character":56,"end_line":558,"end_character":63},"in_reply_to":"5b5a7873_0f263a69","updated":"2022-04-25 20:39:04.000000000","message":"Done","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"117ee21dd2fd84e4292b8917dd65b9ce89ec06b8","unresolved":true,"context_lines":[{"line_number":549,"context_line":"setting ``TUNNEL_IP_VERSION`` to either ``TUNNEL_IP_VERSION\u003d4`` or"},{"line_number":550,"context_line":"``TUNNEL_IP_VERSION\u003d6`` respectively."},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"When set to ``4`` neutron will use an IPv4 address for tunnel endpoints,"},{"line_number":553,"context_line":"for example, ``HOST_IP``."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"}],"source_content_type":"text/x-rst","patch_set":24,"id":"460e8423_d5632ab3","line":552,"range":{"start_line":552,"start_character":18,"end_line":552,"end_character":25},"updated":"2022-05-18 09:26:31.000000000","message":"nit: Neutron?","commit_id":"04ad8d8a10e6f35b3ef7200daefe8e1e4c321a6f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e639546fd3e3a86e2b3ef98dc9c1234c21e8248","unresolved":false,"context_lines":[{"line_number":549,"context_line":"setting ``TUNNEL_IP_VERSION`` to either ``TUNNEL_IP_VERSION\u003d4`` or"},{"line_number":550,"context_line":"``TUNNEL_IP_VERSION\u003d6`` respectively."},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"When set to ``4`` neutron will use an IPv4 address for tunnel endpoints,"},{"line_number":553,"context_line":"for example, ``HOST_IP``."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"}],"source_content_type":"text/x-rst","patch_set":24,"id":"d1272b8e_563b9dcf","line":552,"range":{"start_line":552,"start_character":18,"end_line":552,"end_character":25},"in_reply_to":"460e8423_d5632ab3","updated":"2022-05-19 01:27:20.000000000","message":"Done","commit_id":"04ad8d8a10e6f35b3ef7200daefe8e1e4c321a6f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"117ee21dd2fd84e4292b8917dd65b9ce89ec06b8","unresolved":true,"context_lines":[{"line_number":553,"context_line":"for example, ``HOST_IP``."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"},{"line_number":556,"context_line":"for example, ``HOST_IPV6``."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"The default value for this setting is ``4``.  Dual-mode support, for"},{"line_number":559,"context_line":"example ``4+6`` is not supported, as this value must match the address"}],"source_content_type":"text/x-rst","patch_set":24,"id":"3c9ca72e_abc14684","line":556,"updated":"2022-05-18 09:26:31.000000000","message":"Can you mention TUNNEL_ENDPOINT_IP here and clarify that HOST_IP/HOST_IPV6 are the default values for it?","commit_id":"04ad8d8a10e6f35b3ef7200daefe8e1e4c321a6f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e639546fd3e3a86e2b3ef98dc9c1234c21e8248","unresolved":false,"context_lines":[{"line_number":553,"context_line":"for example, ``HOST_IP``."},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"When set to ``6`` neutron will use an IPv6 address for tunnel endpoints,"},{"line_number":556,"context_line":"for example, ``HOST_IPV6``."},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"The default value for this setting is ``4``.  Dual-mode support, for"},{"line_number":559,"context_line":"example ``4+6`` is not supported, as this value must match the address"}],"source_content_type":"text/x-rst","patch_set":24,"id":"8f07187b_924c8179","line":556,"in_reply_to":"3c9ca72e_abc14684","updated":"2022-05-19 01:27:20.000000000","message":"Done","commit_id":"04ad8d8a10e6f35b3ef7200daefe8e1e4c321a6f"}],"lib/neutron":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# When Neutron tunnels are enabled it is needed to specify the"},{"line_number":92,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_afcc5d6a","line":93,"range":{"start_line":93,"start_character":45,"end_line":93,"end_character":52},"updated":"2020-02-28 20:38:12.000000000","message":"not exactly true","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a0cb78ca69ad3958ccad73d293d4217abfb88b9e","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# When Neutron tunnels are enabled it is needed to specify the"},{"line_number":92,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_89add989","line":93,"range":{"start_line":93,"start_character":45,"end_line":93,"end_character":52},"in_reply_to":"1fa4df85_72c08a7c","updated":"2020-02-29 17:46:01.000000000","message":"I mean, it could default to IPv6 one. But I see what you mean - \"the default default\" is IPv4 ;-)","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a57931421bd7ce71d6f7f40107ad6669df175038","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# When Neutron tunnels are enabled it is needed to specify the"},{"line_number":92,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_72c08a7c","line":93,"range":{"start_line":93,"start_character":45,"end_line":93,"end_character":52},"in_reply_to":"1fa4df85_afcc5d6a","updated":"2020-02-28 21:31:46.000000000","message":"Based on L256 and L260 it is, I must be missing something?","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"# When Neutron tunnels are enabled it is needed to specify the"},{"line_number":92,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":97,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_2fde2d11","line":94,"updated":"2020-02-28 20:38:12.000000000","message":"I would copy example from -legacy too","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a57931421bd7ce71d6f7f40107ad6669df175038","unresolved":false,"context_lines":[{"line_number":91,"context_line":"# When Neutron tunnels are enabled it is needed to specify the"},{"line_number":92,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":97,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_52d78e24","line":94,"in_reply_to":"1fa4df85_2fde2d11","updated":"2020-02-28 21:31:46.000000000","message":"Done","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":97,"context_line":"else"},{"line_number":98,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_0f04917a","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":26},"updated":"2020-02-28 20:38:12.000000000","message":"TUNNEL_IP_VERSION?","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a57931421bd7ce71d6f7f40107ad6669df175038","unresolved":false,"context_lines":[{"line_number":92,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":97,"context_line":"else"},{"line_number":98,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_92e2e62e","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":26},"in_reply_to":"1fa4df85_0f04917a","updated":"2020-02-28 21:31:46.000000000","message":"Hah, this all worked since I was always setting SERVICE_IP_VERSION\u003d6 too","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":97,"context_line":"else"},{"line_number":98,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"},{"line_number":99,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_4f936950","line":96,"range":{"start_line":96,"start_character":4,"end_line":96,"end_character":13},"updated":"2020-02-28 20:38:12.000000000","message":"DEFAULT_TUNNEL_ENDPOINT_IP?","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a57931421bd7ce71d6f7f40107ad6669df175038","unresolved":false,"context_lines":[{"line_number":93,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":94,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":97,"context_line":"else"},{"line_number":98,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"},{"line_number":99,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_92fe66ac","line":96,"range":{"start_line":96,"start_character":4,"end_line":96,"end_character":13},"in_reply_to":"1fa4df85_4f936950","updated":"2020-02-28 21:31:46.000000000","message":"Done","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":95,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":96,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":97,"context_line":"else"},{"line_number":98,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"},{"line_number":99,"context_line":"fi"},{"line_number":100,"context_line":"TUNNEL_ENDPOINT_IP\u003d${TUNNEL_ENDPOINT_IP:-$TUNNEL_IP}"},{"line_number":101,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_ef99f56d","line":98,"range":{"start_line":98,"start_character":4,"end_line":98,"end_character":13},"updated":"2020-02-28 20:38:12.000000000","message":"ditto","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":97,"context_line":"else"},{"line_number":98,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"},{"line_number":99,"context_line":"fi"},{"line_number":100,"context_line":"TUNNEL_ENDPOINT_IP\u003d${TUNNEL_ENDPOINT_IP:-$TUNNEL_IP}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"NEUTRON_AUTH_STRATEGY\u003d${NEUTRON_AUTH_STRATEGY:-keystone}"},{"line_number":103,"context_line":"NEUTRON_ROOTWRAP\u003d$(get_rootwrap_location neutron)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_0f9d7158","line":100,"range":{"start_line":100,"start_character":42,"end_line":100,"end_character":51},"updated":"2020-02-28 20:38:12.000000000","message":"ditto","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"}],"lib/neutron-legacy":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"# When Neutron tunnels are enabled it is needed to specify the"},{"line_number":242,"context_line":"# IP address of the end point in the local server. This IP is set"},{"line_number":243,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":244,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":245,"context_line":"# Example: ``TUNNEL_ENDPOINT_IP\u003d1.1.1.1``"},{"line_number":246,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_4fe129d0","line":243,"range":{"start_line":243,"start_character":45,"end_line":243,"end_character":52},"updated":"2020-02-28 20:38:12.000000000","message":"ditto","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":244,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":245,"context_line":"# Example: ``TUNNEL_ENDPOINT_IP\u003d1.1.1.1``"},{"line_number":246,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":247,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":248,"context_line":"else"},{"line_number":249,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"},{"line_number":250,"context_line":"fi"},{"line_number":251,"context_line":"TUNNEL_ENDPOINT_IP\u003d${TUNNEL_ENDPOINT_IP:-$TUNNEL_IP}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"# With the openvswitch plugin, set to True in ``localrc`` to enable"},{"line_number":254,"context_line":"# provider GRE tunnels when ``ENABLE_TENANT_TUNNELS`` is False."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_cf9e7953","line":251,"range":{"start_line":246,"start_character":0,"end_line":251,"end_character":52},"updated":"2020-02-28 20:38:12.000000000","message":"dittos","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a57931421bd7ce71d6f7f40107ad6669df175038","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# by default to the same IP address that the HOST IP."},{"line_number":244,"context_line":"# This variable can be used to specify a different end point IP address"},{"line_number":245,"context_line":"# Example: ``TUNNEL_ENDPOINT_IP\u003d1.1.1.1``"},{"line_number":246,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 4]]; then"},{"line_number":247,"context_line":"    TUNNEL_IP\u003d$HOST_IP"},{"line_number":248,"context_line":"else"},{"line_number":249,"context_line":"    TUNNEL_IP\u003d$HOST_IPV6"},{"line_number":250,"context_line":"fi"},{"line_number":251,"context_line":"TUNNEL_ENDPOINT_IP\u003d${TUNNEL_ENDPOINT_IP:-$TUNNEL_IP}"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"# With the openvswitch plugin, set to True in ``localrc`` to enable"},{"line_number":254,"context_line":"# provider GRE tunnels when ``ENABLE_TENANT_TUNNELS`` is False."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_921746ee","line":251,"range":{"start_line":246,"start_character":0,"end_line":251,"end_character":52},"in_reply_to":"1fa4df85_cf9e7953","updated":"2020-02-28 21:31:46.000000000","message":"Done","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"}],"stackrc":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c13aab68f2c2e6f7f763e7ebe3a8f221bd598de5","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    die $LINENO \"TUNNEL_IP_VERSION must be either 4 or 6\""},{"line_number":906,"context_line":"fi"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 4 ]]; then"},{"line_number":909,"context_line":"    DEF_TUNNEL_HOST\u003d$HOST_IP"},{"line_number":910,"context_line":"fi"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":913,"context_line":"    if [ \"$HOST_IPV6\" \u003d\u003d \"\" ]; then"},{"line_number":914,"context_line":"        die $LINENO \"Could not determine host IPv6 address.  See local.conf for suggestions on setting HOST_IPV6.\""},{"line_number":915,"context_line":"    fi"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    DEF_TUNNEL_HOST\u003d[$HOST_IPV6]"},{"line_number":918,"context_line":"fi"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"# Allow the use of an alternate address for tunnel endpoints."},{"line_number":921,"context_line":"# Default is dependent on TUNNEL_IP_VERSION above."},{"line_number":922,"context_line":"TUNNEL_HOST\u003d${TUNNEL_HOST:-${DEF_TUNNEL_HOST}}"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"REGION_NAME\u003d${REGION_NAME:-RegionOne}"},{"line_number":925,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_0f39f13f","line":922,"range":{"start_line":908,"start_character":0,"end_line":922,"end_character":46},"updated":"2020-02-28 20:38:12.000000000","message":"unused? (except for extra die)\n\nThe remaining bits might be better off in neutron and -legacy (that said, we should get rid of -legacy finally... :D ).","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a57931421bd7ce71d6f7f40107ad6669df175038","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    die $LINENO \"TUNNEL_IP_VERSION must be either 4 or 6\""},{"line_number":906,"context_line":"fi"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 4 ]]; then"},{"line_number":909,"context_line":"    DEF_TUNNEL_HOST\u003d$HOST_IP"},{"line_number":910,"context_line":"fi"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":913,"context_line":"    if [ \"$HOST_IPV6\" \u003d\u003d \"\" ]; then"},{"line_number":914,"context_line":"        die $LINENO \"Could not determine host IPv6 address.  See local.conf for suggestions on setting HOST_IPV6.\""},{"line_number":915,"context_line":"    fi"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    DEF_TUNNEL_HOST\u003d[$HOST_IPV6]"},{"line_number":918,"context_line":"fi"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"# Allow the use of an alternate address for tunnel endpoints."},{"line_number":921,"context_line":"# Default is dependent on TUNNEL_IP_VERSION above."},{"line_number":922,"context_line":"TUNNEL_HOST\u003d${TUNNEL_HOST:-${DEF_TUNNEL_HOST}}"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"REGION_NAME\u003d${REGION_NAME:-RegionOne}"},{"line_number":925,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_b27e0217","line":922,"range":{"start_line":908,"start_character":0,"end_line":922,"end_character":46},"in_reply_to":"1fa4df85_0f39f13f","updated":"2020-02-28 21:31:46.000000000","message":"Sigh, this must have been and old version, I could have sworn I did all the heavy lifting here and just had neutron/neutron-legacy use it.  Friday.  I\u0027ll send an update but need to test it again next week.","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a0cb78ca69ad3958ccad73d293d4217abfb88b9e","unresolved":false,"context_lines":[{"line_number":905,"context_line":"    die $LINENO \"TUNNEL_IP_VERSION must be either 4 or 6\""},{"line_number":906,"context_line":"fi"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 4 ]]; then"},{"line_number":909,"context_line":"    DEF_TUNNEL_HOST\u003d$HOST_IP"},{"line_number":910,"context_line":"fi"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":913,"context_line":"    if [ \"$HOST_IPV6\" \u003d\u003d \"\" ]; then"},{"line_number":914,"context_line":"        die $LINENO \"Could not determine host IPv6 address.  See local.conf for suggestions on setting HOST_IPV6.\""},{"line_number":915,"context_line":"    fi"},{"line_number":916,"context_line":""},{"line_number":917,"context_line":"    DEF_TUNNEL_HOST\u003d[$HOST_IPV6]"},{"line_number":918,"context_line":"fi"},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"# Allow the use of an alternate address for tunnel endpoints."},{"line_number":921,"context_line":"# Default is dependent on TUNNEL_IP_VERSION above."},{"line_number":922,"context_line":"TUNNEL_HOST\u003d${TUNNEL_HOST:-${DEF_TUNNEL_HOST}}"},{"line_number":923,"context_line":""},{"line_number":924,"context_line":"REGION_NAME\u003d${REGION_NAME:-RegionOne}"},{"line_number":925,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1fa4df85_09b329ec","line":922,"range":{"start_line":908,"start_character":0,"end_line":922,"end_character":46},"in_reply_to":"1fa4df85_b27e0217","updated":"2020-02-29 17:46:01.000000000","message":"Ack.\nIt would probably be best for this code to live in one place (possibly shared between \"new\" and \"legacy\"), but not everywhere.","commit_id":"587295bf80f6d501dd45e5f9762d399029a4bc6b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"14c58b38127723b0d3f8e3524f23e84b9c2962d8","unresolved":true,"context_lines":[{"line_number":884,"context_line":""},{"line_number":885,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":886,"context_line":"    if [ \"$HOST_IPV6\" \u003d\u003d \"\" ]; then"},{"line_number":887,"context_line":"        die $LINENO \"Could not determine host IPv6 address.  See local.conf for suggestions on setting HOST_IPV6.\""},{"line_number":888,"context_line":"    fi"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    DEF_TUNNEL_ENDPOINT_IP\u003d$HOST_IPV6"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"5d091821_5082ea02","line":887,"updated":"2022-04-20 10:35:47.000000000","message":"do we want to die here even if TUNNEL_ENDPOINT_IP is actually set manually by user?","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ee1376b8db035153163c77da3392016cce8bc284","unresolved":true,"context_lines":[{"line_number":884,"context_line":""},{"line_number":885,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":886,"context_line":"    if [ \"$HOST_IPV6\" \u003d\u003d \"\" ]; then"},{"line_number":887,"context_line":"        die $LINENO \"Could not determine host IPv6 address.  See local.conf for suggestions on setting HOST_IPV6.\""},{"line_number":888,"context_line":"    fi"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    DEF_TUNNEL_ENDPOINT_IP\u003d$HOST_IPV6"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"70b5807e_3c462e61","line":887,"in_reply_to":"5d091821_5082ea02","updated":"2022-04-20 16:28:12.000000000","message":"I think we do, since wouldn\u0027t it be detecting an invalid config? Hmm, or maybe your question is about the user specifying mis-matched values for TUNNEL_IP_VERSION and TUNNEL_ENDPOINT_IP? And we should die in that case? I think the code I added to the verification script will exit in that case so maybe this code is fine, but I could be wrong.\n\nAlso, this was a copy/paste from L854 above which does a similar thing for SERVICE_IP_VERSION.","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d9101d2226cccf683c8f25aef53f6187e0ebdd33","unresolved":false,"context_lines":[{"line_number":884,"context_line":""},{"line_number":885,"context_line":"if [[ \"$TUNNEL_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":886,"context_line":"    if [ \"$HOST_IPV6\" \u003d\u003d \"\" ]; then"},{"line_number":887,"context_line":"        die $LINENO \"Could not determine host IPv6 address.  See local.conf for suggestions on setting HOST_IPV6.\""},{"line_number":888,"context_line":"    fi"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"    DEF_TUNNEL_ENDPOINT_IP\u003d$HOST_IPV6"}],"source_content_type":"application/x-shellscript","patch_set":23,"id":"79a5e5f3_e46f90d6","line":887,"in_reply_to":"70b5807e_3c462e61","updated":"2022-04-25 20:39:04.000000000","message":"I\u0027ll tweak this a little too.","commit_id":"4d49f3f573d8c6ffe91ffae30cdc3a80b2b828d8"}]}