)]}'
{"id":"openstack%2Fdevstack~713700","triplet_id":"openstack%2Fdevstack~master~Ifd26152899d68ac8f8f7fc0621b1f2b49416a847","project":"openstack/devstack","branch":"master","hashtags":[],"change_id":"Ifd26152899d68ac8f8f7fc0621b1f2b49416a847","subject":"Restart only the DB service if the installer runs in localhost","status":"ABANDONED","created":"2020-03-18 17:04:14.000000000","updated":"2020-03-18 20:46:06.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c398138f34277daf6ff2f506966b4438e0f62b0c","_number":713700,"virtual_id_number":713700,"owner":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-03-18 20:28:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"date":"2020-03-18 20:27:44.000000000","_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-03-18 17:50:32.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},{"value":-1,"date":"2020-03-18 19:38:53.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-18 17:50:32.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-03-18 19:38:53.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2020-03-18 20:28:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"88e56aa9ef50e6ce6a12e6f3df6a2ead4d949f71","author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"date":"2020-03-18 17:04:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"afba8e25fba268683a074b8b8233e2973a25d5f1","author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"date":"2020-03-18 17:37:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b9a790806e9fbb13db528df3cfdfc1328a7f754a","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-03-18 17:50:32.000000000","message":"Patch Set 2: Code-Review-1\n\nall database engine deployment code should be disabled in such a case, this smells hacky","accounts_in_message":[],"_revision_number":2},{"id":"e611a23e4ea2bfc7dada90a0925c919a00fc505d","author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"date":"2020-03-18 18:04:46.000000000","message":"Patch Set 2:\n\nYeah, the problem is that if we remove mysql from the enabled services list, then we wont create/populate the databases.\n\nThe problem is this service restart, which IMHO is unneeded. As it\u0027s not mandatory to do a full database engine restart.\n\n@radoslaw, do you think we can remove the service restart?","accounts_in_message":[],"_revision_number":2},{"id":"baa49391afea23e9807b4b1a1b7254a86a575342","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-03-18 19:31:02.000000000","message":"Patch Set 2:\n\n\u003e Yeah, the problem is that if we remove mysql from the enabled\n \u003e services list, then we wont create/populate the databases.\n\nWhat\u0027s the usecase for this? Are you trying to skip this on the primary nodes?\n\nI don\u0027t see this happening when we deploy on subnodes.\n\nhttps://zuul.opendev.org/t/openstack/build/daabc75c8992406f8a089a808c2553b9/log/logs/subnode-2/devstacklog.txt\nhttps://zuul.opendev.org/t/openstack/build/daabc75c8992406f8a089a808c2553b9/log/logs/subnode-2/local.conf.txt#24\n\n \u003e The problem is this service restart, which IMHO is unneeded. As\n \u003e it\u0027s not mandatory to do a full database engine restart.\n \u003e \n \u003e @radoslaw, do you think we can remove the service restart?","accounts_in_message":[],"_revision_number":2},{"id":"2650a3465eac71beec8c61773dce732b804dee1f","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2020-03-18 19:38:53.000000000","message":"Patch Set 2: Code-Review-1","accounts_in_message":[],"_revision_number":2},{"id":"911518183c62c8d172c7c5eba55599a88c0bbc52","author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"date":"2020-03-18 19:46:31.000000000","message":"Patch Set 2:\n\n@Lee Yarwood thanks for the feedback. So the specific use case for this is that we are deploying Devstack part of the upstream CI for os-migrate[1]. In this case, we install Devstack with some services in a container, and the database must be located in a different container with lets say a different IP/FQDN but the container running the actual stack.sh fails because the mysql service is not installed locally.\n\n\n\n[1]: https://github.com/os-migrate/os-migrate","accounts_in_message":[],"_revision_number":2},{"id":"8f6822172b96fdd4aa675d56703d6116d0793c3b","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-03-18 20:00:02.000000000","message":"Patch Set 2:\n\nCarlos, you have actually answered yourself - there should be separate logic for \u0027configure db engine for me\u0027 and \u0027set the databases up for me\u0027.","accounts_in_message":[],"_revision_number":2},{"id":"fd0b7cd6bb31c894d59ee1b9b5d477e4a5c5a7d1","author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"date":"2020-03-18 20:08:16.000000000","message":"Patch Set 2:\n\n@Radosław is this something documented somewhere? Like, using an external DB for Devstack? I know I can skip it from the configured services list, but the install fails as the database is not setup correctly.","accounts_in_message":[],"_revision_number":2},{"id":"19bc943310b64d1ee48f5e4ba9b65de9fa57aa82","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-03-18 20:21:41.000000000","message":"Patch Set 2:\n\nCarlos, none I\u0027m aware of. I meant devstack might not have been designed with this in mind as it\u0027s meant more for throw-away environments.","accounts_in_message":[],"_revision_number":2},{"id":"8f5e8862e3ee3b99b42b56df6d15dc1fee9aa2b9","author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"date":"2020-03-18 20:27:44.000000000","message":"Patch Set 2:\n\nack, throw-away environments is what we do, only that the mysql is living now in a different container :) I can mock a system service called mysql to trick the stack.sh in any case I just believed this might be a cleaner solution.","accounts_in_message":[],"_revision_number":2},{"id":"359df3707d0a810d4d6e88034461f192b31d0f6a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-18 20:28:33.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/460e48dc1af64a2b81ca804d6f1f5986 : SUCCESS in 1h 01m 01s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f67fc00176654401bc4e53a5cd69ab70 : SUCCESS in 1h 32m 02s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4cc9ddd8c88442dda6b8bfd977f8ca65 : SUCCESS in 5m 01s\n- devstack https://zuul.opendev.org/t/openstack/build/c0cd43bf49974a579081212846de29fd : SUCCESS in 27m 28s\n- devstack-ipv6 https://zuul.opendev.org/t/openstack/build/417b02bde6134b9b9e02b730ef2b7d0a : FAILURE in 14m 33s\n- devstack-platform-opensuse-15 https://zuul.opendev.org/t/openstack/build/4d51a83bfc4e4c838dd8b763d4e5c7a3 : FAILURE in 13m 12s (non-voting)\n- devstack-platform-fedora-latest https://zuul.opendev.org/t/openstack/build/d0220ce85fac4fc8bb40ba31e7193259 : RETRY_LIMIT in 6m 05s (non-voting)\n- devstack-multinode https://zuul.opendev.org/t/openstack/build/965460e662f540e2b42c83e008bc2750 : SUCCESS in 38m 44s\n- devstack-unit-tests https://zuul.opendev.org/t/openstack/build/fa3d7d0c78f44a048717ae2d7288a150 : SUCCESS in 4m 15s\n- openstack-tox-bashate https://zuul.opendev.org/t/openstack/build/72d6367d1aff4c61b94ba999c98e6454 : SUCCESS in 3m 18s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/656266435626454ea7840c8404ad52ff : FAILURE in 45m 27s (non-voting)\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a1fb6caa8f164988b8ef9cdcb6bd7bc8 : SUCCESS in 28m 30s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/ab03e4ae91fd4277b560968ec8f6fd08 : SUCCESS in 1h 09m 48s\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/e6ba5c21e59a430cbb5c4ba87a08b4b1 : SUCCESS in 1h 02m 54s\n- tempest-multinode-full-py3 https://zuul.opendev.org/t/openstack/build/7dd8226e89094792b7b9304dd6f17f27 : FAILURE in 2h 32m 46s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/b2f26a3fad9c43feaad334e73f9f363e : SUCCESS in 56m 14s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/66716adf6e874d379f062bd3370c3fd7 : FAILURE in 23m 54s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/b8c645b5d1d94b779c2439a2562c78bf : SUCCESS in 55m 05s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c398138f34277daf6ff2f506966b4438e0f62b0c","author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"date":"2020-03-18 20:46:06.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ea6a7ee4f8548959126d4b826221eeef4246cb39","revisions":{"7eb06c80ff9f01840f99ac0e24f377c9935798b0":{"kind":"REWORK","_number":1,"created":"2020-03-18 17:04:14.000000000","uploader":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"ref":"refs/changes/00/713700/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/00/713700/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/713700/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/713700/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/713700/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/00/713700/1"}}},"commit":{"parents":[{"commit":"5ae8a3504ce0619eda5fceaa638b01ba123e5e14","subject":"Drop DEVSTACK_GATE_FEATURE_MATRIX","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5ae8a3504ce0619eda5fceaa638b01ba123e5e14"}]}],"author":{"name":"Carlos Camacho","email":"ccamacho@redhat.com","date":"2020-03-18 17:02:55.000000000","tz":60},"committer":{"name":"Carlos Camacho","email":"ccamacho@redhat.com","date":"2020-03-18 17:04:12.000000000","tz":60},"subject":"Restart only the DB service if the installer runs in localhost","message":"Restart only the DB service if the installer runs in localhost\n\nIf the DB location is a remote site restarting the service\nfrom the installer will fail as there is no actual\ndatabase server available.\n\nChange-Id: Ifd26152899d68ac8f8f7fc0621b1f2b49416a847\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7eb06c80ff9f01840f99ac0e24f377c9935798b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/7eb06c80ff9f01840f99ac0e24f377c9935798b0"}]},"branch":"refs/heads/master"},"ea6a7ee4f8548959126d4b826221eeef4246cb39":{"kind":"REWORK","_number":2,"created":"2020-03-18 17:37:17.000000000","uploader":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"ref":"refs/changes/00/713700/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/00/713700/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/713700/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/713700/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/00/713700/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/00/713700/2"}}},"commit":{"parents":[{"commit":"5ae8a3504ce0619eda5fceaa638b01ba123e5e14","subject":"Drop DEVSTACK_GATE_FEATURE_MATRIX","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5ae8a3504ce0619eda5fceaa638b01ba123e5e14"}]}],"author":{"name":"Carlos Camacho","email":"ccamacho@redhat.com","date":"2020-03-18 17:02:55.000000000","tz":60},"committer":{"name":"Carlos Camacho","email":"ccamacho@redhat.com","date":"2020-03-18 17:37:15.000000000","tz":60},"subject":"Restart only the DB service if the installer runs in localhost","message":"Restart only the DB service if the installer runs in localhost\n\nIf the DB location is a remote site restarting the service\nfrom the installer will fail as there is no actual\ndatabase server available.\n\nChange-Id: Ifd26152899d68ac8f8f7fc0621b1f2b49416a847\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ea6a7ee4f8548959126d4b826221eeef4246cb39"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/ea6a7ee4f8548959126d4b826221eeef4246cb39"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}