)]}'
{"lib/swift":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"00f50b6ffb52f5917ef350c30f2ea77b7056e5a8","unresolved":false,"context_lines":[{"line_number":540,"context_line":"            --internalurl \"http://$SERVICE_HOST:8080/v1/AUTH_\\$(tenant_id)s\""},{"line_number":541,"context_line":"    fi"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    # Defines specific passwords used by tools/create_userrc.sh"},{"line_number":544,"context_line":"    SWIFTUSERTEST1_PASSWORD\u003dtesting"},{"line_number":545,"context_line":"    SWIFTUSERTEST2_PASSWORD\u003dtesting2"},{"line_number":546,"context_line":"    SWIFTUSERTEST3_PASSWORD\u003dtesting3"}],"source_content_type":"text/x-swift","patch_set":5,"id":"AAAAUX%2F%2Fhk4%3D","line":543,"updated":"2014-02-12 15:56:53.000000000","message":"shouldn\u0027t be at the top of the function instead ?","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"}],"tools/create_userrc.sh":[{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"00f50b6ffb52f5917ef350c30f2ea77b7056e5a8","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # Checks for a specific password defined for an user."},{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                             JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            SPECIFIC_UPASSWORD\u003d\"\\$$(echo $USER_NAME| tr \u0027[:lower:]\u0027 \u0027[:upper:]\u0027)_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ] \u0026\u0026 [ ! \"$SPECIFIC_UPASSWORD\" \u003d \"\\$_PASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUX%2F%2Fhlw%3D","line":260,"updated":"2014-02-12 15:56:53.000000000","message":"I think the syntax looks a bit weird to me, what about :\n\nSPECIFIC_PASSWORD\u003d${USER_NAME^^}_PASSWORD\n\n(^^ upper case in bash)","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"2ae1721af1f048dcb7de1f733fd3085bc939e9e1","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # Checks for a specific password defined for an user."},{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                             JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            SPECIFIC_UPASSWORD\u003d\"\\$$(echo $USER_NAME| tr \u0027[:lower:]\u0027 \u0027[:upper:]\u0027)_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ] \u0026\u0026 [ ! \"$SPECIFIC_UPASSWORD\" \u003d \"\\$_PASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUX%2F%2FhVs%3D","line":260,"in_reply_to":"AAAAUX%2F%2Fhhw%3D","updated":"2014-02-12 16:21:31.000000000","message":"I don\u0027t think we (devstack) run on any distros that are not using bash4, if you really want to do the tr dance then  you don\u0027t need all those double quotes and backslash dollar","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f72a49481b620c44ab1fd6bcafe23ec797413a69","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # Checks for a specific password defined for an user."},{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                             JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            SPECIFIC_UPASSWORD\u003d\"\\$$(echo $USER_NAME| tr \u0027[:lower:]\u0027 \u0027[:upper:]\u0027)_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ] \u0026\u0026 [ ! \"$SPECIFIC_UPASSWORD\" \u003d \"\\$_PASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUX%2F%2Fhhw%3D","line":260,"in_reply_to":"AAAAUX%2F%2Fhlw%3D","updated":"2014-02-12 16:14:32.000000000","message":"This syntax is not supported by all version of bash","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"00f50b6ffb52f5917ef350c30f2ea77b7056e5a8","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                             JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            SPECIFIC_UPASSWORD\u003d\"\\$$(echo $USER_NAME| tr \u0027[:lower:]\u0027 \u0027[:upper:]\u0027)_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ] \u0026\u0026 [ ! \"$SPECIFIC_UPASSWORD\" \u003d \"\\$_PASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"},{"line_number":264,"context_line":"            add_entry \"$user_id\" \"$user_name\" \"$tenant_id\" \"$tenant_name\" \"$USER_PASS\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUX%2F%2FhlQ%3D","line":261,"updated":"2014-02-12 15:56:53.000000000","message":"why do you backslash _PASSWORD? and i think the comparaison like that :\n\n\u0026\u0026\u0026 [ $SPECIFIC_UPASSWORD !\u003d \"\\$_PASSWORD\" ]\n\nmake more sense.","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f72a49481b620c44ab1fd6bcafe23ec797413a69","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                             JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            SPECIFIC_UPASSWORD\u003d\"\\$$(echo $USER_NAME| tr \u0027[:lower:]\u0027 \u0027[:upper:]\u0027)_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ] \u0026\u0026 [ ! \"$SPECIFIC_UPASSWORD\" \u003d \"\\$_PASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"},{"line_number":264,"context_line":"            add_entry \"$user_id\" \"$user_name\" \"$tenant_id\" \"$tenant_name\" \"$USER_PASS\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUX%2F%2FhYQ%3D","line":261,"in_reply_to":"AAAAUX%2F%2FhkE%3D","updated":"2014-02-12 16:14:32.000000000","message":"Done","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"16853a03dcdcf6391bd27cd6df78606d1762b510","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                             JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            SPECIFIC_UPASSWORD\u003d\"\\$$(echo $USER_NAME| tr \u0027[:lower:]\u0027 \u0027[:upper:]\u0027)_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ] \u0026\u0026 [ ! \"$SPECIFIC_UPASSWORD\" \u003d \"\\$_PASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"},{"line_number":264,"context_line":"            add_entry \"$user_id\" \"$user_name\" \"$tenant_id\" \"$tenant_name\" \"$USER_PASS\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUX%2F%2FhkE%3D","line":261,"in_reply_to":"AAAAUX%2F%2FhlQ%3D","updated":"2014-02-12 15:57:25.000000000","message":"I mean just two \u0026\u0026","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f72a49481b620c44ab1fd6bcafe23ec797413a69","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                             JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            SPECIFIC_UPASSWORD\u003d\"\\$$(echo $USER_NAME| tr \u0027[:lower:]\u0027 \u0027[:upper:]\u0027)_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ] \u0026\u0026 [ ! \"$SPECIFIC_UPASSWORD\" \u003d \"\\$_PASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"},{"line_number":264,"context_line":"            add_entry \"$user_id\" \"$user_name\" \"$tenant_id\" \"$tenant_name\" \"$USER_PASS\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"AAAAUX%2F%2FhYc%3D","line":261,"in_reply_to":"AAAAUX%2F%2FhlQ%3D","updated":"2014-02-12 16:14:32.000000000","message":"yes your are right... I made a mistake.","commit_id":"ba697cd4358ce704768550ec0427af1680e66778"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"661eb202860a7571c4c6c275460da234580a3d97","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # Checks for a specific password defined for an user."},{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                     JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            eval SPECIFIC_UPASSWORD\u003d\"\\$${USER_NAME^^}_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAUX%2F%2FhLU%3D","line":260,"updated":"2014-02-12 16:33:53.000000000","message":"looks more readable, thanks for your reviews Chmouel :)","commit_id":"36c4d7116f51e97c2b91dda87f6646f53f7b4115"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bc4d7a0bdda092f18ea177d9818f28290e679804","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            #                     JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            eval SPECIFIC_UPASSWORD\u003d\"\\$${USER_NAME^^}_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ]; then"},{"line_number":262,"context_line":"                $USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"},{"line_number":264,"context_line":"            add_entry \"$user_id\" \"$user_name\" \"$tenant_id\" \"$tenant_name\" \"$USER_PASS\""},{"line_number":265,"context_line":"        done"}],"source_content_type":"text/x-sh","patch_set":6,"id":"AAAAUX%2F%2FhKQ%3D","line":262,"updated":"2014-02-12 16:35:19.000000000","message":"I made a mistake, I\u0027m going to push a new patch","commit_id":"36c4d7116f51e97c2b91dda87f6646f53f7b4115"},{"author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"change_message_id":"d670eab5ee221a264c91347b478e27a9964e9f38","unresolved":false,"context_lines":[{"line_number":257,"context_line":"            # Checks for a specific password defined for an user."},{"line_number":258,"context_line":"            # Example for an username johndoe:"},{"line_number":259,"context_line":"            #                     JOHNDOE_PASSWORD\u003d1234"},{"line_number":260,"context_line":"            eval SPECIFIC_UPASSWORD\u003d\"\\$${USER_NAME^^}_PASSWORD\""},{"line_number":261,"context_line":"            if [ -n \"$SPECIFIC_UPASSWORD\" ]; then"},{"line_number":262,"context_line":"                USER_PASS\u003d$SPECIFIC_UPASSWORD"},{"line_number":263,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"AAAAUX%2F%2Fg%2B0%3D","line":260,"updated":"2014-02-12 16:50:07.000000000","message":"cool thanks for make it more readable, \n\nI think the eval thing is a bourne shell (i.e: not bash) antic, these days we can use indirections with bash (since version 2) like :\n\nSPECIFIC_PASSWORD\u003d${!TENANT_1_PASSWORD}\n\n(which would get the value of TENANT_1_PASSWORD)\n\nbut I could not figure out how to make it work here in this context and this look good enough for me so i\u0027ll stop nitpicking ;)\n\nthanks for fixing that, this has been annoying since the day I started to grep for ERROR in devstack logs.","commit_id":"1814e671d3af0231aa18a08d3406d54332f9b4ef"}]}