)]}'
{"lib/nova_plugins/hypervisor-ironic":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b1da923a3448ce7d5b22dce60d93830828502aec","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if [[ \"$IRONIC_VM_LOG_CONSOLE\" \u003d\u003d \"True\" ]] \u0026\u0026 is_ubuntu; then"},{"line_number":72,"context_line":"        # Ubuntu packaging+apparmor issue prevents libvirt from loading"},{"line_number":73,"context_line":"        # the ROM from /usr/share/misc.  Workaround by installing it directly"},{"line_number":74,"context_line":"        # to a directory that it can read from. (LP: #1393548)"},{"line_number":75,"context_line":"        # NOTE(rpittau) we need to do this only if /usr/share/qemu/sgabios.bin"},{"line_number":76,"context_line":"        # is a symlink. In recent distributions (e.g. Ubuntu 20.04) this is"},{"line_number":77,"context_line":"        # an actual file."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff570b3c_3fe2af02","line":74,"range":{"start_line":74,"start_character":54,"end_line":74,"end_character":61},"updated":"2020-05-25 09:04:10.000000000","message":"That bug is resolved since a couple of years, are you really sure that this workaround is still needed?\n\nIn /etc/apparmor.d/abstractions/libvirt-qemu there\u0027s:\n/usr/share/misc/sgabios.bin r","commit_id":"6de1c8775a6d73b802b69f866e30ce57c0e2f1ec"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"ea388dc180625c61a4d49790127bcd0c0fca2a57","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if [[ \"$IRONIC_VM_LOG_CONSOLE\" \u003d\u003d \"True\" ]] \u0026\u0026 is_ubuntu; then"},{"line_number":72,"context_line":"        # Ubuntu packaging+apparmor issue prevents libvirt from loading"},{"line_number":73,"context_line":"        # the ROM from /usr/share/misc.  Workaround by installing it directly"},{"line_number":74,"context_line":"        # to a directory that it can read from. (LP: #1393548)"},{"line_number":75,"context_line":"        # NOTE(rpittau) we need to do this only if /usr/share/qemu/sgabios.bin"},{"line_number":76,"context_line":"        # is a symlink. In recent distributions (e.g. Ubuntu 20.04) this is"},{"line_number":77,"context_line":"        # an actual file."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff570b3c_aa495b61","line":74,"range":{"start_line":74,"start_character":54,"end_line":74,"end_character":61},"in_reply_to":"ff570b3c_3f68ef1f","updated":"2020-05-25 09:49:13.000000000","message":"Apologies, I didn\u0027t realize the bug was closed since a while :/\nI will just remove it","commit_id":"6de1c8775a6d73b802b69f866e30ce57c0e2f1ec"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3cbbd737e00cfeefb80d6fc7dc90bb92714fd586","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if [[ \"$IRONIC_VM_LOG_CONSOLE\" \u003d\u003d \"True\" ]] \u0026\u0026 is_ubuntu; then"},{"line_number":72,"context_line":"        # Ubuntu packaging+apparmor issue prevents libvirt from loading"},{"line_number":73,"context_line":"        # the ROM from /usr/share/misc.  Workaround by installing it directly"},{"line_number":74,"context_line":"        # to a directory that it can read from. (LP: #1393548)"},{"line_number":75,"context_line":"        # NOTE(rpittau) we need to do this only if /usr/share/qemu/sgabios.bin"},{"line_number":76,"context_line":"        # is a symlink. In recent distributions (e.g. Ubuntu 20.04) this is"},{"line_number":77,"context_line":"        # an actual file."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff570b3c_5fcfa356","line":74,"range":{"start_line":74,"start_character":54,"end_line":74,"end_character":61},"in_reply_to":"ff570b3c_3fe2af02","updated":"2020-05-25 09:17:32.000000000","message":"You\u0027re right, it seems the workaround is actually not needed in the end.\nI\u0027m more than happy to convert the patch and just remove it at this point.","commit_id":"6de1c8775a6d73b802b69f866e30ce57c0e2f1ec"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bff50edcc0f63e15ddd14609a485452b6fd886bc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    if [[ \"$IRONIC_VM_LOG_CONSOLE\" \u003d\u003d \"True\" ]] \u0026\u0026 is_ubuntu; then"},{"line_number":72,"context_line":"        # Ubuntu packaging+apparmor issue prevents libvirt from loading"},{"line_number":73,"context_line":"        # the ROM from /usr/share/misc.  Workaround by installing it directly"},{"line_number":74,"context_line":"        # to a directory that it can read from. (LP: #1393548)"},{"line_number":75,"context_line":"        # NOTE(rpittau) we need to do this only if /usr/share/qemu/sgabios.bin"},{"line_number":76,"context_line":"        # is a symlink. In recent distributions (e.g. Ubuntu 20.04) this is"},{"line_number":77,"context_line":"        # an actual file."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff570b3c_3f68ef1f","line":74,"range":{"start_line":74,"start_character":54,"end_line":74,"end_character":61},"in_reply_to":"ff570b3c_5fcfa356","updated":"2020-05-25 09:24:42.000000000","message":"Oh, you sounded pretty sure it is required the last time I asked. ;p You know my opinion - remove. :D","commit_id":"6de1c8775a6d73b802b69f866e30ce57c0e2f1ec"}]}
