)]}'
{".zuul.yaml":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3067b3f42f57b31151c53ad796be9e08abf2e1c4","unresolved":false,"context_lines":[{"line_number":466,"context_line":"          placement-client: true"},{"line_number":467,"context_line":"          # OVN services"},{"line_number":468,"context_line":"          ovn-controller: true"},{"line_number":469,"context_line":"          ovn-northd: false"},{"line_number":470,"context_line":"          ovs-vswitchd: true"},{"line_number":471,"context_line":"          ovsdb-server: true"},{"line_number":472,"context_line":"          # Neutron services"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_de4cea9f","line":469,"range":{"start_line":469,"start_character":22,"end_line":469,"end_character":27},"updated":"2020-07-09 09:51:15.000000000","message":"Why is this false?","commit_id":"d979ad2dc649f460b7e59b86222be17976f53b52"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7d0e087fdd8e7df5410d2744c459529aaf0f071d","unresolved":false,"context_lines":[{"line_number":466,"context_line":"          placement-client: true"},{"line_number":467,"context_line":"          # OVN services"},{"line_number":468,"context_line":"          ovn-controller: true"},{"line_number":469,"context_line":"          ovn-northd: false"},{"line_number":470,"context_line":"          ovs-vswitchd: true"},{"line_number":471,"context_line":"          ovsdb-server: true"},{"line_number":472,"context_line":"          # Neutron services"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_f40f4d85","line":469,"range":{"start_line":469,"start_character":22,"end_line":469,"end_character":27},"in_reply_to":"bf51134e_54cc3969","updated":"2020-07-09 11:07:41.000000000","message":"Ah, I swear I checked that before asking this question :) My apologies, thanks for clarification.","commit_id":"d979ad2dc649f460b7e59b86222be17976f53b52"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e310499fb7eb7da0bff15abfefa4704458c31f9","unresolved":false,"context_lines":[{"line_number":466,"context_line":"          placement-client: true"},{"line_number":467,"context_line":"          # OVN services"},{"line_number":468,"context_line":"          ovn-controller: true"},{"line_number":469,"context_line":"          ovn-northd: false"},{"line_number":470,"context_line":"          ovs-vswitchd: true"},{"line_number":471,"context_line":"          ovsdb-server: true"},{"line_number":472,"context_line":"          # Neutron services"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bf51134e_54cc3969","line":469,"range":{"start_line":469,"start_character":22,"end_line":469,"end_character":27},"in_reply_to":"bf51134e_de4cea9f","updated":"2020-07-09 11:01:56.000000000","message":"This is the configuration for the compute node","commit_id":"d979ad2dc649f460b7e59b86222be17976f53b52"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"558b5a82d754158ded2cf8da1608fad273da32b1","unresolved":true,"context_lines":[{"line_number":558,"context_line":"          ovs-vswitchd: true"},{"line_number":559,"context_line":"          ovsdb-server: true"},{"line_number":560,"context_line":"          # Neutron services"},{"line_number":561,"context_line":"          q-fake: true"},{"line_number":562,"context_line":"          q-svc: false"},{"line_number":563,"context_line":"          q-agt: false"},{"line_number":564,"context_line":"          q-dhcp: false"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"3ed28139_a929daee","line":561,"range":{"start_line":561,"start_character":10,"end_line":561,"end_character":22},"updated":"2021-01-09 09:08:02.000000000","message":"what is this for?","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea3610abe33972a9ade910b755ee1c4988432534","unresolved":true,"context_lines":[{"line_number":558,"context_line":"          ovs-vswitchd: true"},{"line_number":559,"context_line":"          ovsdb-server: true"},{"line_number":560,"context_line":"          # Neutron services"},{"line_number":561,"context_line":"          q-fake: true"},{"line_number":562,"context_line":"          q-svc: false"},{"line_number":563,"context_line":"          q-agt: false"},{"line_number":564,"context_line":"          q-dhcp: false"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"170a8240_d7681a85","line":561,"range":{"start_line":561,"start_character":10,"end_line":561,"end_character":22},"in_reply_to":"3ed28139_a929daee","updated":"2021-01-11 09:48:10.000000000","message":"Ops, this seems to be a troubleshoot that I did in the gate or something, q-fake is not a valid service... Sorry for that, I will remove it.","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"558b5a82d754158ded2cf8da1608fad273da32b1","unresolved":true,"context_lines":[{"line_number":580,"context_line":"          # ceilometer-*: false"},{"line_number":581,"context_line":"        devstack_localrc:"},{"line_number":582,"context_line":"          ENABLE_CHASSIS_AS_GW: false"},{"line_number":583,"context_line":"          Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":584,"context_line":"          PHYSICAL_NETWORK: public"},{"line_number":585,"context_line":"          # Subnode specific settings"},{"line_number":586,"context_line":"          GLANCE_HOSTPORT: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:9292\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"c2bfdbeb_7a89d13e","line":583,"range":{"start_line":583,"start_character":10,"end_line":583,"end_character":44},"updated":"2021-01-09 09:08:02.000000000","message":"this is already set above for all the hosts","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea3610abe33972a9ade910b755ee1c4988432534","unresolved":true,"context_lines":[{"line_number":580,"context_line":"          # ceilometer-*: false"},{"line_number":581,"context_line":"        devstack_localrc:"},{"line_number":582,"context_line":"          ENABLE_CHASSIS_AS_GW: false"},{"line_number":583,"context_line":"          Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":584,"context_line":"          PHYSICAL_NETWORK: public"},{"line_number":585,"context_line":"          # Subnode specific settings"},{"line_number":586,"context_line":"          GLANCE_HOSTPORT: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:9292\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"b787be29_f58dae15","line":583,"range":{"start_line":583,"start_character":10,"end_line":583,"end_character":44},"in_reply_to":"c2bfdbeb_7a89d13e","updated":"2021-01-11 09:48:10.000000000","message":"Ah, great I will remove it.","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"558b5a82d754158ded2cf8da1608fad273da32b1","unresolved":true,"context_lines":[{"line_number":581,"context_line":"        devstack_localrc:"},{"line_number":582,"context_line":"          ENABLE_CHASSIS_AS_GW: false"},{"line_number":583,"context_line":"          Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":584,"context_line":"          PHYSICAL_NETWORK: public"},{"line_number":585,"context_line":"          # Subnode specific settings"},{"line_number":586,"context_line":"          GLANCE_HOSTPORT: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:9292\""},{"line_number":587,"context_line":"          Q_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"cc028bca_2df7d7c3","line":584,"range":{"start_line":584,"start_character":10,"end_line":584,"end_character":34},"updated":"2021-01-09 09:08:02.000000000","message":"why is this only on the subnode?","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea3610abe33972a9ade910b755ee1c4988432534","unresolved":true,"context_lines":[{"line_number":581,"context_line":"        devstack_localrc:"},{"line_number":582,"context_line":"          ENABLE_CHASSIS_AS_GW: false"},{"line_number":583,"context_line":"          Q_USE_PROVIDERNET_FOR_PUBLIC: true"},{"line_number":584,"context_line":"          PHYSICAL_NETWORK: public"},{"line_number":585,"context_line":"          # Subnode specific settings"},{"line_number":586,"context_line":"          GLANCE_HOSTPORT: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}:9292\""},{"line_number":587,"context_line":"          Q_HOST: \"{{ hostvars[\u0027controller\u0027][\u0027nodepool\u0027][\u0027private_ipv4\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"c4f13647_c386ef5a","line":584,"range":{"start_line":584,"start_character":10,"end_line":584,"end_character":34},"in_reply_to":"cc028bca_2df7d7c3","updated":"2021-01-11 09:48:10.000000000","message":"Just like the Q_USER_PROVIDERNET... above, the default value of this variable in devstack is already public [0]. I will remove it.\n\nI added it cause that\u0027s also defined in the templates for the OVN jobs in Neutron but it\u0027s redundant.\n\n[0] https://github.com/openstack/devstack/blob/0d2d6f93f6bebaa05588d1c3b65184f99d8a1bb4/lib/neutron-legacy#L217","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8dcd1e04b0b4cced6e291c086f6514411b78fc86","unresolved":true,"context_lines":[{"line_number":510,"context_line":"        ovs-vswitchd: true"},{"line_number":511,"context_line":"        ovsdb-server: true"},{"line_number":512,"context_line":"        # Neutron services"},{"line_number":513,"context_line":"        q-agt: false"},{"line_number":514,"context_line":"        q-dhcp: false"},{"line_number":515,"context_line":"        q-l3: false"},{"line_number":516,"context_line":"        q-meta: false"},{"line_number":517,"context_line":"        q-metering: false"},{"line_number":518,"context_line":"        q-svc: true"},{"line_number":519,"context_line":"        q-ovn-metadata-agent: true"},{"line_number":520,"context_line":"        # Swift services"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"e29caee1_7b25ef2e","line":517,"range":{"start_line":513,"start_character":0,"end_line":517,"end_character":25},"updated":"2021-05-10 13:38:28.000000000","message":"I suggest we drop these","commit_id":"ade0277b10064aa5f5091cec8ecc7834039a7b47"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8dcd1e04b0b4cced6e291c086f6514411b78fc86","unresolved":true,"context_lines":[{"line_number":558,"context_line":"          ovs-vswitchd: true"},{"line_number":559,"context_line":"          ovsdb-server: true"},{"line_number":560,"context_line":"          # Neutron services"},{"line_number":561,"context_line":"          q-svc: false"},{"line_number":562,"context_line":"          q-agt: false"},{"line_number":563,"context_line":"          q-dhcp: false"},{"line_number":564,"context_line":"          q-l3: false"},{"line_number":565,"context_line":"          q-meta: false"},{"line_number":566,"context_line":"          q-metering: false"},{"line_number":567,"context_line":"          q-ovn-metadata-agent: true"},{"line_number":568,"context_line":"          # Cinder services"},{"line_number":569,"context_line":"          c-bak: true"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"3525f8a3_5b69aef3","line":566,"range":{"start_line":561,"start_character":0,"end_line":566,"end_character":27},"updated":"2021-05-10 13:38:28.000000000","message":"ditto, especially let\u0027s not add them if they were not there already","commit_id":"ade0277b10064aa5f5091cec8ecc7834039a7b47"}],"lib/neutron_plugins/ml2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"558b5a82d754158ded2cf8da1608fad273da32b1","unresolved":true,"context_lines":[{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# List of MechanismDrivers to load"},{"line_number":27,"context_line":"Q_ML2_PLUGIN_MECHANISM_DRIVERS\u003d${Q_ML2_PLUGIN_MECHANISM_DRIVERS:-ovn,logger}"},{"line_number":28,"context_line":"# Default GRE TypeDriver options"},{"line_number":29,"context_line":"Q_ML2_PLUGIN_GRE_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_GRE_TYPE_OPTIONS:-tunnel_id_ranges\u003d$TENANT_TUNNEL_RANGES}"},{"line_number":30,"context_line":"# Default VXLAN TypeDriver options"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"35645b8d_f24a07cd","line":27,"range":{"start_line":27,"start_character":68,"end_line":27,"end_character":75},"updated":"2021-01-09 09:08:02.000000000","message":"this seems way extra","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3b43f4c56706ea247a71f3527f2bae9bb704105c","unresolved":true,"context_lines":[{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# List of MechanismDrivers to load"},{"line_number":27,"context_line":"Q_ML2_PLUGIN_MECHANISM_DRIVERS\u003d${Q_ML2_PLUGIN_MECHANISM_DRIVERS:-ovn,logger}"},{"line_number":28,"context_line":"# Default GRE TypeDriver options"},{"line_number":29,"context_line":"Q_ML2_PLUGIN_GRE_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_GRE_TYPE_OPTIONS:-tunnel_id_ranges\u003d$TENANT_TUNNEL_RANGES}"},{"line_number":30,"context_line":"# Default VXLAN TypeDriver options"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"484b4fd9_6c46376b","line":27,"range":{"start_line":27,"start_character":68,"end_line":27,"end_character":75},"in_reply_to":"35645b8d_f24a07cd","updated":"2021-01-11 17:49:43.000000000","message":"Thanks for addressing the other comments! What about this one?","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a9c60054075570631b9a8ffcd713f25bddf2e1f5","unresolved":true,"context_lines":[{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# List of MechanismDrivers to load"},{"line_number":27,"context_line":"Q_ML2_PLUGIN_MECHANISM_DRIVERS\u003d${Q_ML2_PLUGIN_MECHANISM_DRIVERS:-ovn,logger}"},{"line_number":28,"context_line":"# Default GRE TypeDriver options"},{"line_number":29,"context_line":"Q_ML2_PLUGIN_GRE_TYPE_OPTIONS\u003d${Q_ML2_PLUGIN_GRE_TYPE_OPTIONS:-tunnel_id_ranges\u003d$TENANT_TUNNEL_RANGES}"},{"line_number":30,"context_line":"# Default VXLAN TypeDriver options"}],"source_content_type":"application/x-shellscript","patch_set":33,"id":"ff9bb706_19723713","line":27,"range":{"start_line":27,"start_character":68,"end_line":27,"end_character":75},"in_reply_to":"484b4fd9_6c46376b","updated":"2021-01-15 09:24:32.000000000","message":"Ops I am sorry, I totally overlooked this. Yeah this can probably be removed as well, the reason why I set it is because that\u0027s also set in our templates in Neutron [0][1].\n\nI will remove it in the next patch-set.\n\n[0] https://github.com/openstack/neutron/blob/ab1e5fb0dd2ab4aa3bd83320f5d49888324cb84b/zuul.d/tempest-singlenode.yaml#L305\n[1] https://github.com/openstack/neutron/blob/ab1e5fb0dd2ab4aa3bd83320f5d49888324cb84b/zuul.d/tempest-multinode.yaml#L175","commit_id":"34e1b0a0730d8a3ac04490888fff6b106e5d1db1"}]}