)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c0f20453bec6b5a8e89c30c923c40f81312dfa7","unresolved":true,"context_lines":[{"line_number":12,"context_line":"the public site."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Drop all KEYSTONE_AUTH_* variables except KEYSTONE_AUTH_URI which may"},{"line_number":15,"context_line":"still be in use in some plugins."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also allows to finally drop the fixup_keystone() function."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"42813780_fd17e90e","line":15,"updated":"2021-10-25 17:28:31.000000000","message":"need to patch blazar though as it uses others:\nhttps://opendev.org/openstack/blazar/src/commit/949c52dba434d6888b14c35c4db687118f0c74e0/devstack/plugin.sh#L34\nand further down this file","commit_id":"c2491bac9d3b3f0446e67b4ea960cb88da9aec0e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7897434b0bf1ab9d401a356c3b8a769b63db20ad","unresolved":true,"context_lines":[{"line_number":12,"context_line":"the public site."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Drop all KEYSTONE_AUTH_* variables except KEYSTONE_AUTH_URI which may"},{"line_number":15,"context_line":"still be in use in some plugins."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This also allows to finally drop the fixup_keystone() function."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"31698e82_0b923475","line":15,"in_reply_to":"42813780_fd17e90e","updated":"2021-10-25 17:56:14.000000000","message":"That looks pretty broken, I\u0027ll need to take a closer look.","commit_id":"c2491bac9d3b3f0446e67b4ea960cb88da9aec0e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"da86b788145e32de1cc6bf7d0cd917e156b7261a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"20509435_2bac2ab2","updated":"2021-10-25 17:38:47.000000000","message":"CC\u0027ing blazar\u0027s PTL to at least inform about possible disruption","commit_id":"c2491bac9d3b3f0446e67b4ea960cb88da9aec0e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"0da43b194f2f02293f60c404f99b590a3ed464aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4f7c69f3_b3e6e782","updated":"2021-11-03 08:17:43.000000000","message":"lgtm, this can break some consumers (those who don\u0027t have the public alternative var set - see f.e. https://codesearch.opendev.org/?q\u003dKEYSTONE_AUTH_HOST\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003d), however, the change on their side is easy - replace admin configuration by public one - e.g. KEYSTONE_AUTH_HOST -\u003e KEYSTONE_SERVICE_HOST ","commit_id":"c2491bac9d3b3f0446e67b4ea960cb88da9aec0e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"851a977b64d6e4f268df2bf7f74f6265b2cc3204","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"750700d2_6681e1ff","updated":"2021-10-25 17:29:56.000000000","message":"would be nice to get this cleaned up in kolla too 😊","commit_id":"c2491bac9d3b3f0446e67b4ea960cb88da9aec0e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7897434b0bf1ab9d401a356c3b8a769b63db20ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"539e2764_91c1eaaa","in_reply_to":"750700d2_6681e1ff","updated":"2021-10-25 17:56:14.000000000","message":"The first step would likely be to stop creating admin endpoints for all other services, I was going to bring that up in one of the next weeklies ;)","commit_id":"c2491bac9d3b3f0446e67b4ea960cb88da9aec0e"}],"lib/keystone":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c0f20453bec6b5a8e89c30c923c40f81312dfa7","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        sudo rm -f $(apache_site_config_for keystone)"},{"line_number":155,"context_line":"    else"},{"line_number":156,"context_line":"        stop_process \"keystone\""},{"line_number":157,"context_line":"        # TODO: remove admin at pike-2"},{"line_number":158,"context_line":"        remove_uwsgi_config \"$KEYSTONE_PUBLIC_UWSGI_CONF\" \"$KEYSTONE_PUBLIC_UWSGI\""},{"line_number":159,"context_line":"        remove_uwsgi_config \"$KEYSTONE_ADMIN_UWSGI_CONF\" \"$KEYSTONE_ADMIN_UWSGI\""},{"line_number":160,"context_line":"        sudo rm -f $(apache_site_config_for keystone-wsgi-public)"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"f2b2dd7d_85c3193d","side":"PARENT","line":157,"range":{"start_line":157,"start_character":32,"end_line":157,"end_character":38},"updated":"2021-10-25 17:28:31.000000000","message":"yeah, right! 😄","commit_id":"c027ddd3f895802f5cab37d2cb04162686a3a3cb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c0f20453bec6b5a8e89c30c923c40f81312dfa7","unresolved":true,"context_lines":[{"line_number":567,"context_line":"# This function uses the following GLOBAL variables:"},{"line_number":568,"context_line":"# - ``KEYSTONE_BIN_DIR``"},{"line_number":569,"context_line":"# - ``ADMIN_PASSWORD``"},{"line_number":570,"context_line":"# - ``IDENTITY_API_VERSION``"},{"line_number":571,"context_line":"# - ``REGION_NAME``"},{"line_number":572,"context_line":"# - ``KEYSTONE_SERVICE_PROTOCOL``"},{"line_number":573,"context_line":"# - ``KEYSTONE_SERVICE_HOST``"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"0bceabca_1397592b","side":"PARENT","line":570,"range":{"start_line":570,"start_character":6,"end_line":570,"end_character":26},"updated":"2021-10-25 17:28:31.000000000","message":"nope, can be removed","commit_id":"c027ddd3f895802f5cab37d2cb04162686a3a3cb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7897434b0bf1ab9d401a356c3b8a769b63db20ad","unresolved":true,"context_lines":[{"line_number":567,"context_line":"# This function uses the following GLOBAL variables:"},{"line_number":568,"context_line":"# - ``KEYSTONE_BIN_DIR``"},{"line_number":569,"context_line":"# - ``ADMIN_PASSWORD``"},{"line_number":570,"context_line":"# - ``IDENTITY_API_VERSION``"},{"line_number":571,"context_line":"# - ``REGION_NAME``"},{"line_number":572,"context_line":"# - ``KEYSTONE_SERVICE_PROTOCOL``"},{"line_number":573,"context_line":"# - ``KEYSTONE_SERVICE_HOST``"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fe272023_45829b2a","side":"PARENT","line":570,"range":{"start_line":570,"start_character":6,"end_line":570,"end_character":26},"in_reply_to":"0bceabca_1397592b","updated":"2021-10-25 17:56:14.000000000","message":"Kind of unrelated, but yes. Will do inline or as followup.","commit_id":"c027ddd3f895802f5cab37d2cb04162686a3a3cb"}],"tools/fixup_stuff.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6c0f20453bec6b5a8e89c30c923c40f81312dfa7","unresolved":true,"context_lines":[{"line_number":148,"context_line":"    sudo rm -rf /usr/lib/python3/dist-packages/simplejson-*.egg-info"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"function fixup_all {"},{"line_number":152,"context_line":"    fixup_ubuntu"},{"line_number":153,"context_line":"    fixup_fedora"},{"line_number":154,"context_line":"    fixup_suse"}],"source_content_type":"text/x-sh","patch_set":5,"id":"a0a6fd43_f50aa5d1","line":151,"updated":"2021-10-25 17:28:31.000000000","message":"nice, now it\u0027s only about distros like it should be","commit_id":"c2491bac9d3b3f0446e67b4ea960cb88da9aec0e"}]}