)]}'
{"stack.sh":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4a2d210233146cc51fbb0159e3bd5d98752ac1b2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Not all distros, like openSUSE, have this by default"},{"line_number":70,"context_line":"PATH\u003d$PATH:/usr/local/bin"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Keep track of the DevStack directory"},{"line_number":73,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":7,"id":"bf51134e_de4f5532","line":70,"updated":"2020-06-30 05:07:58.000000000","message":"Tempest runs as a different user and doesn\u0027t seem to find /usr/local/bin/tox in the path, then. Seem you either need to a) make this setting globally on a system level, b) create a fixup_suse func that symlinks it into the existing path or c) also amend $PATH in the tempest playbook.","commit_id":"2b62519239fc06b066d2f79294009e28eaf08261"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"45d0077e4a20d635a073c1a22a4a8fb19b1e6c36","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    PATH\u003d$PATH:/usr/local/bin"},{"line_number":72,"context_line":"    # tox is needed by tempest in the CI, which doesn\u0027t pick up the PATH change"},{"line_number":73,"context_line":"    # as it is not run from this script, so persist it for it to pick up later"},{"line_number":74,"context_line":"    echo \"PATH\u003d$PATH\" | sudo tee /etc/environment"},{"line_number":75,"context_line":"fi"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Keep track of the DevStack directory"}],"source_content_type":"text/x-sh","patch_set":14,"id":"bf51134e_a5bb45c2","line":74,"updated":"2020-07-02 13:56:33.000000000","message":"This seems like a pretty strong invasion into the host setup when someone runs this outside of the CI. Can we move this into tools/fixup_stuff.sh and only run it for suse?\n\nOr maybe even better fix the path setting directly in the tempest playbook?","commit_id":"251ea2cc4ac5010e8137aa5385cab165797936a5"},{"author":{"_account_id":12907,"name":"Jan Zerebecki","email":"jan.openstack@zerebecki.de","username":"jzerebecki"},"change_message_id":"59d622890f068cff265d4efcfa53b15a91247351","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    PATH\u003d$PATH:/usr/local/bin"},{"line_number":72,"context_line":"    # tox is needed by tempest in the CI, which doesn\u0027t pick up the PATH change"},{"line_number":73,"context_line":"    # as it is not run from this script, so persist it for it to pick up later"},{"line_number":74,"context_line":"    echo \"PATH\u003d$PATH\" | sudo tee /etc/environment"},{"line_number":75,"context_line":"fi"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Keep track of the DevStack directory"}],"source_content_type":"text/x-sh","patch_set":14,"id":"bf51134e_953d882e","line":74,"in_reply_to":"bf51134e_a5bb45c2","updated":"2020-07-02 20:32:41.000000000","message":"Now that I checked it, the comment above is wrong. The same thing would happen on Debian. Both OS defaults set it in profile, but tempest doesn\u0027t seem to run profile. Its just that it is new that we only put tox in /usr/local/bin. Yes, it would be better to fix the tempest playbook.","commit_id":"251ea2cc4ac5010e8137aa5385cab165797936a5"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"64f187433ae087e372665bb8ffc8c00226af61dd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# Not all distros have sbin in PATH for regular users."},{"line_number":67,"context_line":"# Also we do not pick up /etc/profile where /usr/local/bin is usually added,"},{"line_number":68,"context_line":"# but we need it for things that are installed via pip."},{"line_number":69,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin:/usr/local/bin"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Keep track of the DevStack directory"},{"line_number":72,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":16,"id":"9f560f44_a6c68668","line":69,"range":{"start_line":69,"start_character":43,"end_line":69,"end_character":57},"updated":"2020-10-04 08:04:31.000000000","message":"it should likely go first as local is usually meant to override non-local","commit_id":"ad3a8c81a3c783b1e7b8be188d77aa7dec175151"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a9620547d12e51887373f835e378ca0e05c6c99f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"# Not all distros have sbin in PATH for regular users."},{"line_number":67,"context_line":"# Also we do not pick up /etc/profile where /usr/local/bin is usually added,"},{"line_number":68,"context_line":"# but we need it for things that are installed via pip."},{"line_number":69,"context_line":"PATH\u003d$PATH:/usr/local/sbin:/usr/sbin:/sbin:/usr/local/bin"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Keep track of the DevStack directory"},{"line_number":72,"context_line":"TOP_DIR\u003d$(cd $(dirname \"$0\") \u0026\u0026 pwd)"}],"source_content_type":"text/x-sh","patch_set":16,"id":"1f621f24_0f0c7892","line":69,"range":{"start_line":69,"start_character":43,"end_line":69,"end_character":57},"in_reply_to":"9f560f44_a6c68668","updated":"2020-11-07 09:09:45.000000000","message":"Well, a sane path would also have /sbin in front of /bin etc., but I\u0027m not sure we need this here, it is just a hack to work around OSes that provide a broken path.","commit_id":"ad3a8c81a3c783b1e7b8be188d77aa7dec175151"}]}