)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"82bd770a7a049554348049cadd86ca65eef9f833","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-17 05:16:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use glance import workflow for crating image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack client does not has support to use new glance import workflow,"},{"line_number":10,"context_line":"which creates problem to use newly added import plugins like conversion,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_fc5f88e2","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":38},"updated":"2020-06-17 14:17:34.000000000","message":"creating","commit_id":"132d53a5cd7c9eb18552685f6ad1c6869c16a9a8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e9d3f0b203ad66186587e66b411956d68d37cbac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use glance import workflow for crating image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack client does not has support to use new glance import workflow,"},{"line_number":10,"context_line":"which creates problem to use newly added import plugins like conversion,"},{"line_number":11,"context_line":"inject metadata etc."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added new boolean option \u0027GLANCE_USE_IMPORT_WORKFLOW\u0027 default to False."},{"line_number":14,"context_line":"If this parameter set in local.conf as True then devstack will use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_803d48bd","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":20},"updated":"2020-06-17 09:27:40.000000000","message":"I quite don\u0027t understand the problem here, what plugins are we talking about? Can you describe more what the problem is, when, how, why, etc ..","commit_id":"132d53a5cd7c9eb18552685f6ad1c6869c16a9a8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f100d1ddfabb48070d2352eb302180a62bdbc19a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use glance import workflow for crating image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack client does not has support to use new glance import workflow,"},{"line_number":10,"context_line":"which creates problem to use newly added import plugins like conversion,"},{"line_number":11,"context_line":"inject metadata etc."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added new boolean option \u0027GLANCE_USE_IMPORT_WORKFLOW\u0027 default to False."},{"line_number":14,"context_line":"If this parameter set in local.conf as True then devstack will use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_dc2c449b","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":20},"in_reply_to":"bf51134e_803d48bd","updated":"2020-06-17 14:15:03.000000000","message":"Glance has added new import workflow to create images, which includes some plugins which I mentioned in commit messages [1].\n\nAlso recently glance started supporting multiple stores configuration. Now we want to add new job for (nova + glance) to use this multiple stores feature with its plugins like copy-image existing image in multiple stores, convert image from qcow2 to raw etc.\n\nAt this moment OSC has not support for these new features/commands so we need to use glance client instead.\n\n[1] https://docs.openstack.org/glance/latest/admin/interoperable-image-import.html","commit_id":"132d53a5cd7c9eb18552685f6ad1c6869c16a9a8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a699d04e3426ca02c3db1a97da250fa40702311f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use glance import workflow for crating image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack client does not has support to use new glance import workflow,"},{"line_number":10,"context_line":"which creates problem to use newly added import plugins like conversion,"},{"line_number":11,"context_line":"inject metadata etc."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added new boolean option \u0027GLANCE_USE_IMPORT_WORKFLOW\u0027 default to False."},{"line_number":14,"context_line":"If this parameter set in local.conf as True then devstack will use"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf51134e_3c41000d","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":20},"in_reply_to":"bf51134e_dc2c449b","updated":"2020-06-17 14:17:12.000000000","message":"Yep, I\u0027m here from the Nova side trying to get image conversion to work for our job, which is why we\u0027re looking for this to be possible in devstack.","commit_id":"132d53a5cd7c9eb18552685f6ad1c6869c16a9a8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d160d7473472885d547e021d46561e6ed3f5297","unresolved":false,"context_lines":[{"line_number":18,"context_line":"In order to use new import workflow of glance;"},{"line_number":19,"context_line":"user need to set below options in local.conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"GLANCE_USE_IMPORT_WORKFLOW\u003dTrue"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-Authored-By: Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":24,"context_line":"Co-Authored-By: Dan Smith \u003cdansmith@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_4ad8f11c","line":21,"updated":"2020-06-24 06:33:01.000000000","message":"Where is this going to be used? Is there some glance or nova job that depends on this to actually exercise this option? If yes, please add a reference as \"Needed-By:\"","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e96755af8db2f3255e595bb70d9aa0162e6bb063","unresolved":false,"context_lines":[{"line_number":18,"context_line":"In order to use new import workflow of glance;"},{"line_number":19,"context_line":"user need to set below options in local.conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"GLANCE_USE_IMPORT_WORKFLOW\u003dTrue"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-Authored-By: Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":24,"context_line":"Co-Authored-By: Dan Smith \u003cdansmith@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_b6c92fad","line":21,"in_reply_to":"bf51134e_4ad8f11c","updated":"2020-06-24 13:35:23.000000000","message":"It\u0027s going to have to be used by nova\u0027s multistore ceph job at least. I\u0027ve never added a Needed-By link, but.. sure.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d160d7473472885d547e021d46561e6ed3f5297","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-Authored-By: Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":24,"context_line":"Co-Authored-By: Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/#/c/737625"},{"line_number":26,"context_line":"Change-Id: I1306fe816b7a3eca1e2312c0c454be3d81118eca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_6ae335da","line":25,"updated":"2020-06-24 06:33:01.000000000","message":"This doesn\u0027t work as we consume OSC from pypi it seems.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e96755af8db2f3255e595bb70d9aa0162e6bb063","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Co-Authored-By: Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":24,"context_line":"Co-Authored-By: Dan Smith \u003cdansmith@redhat.com\u003e"},{"line_number":25,"context_line":"Depends-On: https://review.opendev.org/#/c/737625"},{"line_number":26,"context_line":"Change-Id: I1306fe816b7a3eca1e2312c0c454be3d81118eca"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_56d89379","line":25,"in_reply_to":"bf51134e_6ae335da","updated":"2020-06-24 13:35:23.000000000","message":"I was depends-on\u0027ing this from a job that configures osc to be built from git. I just got in and haven\u0027t checked that zuul kept that dep all the way through here, but that was the intention.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8035dc752f3b5ad61d8f9a1c9b36351612943aab","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"GLANCE_USE_IMPORT_WORKFLOW\u003dTrue"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Note that the import workflow requires WSGI_MODE\u003dmod_wsgi, otherwise"},{"line_number":19,"context_line":"glance will not be able to process the imports. The new helper function"},{"line_number":20,"context_line":"will abort to avoid in that case to avoid waiting for something that"},{"line_number":21,"context_line":"will never happen."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_631f0208","line":18,"updated":"2020-07-09 14:19:59.000000000","message":"Can you rewrite this to make it more explicit that glance-api actually needs to be running in standalone mode? Running it under mod_wsgi wouldn\u0027t work either according to the discussion in IRC.\n\nActually lib/glance should be rewritten to do that via a different flag, getting this to work shouldn\u0027t need to change how all other services are being deployed, but that may be fine for a followup.","commit_id":"38e703525ffd6b9e0837ee995e2d9d217a9ebf4e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"beb2654a128c8ffc20c5d1675ee8a39194333808","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"GLANCE_USE_IMPORT_WORKFLOW\u003dTrue"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Note that the import workflow requires WSGI_MODE\u003dmod_wsgi, otherwise"},{"line_number":19,"context_line":"glance will not be able to process the imports. The new helper function"},{"line_number":20,"context_line":"will abort to avoid in that case to avoid waiting for something that"},{"line_number":21,"context_line":"will never happen."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_c3e1ae9d","line":18,"in_reply_to":"bf51134e_631f0208","updated":"2020-07-09 14:35:21.000000000","message":"\u003e Can you rewrite this to make it more explicit that glance-api\n \u003e actually needs to be running in standalone mode? Running it under\n \u003e mod_wsgi wouldn\u0027t work either according to the discussion in IRC.\n\nmod_wsgi does work, because it starts another python process which allows eventlet threads that were scheduled during a request to continue running. Since there\u0027s only one way to configure devstack (that I know of) to allow this to work (even if it\u0027s poorly named) it seemed better to call it out specifically here. What would you prefer that I say? \"This workflow requires a non-uwsgi deployment\" ?\n\n \u003e Actually lib/glance should be rewritten to do that via a different\n \u003e flag, getting this to work shouldn\u0027t need to change how all other\n \u003e services are being deployed, but that may be fine for a followup.\n\nAgree that needs to happen, but we will likely need some help and examples.","commit_id":"38e703525ffd6b9e0837ee995e2d9d217a9ebf4e"}],"functions":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ba90c017eec0fb6d2a0fca85503169aa7ce0c909","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            source $TOP_DIR/openrc admin admin"},{"line_number":126,"context_line":"            glance image-create-via-import --visibility public --container-format ami --disk-format ami --name \"$image_name\" --file \"${image}\""},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":"        fi"},{"line_number":129,"context_line":"    fi"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    # vmdk format images"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bf51134e_7b59d458","line":128,"updated":"2020-06-16 16:42:22.000000000","message":"I wonder if it would make sense to just define a function for this so the check can happen in one place and everywhere else here can just call that function?\n\n glance_import_image \"foo\" \"ami\" \"ami\" $path","commit_id":"1a7c93f20197a60ab6160e3c76dbf4ab9d6fb5f8"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e9d3f0b203ad66186587e66b411956d68d37cbac","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # OpenVZ-format images are provided as .tar.gz, but not decompressed prior to loading"},{"line_number":119,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027openvz\u0027 ]]; then"},{"line_number":120,"context_line":"        image_name\u003d\"${image_fname%.tar.gz}\""},{"line_number":121,"context_line":"        if [[ \"GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":122,"context_line":"            openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format ami --disk-format ami \u003c \"${image}\""},{"line_number":123,"context_line":"            return"},{"line_number":124,"context_line":"        else"},{"line_number":125,"context_line":"            source $TOP_DIR/openrc admin admin"},{"line_number":126,"context_line":"            glance image-create-via-import --visibility public --container-format ami --disk-format ami --name \"$image_name\" \u003c \"${image}\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_d52ee0a3","line":123,"range":{"start_line":121,"start_character":8,"end_line":123,"end_character":18},"updated":"2020-06-17 09:27:40.000000000","message":"based on the commit message the default value of the GLANCE_USE_IMPORT_WORKFLOW is False - in that case to preserve default behavior as it was the condition must be \u0027... !\u003d True\u0027 or \u0027... \u003d\u003d False\u0027, right?","commit_id":"132d53a5cd7c9eb18552685f6ad1c6869c16a9a8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f100d1ddfabb48070d2352eb302180a62bdbc19a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # OpenVZ-format images are provided as .tar.gz, but not decompressed prior to loading"},{"line_number":119,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027openvz\u0027 ]]; then"},{"line_number":120,"context_line":"        image_name\u003d\"${image_fname%.tar.gz}\""},{"line_number":121,"context_line":"        if [[ \"GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":122,"context_line":"            openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format ami --disk-format ami \u003c \"${image}\""},{"line_number":123,"context_line":"            return"},{"line_number":124,"context_line":"        else"},{"line_number":125,"context_line":"            source $TOP_DIR/openrc admin admin"},{"line_number":126,"context_line":"            glance image-create-via-import --visibility public --container-format ami --disk-format ami --name \"$image_name\" \u003c \"${image}\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_fc75c899","line":123,"range":{"start_line":121,"start_character":8,"end_line":123,"end_character":18},"in_reply_to":"bf51134e_d52ee0a3","updated":"2020-06-17 14:15:03.000000000","message":"Yes, this is correct.\nWill change it, but still if someone sets this to True and ran tempest then it will fail with what I have commented in the replies.\n\nKindly let me know what is going wrong in this scenario as I am out of ideas now.","commit_id":"132d53a5cd7c9eb18552685f6ad1c6869c16a9a8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e32bd3af53ac3ae1cde588a9bc6ea926416927c6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    # OpenVZ-format images are provided as .tar.gz, but not decompressed prior to loading"},{"line_number":119,"context_line":"    if [[ \"$image_url\" \u003d~ \u0027openvz\u0027 ]]; then"},{"line_number":120,"context_line":"        image_name\u003d\"${image_fname%.tar.gz}\""},{"line_number":121,"context_line":"        if [[ \"GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":122,"context_line":"            openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format ami --disk-format ami \u003c \"${image}\""},{"line_number":123,"context_line":"            return"},{"line_number":124,"context_line":"        else"},{"line_number":125,"context_line":"            source $TOP_DIR/openrc admin admin"},{"line_number":126,"context_line":"            glance image-create-via-import --visibility public --container-format ami --disk-format ami --name \"$image_name\" \u003c \"${image}\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bf51134e_e24dec72","line":123,"range":{"start_line":121,"start_character":8,"end_line":123,"end_character":18},"in_reply_to":"bf51134e_fc75c899","updated":"2020-06-19 14:59:32.000000000","message":"The problem is that WSGI_MODE\u003duwsgi, which means we use the import mechanism, but the image never gets out of \u0027uploading\u0027 state because the task doesn\u0027t run. I think we need to make this only do import if both the flag is true AND WSGI_MODE!\u003duwsgi. See my revision patch on top of this one.","commit_id":"132d53a5cd7c9eb18552685f6ad1c6869c16a9a8"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"1bea914cf80b27e38ecdcd08e9d5140eda78f0d7","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    if [[ \"$canimport\" \u003d\u003d \"False\" ]]; then"},{"line_number":113,"context_line":"        openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format \"$container\" --disk-format \"$disk\" $properties \u003c \"${image}\""},{"line_number":114,"context_line":"    else"},{"line_number":115,"context_line":"        source $TOP_DIR/openrc admin admin"},{"line_number":116,"context_line":"        glance image-create-via-import --visibility public --container-format \"$container\" --disk-format \"$disk\" --name \"$image_name\" $properties \u003c \"${image}\""},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_ff18ac1e","line":115,"updated":"2020-06-23 18:56:17.000000000","message":"Not being able to use the cloud.yaml config is a show stopper for me, can that functionality be added to glanceclient? Otherwise I\u0027d strongly vote to only use OSC functionality.","commit_id":"ec4884899d8a4c3c69ef2f99623616e96eba66b3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ccc8bcc4b91b548f88cf18e94f4b549a871cf4e2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    if [[ \"$canimport\" \u003d\u003d \"False\" ]]; then"},{"line_number":113,"context_line":"        openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format \"$container\" --disk-format \"$disk\" $properties \u003c \"${image}\""},{"line_number":114,"context_line":"    else"},{"line_number":115,"context_line":"        source $TOP_DIR/openrc admin admin"},{"line_number":116,"context_line":"        glance image-create-via-import --visibility public --container-format \"$container\" --disk-format \"$disk\" --name \"$image_name\" $properties \u003c \"${image}\""},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_dad4d6eb","line":115,"in_reply_to":"bf51134e_ba6ac2af","updated":"2020-06-23 19:55:43.000000000","message":"\u003e This seems like a great opportunity to work together and improve\n \u003e everyone\u0027s experience.\n\nI\u0027m trying to fix up as much glance and devstack stuff as I can so that I can test my nova feature in support of this goal :)\n\n \u003e https://review.opendev.org/#/c/737608/\n \u003e \n \u003e I just wrote a patch to use the already-existing support for image\n \u003e upload in sdk with the image creation workflow. Assuming this works\n \u003e (which, you know - let\u0027s assume there\u0027s a bug - and also probably\n \u003e will need to update an existing unittest and add another unittest\n \u003e to we\u0027ve covering both sides) it will, upon being released,\n \u003e immediately make osc use the interop image workflow if it finds it.\n\nIt\u0027s not clear to me that what you\u0027re saying is the same as image-create-via-import, but if so, then ... great.\n\n \u003e It seems like having a devstack config both with and without uwsgi\n \u003e for sdk\u0027s functional tests should cover both with and without image\n \u003e upload, yes?\n\nNot sure about that. For glanceclient, they\u0027re two different mechanisms. The regular way (which is equivalent to the osc way) doesn\u0027t trigger the import mechanism at all. The import way (line below) does trigger it, but will cause the image to never go into active state if glance is running as a uwsgi app.\n\nSo assuming you know more about the parity among those operations than I do, then ... great, I don\u0027t care how we tickle it, just that we do. This has been a kinda critical feature for glance for a while now that we\u0027ve not been testing in CI, which is a problem, IMHO.\n\nI\u0027d also like an answer from whoever to my question about devstack requiring osc going forward. We have things in nova you can\u0027t do with osc, and we just had a PTG where support for requiring new features be added to osc/sdk before they can be landed in nova was pretty chilly. I\u0027m definitely not in support of devstack being the stick we use to beat people into submission, instead of a tool to help keep test coverage high. From what I can tell, glance\u0027s recent dearth of real test coverage on their new features has come from not being able to meet devstack\u0027s demands with their paltry staffing (see the just recently merged g-reg removal, years after a stub was put into glance to be able to remove it without disturbing devstack). I\u0027d much rather have devstack be inconsistent in client usage (a reflection of the current reality, btw) than projects like glance just not even trying to test new features that require things like this.","commit_id":"ec4884899d8a4c3c69ef2f99623616e96eba66b3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"96d4d0ad0848b4db6b96e28751eadf0750069530","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    if [[ \"$canimport\" \u003d\u003d \"False\" ]]; then"},{"line_number":113,"context_line":"        openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format \"$container\" --disk-format \"$disk\" $properties \u003c \"${image}\""},{"line_number":114,"context_line":"    else"},{"line_number":115,"context_line":"        source $TOP_DIR/openrc admin admin"},{"line_number":116,"context_line":"        glance image-create-via-import --visibility public --container-format \"$container\" --disk-format \"$disk\" --name \"$image_name\" $properties \u003c \"${image}\""},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_fff0ac93","line":115,"in_reply_to":"bf51134e_ff18ac1e","updated":"2020-06-23 19:07:45.000000000","message":"Just to be clear, you would rather us not be able to test import image conversion (which has been in glance untested for several cycles) and Nova\u0027s use of that feature (which I just implemented and am trying to use now) until osc gains support for this mechanism? I have a hard time understanding that tradeoff, unless there is some actual technical reason. This does work in my testing here, so what is the actual hard dep on cloud.yaml? FWIW, people using this in the wild are doing it with glanceclient, just like many things in nova that aren\u0027t supported in OSC have to be done with novaclient today.","commit_id":"ec4884899d8a4c3c69ef2f99623616e96eba66b3"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3743921d8e8a1f833aaf941819c33c31c4bf7241","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    if [[ \"$canimport\" \u003d\u003d \"False\" ]]; then"},{"line_number":113,"context_line":"        openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format \"$container\" --disk-format \"$disk\" $properties \u003c \"${image}\""},{"line_number":114,"context_line":"    else"},{"line_number":115,"context_line":"        source $TOP_DIR/openrc admin admin"},{"line_number":116,"context_line":"        glance image-create-via-import --visibility public --container-format \"$container\" --disk-format \"$disk\" --name \"$image_name\" $properties \u003c \"${image}\""},{"line_number":117,"context_line":"    fi"},{"line_number":118,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_ba6ac2af","line":115,"in_reply_to":"bf51134e_fff0ac93","updated":"2020-06-23 19:32:18.000000000","message":"This seems like a great opportunity to work together and improve everyone\u0027s experience.\n\nhttps://review.opendev.org/#/c/737608/\n\nI just wrote a patch to use the already-existing support for image upload in sdk with the image creation workflow. Assuming this works (which, you know - let\u0027s assume there\u0027s a bug - and also probably will need to update an existing unittest and add another unittest to we\u0027ve covering both sides) it will, upon being released, immediately make osc use the interop image workflow if it finds it.\n\nI\u0027ll follow up with a patch add plumb through support for the --url import flag, but for now that patch should take care of it.\n\nIt seems like having a devstack config both with and without uwsgi for sdk\u0027s functional tests should cover both with and without image upload, yes?\n\nAnyway - I don\u0027t see any reason we can\u0027t get that patch finished up, landed and released in the next day ... at which point it\u0027ll mean we will have added support to sdk, zuul, openstackclient, ansible and salt.","commit_id":"ec4884899d8a4c3c69ef2f99623616e96eba66b3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d160d7473472885d547e021d46561e6ed3f5297","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    done"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" \u0026\u0026 \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":107,"context_line":"        echo \"*** Unable to use glance import workflow because WSGI_MODE\u003duwsgi! ***\""},{"line_number":108,"context_line":"        canimport\u003dFalse"},{"line_number":109,"context_line":"    else"},{"line_number":110,"context_line":"        canimport\u003d$GLANCE_USE_IMPORT_WORKFLOW"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_4abd9100","line":107,"updated":"2020-06-24 06:33:01.000000000","message":"Just being curious: Is there a technical reason for this or is this just a bug in glance that prevents this?","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a9a5cbee4c448eaabfc8b66499b6ea2e26490e8c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    done"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" \u0026\u0026 \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":107,"context_line":"        echo \"*** Unable to use glance import workflow because WSGI_MODE\u003duwsgi! ***\""},{"line_number":108,"context_line":"        canimport\u003dFalse"},{"line_number":109,"context_line":"    else"},{"line_number":110,"context_line":"        canimport\u003d$GLANCE_USE_IMPORT_WORKFLOW"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_f1fa9172","line":107,"in_reply_to":"bf51134e_16b3bb4e","updated":"2020-06-24 14:29:37.000000000","message":"IIUC neutron has created a neutron-rpc service to be handling such things when neutron-server is running under uwsgi.\n\nBut indeed I would like to consider devstack not only a testing tool, but also a blueprint for how to deploy OpenStack in the real world, so I\u0027m all for making stuff more realistic.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e96755af8db2f3255e595bb70d9aa0162e6bb063","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    done"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" \u0026\u0026 \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":107,"context_line":"        echo \"*** Unable to use glance import workflow because WSGI_MODE\u003duwsgi! ***\""},{"line_number":108,"context_line":"        canimport\u003dFalse"},{"line_number":109,"context_line":"    else"},{"line_number":110,"context_line":"        canimport\u003d$GLANCE_USE_IMPORT_WORKFLOW"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_16b3bb4e","line":107,"in_reply_to":"bf51134e_4abd9100","updated":"2020-06-24 13:35:23.000000000","message":"Yeah, glance is unable to spawn background threads that run to completion when used under uwsgi. Nova has the same problem, which prevents checking things like rabbit heartbeats, which we\u0027ve had to squelch since the move to uwsgi.\n\nSince things like import format conversion, metadata tagging, and import copy-to-store all require background threads in the glance-api worker, these features will never work under uwsgi.\n\nTBH, my next step after getting all this stuff working and tested with WSGI_MODE\u003dmod_wsgi, was going to be to suggest a way to make glance-api never run under uwsgi, since it pretty much can\u0027t function normally at all in that way. At RedHat, we don\u0027t run it under uwsgi in the product that way, and testing it like that makes this not very realistic.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a2a6f6e9ad3a751a2fb75569016cb6ce1b260e9e","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    done"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" \u0026\u0026 \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":107,"context_line":"        echo \"*** Unable to use glance import workflow because WSGI_MODE\u003duwsgi! ***\""},{"line_number":108,"context_line":"        canimport\u003dFalse"},{"line_number":109,"context_line":"    else"},{"line_number":110,"context_line":"        canimport\u003d$GLANCE_USE_IMPORT_WORKFLOW"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_9116b554","line":107,"in_reply_to":"bf51134e_f1fa9172","updated":"2020-06-24 14:44:00.000000000","message":"Yep, and Nova has workers over RPC to handle such things (other than what can\u0027t be delegated like the heartbeat checks). Since glance needs to stream the image it\u0027s working on, it\u0027s kinda fundamentally not able to delegate long-running tasks like this, as it wouldn\u0027t be reasonable to either stream a multi-GiB image over RPC, nor require a shared highly-available filesystem or similar. Obviously addressing this would be a fundamental architectural change to Glance, which just isn\u0027t feasible, especially given they are already struggling to keep up with maintenance.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d160d7473472885d547e021d46561e6ed3f5297","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    if [ \"$container_format\" \u003d \"bare\" ]; then"},{"line_number":405,"context_line":"        if [ \"$unpack\" \u003d \"zcat\" ]; then"},{"line_number":406,"context_line":"            _upload_image \"$image_name\" $container_format $disk_format \u003c(zcat --force \"$image\") $image_property"},{"line_number":407,"context_line":"        elif [ \"$unpack\" \u003d \"bunzip2\" ]; then"},{"line_number":408,"context_line":"            _upload_image \"$image_name\" $container_format $disk_format \u003c(bunzip2 -cdk \"$image\") $image_property"},{"line_number":409,"context_line":"        elif [ \"$unpack\" \u003d \"unxz\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_6a34d593","line":406,"range":{"start_line":406,"start_character":97,"end_line":406,"end_character":111},"updated":"2020-06-24 06:33:01.000000000","message":"img_property, same below","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d160d7473472885d547e021d46561e6ed3f5297","unresolved":false,"context_lines":[{"line_number":430,"context_line":"        if [ -n \"$ramdisk\" ]; then"},{"line_number":431,"context_line":"            ramdisk_id\u003d$(openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name-ramdisk\" $img_property --public --container-format ari --disk-format ari \u003c \"$ramdisk\" | grep \u0027 id \u0027 | get_field 2)"},{"line_number":432,"context_line":"        fi"},{"line_number":433,"context_line":"        _upload_image \"${image_name%.img}\" ami ami \"$image\" ${kernel_id:+ kernel_id\u003d$kernel_id} ${ramdisk_id:+ ramdisk_id\u003d$ramdisk_id}"},{"line_number":434,"context_line":"    fi"},{"line_number":435,"context_line":"}"},{"line_number":436,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_0a239957","line":433,"updated":"2020-06-24 06:33:01.000000000","message":"Insert $img_property here, too?","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8e2a2cc3fddfc95cb82716281ae90fcb79457507","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        properties+\u003d\" --property $prop\""},{"line_number":104,"context_line":"    done"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" \u0026\u0026 \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":107,"context_line":"        echo \"*** Unable to use glance import workflow because WSGI_MODE\u003duwsgi! ***\""},{"line_number":108,"context_line":"        canimport\u003dFalse"},{"line_number":109,"context_line":"    else"},{"line_number":110,"context_line":"        canimport\u003d$GLANCE_USE_IMPORT_WORKFLOW"},{"line_number":111,"context_line":"    fi"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    if [[ \"$canimport\" \u003d\u003d \"True\" ]]; then"},{"line_number":114,"context_line":"        useimport\u003d\"--import\""},{"line_number":115,"context_line":"    fi"},{"line_number":116,"context_line":"    openstack --os-cloud\u003ddevstack-admin --os-region-name\u003d\"$REGION_NAME\" image create \"$image_name\" --public --container-format \"$container\" --disk-format \"$disk\" $useimport $properties \u003c \"${image}\""},{"line_number":117,"context_line":"}"},{"line_number":118,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_626071a6","line":115,"range":{"start_line":106,"start_character":0,"end_line":115,"end_character":6},"updated":"2020-07-13 18:06:53.000000000","message":"let\u0027s not echo \"unable to use import...\" if import itself is not requested.\n\nsomething like below.\n\n    if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then\n        if [[ $WSGI_MODE\" !\u003d \"uwsgi\" ]]; then\n            echo \"*** Using glance import workflow ***\"\n            useimport\u003d\"--import\"\n        else \n           echo \"*** Glance import workflow requested but unable to use because WSGI_MODE\u003duwsgi! ***\"\n        fi\n    fi","commit_id":"d6c1a3f155c29229dd11b8c9f851efb7439d3f50"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1e679b8a1a68f1db51ddfdd12a5ad5753f24e41c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    done"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if [[ \"$GLANCE_USE_IMPORT_WORKFLOW\" \u003d\u003d \"True\" ]]; then"},{"line_number":106,"context_line":"        if [[ \"$WSGI_MODE\" \u003d\u003d \"uwsgi\" ]]; then"},{"line_number":107,"context_line":"            useimport\u003d\"--import\""},{"line_number":108,"context_line":"        else"},{"line_number":109,"context_line":"            echo \"*** Unable to use glance import workflow because WSGI_MODE\u003duwsgi! ***\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bf51134e_f961d3aa","line":106,"range":{"start_line":106,"start_character":27,"end_line":106,"end_character":29},"updated":"2020-07-13 20:56:36.000000000","message":"it should be !\u003d","commit_id":"fa919dc196479f145a74fdbb837a51571cd606ce"}],"lib/tempest":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8d160d7473472885d547e021d46561e6ed3f5297","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        # Make sure we don\u0027t fail if the image is still in the"},{"line_number":155,"context_line":"        # uploading state. If we used the import mechanism, the image"},{"line_number":156,"context_line":"        # could technically still be in \"uploading\" state."},{"line_number":157,"context_line":"        while openstack image list | grep uploading; do"},{"line_number":158,"context_line":"            echo \u0027Waiting for image upload to complete...\u0027"},{"line_number":159,"context_line":"            sleep 3"},{"line_number":160,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_cab36109","line":157,"updated":"2020-06-24 06:33:01.000000000","message":"Can you please add a retry counter with a limit? Waiting forever without a timeout when somethings gets stuck should be avoided.\n\nI\u0027m also unsure whether this wait should actually happen here or directly after the image upload in lib/glance, which would also protect other possible consumers.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a2a6f6e9ad3a751a2fb75569016cb6ce1b260e9e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        # Make sure we don\u0027t fail if the image is still in the"},{"line_number":155,"context_line":"        # uploading state. If we used the import mechanism, the image"},{"line_number":156,"context_line":"        # could technically still be in \"uploading\" state."},{"line_number":157,"context_line":"        while openstack image list | grep uploading; do"},{"line_number":158,"context_line":"            echo \u0027Waiting for image upload to complete...\u0027"},{"line_number":159,"context_line":"            sleep 3"},{"line_number":160,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_ec13da5a","line":157,"in_reply_to":"bf51134e_11a745a9","updated":"2020-06-24 14:44:00.000000000","message":"Yep, understand, no argument about a timeout. I put this here because the image was _never_ going into active state and the below search for active images wasn\u0027t showing us useful info. I think that a specific check that something went to active is a good idea, which is why I left it here, but am happy to make it timeout.\n\nTBH, I\u0027m not super concerned about the grenade case as I don\u0027t think there\u0027s any reason to need to configure a grenade job to use the import workflow in the short term (we don\u0027t test ceph deployments with grenade currently, AFAIK). In reality, if things don\u0027t break, a cirros image should upload and convert very fast and not ever even need us to wait here.\n\nBut, if you would rather me put the wait loop near image upload for the future, then that\u0027s fine.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a9a5cbee4c448eaabfc8b66499b6ea2e26490e8c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        # Make sure we don\u0027t fail if the image is still in the"},{"line_number":155,"context_line":"        # uploading state. If we used the import mechanism, the image"},{"line_number":156,"context_line":"        # could technically still be in \"uploading\" state."},{"line_number":157,"context_line":"        while openstack image list | grep uploading; do"},{"line_number":158,"context_line":"            echo \u0027Waiting for image upload to complete...\u0027"},{"line_number":159,"context_line":"            sleep 3"},{"line_number":160,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_11a745a9","line":157,"in_reply_to":"bf51134e_36e4ff3b","updated":"2020-06-24 14:29:37.000000000","message":"\u003e Waiting here makes the job take less time because we overlap the\n \u003e import operation with more stack setup. Only here does it matter,\n \u003e and if you were to not enable tempest, it wouldn\u0027t matter if it\n \u003e didn\u0027t finish by the time devstack ended.\n\nWhat about e.g. grenade? That will run devstack to install the \"old\" side and then start the upgrade procedure. What will happen to the image if glance api is restarted halfway?\n\n \u003e Yes, I can add a limit. This was to catch an error so we could see\n \u003e it and I relied on the job timeout to eventually kill it.\n\nIf we can call this failed after like 5 minutes, we don\u0027t need to wait two more hours. Also devstack isn\u0027t only used for jobs but also by users to deploy a developing environment.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e96755af8db2f3255e595bb70d9aa0162e6bb063","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        # Make sure we don\u0027t fail if the image is still in the"},{"line_number":155,"context_line":"        # uploading state. If we used the import mechanism, the image"},{"line_number":156,"context_line":"        # could technically still be in \"uploading\" state."},{"line_number":157,"context_line":"        while openstack image list | grep uploading; do"},{"line_number":158,"context_line":"            echo \u0027Waiting for image upload to complete...\u0027"},{"line_number":159,"context_line":"            sleep 3"},{"line_number":160,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_36e4ff3b","line":157,"in_reply_to":"bf51134e_cab36109","updated":"2020-06-24 13:35:23.000000000","message":"Waiting here makes the job take less time because we overlap the import operation with more stack setup. Only here does it matter, and if you were to not enable tempest, it wouldn\u0027t matter if it didn\u0027t finish by the time devstack ended.\n\nYes, I can add a limit. This was to catch an error so we could see it and I relied on the job timeout to eventually kill it.","commit_id":"f308e76d6547b57a7d66bb7d1eb64337c6e8cac0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8035dc752f3b5ad61d8f9a1c9b36351612943aab","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        # times (30s) and if we don\u0027t find it, let the next check for"},{"line_number":158,"context_line":"        # valid images stop us."},{"line_number":159,"context_line":"        for i in $(seq 10); do"},{"line_number":160,"context_line":"            if openstack image list | grep uploading; then"},{"line_number":161,"context_line":"                break"},{"line_number":162,"context_line":"            fi"},{"line_number":163,"context_line":"            echo \u0027Waiting for image upload to complete...\u0027"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"bf51134e_e365d2b6","line":160,"updated":"2020-07-09 14:19:59.000000000","message":"Isn\u0027t that the wrong way round? You want to wait when the state is still uploading, not end the loop.","commit_id":"38e703525ffd6b9e0837ee995e2d9d217a9ebf4e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8e2a2cc3fddfc95cb82716281ae90fcb79457507","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        # times (30s) and if we don\u0027t find it, let the next check for"},{"line_number":158,"context_line":"        # valid images stop us."},{"line_number":159,"context_line":"        for i in $(seq 10); do"},{"line_number":160,"context_line":"            if openstack image list | grep uploading; then"},{"line_number":161,"context_line":"                break"},{"line_number":162,"context_line":"            fi"},{"line_number":163,"context_line":"            echo \u0027Waiting for image upload to complete...\u0027"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"bf51134e_a23d698f","line":160,"in_reply_to":"bf51134e_a3ed9ab8","updated":"2020-07-13 18:06:53.000000000","message":"yeah, anyways tempest will be using these image while running tests so enough time for image to be in active. but as dan mentioned we can add some wait if it start failing.","commit_id":"38e703525ffd6b9e0837ee995e2d9d217a9ebf4e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"beb2654a128c8ffc20c5d1675ee8a39194333808","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        # times (30s) and if we don\u0027t find it, let the next check for"},{"line_number":158,"context_line":"        # valid images stop us."},{"line_number":159,"context_line":"        for i in $(seq 10); do"},{"line_number":160,"context_line":"            if openstack image list | grep uploading; then"},{"line_number":161,"context_line":"                break"},{"line_number":162,"context_line":"            fi"},{"line_number":163,"context_line":"            echo \u0027Waiting for image upload to complete...\u0027"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"bf51134e_a3ed9ab8","line":160,"in_reply_to":"bf51134e_e365d2b6","updated":"2020-07-09 14:35:21.000000000","message":"Yeah, I said I was just going to delete this and I should have, since we don\u0027t hit it in CI anyway. So I\u0027ll just remove it and let the below active image search fail.","commit_id":"38e703525ffd6b9e0837ee995e2d9d217a9ebf4e"}]}