)]}'
{"lib/apache":[{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"39eb6849b3b898e8c5fa9934e242e8bebefd03fc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"function download_and_compile_uwsgi {"},{"line_number":77,"context_line":"    local dir"},{"line_number":78,"context_line":"    dir\u003d$(mktemp -d)"},{"line_number":79,"context_line":"    pushd $dir"},{"line_number":80,"context_line":"    pip_install uwsgi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_215f1be3","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":13},"updated":"2020-06-17 14:34:15.000000000","message":"NIT: dir is a too simple name for me. Please call it something like temp_dir or build_dir instead.","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":31956,"name":"Ignacy Osetek","email":"iosetek@juniper.net","username":"iosetek"},"change_message_id":"b827ce81c0e0ad017fe4bcb84c848316a31deb77","unresolved":false,"context_lines":[{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"function download_and_compile_uwsgi {"},{"line_number":77,"context_line":"    local dir"},{"line_number":78,"context_line":"    dir\u003d$(mktemp -d)"},{"line_number":79,"context_line":"    pushd $dir"},{"line_number":80,"context_line":"    pip_install uwsgi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_12a4e356","line":77,"range":{"start_line":77,"start_character":10,"end_line":77,"end_character":13},"in_reply_to":"bf51134e_215f1be3","updated":"2020-06-17 15:41:52.000000000","message":"Done","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"39eb6849b3b898e8c5fa9934e242e8bebefd03fc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"function download_and_compile_uwsgi {"},{"line_number":77,"context_line":"    local dir"},{"line_number":78,"context_line":"    dir\u003d$(mktemp -d)"},{"line_number":79,"context_line":"    pushd $dir"},{"line_number":80,"context_line":"    pip_install uwsgi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # We need to download uwsgi from pip. Since we don\u0027t know the full name"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_21143bf5","line":79,"range":{"start_line":79,"start_character":4,"end_line":79,"end_character":14},"updated":"2020-06-17 14:34:15.000000000","message":"Do you really need to move to this directory? Is there some file saved there?","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":31956,"name":"Ignacy Osetek","email":"iosetek@juniper.net","username":"iosetek"},"change_message_id":"b827ce81c0e0ad017fe4bcb84c848316a31deb77","unresolved":false,"context_lines":[{"line_number":76,"context_line":"function download_and_compile_uwsgi {"},{"line_number":77,"context_line":"    local dir"},{"line_number":78,"context_line":"    dir\u003d$(mktemp -d)"},{"line_number":79,"context_line":"    pushd $dir"},{"line_number":80,"context_line":"    pip_install uwsgi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # We need to download uwsgi from pip. Since we don\u0027t know the full name"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_b29257f5","line":79,"range":{"start_line":79,"start_character":4,"end_line":79,"end_character":14},"in_reply_to":"bf51134e_21143bf5","updated":"2020-06-17 15:41:52.000000000","message":"I just kept the previous solution but you\u0027re right. It is not needed.","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"39eb6849b3b898e8c5fa9934e242e8bebefd03fc","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    uwsgidir\u003d\"$dir/uwsgidir\""},{"line_number":87,"context_line":"    mkdir -p \"$uwsgidir\""},{"line_number":88,"context_line":"    pip download uwsgi -c /home/centos/test/requirements.txt -d \"$uwsgidir\""},{"line_number":89,"context_line":"    if [[ \"$(ls \"$uwsgidir\" | wc -l)\" !\u003d \"1\" ]] ; then"},{"line_number":90,"context_line":"        echo \"Expected single uwsgi tar file. Got: \u0027$(ls $uwsgidir)\u0027\""},{"line_number":91,"context_line":"        popd"},{"line_number":92,"context_line":"        sudo rm -rf $dir"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_fc7828f9","line":89,"range":{"start_line":89,"start_character":17,"end_line":89,"end_character":26},"updated":"2020-06-17 14:34:15.000000000","message":"I would use find command instead so you can get the whole file name:\n\n local downloaded_files\u003d( $(find \"${uwsgidir}\" ) )\n if [ ${#downloaded_files[@]} !\u003d 1 ]; then\n     echo \"Expected single uwsgi tar file. Got: \n ${#downloaded_files[@]}\"\n fi\n\nAt this point you can have your tar file as: \n local uwsgitar\u003d${#downloaded_files[0]}","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":31956,"name":"Ignacy Osetek","email":"iosetek@juniper.net","username":"iosetek"},"change_message_id":"b827ce81c0e0ad017fe4bcb84c848316a31deb77","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    uwsgidir\u003d\"$dir/uwsgidir\""},{"line_number":87,"context_line":"    mkdir -p \"$uwsgidir\""},{"line_number":88,"context_line":"    pip download uwsgi -c /home/centos/test/requirements.txt -d \"$uwsgidir\""},{"line_number":89,"context_line":"    if [[ \"$(ls \"$uwsgidir\" | wc -l)\" !\u003d \"1\" ]] ; then"},{"line_number":90,"context_line":"        echo \"Expected single uwsgi tar file. Got: \u0027$(ls $uwsgidir)\u0027\""},{"line_number":91,"context_line":"        popd"},{"line_number":92,"context_line":"        sudo rm -rf $dir"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_124b4384","line":89,"range":{"start_line":89,"start_character":17,"end_line":89,"end_character":26},"in_reply_to":"bf51134e_fc7828f9","updated":"2020-06-17 15:41:52.000000000","message":"Done.\nThat\u0027s actually better. Thanks.\nOnly had to change find formula to:\nfind $uwsgidir/*\notherwise the result included $uwsgidir as well.","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"39eb6849b3b898e8c5fa9934e242e8bebefd03fc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        exit 1"},{"line_number":94,"context_line":"    fi"},{"line_number":95,"context_line":"    local uwsgitar"},{"line_number":96,"context_line":"    uwsgitar\u003d\"$uwsgidir/$(ls $uwsgidir)\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # Now we can unwrap it somewhere else."},{"line_number":99,"context_line":"    local uwsgiout"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_1cb7dcd7","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":39},"updated":"2020-06-17 14:34:15.000000000","message":"I think you should have the output of this call into a local variable instead of calling it every time.","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":31956,"name":"Ignacy Osetek","email":"iosetek@juniper.net","username":"iosetek"},"change_message_id":"b827ce81c0e0ad017fe4bcb84c848316a31deb77","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        exit 1"},{"line_number":94,"context_line":"    fi"},{"line_number":95,"context_line":"    local uwsgitar"},{"line_number":96,"context_line":"    uwsgitar\u003d\"$uwsgidir/$(ls $uwsgidir)\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # Now we can unwrap it somewhere else."},{"line_number":99,"context_line":"    local uwsgiout"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bf51134e_92563329","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":39},"in_reply_to":"bf51134e_1cb7dcd7","updated":"2020-06-17 15:41:52.000000000","message":"Removed it already.","commit_id":"48fb4a54303d62a740fcd83bf1a55606ef932c43"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa138c11627eaa1b835fccbbd5cc42b325fb5c9e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"function download_and_compile_uwsgi {"},{"line_number":77,"context_line":"    local build_dir\u003d\"$(mktemp -d)\""},{"line_number":78,"context_line":"    pip_install uwsgi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # We need to download uwsgi from pip. Since we don\u0027t know the full name"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_7a3411fc","line":77,"updated":"2020-06-17 20:49:06.000000000","message":"bashate: E042 local declaration hides errors","commit_id":"cb5f96f28d75a955150a88f26b7896dbaaa2277c"},{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"3ebc6d5327635c37692e10ed3e4b234966424aa9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"function download_and_compile_uwsgi {"},{"line_number":77,"context_line":"    local build_dir\u003d\"$(mktemp -d)\""},{"line_number":78,"context_line":"    pip_install uwsgi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # We need to download uwsgi from pip. Since we don\u0027t know the full name"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_8c028c08","line":77,"in_reply_to":"bf51134e_7a3411fc","updated":"2020-06-18 06:52:13.000000000","message":"please separate declaration from subshell command capture","commit_id":"cb5f96f28d75a955150a88f26b7896dbaaa2277c"},{"author":{"_account_id":31956,"name":"Ignacy Osetek","email":"iosetek@juniper.net","username":"iosetek"},"change_message_id":"e1b7acc5d1fecb45af5a75feb23829d35b47008f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"function download_and_compile_uwsgi {"},{"line_number":77,"context_line":"    local build_dir\u003d\"$(mktemp -d)\""},{"line_number":78,"context_line":"    pip_install uwsgi"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # We need to download uwsgi from pip. Since we don\u0027t know the full name"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf51134e_f2f83e4a","line":77,"in_reply_to":"bf51134e_8c028c08","updated":"2020-06-18 08:31:43.000000000","message":"Done","commit_id":"cb5f96f28d75a955150a88f26b7896dbaaa2277c"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"028ba4fa93f52fc5e1726ed3663e4021097b4ab4","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # Unwrapped uwsgi can be wrapped with additional directory so"},{"line_number":103,"context_line":"    # we need to resolve a path to it."},{"line_number":104,"context_line":"    local extracted_files"},{"line_number":105,"context_line":"    extracted_files\u003d( $(ls $uwsgiout ) )"},{"line_number":106,"context_line":"    if [[ \"${#extracted_files[@]}\" \u003d\u003d \"1\" ]] ; then"},{"line_number":107,"context_line":"        local uwsgipath\u003d\"$uwsgiout/${extracted_files[0]}\""},{"line_number":108,"context_line":"    else"},{"line_number":109,"context_line":"        local uwsgipath\u003d\"$uwsgiout\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_fedora; then"},{"line_number":113,"context_line":"        sudo apxs -i -c $uwsgipath/apache2/mod_proxy_uwsgi.c"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_18fc4f3c","line":110,"range":{"start_line":104,"start_character":4,"end_line":110,"end_character":6},"updated":"2020-06-29 12:25:45.000000000","message":"You will simplify this block if you look for mod_proxy_uwsgi.c path by using find command.\n\n local mod_proxy_uwsgi_path\u003d$(find uwsgiout -name mod_proxy_uwsgi.c)\n if is_fedora; then\n     sudo apxs -i -c \"${mod_proxy_uwsgi_path}\"\n else\n     sudo apxs2 -i -c \"${mod_proxy_uwsgi_path}\"\n fi","commit_id":"5f0cd73e1038fb572e2a6c9390b308320e9378f2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3058e2a881d6a7ad3680e082830c015169fc367","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    # Unwrapped uwsgi can be wrapped with additional directory so"},{"line_number":103,"context_line":"    # we need to resolve a path to it."},{"line_number":104,"context_line":"    local extracted_files"},{"line_number":105,"context_line":"    extracted_files\u003d( $(ls $uwsgiout ) )"},{"line_number":106,"context_line":"    if [[ \"${#extracted_files[@]}\" \u003d\u003d \"1\" ]] ; then"},{"line_number":107,"context_line":"        local uwsgipath\u003d\"$uwsgiout/${extracted_files[0]}\""},{"line_number":108,"context_line":"    else"},{"line_number":109,"context_line":"        local uwsgipath\u003d\"$uwsgiout\""},{"line_number":110,"context_line":"    fi"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    if is_fedora; then"},{"line_number":113,"context_line":"        sudo apxs -i -c $uwsgipath/apache2/mod_proxy_uwsgi.c"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_2c7c6bea","line":110,"range":{"start_line":104,"start_character":4,"end_line":110,"end_character":6},"in_reply_to":"bf51134e_18fc4f3c","updated":"2020-06-30 09:35:35.000000000","message":"Except you\u0027d need to split the local declaration and the assignment into two lines in order not to hide possible errors.\n\nBut see also below.","commit_id":"5f0cd73e1038fb572e2a6c9390b308320e9378f2"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d3058e2a881d6a7ad3680e082830c015169fc367","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                        uwsgi-python3 \\"},{"line_number":155,"context_line":"                        apache2-mod_uwsgi"},{"line_number":156,"context_line":"    else"},{"line_number":157,"context_line":"        # Centos actually has the module in epel, but there was a big"},{"line_number":158,"context_line":"        # push to disable epel by default. As such, compile from source"},{"line_number":159,"context_line":"        # there."},{"line_number":160,"context_line":"        download_and_compile_uwsgi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_cc25ef0c","line":157,"updated":"2020-06-30 09:35:35.000000000","message":"Centos is handled by the \"is_fedora\" branch above, so this comment is misleading.\n\nActually I don\u0027t think we install from source on any distro anymore, so we should rather drop this branch.","commit_id":"5f0cd73e1038fb572e2a6c9390b308320e9378f2"},{"author":{"_account_id":27329,"name":"Federico Ressi","email":"fressi@redhat.com","username":"fressi_redhat"},"change_message_id":"aa79e11401f7b37c742b140793acf85655a39be1","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                        uwsgi-python3 \\"},{"line_number":155,"context_line":"                        apache2-mod_uwsgi"},{"line_number":156,"context_line":"    else"},{"line_number":157,"context_line":"        # Centos actually has the module in epel, but there was a big"},{"line_number":158,"context_line":"        # push to disable epel by default. As such, compile from source"},{"line_number":159,"context_line":"        # there."},{"line_number":160,"context_line":"        download_and_compile_uwsgi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_1d0fa1e1","line":157,"in_reply_to":"bf51134e_bb27c8b6","updated":"2020-07-08 07:55:24.000000000","message":"Please look at the log generated from centos job. Look for these lines. CentOS should give true to the is_fedora check.\n\nIt looks like line 160 is never executed, but line 150 yes it is.","commit_id":"5f0cd73e1038fb572e2a6c9390b308320e9378f2"},{"author":{"_account_id":31956,"name":"Ignacy Osetek","email":"iosetek@juniper.net","username":"iosetek"},"change_message_id":"656f8a6cda765c3a0d185a1a85b4c66e7e91a2ef","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                        uwsgi-python3 \\"},{"line_number":155,"context_line":"                        apache2-mod_uwsgi"},{"line_number":156,"context_line":"    else"},{"line_number":157,"context_line":"        # Centos actually has the module in epel, but there was a big"},{"line_number":158,"context_line":"        # push to disable epel by default. As such, compile from source"},{"line_number":159,"context_line":"        # there."},{"line_number":160,"context_line":"        download_and_compile_uwsgi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf51134e_bb27c8b6","line":157,"in_reply_to":"bf51134e_cc25ef0c","updated":"2020-07-06 08:59:17.000000000","message":"Are you sure about that one?\n\nBecause in my 5th patchset I made a small error by placing the wrong directory in this method. The Zuul accepted the change but I noticed that centos JOB failed so it seems that for centos job \"is_fedora\" was set to false.","commit_id":"5f0cd73e1038fb572e2a6c9390b308320e9378f2"}]}