)]}'
{"id":"openstack%2Fdevstack~737011","triplet_id":"openstack%2Fdevstack~master~I250231a2e63ebc67afe755124d7239f5457c72e2","project":"openstack/devstack","branch":"master","topic":"bug/1884256","hashtags":[],"change_id":"I250231a2e63ebc67afe755124d7239f5457c72e2","subject":"Add ensure-tox in devstack base job","status":"ABANDONED","created":"2020-06-19 14:03:57.000000000","updated":"2020-06-19 14:24:46.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"970eb509ab4101e1b1cb5a8e98fbdd421d90769f","_number":737011,"virtual_id_number":737011,"owner":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"date":"2020-06-19 14:24:41.000000000","_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":-1,"date":"2020-06-19 14:13:17.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-19 14:13:17.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"}],"messages":[{"id":"674670abe949f828597c628a49c32406498cbfd8","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-06-19 14:03:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8b5eb4e35bbf5c8c9a207871f3e4bd9132327982","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-06-19 14:13:17.000000000","message":"Patch Set 1: Code-Review-1\n\nI don\u0027t think we should do this, it will mask failures in the tox installation in lib/tempest, also other consumers may not need tox and then this is wasted time.","accounts_in_message":[],"_revision_number":1},{"id":"624898aa32317fbc752710649af5682e8d9e4a15","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-06-19 14:24:41.000000000","message":"Patch Set 1:\n\n\u003e I don\u0027t think we should do this, it will mask failures in the tox\n \u003e installation in lib/tempest, also other consumers may not need tox\n \u003e and then this is wasted time.\n\ndoing it on neutron side and if it is happening globally then we can reiterate- https://review.opendev.org/#/c/737016/","accounts_in_message":[],"_revision_number":1},{"id":"5d440cd5a697459c7959add06b87058d59578765","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2020-06-19 14:24:46.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8d9adc19f96d68b90de5db68aa3617f020588a23","revisions":{"8d9adc19f96d68b90de5db68aa3617f020588a23":{"kind":"REWORK","_number":1,"created":"2020-06-19 14:03:57.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/11/737011/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/11/737011/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/11/737011/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/11/737011/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/11/737011/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/11/737011/1"}}},"commit":{"parents":[{"commit":"a13ab8db2dbd959b5a1f52ac03d3fca07a19eb04","subject":"Merge \"Revert \"Work around uwsgi breakage\"\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/a13ab8db2dbd959b5a1f52ac03d3fca07a19eb04"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-06-19 13:57:12.000000000","tz":-300},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2020-06-19 14:03:56.000000000","tz":-300},"subject":"Add ensure-tox in devstack base job","message":"Add ensure-tox in devstack base job\n\ndevstack base jobs might be used for running the tox env.\nEven tempest jobs need tox to be present to run the tempest\ntests in venv. but devstack base jobs does not make sure tox\nis present or not using ensure-tox role.\n\nTempest jobs are fine as tox is being explicitly installed by install_tempest\n- https://opendev.org/openstack/devstack/src/branch/stable/stein/lib/tempest#L691-L708\n\nBut any other job not using devstack installing the tempest\nor devstack jobs used as base job for functional tests started failing on that,\nCurrent neutorn functional job failure-\n- https://zuul.opendev.org/t/openstack/build/59865004855c404ab18f06fc0ec1d005\n\nlet\u0027s call ensure-tox role in devstack base job itself to be safer side.\n\nChange-Id: I250231a2e63ebc67afe755124d7239f5457c72e2\nCloses-Bug: 1884256\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8d9adc19f96d68b90de5db68aa3617f020588a23"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/8d9adc19f96d68b90de5db68aa3617f020588a23"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}