)]}'
{"functions":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"70f6f6afc57162bfb4122060ffe99b9506ff3472","unresolved":false,"context_lines":[{"line_number":759,"context_line":"    local loopback_disk_size\u003d${3}"},{"line_number":760,"context_line":"    local key"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    # Create a loopback disk and format it to XFS."},{"line_number":763,"context_line":"    if [[ -e ${disk_image} ]]; then"},{"line_number":764,"context_line":"        if egrep -q ${storage_data_dir} /proc/mounts; then"},{"line_number":765,"context_line":"            sudo umount ${storage_data_dir}"},{"line_number":766,"context_line":"            sudo rm -f ${disk_image}"},{"line_number":767,"context_line":"        fi"},{"line_number":768,"context_line":"    fi"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    sudo mkdir -p ${storage_data_dir}/drives/images"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    sudo truncate -s ${loopback_disk_size} ${disk_image}"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    # Make a fresh XFS filesystem. Use bigger inodes so xattr can fit in"},{"line_number":775,"context_line":"    # a single inode. Keeping the default inode size (256) will result in multiple"},{"line_number":776,"context_line":"    # inodes being used to store xattr. Retrieving the xattr will be slower"},{"line_number":777,"context_line":"    # since we have to read multiple inodes. This statement is true for both"},{"line_number":778,"context_line":"    # Swift and Ceph."},{"line_number":779,"context_line":"    sudo mkfs.xfs -f -i size\u003d1024 ${disk_image}"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    # Unmount the target, if mounted"},{"line_number":782,"context_line":"    if egrep -q $storage_data_dir /proc/mounts; then"},{"line_number":783,"context_line":"        sudo umount $storage_data_dir"},{"line_number":784,"context_line":"    fi"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    # Clear any old fstab rules, install a new one for this disk, and mount it"},{"line_number":787,"context_line":"    key\u003d$(echo $disk_image | sed \u0027s#/.##\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f621f24_ea044a17","line":784,"range":{"start_line":762,"start_character":4,"end_line":784,"end_character":6},"updated":"2020-11-12 19:26:43.000000000","message":"Since we are changing logic here anyway - should not we simply rewrite this finally? This logic looks messy :/ e.g. why is there even that mkdir there?","commit_id":"6766f71d62af10f8b59b5f829a49752775e9dabe"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c588e2ed9aa15c875c94692007a0d9e2ed8f5bfa","unresolved":false,"context_lines":[{"line_number":759,"context_line":"    local loopback_disk_size\u003d${3}"},{"line_number":760,"context_line":"    local key"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    # Create a loopback disk and format it to XFS."},{"line_number":763,"context_line":"    if [[ -e ${disk_image} ]]; then"},{"line_number":764,"context_line":"        if egrep -q ${storage_data_dir} /proc/mounts; then"},{"line_number":765,"context_line":"            sudo umount ${storage_data_dir}"},{"line_number":766,"context_line":"            sudo rm -f ${disk_image}"},{"line_number":767,"context_line":"        fi"},{"line_number":768,"context_line":"    fi"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    sudo mkdir -p ${storage_data_dir}/drives/images"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    sudo truncate -s ${loopback_disk_size} ${disk_image}"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    # Make a fresh XFS filesystem. Use bigger inodes so xattr can fit in"},{"line_number":775,"context_line":"    # a single inode. Keeping the default inode size (256) will result in multiple"},{"line_number":776,"context_line":"    # inodes being used to store xattr. Retrieving the xattr will be slower"},{"line_number":777,"context_line":"    # since we have to read multiple inodes. This statement is true for both"},{"line_number":778,"context_line":"    # Swift and Ceph."},{"line_number":779,"context_line":"    sudo mkfs.xfs -f -i size\u003d1024 ${disk_image}"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    # Unmount the target, if mounted"},{"line_number":782,"context_line":"    if egrep -q $storage_data_dir /proc/mounts; then"},{"line_number":783,"context_line":"        sudo umount $storage_data_dir"},{"line_number":784,"context_line":"    fi"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    # Clear any old fstab rules, install a new one for this disk, and mount it"},{"line_number":787,"context_line":"    key\u003d$(echo $disk_image | sed \u0027s#/.##\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f621f24_4a9e1e07","line":784,"range":{"start_line":762,"start_character":4,"end_line":784,"end_character":6},"in_reply_to":"1f621f24_2a5c82eb","updated":"2020-11-12 20:46:19.000000000","message":"I believe the two \u0027if\u0027s can be simplified as well (the upper one and this lower one). I\u0027m fine to accept this change as it is though.","commit_id":"6766f71d62af10f8b59b5f829a49752775e9dabe"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"2e473dff145ad4479dd80f93809f85ff5cfae619","unresolved":false,"context_lines":[{"line_number":759,"context_line":"    local loopback_disk_size\u003d${3}"},{"line_number":760,"context_line":"    local key"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    # Create a loopback disk and format it to XFS."},{"line_number":763,"context_line":"    if [[ -e ${disk_image} ]]; then"},{"line_number":764,"context_line":"        if egrep -q ${storage_data_dir} /proc/mounts; then"},{"line_number":765,"context_line":"            sudo umount ${storage_data_dir}"},{"line_number":766,"context_line":"            sudo rm -f ${disk_image}"},{"line_number":767,"context_line":"        fi"},{"line_number":768,"context_line":"    fi"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"    sudo mkdir -p ${storage_data_dir}/drives/images"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"    sudo truncate -s ${loopback_disk_size} ${disk_image}"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    # Make a fresh XFS filesystem. Use bigger inodes so xattr can fit in"},{"line_number":775,"context_line":"    # a single inode. Keeping the default inode size (256) will result in multiple"},{"line_number":776,"context_line":"    # inodes being used to store xattr. Retrieving the xattr will be slower"},{"line_number":777,"context_line":"    # since we have to read multiple inodes. This statement is true for both"},{"line_number":778,"context_line":"    # Swift and Ceph."},{"line_number":779,"context_line":"    sudo mkfs.xfs -f -i size\u003d1024 ${disk_image}"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    # Unmount the target, if mounted"},{"line_number":782,"context_line":"    if egrep -q $storage_data_dir /proc/mounts; then"},{"line_number":783,"context_line":"        sudo umount $storage_data_dir"},{"line_number":784,"context_line":"    fi"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    # Clear any old fstab rules, install a new one for this disk, and mount it"},{"line_number":787,"context_line":"    key\u003d$(echo $disk_image | sed \u0027s#/.##\u0027)"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f621f24_2a5c82eb","line":784,"range":{"start_line":762,"start_character":4,"end_line":784,"end_character":6},"in_reply_to":"1f621f24_ea044a17","updated":"2020-11-12 19:53:46.000000000","message":"Yeah I dunno. I\u0027m happy to remove the mkdir, although I think it\u0027d be better to do it in a separate patch. I wanted to make this as minor of a change as possible for the new behavior, because it makes it easiest to detect if something broke that way.\n\nIf you want to change something else, that\u0027s cool but IMHO we should do it before or after this patch which just addresses the persistence aspect.\n\nWhat else, besides the extra mkdir do you want to change?","commit_id":"6766f71d62af10f8b59b5f829a49752775e9dabe"}]}