)]}'
{"lib/glance":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f432515c70f4687e08fcaf155632d2b5b0d452a4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":48,"context_line":"    LIBS_FROM_GIT\u003d\"glance_store\""},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_b90bc08b","line":48,"updated":"2020-08-07 13:58:57.000000000","message":"I could be wrong, but I don\u0027t think this is legit. I think anything merged in devstack should be expected to run with the released version of stuff. AFAIK, LIBS_FROM_GIT in a localrc is mostly for local developer testing, or for overriding in jobs to make sure we\u0027re testing against the master branch of another tree.\n\nEven still, always deploying from git here won\u0027t actually help anyone that runs devstack with this enabled until you have merged your glance_store patch, which I assume this is for. So I think we need to wait on this devstack patch until that glance_store one merges.","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a92169288302386686bedccd3182f528395f1cef","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":48,"context_line":"    LIBS_FROM_GIT\u003d\"glance_store\""},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_6ba66dc3","line":48,"in_reply_to":"9f560f44_14aa7383","updated":"2020-08-07 16:01:19.000000000","message":"Surely if those are required for glance_store when installed, then it should be putting them somewhere on the system right? \n\nLooks like glance_store/setup.cfg doesn\u0027t include any data_files and thus doesn\u0027t install the rootwrap rules. Maybe that\u0027s the bug?","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"613e63835c9840f14726dfe43c1c79c22f02d0db","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":48,"context_line":"    LIBS_FROM_GIT\u003d\"glance_store\""},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_8bdf810b","line":48,"in_reply_to":"9f560f44_6ba66dc3","updated":"2020-08-07 16:06:42.000000000","message":"I am not certain that it is a bug as those files needs only if we setup cinder as a glance store. Until now there was no devstack support to configure cinder store for glance or neither I seen any bug report around this issue.\n\nAlso I am not sure how reasonable it is to modify glance_store/setup.cfg.","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4e334a19cc677acb2f9dd01c4ac01bc5b9adfea6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":48,"context_line":"    LIBS_FROM_GIT\u003d\"glance_store\""},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_aeb373e8","line":48,"in_reply_to":"9f560f44_8bdf810b","updated":"2020-08-07 16:58:15.000000000","message":"I don\u0027t mean modify it here, I mean modify it in glance_store itself :)\n\nIf a real deployment is going to use glance_store with the cinder backend, don\u0027t they need those files installed on their system? If so, then glance_store should install them. If not, then I\u0027m not sure why devstack needs them.","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"80a046da7975c0e31069e272c6d81b8017fa14c7","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":48,"context_line":"    LIBS_FROM_GIT\u003d\"glance_store\""},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_0e41bfa9","line":48,"in_reply_to":"9f560f44_aeb373e8","updated":"2020-08-07 17:03:28.000000000","message":"Yes, real deployments which will use glance_store with cinder backend needs those files. Could be better if glance_store installs them.","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"62ab1aa3b7969d84bc992caf231704c937c8f655","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":48,"context_line":"    LIBS_FROM_GIT\u003d\"glance_store\""},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_14aa7383","line":48,"in_reply_to":"9f560f44_b90bc08b","updated":"2020-08-07 14:32:28.000000000","message":"Actually the case is that I need to copy contents from https://github.com/openstack/glance_store/tree/master/etc/glance to /etc/glance folder and this is not possible unless I clone the glance_store repo instead of installing it directly. \n\nAnother way I can think of is add those files under devstack repo and then if \u0027cinder_glance\u0027 is enabled then copy those to /etc/glance.\n\nIf you have any suggestions about the same, please let me know.","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f432515c70f4687e08fcaf155632d2b5b0d452a4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # Glance configure reserved stores"},{"line_number":172,"context_line":"        iniset $GLANCE_API_CONF os_glance_staging_store filesystem_store_datadir \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_staging_store/\""},{"line_number":173,"context_line":"        iniset $GLANCE_API_CONF os_glance_tasks_store filesystem_store_datadir \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_tasks_store/\""},{"line_number":174,"context_line":"    else"},{"line_number":175,"context_line":"        # Need to configure single cinder store for glance"},{"line_number":176,"context_line":"        iniset $GLANCE_API_CONF glance_store stores \"cinder, file, http\""},{"line_number":177,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store cinder"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_f90ff884","line":174,"updated":"2020-08-07 13:58:57.000000000","message":"I dunno what to suggest, but this now makes four places that the store config can be written. If cinder is not used, then two places in configure_glance(), one for single-store, one for multi-store. If cinder is used, then two more in here, for single and multi.\n\nIt would be great if we had one single-or-multi configuration place, and if cinder is enabled, update the variables that that code will use accordingly, but only do it in one place.","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"62ab1aa3b7969d84bc992caf231704c937c8f655","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        # Glance configure reserved stores"},{"line_number":172,"context_line":"        iniset $GLANCE_API_CONF os_glance_staging_store filesystem_store_datadir \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_staging_store/\""},{"line_number":173,"context_line":"        iniset $GLANCE_API_CONF os_glance_tasks_store filesystem_store_datadir \"${GLANCE_MULTISTORE_FILE_IMAGE_DIR}/os_glance_tasks_store/\""},{"line_number":174,"context_line":"    else"},{"line_number":175,"context_line":"        # Need to configure single cinder store for glance"},{"line_number":176,"context_line":"        iniset $GLANCE_API_CONF glance_store stores \"cinder, file, http\""},{"line_number":177,"context_line":"        iniset $GLANCE_API_CONF glance_store default_store cinder"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9f560f44_54806bf5","line":174,"in_reply_to":"9f560f44_f90ff884","updated":"2020-08-07 14:32:28.000000000","message":"I will try to create one function for the same.\nFact is I am not much familiar to shell scripting :D\n\nBut I will definitely try to refactor it.","commit_id":"3883003a57702468546115c8c1e17d9b214ca2dc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6ef4cd5dc708ff5100a17c05445fa0b84ac6bc08","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    if use_library_from_git \"glance_store\"; then"},{"line_number":466,"context_line":"        git_clone_by_name \"glance_store\""},{"line_number":467,"context_line":"        setup_dev_lib \"glance_store\" $(join_extras \"${glance_store_extras[@]}\")"},{"line_number":468,"context_line":"        copy_rootwrap True"},{"line_number":469,"context_line":"    else"},{"line_number":470,"context_line":"        # we still need to pass extras"},{"line_number":471,"context_line":"        pip_install_gr_extras glance-store $(join_extras \"${glance_store_extras[@]}\")"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_e06713ea","line":468,"updated":"2020-08-11 19:43:17.000000000","message":"I think better would be:\n\n copy_rootwrap ${DEST}/glance_store/etc\n\n...","commit_id":"dae1f00a066e461236b1f6831e41bd6e078df30b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"79b3d6781fbcecdf16dd771d59eabe89f266b393","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    if use_library_from_git \"glance_store\"; then"},{"line_number":466,"context_line":"        git_clone_by_name \"glance_store\""},{"line_number":467,"context_line":"        setup_dev_lib \"glance_store\" $(join_extras \"${glance_store_extras[@]}\")"},{"line_number":468,"context_line":"        copy_rootwrap True"},{"line_number":469,"context_line":"    else"},{"line_number":470,"context_line":"        # we still need to pass extras"},{"line_number":471,"context_line":"        pip_install_gr_extras glance-store $(join_extras \"${glance_store_extras[@]}\")"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_005047d4","line":468,"in_reply_to":"9f560f44_e06713ea","updated":"2020-08-11 19:56:41.000000000","message":"Done","commit_id":"dae1f00a066e461236b1f6831e41bd6e078df30b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6ef4cd5dc708ff5100a17c05445fa0b84ac6bc08","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    else"},{"line_number":470,"context_line":"        # we still need to pass extras"},{"line_number":471,"context_line":"        pip_install_gr_extras glance-store $(join_extras \"${glance_store_extras[@]}\")"},{"line_number":472,"context_line":"        copy_rootwrap False"},{"line_number":473,"context_line":"    fi"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    git_clone $GLANCE_REPO $GLANCE_DIR $GLANCE_BRANCH"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_c0648fe8","line":472,"updated":"2020-08-11 19:43:17.000000000","message":"and:\n\n copy_rootwrap $GLANCE_STORE_ROOTWRAP_BASE_DIR\n...","commit_id":"dae1f00a066e461236b1f6831e41bd6e078df30b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"79b3d6781fbcecdf16dd771d59eabe89f266b393","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    else"},{"line_number":470,"context_line":"        # we still need to pass extras"},{"line_number":471,"context_line":"        pip_install_gr_extras glance-store $(join_extras \"${glance_store_extras[@]}\")"},{"line_number":472,"context_line":"        copy_rootwrap False"},{"line_number":473,"context_line":"    fi"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"    git_clone $GLANCE_REPO $GLANCE_DIR $GLANCE_BRANCH"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f560f44_40635fb2","line":472,"in_reply_to":"9f560f44_c0648fe8","updated":"2020-08-11 19:56:41.000000000","message":"Done","commit_id":"dae1f00a066e461236b1f6831e41bd6e078df30b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6bf4fb4657e5fc528f271b186de509b814ce15e4","unresolved":false,"context_lines":[{"line_number":147,"context_line":"# config_param"},{"line_number":148,"context_line":"# config_value"},{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"function set_glance_store_params {"},{"line_number":151,"context_line":"    local config_section\u003d\"$1\""},{"line_number":152,"context_line":"    local config_param\u003d\"$2\""},{"line_number":153,"context_line":"    local config_value\u003d\"$3\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9f560f44_a946b61f","line":150,"range":{"start_line":150,"start_character":9,"end_line":150,"end_character":32},"updated":"2020-08-27 14:28:31.000000000","message":"This is a nit, but the naming here is confusing. This should probably be \"set_glance_api_conf\" or something. It has nothing to do with glance_store (AFAICT). I\u0027m also not sure it really saves anything since it\u0027s just implying the \"iniset $GLANCE_API_CONF\" which is maybe not much different than \"set_glance_store_params\" and it makes it harder to see what\u0027s going on in the places from which it\u0027s used :)","commit_id":"e45b1bc59accfa67216203c439ff93981a943d69"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b36857e104164f9e6f8ef25dadc7363a014b6bf8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"# config_param"},{"line_number":148,"context_line":"# config_value"},{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"function set_glance_store_params {"},{"line_number":151,"context_line":"    local config_section\u003d\"$1\""},{"line_number":152,"context_line":"    local config_param\u003d\"$2\""},{"line_number":153,"context_line":"    local config_value\u003d\"$3\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9f560f44_4b28a5ed","line":150,"range":{"start_line":150,"start_character":9,"end_line":150,"end_character":32},"in_reply_to":"9f560f44_890bf27a","updated":"2020-08-28 08:13:45.000000000","message":"Done","commit_id":"e45b1bc59accfa67216203c439ff93981a943d69"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc3c449ee88314933e4bc413eafe288f37bdded1","unresolved":false,"context_lines":[{"line_number":147,"context_line":"# config_param"},{"line_number":148,"context_line":"# config_value"},{"line_number":149,"context_line":"#"},{"line_number":150,"context_line":"function set_glance_store_params {"},{"line_number":151,"context_line":"    local config_section\u003d\"$1\""},{"line_number":152,"context_line":"    local config_param\u003d\"$2\""},{"line_number":153,"context_line":"    local config_value\u003d\"$3\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9f560f44_890bf27a","line":150,"range":{"start_line":150,"start_character":9,"end_line":150,"end_character":32},"in_reply_to":"9f560f44_a946b61f","updated":"2020-08-27 14:45:22.000000000","message":"Ack, will think of better name, or will try to get rid of it.","commit_id":"e45b1bc59accfa67216203c439ff93981a943d69"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6bf4fb4657e5fc528f271b186de509b814ce15e4","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            set_glance_store_params $be_name cinder_mount_point_base \"$GLANCE_NFS_MOUNTPOINT\""},{"line_number":173,"context_line":"        fi"},{"line_number":174,"context_line":"    done"},{"line_number":175,"context_line":"    set_glance_store_params DEFAULT enabled_backends ${enabled_backends::-1}"},{"line_number":176,"context_line":"    set_glance_store_params glance_store default_backend $GLANCE_CINDER_DEFAULT_BACKEND"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9f560f44_0919a220","line":175,"updated":"2020-08-27 14:28:31.000000000","message":"This is going to make it difficult to mix and match cinder and file backends. It would be better if we load and append the current value every time so that we could have some of each and not have them stomp all over each other..","commit_id":"e45b1bc59accfa67216203c439ff93981a943d69"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fc3c449ee88314933e4bc413eafe288f37bdded1","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            set_glance_store_params $be_name cinder_mount_point_base \"$GLANCE_NFS_MOUNTPOINT\""},{"line_number":173,"context_line":"        fi"},{"line_number":174,"context_line":"    done"},{"line_number":175,"context_line":"    set_glance_store_params DEFAULT enabled_backends ${enabled_backends::-1}"},{"line_number":176,"context_line":"    set_glance_store_params glance_store default_backend $GLANCE_CINDER_DEFAULT_BACKEND"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9f560f44_49639a42","line":175,"in_reply_to":"9f560f44_0919a220","updated":"2020-08-27 14:45:22.000000000","message":"Make sense, will try to work as per your suggestion.","commit_id":"e45b1bc59accfa67216203c439ff93981a943d69"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b36857e104164f9e6f8ef25dadc7363a014b6bf8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            set_glance_store_params $be_name cinder_mount_point_base \"$GLANCE_NFS_MOUNTPOINT\""},{"line_number":173,"context_line":"        fi"},{"line_number":174,"context_line":"    done"},{"line_number":175,"context_line":"    set_glance_store_params DEFAULT enabled_backends ${enabled_backends::-1}"},{"line_number":176,"context_line":"    set_glance_store_params glance_store default_backend $GLANCE_CINDER_DEFAULT_BACKEND"},{"line_number":177,"context_line":"}"},{"line_number":178,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"9f560f44_ebed39b8","line":175,"in_reply_to":"9f560f44_49639a42","updated":"2020-08-28 08:13:45.000000000","message":"At the moment, we are not configuring combination of different types of stores (see line #269), this is similar to old way that if you want to use cinder then default store is set to cinder under glance_store section.\n\nIMO, We can enhance this afterwards by considering all types of stores like swift, file, rbd and cinder.","commit_id":"e45b1bc59accfa67216203c439ff93981a943d69"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# configure_glance() - Set config files, create data dirs, etc"},{"line_number":139,"context_line":"function configure_glance {"},{"line_number":140,"context_line":"    sudo install -d -o $STACK_USER $GLANCE_CONF_DIR $GLANCE_METADEF_DIR"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # Set non-default configuration options for the API server"},{"line_number":143,"context_line":"    local dburl"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_8a290e39","side":"PARENT","line":140,"range":{"start_line":140,"start_character":36,"end_line":140,"end_character":51},"updated":"2020-09-14 17:12:53.000000000","message":"do not we need to create GLANCE_CONF_DIR here? we are changing all config file int this method also not only in copy_rootwrap","commit_id":"8a7726f4dcfd2e3a7707d919fdfcccb49336f43e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"# configure_glance() - Set config files, create data dirs, etc"},{"line_number":139,"context_line":"function configure_glance {"},{"line_number":140,"context_line":"    sudo install -d -o $STACK_USER $GLANCE_CONF_DIR $GLANCE_METADEF_DIR"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # Set non-default configuration options for the API server"},{"line_number":143,"context_line":"    local dburl"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_29444f47","side":"PARENT","line":140,"range":{"start_line":140,"start_character":36,"end_line":140,"end_character":51},"in_reply_to":"9f560f44_8a290e39","updated":"2020-09-14 17:42:38.000000000","message":"+1","commit_id":"8a7726f4dcfd2e3a7707d919fdfcccb49336f43e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"GLANCE_CINDER_DEFAULT_BACKEND\u003d${GLANCE_CINDER_DEFAULT_BACKEND:-lvmdriver-1}"},{"line_number":48,"context_line":"GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/local/etc/glance"},{"line_number":49,"context_line":"# Glance multi-store configuration"},{"line_number":50,"context_line":"# Boolean flag to enable multiple store configuration for glance"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_2fc29435","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":75},"updated":"2020-09-14 17:12:53.000000000","message":"can you add a comment here about GLANCE_CINDER_DEFAULT_BACKEND should be one of the value from CINDER_ENABLED_BACKENDS. This is help to configure it correctly.","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"GLANCE_CINDER_DEFAULT_BACKEND\u003d${GLANCE_CINDER_DEFAULT_BACKEND:-lvmdriver-1}"},{"line_number":48,"context_line":"GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/local/etc/glance"},{"line_number":49,"context_line":"# Glance multi-store configuration"},{"line_number":50,"context_line":"# Boolean flag to enable multiple store configuration for glance"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_65482d8a","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":75},"in_reply_to":"9f560f44_2fc29435","updated":"2020-09-14 17:42:38.000000000","message":"will submit it in new PS","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Default store/backend for glance, must be one of the store specified"},{"line_number":58,"context_line":"# in GLANCE_MULTIPLE_FILE_STORES option."},{"line_number":59,"context_line":"GLANCE_DEFAULT_BACKEND\u003d${GLANCE_DEFAULT_BACKEND:-fast}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"GLANCE_CACHE_DIR\u003d${GLANCE_CACHE_DIR:\u003d$DATA_DIR/glance/cache}"},{"line_number":62,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_eff53c86","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":22},"updated":"2020-09-14 17:12:53.000000000","message":"this and new var GLANCE_CINDER_DEFAULT_BACKEND are confusing. either we can use GLANCE_DEFAULT_BACKEND only for cinder backends or rename this to GLANCE_FILE_DEFAULT_BACKEND\n\nanyways this is nit.","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Default store/backend for glance, must be one of the store specified"},{"line_number":58,"context_line":"# in GLANCE_MULTIPLE_FILE_STORES option."},{"line_number":59,"context_line":"GLANCE_DEFAULT_BACKEND\u003d${GLANCE_DEFAULT_BACKEND:-fast}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"GLANCE_CACHE_DIR\u003d${GLANCE_CACHE_DIR:\u003d$DATA_DIR/glance/cache}"},{"line_number":62,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_a5424567","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":22},"in_reply_to":"9f560f44_eff53c86","updated":"2020-09-14 17:42:38.000000000","message":"Will correct it in different review","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    fi"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    # Configure glance_store"},{"line_number":292,"context_line":"    configure_glance_store $USE_CINDER_FOR_GLANCE $GLANCE_ENABLE_MULTIPLE_STORES $GLANCE_MULTIPLE_FILE_STORES $GLANCE_DEFAULT_BACKEND"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    # CORS feature support - to allow calls from Horizon by default"},{"line_number":295,"context_line":"    if [ -n \"$GLANCE_CORS_ALLOWED_ORIGIN\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_655cadf0","line":292,"range":{"start_line":292,"start_character":110,"end_line":292,"end_character":133},"updated":"2020-09-14 17:12:53.000000000","message":"you can use this directly in configure_multiple_file_stores","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    fi"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"    # Configure glance_store"},{"line_number":292,"context_line":"    configure_glance_store $USE_CINDER_FOR_GLANCE $GLANCE_ENABLE_MULTIPLE_STORES $GLANCE_MULTIPLE_FILE_STORES $GLANCE_DEFAULT_BACKEND"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    # CORS feature support - to allow calls from Horizon by default"},{"line_number":295,"context_line":"    if [ -n \"$GLANCE_CORS_ALLOWED_ORIGIN\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_e5727de4","line":292,"range":{"start_line":292,"start_character":110,"end_line":292,"end_character":133},"in_reply_to":"9f560f44_655cadf0","updated":"2020-09-14 17:42:38.000000000","message":"will change in new PS","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    fi"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    # No multiple stores for swift yet"},{"line_number":302,"context_line":"    if [[ \"$glance_enable_multiple_stores\" \u003d\u003d \"False\" ]]; then"},{"line_number":303,"context_line":"        # Store the images in swift if enabled."},{"line_number":304,"context_line":"        if is_service_enabled s-proxy; then"},{"line_number":305,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store swift"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_8f476078","line":302,"range":{"start_line":302,"start_character":0,"end_line":302,"end_character":62},"updated":"2020-09-14 17:12:53.000000000","message":"+1, i think now we can test multustore more correctly by no image in swift and all tests or job should get it from enable store.\n\nit will be good to mention this change in cmt msg.","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    fi"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    # No multiple stores for swift yet"},{"line_number":302,"context_line":"    if [[ \"$glance_enable_multiple_stores\" \u003d\u003d \"False\" ]]; then"},{"line_number":303,"context_line":"        # Store the images in swift if enabled."},{"line_number":304,"context_line":"        if is_service_enabled s-proxy; then"},{"line_number":305,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store swift"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_c5aad918","line":302,"range":{"start_line":302,"start_character":0,"end_line":302,"end_character":62},"in_reply_to":"9f560f44_8f476078","updated":"2020-09-14 17:42:38.000000000","message":"will do it in new PS","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    if use_library_from_git \"glance_store\"; then"},{"line_number":450,"context_line":"        git_clone_by_name \"glance_store\""},{"line_number":451,"context_line":"        setup_dev_lib \"glance_store\" $(join_extras \"${glance_store_extras[@]}\")"},{"line_number":452,"context_line":"        copy_rootwrap ${DEST}/glance_store/etc/glance"},{"line_number":453,"context_line":"    else"},{"line_number":454,"context_line":"        # we still need to pass extras"},{"line_number":455,"context_line":"        pip_install_gr_extras glance-store $(join_extras \"${glance_store_extras[@]}\")"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_effffc32","line":452,"range":{"start_line":452,"start_character":0,"end_line":452,"end_character":53},"updated":"2020-09-14 17:12:53.000000000","message":"For jobs tested with the master glance_store, do not we need this to copy in GLANCE_STORE_ROOTWRAP_BASE_DIR too? or there is no such job yet?","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    if use_library_from_git \"glance_store\"; then"},{"line_number":450,"context_line":"        git_clone_by_name \"glance_store\""},{"line_number":451,"context_line":"        setup_dev_lib \"glance_store\" $(join_extras \"${glance_store_extras[@]}\")"},{"line_number":452,"context_line":"        copy_rootwrap ${DEST}/glance_store/etc/glance"},{"line_number":453,"context_line":"    else"},{"line_number":454,"context_line":"        # we still need to pass extras"},{"line_number":455,"context_line":"        pip_install_gr_extras glance-store $(join_extras \"${glance_store_extras[@]}\")"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"9f560f44_45bfe95f","line":452,"range":{"start_line":452,"start_character":0,"end_line":452,"end_character":53},"in_reply_to":"9f560f44_effffc32","updated":"2020-09-14 17:42:38.000000000","message":"this copy_rootwrap will copy rootwrap files from above path (1st argument) to /etc/glance/*\n\nand else part is about when glance_store is installed using pip, it will copy those files from GLANCE_STORE_ROOTWRAP_BASE_DIR to /etc/glance/* directory","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba6b01c7fc490605c1fb1366cfe1ebfc48c2b8ad","unresolved":false,"context_lines":[{"line_number":32,"context_line":"GITDIR[\"python-glanceclient\"]\u003d$DEST/python-glanceclient"},{"line_number":33,"context_line":"GITDIR[\"glance_store\"]\u003d$DEST/glance_store"},{"line_number":34,"context_line":"GLANCE_DIR\u003d$DEST/glance"},{"line_number":35,"context_line":"GLANCE_NFS_MOUNTPOINT\u003d$DEST/data/glance/images/mnt"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Glance virtual environment"},{"line_number":38,"context_line":"if [[ ${USE_VENV} \u003d True ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_b1e4a70f","line":35,"updated":"2020-09-23 14:23:55.000000000","message":"better use $GLANCE_IMAGE_DIR/mnt and move this after the definition of that variable below","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"facf2a3a672b7ba48bb7e6ac01f9546603f314ec","unresolved":false,"context_lines":[{"line_number":32,"context_line":"GITDIR[\"python-glanceclient\"]\u003d$DEST/python-glanceclient"},{"line_number":33,"context_line":"GITDIR[\"glance_store\"]\u003d$DEST/glance_store"},{"line_number":34,"context_line":"GLANCE_DIR\u003d$DEST/glance"},{"line_number":35,"context_line":"GLANCE_NFS_MOUNTPOINT\u003d$DEST/data/glance/images/mnt"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Glance virtual environment"},{"line_number":38,"context_line":"if [[ ${USE_VENV} \u003d True ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_98eee388","line":35,"in_reply_to":"9f560f44_b1e4a70f","updated":"2020-09-23 15:27:37.000000000","message":"Done","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba6b01c7fc490605c1fb1366cfe1ebfc48c2b8ad","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"# GLANCE_CINDER_DEFAULT_BACKEND should be one of the value"},{"line_number":48,"context_line":"# from CINDER_ENABLED_BACKENDS"},{"line_number":49,"context_line":"GLANCE_CINDER_DEFAULT_BACKEND\u003d${GLANCE_CINDER_DEFAULT_BACKEND:-lvmdriver-1}"},{"line_number":50,"context_line":"GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/local/etc/glance"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_71932f4f","line":47,"range":{"start_line":47,"start_character":53,"end_line":47,"end_character":58},"updated":"2020-09-23 14:23:55.000000000","message":"Nit: values","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"facf2a3a672b7ba48bb7e6ac01f9546603f314ec","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# Cinder for Glance"},{"line_number":46,"context_line":"USE_CINDER_FOR_GLANCE\u003d$(trueorfalse False USE_CINDER_FOR_GLANCE)"},{"line_number":47,"context_line":"# GLANCE_CINDER_DEFAULT_BACKEND should be one of the value"},{"line_number":48,"context_line":"# from CINDER_ENABLED_BACKENDS"},{"line_number":49,"context_line":"GLANCE_CINDER_DEFAULT_BACKEND\u003d${GLANCE_CINDER_DEFAULT_BACKEND:-lvmdriver-1}"},{"line_number":50,"context_line":"GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/local/etc/glance"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_588d6bd2","line":47,"range":{"start_line":47,"start_character":53,"end_line":47,"end_character":58},"in_reply_to":"9f560f44_71932f4f","updated":"2020-09-23 15:27:37.000000000","message":"Done","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba6b01c7fc490605c1fb1366cfe1ebfc48c2b8ad","unresolved":false,"context_lines":[{"line_number":49,"context_line":"GLANCE_CINDER_DEFAULT_BACKEND\u003d${GLANCE_CINDER_DEFAULT_BACKEND:-lvmdriver-1}"},{"line_number":50,"context_line":"GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/local/etc/glance"},{"line_number":51,"context_line":"# NOTE (abhishekk): For opensuse data files are stored in different directory"},{"line_number":52,"context_line":"if is_opensuse; then"},{"line_number":53,"context_line":"    GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/etc/glance"},{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_51838b03","line":52,"updated":"2020-09-23 14:23:55.000000000","message":"I\u0027m not sure whether this would happen for rhel/fedora, too, c.f. the code for setting bindir in lib/nova. Did you test this on fedora/centos?","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"facf2a3a672b7ba48bb7e6ac01f9546603f314ec","unresolved":false,"context_lines":[{"line_number":49,"context_line":"GLANCE_CINDER_DEFAULT_BACKEND\u003d${GLANCE_CINDER_DEFAULT_BACKEND:-lvmdriver-1}"},{"line_number":50,"context_line":"GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/local/etc/glance"},{"line_number":51,"context_line":"# NOTE (abhishekk): For opensuse data files are stored in different directory"},{"line_number":52,"context_line":"if is_opensuse; then"},{"line_number":53,"context_line":"    GLANCE_STORE_ROOTWRAP_BASE_DIR\u003d/usr/etc/glance"},{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":"# Glance multi-store configuration"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_788dcf2f","line":52,"in_reply_to":"9f560f44_51838b03","updated":"2020-09-23 15:27:37.000000000","message":"I have verified that this for fedora, rootwrap base dir is same as line #50","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba6b01c7fc490605c1fb1366cfe1ebfc48c2b8ad","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    fi"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set multiple cinder store related config option for each of the cinder store"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"function configure_multiple_cinder_stores {"},{"line_number":152,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_d16e7b62","line":149,"range":{"start_line":149,"start_character":43,"end_line":149,"end_character":49},"updated":"2020-09-23 14:23:55.000000000","message":"Nit: options","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"facf2a3a672b7ba48bb7e6ac01f9546603f314ec","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    fi"},{"line_number":147,"context_line":"}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set multiple cinder store related config option for each of the cinder store"},{"line_number":150,"context_line":"#"},{"line_number":151,"context_line":"function configure_multiple_cinder_stores {"},{"line_number":152,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_d8b21b96","line":149,"range":{"start_line":149,"start_character":43,"end_line":149,"end_character":49},"in_reply_to":"9f560f44_d16e7b62","updated":"2020-09-23 15:27:37.000000000","message":"Done","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba6b01c7fc490605c1fb1366cfe1ebfc48c2b8ad","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            # set cinder related store parameters"},{"line_number":239,"context_line":"            set_common_cinder_store_params glance_store"},{"line_number":240,"context_line":"            # set nfs mount_point dir"},{"line_number":241,"context_line":"            for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":242,"context_line":"                local be_name\u003d${be##*:}"},{"line_number":243,"context_line":"                if [[ \"$be_name\" \u003d\u003d \"nfs\" ]]; then"},{"line_number":244,"context_line":"                    mkdir -p $GLANCE_NFS_MOUNTPOINT"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_b1f7878c","line":241,"range":{"start_line":241,"start_character":16,"end_line":241,"end_character":18},"updated":"2020-09-23 14:23:55.000000000","message":"make that a local variable, too?","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"facf2a3a672b7ba48bb7e6ac01f9546603f314ec","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            # set cinder related store parameters"},{"line_number":239,"context_line":"            set_common_cinder_store_params glance_store"},{"line_number":240,"context_line":"            # set nfs mount_point dir"},{"line_number":241,"context_line":"            for be in ${CINDER_ENABLED_BACKENDS//,/ }; do"},{"line_number":242,"context_line":"                local be_name\u003d${be##*:}"},{"line_number":243,"context_line":"                if [[ \"$be_name\" \u003d\u003d \"nfs\" ]]; then"},{"line_number":244,"context_line":"                    mkdir -p $GLANCE_NFS_MOUNTPOINT"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_38a35745","line":241,"range":{"start_line":241,"start_character":16,"end_line":241,"end_character":18},"in_reply_to":"9f560f44_b1f7878c","updated":"2020-09-23 15:27:37.000000000","message":"Done","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba6b01c7fc490605c1fb1366cfe1ebfc48c2b8ad","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    fi"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    # No multiple stores for swift yet"},{"line_number":300,"context_line":"    if [[ \"$glance_enable_multiple_stores\" \u003d\u003d \"False\" ]]; then"},{"line_number":301,"context_line":"        # Store the images in swift if enabled."},{"line_number":302,"context_line":"        if is_service_enabled s-proxy; then"},{"line_number":303,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store swift"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_f1429fab","line":300,"range":{"start_line":300,"start_character":12,"end_line":300,"end_character":41},"updated":"2020-09-23 14:23:55.000000000","message":"This is a local variable in configure_glance_store() only?\nYou likely want GLANCE_ENABLE_MULTIPLE_STORES instead.","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"facf2a3a672b7ba48bb7e6ac01f9546603f314ec","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    fi"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    # No multiple stores for swift yet"},{"line_number":300,"context_line":"    if [[ \"$glance_enable_multiple_stores\" \u003d\u003d \"False\" ]]; then"},{"line_number":301,"context_line":"        # Store the images in swift if enabled."},{"line_number":302,"context_line":"        if is_service_enabled s-proxy; then"},{"line_number":303,"context_line":"            iniset $GLANCE_API_CONF glance_store default_store swift"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9f560f44_3ec17f4f","line":300,"range":{"start_line":300,"start_character":12,"end_line":300,"end_character":41},"in_reply_to":"9f560f44_f1429fab","updated":"2020-09-23 15:27:37.000000000","message":"Done","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"}],"stack.sh":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":1289,"context_line":"    create_volume_types"},{"line_number":1290,"context_line":"fi"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1293,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"},{"line_number":1299,"context_line":"if is_service_enabled glance; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f560f44_af8064f9","line":1296,"range":{"start_line":1292,"start_character":0,"end_line":1296,"end_character":2},"updated":"2020-09-14 17:12:53.000000000","message":"can you add this just before where creating the image-volume?","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":1289,"context_line":"    create_volume_types"},{"line_number":1290,"context_line":"fi"},{"line_number":1291,"context_line":""},{"line_number":1292,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1293,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"},{"line_number":1299,"context_line":"if is_service_enabled glance; then"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f560f44_85a0e144","line":1296,"range":{"start_line":1292,"start_character":0,"end_line":1296,"end_character":2},"in_reply_to":"9f560f44_af8064f9","updated":"2020-09-14 17:42:38.000000000","message":"No use if it is moved as the reason is mentioned in below comment applies here as well","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"766940b25373facf15488c17e62b38edcefb1765","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"},{"line_number":1299,"context_line":"if is_service_enabled glance; then"},{"line_number":1300,"context_line":"    echo_summary \"Starting Glance\""},{"line_number":1301,"context_line":"    start_glance"},{"line_number":1302,"context_line":"fi"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"# Install Images"},{"line_number":1305,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f560f44_8f42c00e","line":1302,"range":{"start_line":1297,"start_character":0,"end_line":1302,"end_character":2},"updated":"2020-09-14 17:12:53.000000000","message":"we do not need to move this glance start, we can only move image upload things after cinder service started","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c6ba26fadf524fedba4dc2231d4ab8291db1948a","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"},{"line_number":1299,"context_line":"if is_service_enabled glance; then"},{"line_number":1300,"context_line":"    echo_summary \"Starting Glance\""},{"line_number":1301,"context_line":"    start_glance"},{"line_number":1302,"context_line":"fi"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"# Install Images"},{"line_number":1305,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f560f44_eed4e74d","line":1302,"range":{"start_line":1297,"start_character":0,"end_line":1302,"end_character":2},"in_reply_to":"9f560f44_47da234b","updated":"2020-09-17 07:08:06.000000000","message":"Done","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9a204b3496d7009c95ef7f7e4c69aa9d5bab842b","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"},{"line_number":1299,"context_line":"if is_service_enabled glance; then"},{"line_number":1300,"context_line":"    echo_summary \"Starting Glance\""},{"line_number":1301,"context_line":"    start_glance"},{"line_number":1302,"context_line":"fi"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"# Install Images"},{"line_number":1305,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f560f44_c5fc9941","line":1302,"range":{"start_line":1297,"start_character":0,"end_line":1302,"end_character":2},"in_reply_to":"9f560f44_8f42c00e","updated":"2020-09-14 17:42:38.000000000","message":"when glance service starts it initializes the driver. In case of multiple cinder stores glance-api service will query cinder to validate volume-type defined for each of the store. \n\nSo we need to start glance-api service only after cinder service is started.","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"41b8a6874020c3bfdef96a03d7a419cf37f0741c","unresolved":false,"context_lines":[{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"},{"line_number":1299,"context_line":"if is_service_enabled glance; then"},{"line_number":1300,"context_line":"    echo_summary \"Starting Glance\""},{"line_number":1301,"context_line":"    start_glance"},{"line_number":1302,"context_line":"fi"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"# Install Images"},{"line_number":1305,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":10,"id":"9f560f44_47da234b","line":1302,"range":{"start_line":1297,"start_character":0,"end_line":1302,"end_character":2},"in_reply_to":"9f560f44_c5fc9941","updated":"2020-09-16 18:22:28.000000000","message":"ok, I think that is good to add a comment about it so that we do not move this up accidentally. But I am not blocking for that in case you want to do it in followup or I will re+2 if you respin.","commit_id":"744851c217441e3847a67c057f4de6ed73aa1c61"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ba6b01c7fc490605c1fb1366cfe1ebfc48c2b8ad","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1293,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9f560f44_d1db1be7","line":1295,"updated":"2020-09-23 14:23:55.000000000","message":"Can we somehow actively check for service availability instead of doing a sleep?","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"facf2a3a672b7ba48bb7e6ac01f9546603f314ec","unresolved":false,"context_lines":[{"line_number":1292,"context_line":"# This sleep is required for cinder volume service to become active and"},{"line_number":1293,"context_line":"# publish capabilities to cinder scheduler before creating the image-volume"},{"line_number":1294,"context_line":"if [[ \"$USE_CINDER_FOR_GLANCE\" \u003d\u003d \"True\" ]]; then"},{"line_number":1295,"context_line":"    sleep 30"},{"line_number":1296,"context_line":"fi"},{"line_number":1297,"context_line":""},{"line_number":1298,"context_line":"# Launch the Glance services"}],"source_content_type":"text/x-sh","patch_set":13,"id":"9f560f44_b8ff6764","line":1295,"in_reply_to":"9f560f44_d1db1be7","updated":"2020-09-23 15:27:37.000000000","message":"Not sure how to do this, but can we do it as a improvement in different patch?","commit_id":"2f2f6108b3810c4834741ca7e4f101a221e576eb"}]}