)]}'
{"id":"openstack%2Fdevstack~75308","triplet_id":"openstack%2Fdevstack~master~Ie486cf3395b6acf3a10eb32e116d39ca56134b9f","project":"openstack/devstack","branch":"master","topic":"swift-nested-fn","hashtags":[],"change_id":"Ie486cf3395b6acf3a10eb32e116d39ca56134b9f","subject":"Un-nest generate_swift_config","status":"MERGED","created":"2014-02-21 04:40:36.000000000","updated":"2014-02-24 04:33:30.000000000","submitted":"2014-02-24 04:33:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ed56d3201295793cffe604d5cae17943138ecfef","_number":75308,"virtual_id_number":75308,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":2,"date":"2014-02-24 04:33:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"all":[{"value":2,"date":"2014-02-21 23:40:06.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2014-02-22 06:39:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":2,"date":"2014-02-24 01:43:56.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":0,"date":"2014-02-21 23:40:06.000000000","_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-02-21 04:41:29.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2014-02-21 04:41:15.000000000","_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":1,"date":"2014-02-24 01:43:56.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-21 04:41:15.000000000","updated_by":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"reviewer":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"state":"REVIEWER"},{"updated":"2014-02-21 04:41:29.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-02-21 23:40:06.000000000","updated_by":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"reviewer":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"state":"REVIEWER"},{"updated":"2014-02-24 01:43:56.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-02-24 04:33:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9731d100f69f2a11db33ad7ff0eae53c003229e9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-21 04:40:37.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2049b7e6de0c59e05b7a78f468b04c8a2f87b4aa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-21 05:33:05.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/08/75308/1/check/gate-devstack-bash8/f31c4c3 : SUCCESS in 9s\n- check-devstack-dsvm-cells http://logs.openstack.org/08/75308/1/check/check-devstack-dsvm-cells/f7dc527 : SUCCESS in 13m 46s\n- check-tempest-dsvm-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-full/3e6d5c3 : SUCCESS in 50m 25s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-postgres-full/2fe27c8 : SUCCESS in 46m 39s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-neutron/6ecd545 : SUCCESS in 33m 18s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-neutron-full/714e69f : SUCCESS in 40m 22s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/75308/1/check/gate-tempest-dsvm-large-ops/c124900 : SUCCESS in 13m 39s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/75308/1/check/gate-tempest-dsvm-neutron-large-ops/5308393 : SUCCESS in 12m 40s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-neutron-heat-slow/105754b : SUCCESS in 20m 07s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-cells-full/7e2c1b0 : FAILURE in 35m 06s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/08/75308/1/check/check-grenade-dsvm/2216e7c : SUCCESS in 34m 10s\n- check-swift-dsvm-functional http://logs.openstack.org/08/75308/1/check/check-swift-dsvm-functional/ac92c0d : SUCCESS in 12m 57s\n- check-devstack-dsvm-neutron http://logs.openstack.org/08/75308/1/check/check-devstack-dsvm-neutron/c462235 : FAILURE in 14m 33s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-ironic-nv/f0e941d : SUCCESS in 24m 32s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-ironic-postgres-nv/64746f6 : SUCCESS in 26m 57s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-savanna-full-nv/9385a05 : SUCCESS in 38m 31s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-savanna-postgres-nv/a21d2f7 : SUCCESS in 21m 10s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-savanna-neutron-nv/f3a5aa4 : SUCCESS in 31m 29s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"84ddb2bd98ef59f7babb51f8400d23ec5cb32096","author":{"_account_id":866,"name":"Chmouel Boudjnah","email":"chmouel@chmouel.com","username":"chmouel"},"date":"2014-02-21 23:40:06.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nwell it was not accidental when I did it (a long time ago) but I guess this is not very usual in Bash Shell and may be a bit more easy to read on the eyes.","accounts_in_message":[],"_revision_number":1},{"id":"a751b3225ac30070e9c46a2843dca38ffbcb8036","author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"date":"2014-02-22 06:39:58.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"310bc0d66f38ac7b1866d0c10e1ec80e858bd07d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 01:43:56.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"d66862563911c8f04cd14ebd368cfef49e5b3684","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-02-24 01:43:56.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d12300d3ff20eeb38d35b7bfdca9e12b4190adbe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 02:46:13.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/08/75308/1/check/gate-devstack-bash8/9f051f8 : SUCCESS in 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/08/75308/1/check/check-devstack-dsvm-cells/559b10c : SUCCESS in 11m 27s\n- check-tempest-dsvm-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-full/3fd5861 : SUCCESS in 52m 58s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-postgres-full/715b2c2 : SUCCESS in 57m 32s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-neutron/4b93d40 : SUCCESS in 35m 53s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-neutron-full/25119d1 : SUCCESS in 50m 10s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/75308/1/check/gate-tempest-dsvm-large-ops/93d82db : SUCCESS in 15m 33s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/75308/1/check/gate-tempest-dsvm-neutron-large-ops/4bd8f27 : SUCCESS in 16m 17s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-neutron-heat-slow/962b9cf : SUCCESS in 19m 27s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-cells-full/b566c94 : FAILURE in 22m 54s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/08/75308/1/check/check-grenade-dsvm/aa7219f : SUCCESS in 26m 14s\n- check-swift-dsvm-functional http://logs.openstack.org/08/75308/1/check/check-swift-dsvm-functional/0fb5b62 : SUCCESS in 12m 05s\n- check-devstack-dsvm-neutron http://logs.openstack.org/08/75308/1/check/check-devstack-dsvm-neutron/c1c4299 : FAILURE in 15m 58s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-ironic-nv/80d6cb0 : SUCCESS in 24m 04s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-ironic-postgres-nv/f5f4513 : SUCCESS in 27m 12s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-savanna-full-nv/30116b4 : SUCCESS in 37m 30s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-savanna-postgres-nv/99a2dff : SUCCESS in 20m 01s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/08/75308/1/check/check-tempest-dsvm-savanna-neutron-nv/315da4d : SUCCESS in 34m 37s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"3b21aef9562f79fef3d8fb9837c9e7c3f0aad7cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 02:46:15.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"30563e3efd283902946082b64cf3d3242fcd33f6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 04:33:29.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/08/75308/1/gate/gate-devstack-bash8/00fa800 : SUCCESS in 4s\n- gate-devstack-dsvm-cells http://logs.openstack.org/08/75308/1/gate/gate-devstack-dsvm-cells/bdaf4fb : SUCCESS in 11m 52s\n- gate-tempest-dsvm-full http://logs.openstack.org/08/75308/1/gate/gate-tempest-dsvm-full/e40973d : SUCCESS in 43m 25s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/08/75308/1/gate/gate-tempest-dsvm-postgres-full/efc00dc : SUCCESS in 58m 53s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/08/75308/1/gate/gate-tempest-dsvm-neutron/c2d8841 : SUCCESS in 33m 03s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/75308/1/gate/gate-tempest-dsvm-large-ops/bbdac57 : SUCCESS in 16m 52s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/75308/1/gate/gate-tempest-dsvm-neutron-large-ops/183714b : SUCCESS in 12m 51s\n- gate-grenade-dsvm http://logs.openstack.org/08/75308/1/gate/gate-grenade-dsvm/23afedf : SUCCESS in 34m 34s\n- gate-swift-dsvm-functional http://logs.openstack.org/08/75308/1/gate/gate-swift-dsvm-functional/159f08f : SUCCESS in 14m 41s\n","accounts_in_message":[],"_revision_number":1},{"id":"377a664bb1a38a627bcc7aff2a6a6ddca7159cb1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 04:33:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f8e86bb3129c6aa5cb9c70ceb2a55f01b2dd1bf0","revisions":{"f8e86bb3129c6aa5cb9c70ceb2a55f01b2dd1bf0":{"kind":"REWORK","_number":1,"created":"2014-02-21 04:40:36.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/08/75308/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/08/75308/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/08/75308/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/08/75308/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/08/75308/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/08/75308/1"}}},"commit":{"parents":[{"commit":"5d920e02e30f375253ff9a5f6fef010c95c2fb4b","subject":"Merge \"add heat to the default devstack service list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5d920e02e30f375253ff9a5f6fef010c95c2fb4b"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-21 04:16:31.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-21 04:40:19.000000000","tz":660},"subject":"Un-nest generate_swift_config","message":"Un-nest generate_swift_config\n\nI think this got accidentally nested during some code refactorizing?\n\nChange-Id: Ie486cf3395b6acf3a10eb32e116d39ca56134b9f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f8e86bb3129c6aa5cb9c70ceb2a55f01b2dd1bf0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f8e86bb3129c6aa5cb9c70ceb2a55f01b2dd1bf0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}