)]}'
{"id":"openstack%2Fdevstack~75314","triplet_id":"openstack%2Fdevstack~master~I5e547d87b3921fc7ce6588c28f074e5c9f489c1f","project":"openstack/devstack","branch":"master","topic":"bash8-eof-check","hashtags":[],"change_id":"I5e547d87b3921fc7ce6588c28f074e5c9f489c1f","subject":"Add end-of-file checks to bash8","status":"MERGED","created":"2014-02-21 05:16:56.000000000","updated":"2014-02-27 04:36:59.000000000","submitted":"2014-02-27 04:36:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1019d375ac33ab42920c964d92d5b43e2a5eb7af","_number":75314,"virtual_id_number":75314,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-02-27 04:36:59.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":2,"date":"2014-02-27 00:36:36.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2014-02-25 22:40:39.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2014-02-26 12:30:02.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":1,"date":"2014-02-27 00:36:36.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"date":"2014-02-26 12:30:02.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-25 01:24:10.000000000","updated_by":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"reviewer":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"state":"REVIEWER"},{"updated":"2014-02-26 12:30:02.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2014-02-27 00:36:36.000000000","updated_by":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"reviewer":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"state":"REVIEWER"},{"updated":"2014-02-27 04:36:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c8045c5cab500de5218f4c19d1b9650f3daa0827","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-21 05:16:56.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"059f8d5dff5ee24bbb7d503a445906f0b0d168ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-21 06:08:50.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-devstack-bash8 http://logs.openstack.org/14/75314/1/check/gate-devstack-bash8/6a0cda2 : SUCCESS in 10s\n- check-devstack-dsvm-cells http://logs.openstack.org/14/75314/1/check/check-devstack-dsvm-cells/d7112f0 : FAILURE in 4m 52s\n- check-tempest-dsvm-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-full/a99a7d3 : SUCCESS in 36m 13s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-postgres-full/479bcaa : SUCCESS in 50m 32s\n- check-tempest-dsvm-neutron http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-neutron/caea44c : SUCCESS in 28m 50s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-neutron-full/1bb4dfa : SUCCESS in 50m 32s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/14/75314/1/check/gate-tempest-dsvm-large-ops/ab1cd70 : SUCCESS in 14m 19s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/14/75314/1/check/gate-tempest-dsvm-neutron-large-ops/415025c : SUCCESS in 15m 32s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-neutron-heat-slow/5977293 : SUCCESS in 21m 49s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-cells-full/412a81a : FAILURE in 4m 33s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/14/75314/1/check/check-grenade-dsvm/4b497c1 : SUCCESS in 26m 37s\n- check-swift-dsvm-functional http://logs.openstack.org/14/75314/1/check/check-swift-dsvm-functional/71791ce : SUCCESS in 13m 40s\n- check-devstack-dsvm-neutron http://logs.openstack.org/14/75314/1/check/check-devstack-dsvm-neutron/c28f5da : FAILURE in 17m 32s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-ironic-nv/38ed7bb : FAILURE in 3m 57s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-ironic-postgres-nv/14a22b0 : SUCCESS in 30m 20s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-savanna-full-nv/f42d68a : SUCCESS in 51m 50s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-savanna-postgres-nv/f570894 : SUCCESS in 16m 07s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-savanna-neutron-nv/4c5af10 : FAILURE in 5m 22s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"a2a060c45f21d8f9c335181926b298a54ed62e46","author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"date":"2014-02-24 08:08:53.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\nminor comments inline","accounts_in_message":[],"_revision_number":1},{"id":"92d28e26fbabd89a4638762e7ad44b27664b8ec8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 08:08:55.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"893fe6817f640de89a3c445a22f06d4e97c77104","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 08:52:51.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-devstack-bash8 http://logs.openstack.org/14/75314/1/check/gate-devstack-bash8/b27b753 : SUCCESS in 8s\n- check-devstack-dsvm-cells http://logs.openstack.org/14/75314/1/check/check-devstack-dsvm-cells/409ed81 : SUCCESS in 12m 53s\n- check-tempest-dsvm-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-full/a67f446 : SUCCESS in 41m 42s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-postgres-full/4bf4aa3 : FAILURE in 7m 07s\n- check-tempest-dsvm-neutron http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-neutron/cd60852 : SUCCESS in 34m 49s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-neutron-full/534a3d3 : SUCCESS in 38m 57s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/14/75314/1/check/gate-tempest-dsvm-large-ops/84fd562 : SUCCESS in 12m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/14/75314/1/check/gate-tempest-dsvm-neutron-large-ops/f9f8e1b : SUCCESS in 12m 34s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-neutron-heat-slow/a3f38ad : SUCCESS in 19m 26s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-cells-full/e240b98 : FAILURE in 8m 18s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/14/75314/1/check/check-grenade-dsvm/cf2f013 : SUCCESS in 32m 02s\n- check-swift-dsvm-functional http://logs.openstack.org/14/75314/1/check/check-swift-dsvm-functional/4762c04 : SUCCESS in 14m 30s\n- check-devstack-dsvm-neutron http://logs.openstack.org/14/75314/1/check/check-devstack-dsvm-neutron/5310d33 : FAILURE in 13m 52s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-ironic-nv/2a3b10b : SUCCESS in 27m 40s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-ironic-postgres-nv/2e40556 : SUCCESS in 26m 20s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-savanna-full-nv/e89f6ff : SUCCESS in 43m 52s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-savanna-postgres-nv/92684d0 : SUCCESS in 16m 46s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/14/75314/1/check/check-tempest-dsvm-savanna-neutron-nv/d893356 : SUCCESS in 34m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"482aa8e0c659bb06d4a913c8ccab0ed3c86aeeb6","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-24 21:18:35.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e02c6a74a60d26bebb7ebeb5ee084c70e5bed315","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-24 21:18:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cf31486f4d8c4ebc2123c27609562227082b97f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 21:18:51.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c996a05c4762c8ac076931dc42783665f73a2baa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-24 22:12:58.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-devstack-bash8 http://logs.openstack.org/14/75314/2/check/gate-devstack-bash8/ffdea2f : SUCCESS in 26s\n- check-devstack-dsvm-cells http://logs.openstack.org/14/75314/2/check/check-devstack-dsvm-cells/33cbfbb : SUCCESS in 13m 56s\n- check-tempest-dsvm-full http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-full/76e9a40 : SUCCESS in 45m 27s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-postgres-full/c83baf7 : FAILURE in 8m 44s\n- check-tempest-dsvm-neutron http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-neutron/65be188 : FAILURE in 8m 20s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-neutron-full/061e2f1 : SUCCESS in 47m 26s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/14/75314/2/check/gate-tempest-dsvm-large-ops/a13199d : SUCCESS in 12m 51s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/14/75314/2/check/gate-tempest-dsvm-neutron-large-ops/f12a8bf : SUCCESS in 14m 11s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-neutron-heat-slow/7ff3118 : FAILURE in 10m 28s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-cells-full/549131e : FAILURE in 27m 40s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/14/75314/2/check/check-grenade-dsvm/147431e : FAILURE in 33m 00s\n- check-swift-dsvm-functional http://logs.openstack.org/14/75314/2/check/check-swift-dsvm-functional/b4fff10 : SUCCESS in 13m 04s\n- check-devstack-dsvm-neutron http://logs.openstack.org/14/75314/2/check/check-devstack-dsvm-neutron/328b92b : FAILURE in 9m 17s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-ironic-nv/d6d800d : SUCCESS in 25m 20s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-ironic-postgres-nv/71200d1 : SUCCESS in 33m 49s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-savanna-full-nv/5d2a0a1 : SUCCESS in 49m 25s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-savanna-postgres-nv/96b869e : SUCCESS in 20m 19s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/14/75314/2/check/check-tempest-dsvm-savanna-neutron-nv/52b498c : SUCCESS in 34m 37s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"0e191e76a9966d91dab32faa080cb76674529beb","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-02-24 22:20:55.000000000","message":"Patch Set 2:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://ca.downloads.xensource.com/OpenStack/xenserver-ci/refs/changes/14/75314/2/\n\nRecheck supported; use \"citrix recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.","accounts_in_message":[],"_revision_number":2},{"id":"d314bc39bc2e4bb2c0e9e5c3a5e572fe368a56b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 00:16:02.000000000","message":"Patch Set 2: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"59b35f754724033d92d784717367e3e1ddd81cdd","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-25 00:16:02.000000000","message":"Patch Set 2:\n\nrecheck bug #1283961","accounts_in_message":[],"_revision_number":2},{"id":"b35ac3ec62f87f71121b07f1f1b79c56755caebd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 00:16:03.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"727f3fccb19d7f2fdf56424f435f7d3f5b4b68d1","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-25 00:16:59.000000000","message":"Patch Set 2:\n\nrecheck bug 1283961","accounts_in_message":[],"_revision_number":2},{"id":"031a377f39d820b071820c9fbc221331104243dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 00:17:00.000000000","message":"Patch Set 2: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3bf28d39e88d30a761f05a74a352ec690ed11266","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 00:17:01.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"7168cab0abb7c6988da65a36f232cac7a1a097b9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 00:18:28.000000000","message":"Patch Set 2: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c3c6c207efe3a988b4b23e0d92af60aaf7ab728c","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-25 00:18:28.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"e7da57f5dc50592a3b3a628582673e92b0b50a3b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 00:18:30.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"1c58663b50430b46cdae7a8d74127e76a1404f78","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-25 00:24:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"00fced4da2fed69bb0cec86f7d597d4c223765c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 00:24:30.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"ac87945157d09de0f664b479c0fce40e74cf2f77","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 01:12:28.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/14/75314/3/check/gate-devstack-bash8/f363754 : SUCCESS in 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/14/75314/3/check/check-devstack-dsvm-cells/a420a99 : SUCCESS in 12m 09s\n- check-tempest-dsvm-full http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-full/b7a6046 : SUCCESS in 46m 26s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-postgres-full/958c49f : SUCCESS in 37m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-neutron/a4e753a : SUCCESS in 31m 57s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-neutron-full/49ca9a8 : SUCCESS in 45m 00s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/14/75314/3/check/gate-tempest-dsvm-large-ops/b34d204 : SUCCESS in 16m 24s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/14/75314/3/check/gate-tempest-dsvm-neutron-large-ops/71ae085 : SUCCESS in 14m 09s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-neutron-heat-slow/ea05489 : SUCCESS in 21m 36s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-cells-full/aa09058 : FAILURE in 23m 48s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/14/75314/3/check/check-grenade-dsvm/7416441 : SUCCESS in 34m 58s\n- check-swift-dsvm-functional http://logs.openstack.org/14/75314/3/check/check-swift-dsvm-functional/ed45141 : SUCCESS in 16m 19s\n- check-devstack-dsvm-neutron http://logs.openstack.org/14/75314/3/check/check-devstack-dsvm-neutron/ccd3c79 : FAILURE in 14m 58s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-ironic-nv/f39a4c4 : SUCCESS in 28m 17s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-ironic-postgres-nv/2e926a1 : SUCCESS in 24m 11s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-savanna-full-nv/f0b07c4 : SUCCESS in 47m 52s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-savanna-postgres-nv/4529241 : SUCCESS in 25m 11s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/14/75314/3/check/check-tempest-dsvm-savanna-neutron-nv/b0793f8 : SUCCESS in 43m 28s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"9466c4bfff0dbbae7a8a3e805c166c799545decc","author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"date":"2014-02-25 01:24:10.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nLGTM, Thanks.","accounts_in_message":[],"_revision_number":3},{"id":"4a2cbd542a7e7a003e6ed0af14345f570019e19b","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-02-25 01:26:27.000000000","message":"Patch Set 3:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://ca.downloads.xensource.com/OpenStack/xenserver-ci/refs/changes/14/75314/3/\n\nRecheck supported; use \"citrix recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.","accounts_in_message":[],"_revision_number":3},{"id":"d279448a73799e3450a059576e4f8f30c5451a58","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-02-25 17:25:06.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nThis is an odd and unnecessary way of handling here docs, I don\u0027t know why it is there...and that\u0027s after tracing the first one back to 2 years ago (really!) and my initial support for f16.\n\nI\u0027d rather get rid of the extra bash invocations.","accounts_in_message":[],"_revision_number":3},{"id":"eb96977ff6af17cf543cdfa27102567730f092aa","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-25 22:33:31.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"10be3eadba80fb45c6451a4c4a6c12b7e3bb7b35","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 22:33:34.000000000","message":"Patch Set 4:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"7eb60abeed04b5453359568b0ee5daeb55bc9256","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2014-02-25 22:40:39.000000000","message":"Patch Set 4:\n\n\u003e I\u0027d rather get rid of the extra bash invocations.\n\nOk, I changed the gist of this to a more generic EOF check which picks up this problem","accounts_in_message":[],"_revision_number":4},{"id":"9f263c9d72f51e5bb2a6ad7e83cd3e26159099cd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 23:27:17.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/14/75314/4/check/gate-devstack-bash8/e25c686 : SUCCESS in 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/14/75314/4/check/check-devstack-dsvm-cells/572e193 : SUCCESS in 14m 55s\n- check-tempest-dsvm-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-full/89ac00b : SUCCESS in 53m 39s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-postgres-full/0ae2545 : SUCCESS in 44m 03s\n- check-tempest-dsvm-neutron http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-neutron/11fd8fa : SUCCESS in 29m 22s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-neutron-full/4a0cae7 : SUCCESS in 48m 48s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/14/75314/4/check/gate-tempest-dsvm-large-ops/a79bd65 : SUCCESS in 18m 01s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/14/75314/4/check/gate-tempest-dsvm-neutron-large-ops/e9b5744 : SUCCESS in 16m 44s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-neutron-heat-slow/1cc8195 : SUCCESS in 21m 43s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-cells-full/ae7b36b : SUCCESS in 47m 31s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/14/75314/4/check/check-grenade-dsvm/641bc48 : SUCCESS in 33m 43s\n- check-swift-dsvm-functional http://logs.openstack.org/14/75314/4/check/check-swift-dsvm-functional/05c6b81 : SUCCESS in 12m 24s\n- check-devstack-dsvm-neutron http://logs.openstack.org/14/75314/4/check/check-devstack-dsvm-neutron/454f41b : FAILURE in 17m 01s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-ironic-nv/f9fe5e0 : SUCCESS in 36m 02s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-ironic-postgres-nv/4cff723 : SUCCESS in 33m 54s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-savanna-full-nv/61d5431 : SUCCESS in 42m 19s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-savanna-postgres-nv/a340b9e : SUCCESS in 18m 25s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-savanna-neutron-nv/2658901 : SUCCESS in 33m 33s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"1dde268fc528578779c2fc02a44cf3c659b4db91","author":{"_account_id":10385,"name":"Citrix XenServer CI","username":"citrix_xenserver_ci","tags":["SERVICE_USER"]},"date":"2014-02-25 23:35:03.000000000","message":"Patch Set 4:\n\nPassed using XenAPI driver with XenServer 6.2: Logs at http://ca.downloads.xensource.com/OpenStack/xenserver-ci/refs/changes/14/75314/4/\n\nStandard recheck supported; use \"xenserver recheck\" to trigger only xenserver re-check.  XenServer CI contact: openstack@citrix.com.","accounts_in_message":[],"_revision_number":4},{"id":"3071a7f6189c9c3b17e85e9bc03a7dce1d0b2554","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-02-26 12:30:02.000000000","message":"Patch Set 4: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"43e5183299c3d6c5b382d181b186b1245b88a893","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-02-27 00:36:36.000000000","message":"Patch Set 4: Looks good to me (core reviewer); Approved\n\nThanks Ian","accounts_in_message":[],"_revision_number":4},{"id":"b567d52a18c049f310cb68257f48d0da8afb3e92","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-27 00:36:37.000000000","message":"Patch Set 4: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"e1876daa5ed96c46dbeda4fe7dc733901cb089d9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-27 01:32:51.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/14/75314/4/check/gate-devstack-bash8/2127446 : SUCCESS in 9s\n- check-devstack-dsvm-cells http://logs.openstack.org/14/75314/4/check/check-devstack-dsvm-cells/881a844 : SUCCESS in 12m 41s\n- check-tempest-dsvm-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-full/779528f : SUCCESS in 44m 40s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-postgres-full/0ab3043 : SUCCESS in 45m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-neutron/ae928c6 : SUCCESS in 34m 05s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-neutron-full/2832f05 : SUCCESS in 40m 34s (non-voting)\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/14/75314/4/check/gate-tempest-dsvm-large-ops/86bb7ae : SUCCESS in 17m 42s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/14/75314/4/check/gate-tempest-dsvm-neutron-large-ops/3e10255 : SUCCESS in 14m 24s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-neutron-heat-slow/6c3e063 : SUCCESS in 21m 52s (non-voting)\n- check-tempest-dsvm-cells-full http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-cells-full/75d47dc : SUCCESS in 53m 06s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/14/75314/4/check/check-grenade-dsvm/8f0296e : SUCCESS in 28m 33s\n- check-swift-dsvm-functional http://logs.openstack.org/14/75314/4/check/check-swift-dsvm-functional/0279363 : SUCCESS in 17m 32s\n- check-devstack-dsvm-neutron http://logs.openstack.org/14/75314/4/check/check-devstack-dsvm-neutron/4d02415 : FAILURE in 16m 41s (non-voting)\n- check-tempest-dsvm-ironic-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-ironic-nv/465c2ba : SUCCESS in 24m 39s (non-voting)\n- check-tempest-dsvm-ironic-postgres-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-ironic-postgres-nv/e865696 : SUCCESS in 33m 45s (non-voting)\n- check-tempest-dsvm-savanna-full-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-savanna-full-nv/93ffa92 : SUCCESS in 45m 03s (non-voting)\n- check-tempest-dsvm-savanna-postgres-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-savanna-postgres-nv/1b1c77a : SUCCESS in 17m 19s (non-voting)\n- check-tempest-dsvm-savanna-neutron-nv http://logs.openstack.org/14/75314/4/check/check-tempest-dsvm-savanna-neutron-nv/51dddd6 : SUCCESS in 41m 35s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"6a6c877bb430238bdfd712d9bf88f3f793d0a55c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-27 01:32:53.000000000","message":"Patch Set 4: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"a05094fa0322d7016f6b37986bbb4b16ec947bf2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-27 04:36:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":4},{"id":"afad088b7167889fb24e64f5a870abfa29aa8b2e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-27 04:36:59.000000000","message":"Patch Set 4: Verified\n\nBuild succeeded.\n\n- gate-devstack-bash8 http://logs.openstack.org/14/75314/4/gate/gate-devstack-bash8/4f90599 : SUCCESS in 10s\n- gate-devstack-dsvm-cells http://logs.openstack.org/14/75314/4/gate/gate-devstack-dsvm-cells/073ffc8 : SUCCESS in 12m 38s\n- gate-tempest-dsvm-full http://logs.openstack.org/14/75314/4/gate/gate-tempest-dsvm-full/210006b : SUCCESS in 47m 01s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/14/75314/4/gate/gate-tempest-dsvm-postgres-full/4a0e915 : SUCCESS in 44m 51s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/14/75314/4/gate/gate-tempest-dsvm-neutron/2c4df83 : SUCCESS in 40m 22s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/14/75314/4/gate/gate-tempest-dsvm-large-ops/573c0d9 : SUCCESS in 15m 56s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/14/75314/4/gate/gate-tempest-dsvm-neutron-large-ops/f546ebe : SUCCESS in 12m 02s\n- gate-grenade-dsvm http://logs.openstack.org/14/75314/4/gate/gate-grenade-dsvm/6541085 : SUCCESS in 33m 28s\n- gate-swift-dsvm-functional http://logs.openstack.org/14/75314/4/gate/gate-swift-dsvm-functional/a63e7cd : SUCCESS in 13m 38s\n","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b8e250232ec55b946d2fd7e4237f12632408bdcc","revisions":{"218313ed08791ab974485de2175b1d1ed162282b":{"kind":"REWORK","_number":1,"created":"2014-02-21 05:16:56.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/75314/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/14/75314/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/14/75314/1"}}},"commit":{"parents":[{"commit":"5d920e02e30f375253ff9a5f6fef010c95c2fb4b","subject":"Merge \"add heat to the default devstack service list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/5d920e02e30f375253ff9a5f6fef010c95c2fb4b"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-21 05:14:29.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-21 05:14:29.000000000","tz":660},"subject":"Fix heredoc matching for trailing quote","message":"Fix heredoc matching for trailing quote\n\nThe file lib/nova_plugins/hypervisor-libvirt does heredoc\u0027s like this:\n\n---\nbash -c \"cat \u003c\u003cEOF \u003e foo\n...\nEOF\"\n---\n\nThe trailing quote was throwing the matching in bash8 off and it kept\nappending the next file as if it was still part of the heredoc.\n\nThis fixes the match to recognize this, and additonally adds a check\nthat raises an error if we finish a file and we still seem to be in a\nheredoc\n\nChange-Id: I5e547d87b3921fc7ce6588c28f074e5c9f489c1f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/218313ed08791ab974485de2175b1d1ed162282b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/218313ed08791ab974485de2175b1d1ed162282b"}]},"branch":"refs/heads/master"},"6c2fba0880c34722489dd8fe96da8622582e74b0":{"kind":"REWORK","_number":2,"created":"2014-02-24 21:18:50.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/75314/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/14/75314/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/14/75314/2"}}},"commit":{"parents":[{"commit":"f1eb0475d9320875f1a6c4a9c398e9388350d206","subject":"don\u0027t check for service enabled","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/f1eb0475d9320875f1a6c4a9c398e9388350d206"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-21 05:14:29.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-24 21:17:35.000000000","tz":660},"subject":"Fix heredoc matching for trailing quote","message":"Fix heredoc matching for trailing quote\n\nThe file lib/nova_plugins/hypervisor-libvirt does heredoc\u0027s like this:\n\n---\nbash -c \"cat \u003c\u003cEOF \u003e foo\n...\nEOF\"\n---\n\nThe trailing quote was throwing the matching in bash8 off and it kept\nappending the next file as if it was still part of the heredoc.\n\nThis fixes the match to recognize this, and additonally adds a check\nthat raises an error if we finish a file and we still seem to be in a\nheredoc\n\nChange-Id: I5e547d87b3921fc7ce6588c28f074e5c9f489c1f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6c2fba0880c34722489dd8fe96da8622582e74b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/6c2fba0880c34722489dd8fe96da8622582e74b0"}]},"branch":"refs/heads/master"},"0dbfcae3770e9e5fb79c5b4a5fdda93918e3d62a":{"kind":"REWORK","_number":3,"created":"2014-02-25 00:24:19.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/75314/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/14/75314/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/14/75314/3"}}},"commit":{"parents":[{"commit":"512da6e51328ea004cad8b86c3596b85ac3e775f","subject":"Merge \"make bash8 take a -v flag\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/512da6e51328ea004cad8b86c3596b85ac3e775f"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-21 05:14:29.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-25 00:24:06.000000000","tz":660},"subject":"Fix heredoc matching for trailing quote","message":"Fix heredoc matching for trailing quote\n\nThe file lib/nova_plugins/hypervisor-libvirt does heredoc\u0027s like this:\n\n---\nbash -c \"cat \u003c\u003cEOF \u003e foo\n...\nEOF\"\n---\n\nThe trailing quote was throwing the matching in bash8 off and it kept\nappending the next file as if it was still part of the heredoc.\n\nThis fixes the match to recognize this, and additonally adds a check\nthat raises an error if we finish a file and we still seem to be in a\nheredoc\n\nChange-Id: I5e547d87b3921fc7ce6588c28f074e5c9f489c1f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0dbfcae3770e9e5fb79c5b4a5fdda93918e3d62a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/0dbfcae3770e9e5fb79c5b4a5fdda93918e3d62a"}]},"branch":"refs/heads/master"},"b8e250232ec55b946d2fd7e4237f12632408bdcc":{"kind":"REWORK","_number":4,"created":"2014-02-25 22:33:31.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/14/75314/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack","ref":"refs/changes/14/75314/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack refs/changes/14/75314/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack refs/changes/14/75314/4"}}},"commit":{"parents":[{"commit":"b17fecf7d8c1a0c562ac7d8fc3a8d642f6392ac6","subject":"Merge \"xtrace less\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b17fecf7d8c1a0c562ac7d8fc3a8d642f6392ac6"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-21 05:14:29.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2014-02-25 22:31:15.000000000","tz":660},"subject":"Add end-of-file checks to bash8","message":"Add end-of-file checks to bash8\n\nAdd two end-of-file checks to bash8.  Firstly, alert if heredoc hasn\u0027t\nfinished.  Some heredocs were done like:\n\n---\nsudo bash -c \"cat \u003c\u003cEOF \u003e foo\n...\nEOF\"\n---\n\n(A better way to do this is \"cat \u003c\u003cEOF | sudo tee ...\" as it retains\nthe usual heredoc layout in the code).\n\nThe trailing quote was throwing the matching in bash8 off and it kept\nappending the next file as if it was still part of the heredoc.  To\navoid this, we check if we\u0027re still in a heredoc when we start a new\nfile; if so raise an error and reset the heredoc status fresh.  We\ntrack the state of the previous file, line and lineno so we can give a\ngood error.\n\n---\nE012: heredoc did not end before EOF: \u0027cat \u003c\u003cEOF\u0027\n - lib/trove: L221\n---\n\nThis includes fixes for the existing problem heredocs.\n\nA similar EOF check is to ensure the previous file ended with a\nnewline.\n\n---\nE004: file did not end with a newline: \u0027$MY_XTRACE\u0027\n - lib/neutron_plugins/embrane: L40\n---\n\nThis requires only one fix\n\nChange-Id: I5e547d87b3921fc7ce6588c28f074e5c9f489c1f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b8e250232ec55b946d2fd7e4237f12632408bdcc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack/commit/b8e250232ec55b946d2fd7e4237f12632408bdcc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}