)]}'
{"lib/neutron_plugins/ovn_agent":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"98b380452943f71b51aeca08b5a2a691ea4f7c83","unresolved":false,"context_lines":[{"line_number":89,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":90,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"export OVSDB_SERVER_LOCAL_HOST\u003d$SERVICE_LOCAL_HOST"},{"line_number":93,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":94,"context_line":"    OVSDB_SERVER_LOCAL_HOST\u003d[$(ipv6_unquote $OVSDB_SERVER_LOCAL_HOST)]"},{"line_number":95,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f65232a_5b0afe25","line":92,"updated":"2020-10-26 13:40:16.000000000","message":"What is SERVICE_LOCAL_HOST? I don\u0027t see it defined anywhere in devstack","commit_id":"21e1bf21df1afd7ec887b3d3ed93b4d7b84a1a27"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a02cd3fa52a21edc1959cf239574204f5cd0d436","unresolved":false,"context_lines":[{"line_number":89,"context_line":"OVN_META_CONF\u003d$NEUTRON_CONF_DIR/neutron_ovn_metadata_agent.ini"},{"line_number":90,"context_line":"OVN_META_DATA_HOST\u003d${OVN_META_DATA_HOST:-$(ipv6_unquote $SERVICE_HOST)}"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"export OVSDB_SERVER_LOCAL_HOST\u003d$SERVICE_LOCAL_HOST"},{"line_number":93,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":94,"context_line":"    OVSDB_SERVER_LOCAL_HOST\u003d[$(ipv6_unquote $OVSDB_SERVER_LOCAL_HOST)]"},{"line_number":95,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f65232a_b6b8872a","line":92,"in_reply_to":"3f65232a_5b0afe25","updated":"2020-10-26 13:50:53.000000000","message":"Sorry, my grep was wrong, found it in stackrc.","commit_id":"21e1bf21df1afd7ec887b3d3ed93b4d7b84a1a27"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"98b380452943f71b51aeca08b5a2a691ea4f7c83","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"export OVSDB_SERVER_LOCAL_HOST\u003d$SERVICE_LOCAL_HOST"},{"line_number":93,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":94,"context_line":"    OVSDB_SERVER_LOCAL_HOST\u003d[$(ipv6_unquote $OVSDB_SERVER_LOCAL_HOST)]"},{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"OVN_IGMP_SNOOPING_ENABLE\u003d$(trueorfalse False OVN_IGMP_SNOOPING_ENABLE)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f65232a_d603830c","line":94,"updated":"2020-10-26 13:40:16.000000000","message":"This seems redundant. Either you expect $OVSDB_SERVER_LOCAL_HOST to be a plain IP address, then you don\u0027t need to unquote it. Or you expect it to be quoted in [], then you don\u0027t need to do anything at all. Expecting both variants to be possible adds unneccessary complexity IMO.","commit_id":"21e1bf21df1afd7ec887b3d3ed93b4d7b84a1a27"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"44e4d67c186f28f8befe3480620944531ac80c11","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"export OVSDB_SERVER_LOCAL_HOST\u003d$SERVICE_LOCAL_HOST"},{"line_number":93,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":94,"context_line":"    OVSDB_SERVER_LOCAL_HOST\u003d[$(ipv6_unquote $OVSDB_SERVER_LOCAL_HOST)]"},{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"OVN_IGMP_SNOOPING_ENABLE\u003d$(trueorfalse False OVN_IGMP_SNOOPING_ENABLE)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f65232a_f6e83f17","line":94,"in_reply_to":"3f65232a_76aeefe7","updated":"2020-10-26 13:51:33.000000000","message":"Right, I was trying to account for both cases but indeed. Looking at [0] I think we can assume it\u0027s going to be unquoted. So for this variable I will remove the ipv6_unquote call there.\n\n[0] https://opendev.org/openstack/devstack/src/branch/master/stackrc#L879","commit_id":"21e1bf21df1afd7ec887b3d3ed93b4d7b84a1a27"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a02cd3fa52a21edc1959cf239574204f5cd0d436","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"export OVSDB_SERVER_LOCAL_HOST\u003d$SERVICE_LOCAL_HOST"},{"line_number":93,"context_line":"if [[ \"$SERVICE_IP_VERSION\" \u003d\u003d 6 ]]; then"},{"line_number":94,"context_line":"    OVSDB_SERVER_LOCAL_HOST\u003d[$(ipv6_unquote $OVSDB_SERVER_LOCAL_HOST)]"},{"line_number":95,"context_line":"fi"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"OVN_IGMP_SNOOPING_ENABLE\u003d$(trueorfalse False OVN_IGMP_SNOOPING_ENABLE)"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"3f65232a_76aeefe7","line":94,"in_reply_to":"3f65232a_d603830c","updated":"2020-10-26 13:50:53.000000000","message":"$SERVICE_LOCAL_HOST is defined to be either \"127.0.0.1\" or \"::1\", so you can drop the ipv6_unquote call here and just add \"[]\" around it.","commit_id":"21e1bf21df1afd7ec887b3d3ed93b4d7b84a1a27"}]}